160085 2016-07-22 09:26:03 -0700 Fix default parameter values for window.alert() / prompt() / confirm() 2016-07-22 13:35:24 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez benjamin cdumez commit-queue darin dbates esprehn+autocc kondapallykalyan rniwa sam oldest_to_newest 1213599 0 cdumez 2016-07-22 09:26:03 -0700 Fix default parameter values for window.alert() / prompt() / confirm() to match the specification: - https://html.spec.whatwg.org/multipage/browsers.html#the-window-object They should default to the empty string, not the string "undefined". Firefox and chrome agree with the specification. 1213616 1 284343 cdumez 2016-07-22 10:21:50 -0700 Created attachment 284343 Patch 1213652 2 284343 darin 2016-07-22 11:30:56 -0700 Comment on attachment 284343 Patch Looks like the GTK build failure is real. 1213684 3 284360 cdumez 2016-07-22 12:13:55 -0700 Created attachment 284360 Patch 1213688 4 cdumez 2016-07-22 12:34:15 -0700 GTK is now building properly. 1213701 5 284360 rniwa 2016-07-22 13:11:13 -0700 Comment on attachment 284360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284360&action=review > Source/WebCore/page/DOMWindow.idl:79 > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > + void alert(); > +#endif > + void alert(DOMString message); Doesn't this break Objective-C bindings when alert is called without an argument? 1213702 6 cdumez 2016-07-22 13:12:32 -0700 (In reply to comment #5) > Comment on attachment 284360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284360&action=review > > > Source/WebCore/page/DOMWindow.idl:79 > > +#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT > > + void alert(); > > +#endif > > + void alert(DOMString message); > > Doesn't this break Objective-C bindings when alert is called without an > argument? We had this discussion on another bug already. optional has no impact on ObjC bindings, so no. 1213704 7 284360 rniwa 2016-07-22 13:14:22 -0700 Comment on attachment 284360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284360&action=review >>> Source/WebCore/page/DOMWindow.idl:79 >>> + void alert(DOMString message); >> >> Doesn't this break Objective-C bindings when alert is called without an argument? > > We had this discussion on another bug already. optional has no impact on ObjC bindings, so no. Okay. I didn't see your reply. I guess someone else reviewed it? 1213706 8 cdumez 2016-07-22 13:15:40 -0700 (In reply to comment #7) > Comment on attachment 284360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284360&action=review > > >>> Source/WebCore/page/DOMWindow.idl:79 > >>> + void alert(DOMString message); > >> > >> Doesn't this break Objective-C bindings when alert is called without an argument? > > > > We had this discussion on another bug already. optional has no impact on ObjC bindings, so no. > > Okay. I didn't see your reply. I guess someone else reviewed it? I am referring to https://bugs.webkit.org/show_bug.cgi?id=160060#c3 1213720 9 284360 commit-queue 2016-07-22 13:35:18 -0700 Comment on attachment 284360 Patch Clearing flags on attachment: 284360 Committed r203612: <http://trac.webkit.org/changeset/203612> 1213721 10 commit-queue 2016-07-22 13:35:24 -0700 All reviewed patches have been landed. Closing bug. 284343 2016-07-22 10:21:50 -0700 2016-07-22 12:13:49 -0700 Patch bug-160085-20160722102048.patch text/plain 6718 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTNiNWQ3ZTFhMDVkZDc5 ZTIwM2FmODY4MDJkMTEyNTdmNzQzNzFkZS4uN2Y3ZGY0NDljMjM3ZThiYWQ5NzQ1ODEwMzhiMDEy ODJkNDNhOTAzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE2LTA3LTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IGRlZmF1bHQgcGFyYW1l dGVyIHZhbHVlcyBmb3Igd2luZG93LmFsZXJ0KCkgLyBwcm9tcHQoKSAvIGNvbmZpcm0oKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMDg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGRlZmF1bHQg cGFyYW1ldGVyIHZhbHVlcyBmb3Igd2luZG93LmFsZXJ0KCkgLyBwcm9tcHQoKSAvIGNvbmZpcm0o KSB0bworICAgICAgICBtYXRjaCB0aGUgc3BlY2lmaWNhdGlvbjoKKyAgICAgICAgLSBodHRwczov L2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9icm93c2Vycy5odG1sI3RoZS13aW5kb3ct b2JqZWN0CisKKyAgICAgICAgVGhleSBzaG91bGQgZGVmYXVsdCB0byB0aGUgZW1wdHkgc3RyaW5n LCBub3QgdGhlIHN0cmluZyAidW5kZWZpbmVkIi4KKworICAgICAgICBGaXJlZm94IGFuZCBjaHJv bWUgYWdyZWUgd2l0aCB0aGUgc3BlY2lmaWNhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHVwZGF0ZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmg6Cisg ICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorCisyMDE2LTA3LTIyICBDaHJpcyBEdW1leiAg PGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgUGFyYW1ldGVyIHRvIE5vZGUuY29tcGFyZURv Y3VtZW50UG9zaXRpb24oKSBzaG91bGQgYmUgbWFuZGF0b3J5IGFuZCBub24tbnVsbGFibGUKICAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDA3MQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oIGIvU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuaAppbmRleCA5ZWFmYjA4Njg4MmI1MTNjMjY2ZTRjOGNjYmY4MDBj M2JkMTczMzQwLi44N2ExMTE4NTZlNGU1OThkYTc3MDhhYzFkZWVkNzMwYjFjN2Y4ZjZjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmgKQEAgLTE3NSw3ICsxNzUsNyBAQCBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKICAgICAgICAgdm9pZCBzaG93TW9kYWxEaWFsb2coY29uc3QgU3RyaW5nJiB1cmxTdHJp bmcsIGNvbnN0IFN0cmluZyYgZGlhbG9nRmVhdHVyZXNTdHJpbmcsIERPTVdpbmRvdyYgYWN0aXZl V2luZG93LCBET01XaW5kb3cmIGZpcnN0V2luZG93LCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKERPTVdp bmRvdyYpPiBwcmVwYXJlRGlhbG9nRnVuY3Rpb24pOwogCi0gICAgICAgIHZvaWQgYWxlcnQoY29u c3QgU3RyaW5nJiBtZXNzYWdlKTsKKyAgICAgICAgdm9pZCBhbGVydChjb25zdCBTdHJpbmcmIG1l c3NhZ2UgPSBlbXB0eVN0cmluZygpKTsKICAgICAgICAgYm9vbCBjb25maXJtKGNvbnN0IFN0cmlu ZyYgbWVzc2FnZSk7CiAgICAgICAgIFN0cmluZyBwcm9tcHQoY29uc3QgU3RyaW5nJiBtZXNzYWdl LCBjb25zdCBTdHJpbmcmIGRlZmF1bHRWYWx1ZSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BhZ2UvRE9NV2luZG93LmlkbCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93Lmlk bAppbmRleCBiNjU5NzQzNzlkYTZhNmY2Mjk1NTAxYTRkY2U5M2RlNTM0MzZmNTc3Li5iMGQ1NjMw YTg3YzI0Zjg5YmExYWQxNzJmMDM4MjExNDdkZTg5MjkxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5k b3cuaWRsCkBAIC03MywxMCArNzMsMTAgQEAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG9wdGlvbmFsIGFueSBkaWFsb2dBcmdzLAogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgb3B0aW9uYWwgRE9NU3RyaW5nIGZlYXR1cmVBcmdzKTsKIAotICAg IC8vIEZJWE1FOiBVc2luZyAidW5kZWZpbmVkIiBhcyBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZSBp cyB3cm9uZy4KLSAgICB2b2lkIGFsZXJ0KG9wdGlvbmFsIERPTVN0cmluZyBtZXNzYWdlID0gInVu ZGVmaW5lZCIpOwotICAgIGJvb2xlYW4gY29uZmlybShvcHRpb25hbCBET01TdHJpbmcgbWVzc2Fn ZSA9ICJ1bmRlZmluZWQiKTsKLSAgICBET01TdHJpbmc/IHByb21wdChvcHRpb25hbCBET01TdHJp bmcgbWVzc2FnZSA9ICJ1bmRlZmluZWQiLCBvcHRpb25hbCBET01TdHJpbmc/IGRlZmF1bHRWYWx1 ZSA9IG51bGwpOworICAgIHZvaWQgYWxlcnQoKTsKKyAgICB2b2lkIGFsZXJ0KERPTVN0cmluZyBt ZXNzYWdlKTsKKyAgICBib29sZWFuIGNvbmZpcm0ob3B0aW9uYWwgRE9NU3RyaW5nIG1lc3NhZ2Ug PSAiIik7CisgICAgRE9NU3RyaW5nPyBwcm9tcHQob3B0aW9uYWwgRE9NU3RyaW5nIG1lc3NhZ2Ug PSAiIiwgb3B0aW9uYWwgRE9NU3RyaW5nIGRlZmF1bHRWYWx1ZSA9ICIiKTsKIAogICAgIC8vIEZJ WE1FOiBVc2luZyAidW5kZWZpbmVkIiBhcyBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZSBpcyB3cm9u Zy4KICAgICBib29sZWFuIGZpbmQob3B0aW9uYWwgRE9NU3RyaW5nIHN0cmluZyA9ICJ1bmRlZmlu ZWQiLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IDdmNjUwYWMxOThkN2UzMGIyNmU4MThlYjkxMDhjNzZkNGU3MzNlZGMuLjc5 MDY5NDAwZDQzZWU0Y2VmMWI2NGMzNWQ0ODc2N2M3OWRlNzQ5ZDAgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxNi0wNy0yMiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAg ICAgIEZpeCBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZXMgZm9yIHdpbmRvdy5hbGVydCgpIC8gcHJv bXB0KCkgLyBjb25maXJtKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2MDA4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVwZGF0ZSBleGlzdGluZyB0ZXN0IHRvIHJlZmxlY3QgYmVoYXZpb3IgY2hhbmdl LgorCisgICAgICAgICogZmFzdC9kb20vV2luZG93L2FsZXJ0LXVuZGVmaW5lZC1leHBlY3RlZC50 eHQ6CisgICAgICAgICogZmFzdC9kb20vV2luZG93L2FsZXJ0LXVuZGVmaW5lZC5odG1sOgorCiAy MDE2LTA3LTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgTWFr ZSBwYXJhbWV0ZXJzIHRvIEVsZW1lbnQuZ2V0RWxlbWVudHNCeSooKSBvcGVyYXRpb25zIG1hbmRh dG9yeQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2FsZXJ0LXVuZGVm aW5lZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYWxlcnQtdW5k ZWZpbmVkLWV4cGVjdGVkLnR4dAppbmRleCAzNGJlYzVmNjdjYzMwZGQxOTliMTM0OTM3ZTBhYzJj YzU1MjA4NDRjLi41YTcxMjU0OGJjYWU2ZWUyMTYwOTVlMzM1M2VlZThjODg0MjNkNjRmIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYWxlcnQtdW5kZWZpbmVkLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYWxlcnQtdW5kZWZpbmVk LWV4cGVjdGVkLnR4dApAQCAtMSwxMCArMSwxNyBAQAorQUxFUlQ6ICogVGhlIGxpbmUgYmVsb3cg c2hvdWxkIGhhdmUgbm8gdGV4dAorQUxFUlQ6IAorQUxFUlQ6ICogVGhlIGxpbmUgYmVsb3cgc2hv dWxkIGhhdmUgdGhlIHRleHQgJ3VuZGVmaW5lZCcKIEFMRVJUOiB1bmRlZmluZWQKK0FMRVJUOiAq IFRoZSBsaW5lIGJlbG93IHNob3VsZCBoYXZlIHRoZSB0ZXh0ICdudWxsJwogQUxFUlQ6IG51bGwK LUNPTkZJUk06IHVuZGVmaW5lZAorQUxFUlQ6ICogVGhlIGxpbmVzIGJlbG93IHNob3VsZCBoYXZl IG5vIHRleHQKK0NPTkZJUk06IAorQ09ORklSTTogCitBTEVSVDogKiBUaGUgbGluZSBiZWxvdyBz aG91bGQgaGF2ZSB0aGUgdGV4dCAnbnVsbCcKIENPTkZJUk06IG51bGwKLVBST01QVDogdW5kZWZp bmVkLCBkZWZhdWx0IHRleHQ6IAotUFJPTVBUOiBudWxsLCBkZWZhdWx0IHRleHQ6IAotQUxFUlQ6 IHVuZGVmaW5lZAotQ09ORklSTTogdW5kZWZpbmVkCi1QUk9NUFQ6IHVuZGVmaW5lZCwgZGVmYXVs dCB0ZXh0OiAKLVRoZSBhbGVydHMgdGhhdCBzaG93IHVwIChvciBpZiB0aGlzIGlzIHJ1bm5pbmcg dW5kZXIgRFJULCB0aGF0IGlzIGR1bXBlZCkgc2hvdWxkIGNvbnRhaW4gdGV4dDsgbm9uZSBzaG91 bGQgYmUgZW1wdHkuIFRoaXMgaXNuJ3QgZW50aXJlbHkgY29uc2lzdGVudCB3aXRoIG90aGVyIGJy b3dzZXJzIGluIGV2ZXJ5IGNhc2UsIGJ1dCBzaW5jZSB0aGVyZSdzIG5vIHJlYWwgdXNlIGNhc2Ug Zm9yIHRoaXMsIGl0J3MgYmVzdCB0byBiZSBleHBsaWNpdCByYXRoZXIgdGhhbiBzdWJ0bGUgYW5k IGVtcHR5LgorQUxFUlQ6ICogVGhlIGxpbmVzIGJlbG93IHNob3VsZCBoYXZlIG5vIHRleHQgYW5k IG5vIGRlZmF1bHQgdGV4dAorUFJPTVBUOiAsIGRlZmF1bHQgdGV4dDogCitQUk9NUFQ6ICwgZGVm YXVsdCB0ZXh0OiAKK0FMRVJUOiAqIFRoZSBsaW5lIGJlbG93IHNob3VsZCBoYXZlIHRoZSB0ZXh0 ICdudWxsJyBhbmQgdGhlIGRlZmF1bHQgdGV4dCBudWxsCitQUk9NUFQ6IG51bGwsIGRlZmF1bHQg dGV4dDogbnVsbAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYWxl cnQtdW5kZWZpbmVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYWxlcnQtdW5k ZWZpbmVkLmh0bWwKaW5kZXggYTU3OWE5NTcwMTA5N2FjYjVmNmZmYTA5ZmY1YWIyYzRiN2U1MGM3 YS4uNDAyOWIzMDY4MGU5MzNlMTRjYzQwYWE4MjZjYTdkYWY5ODA3NDgxNiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2FsZXJ0LXVuZGVmaW5lZC5odG1sCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9hbGVydC11bmRlZmluZWQuaHRtbApAQCAtNywyMiAr NywzMSBAQAogICAgICAgICAgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogICAgICAgICAgICAg ICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwogCisgICAgICAgICAgICBhbGVydCgiKiBUaGUg bGluZSBiZWxvdyBzaG91bGQgaGF2ZSBubyB0ZXh0Iik7CisgICAgICAgICAgICBhbGVydCgpOwor CisgICAgICAgICAgICBhbGVydCgiKiBUaGUgbGluZSBiZWxvdyBzaG91bGQgaGF2ZSB0aGUgdGV4 dCAndW5kZWZpbmVkJyIpOwogICAgICAgICAgICAgYWxlcnQodW5kZWZpbmVkKTsKKworICAgICAg ICAgICAgYWxlcnQoIiogVGhlIGxpbmUgYmVsb3cgc2hvdWxkIGhhdmUgdGhlIHRleHQgJ251bGwn Iik7CiAgICAgICAgICAgICBhbGVydChudWxsKTsKKworICAgICAgICAgICAgYWxlcnQoIiogVGhl IGxpbmVzIGJlbG93IHNob3VsZCBoYXZlIG5vIHRleHQiKTsKKyAgICAgICAgICAgIGNvbmZpcm0o KTsKICAgICAgICAgICAgIGNvbmZpcm0odW5kZWZpbmVkKTsKKworICAgICAgICAgICAgYWxlcnQo IiogVGhlIGxpbmUgYmVsb3cgc2hvdWxkIGhhdmUgdGhlIHRleHQgJ251bGwnIik7CiAgICAgICAg ICAgICBjb25maXJtKG51bGwpOwotICAgICAgICAgICAgcHJvbXB0KHVuZGVmaW5lZCk7Ci0gICAg ICAgICAgICBwcm9tcHQobnVsbCk7CiAKLSAgICAgICAgICAgIGFsZXJ0KCk7Ci0gICAgICAgICAg ICBjb25maXJtKCk7CisgICAgICAgICAgICBhbGVydCgiKiBUaGUgbGluZXMgYmVsb3cgc2hvdWxk IGhhdmUgbm8gdGV4dCBhbmQgbm8gZGVmYXVsdCB0ZXh0Iik7CiAgICAgICAgICAgICBwcm9tcHQo KTsKKyAgICAgICAgICAgIHByb21wdCh1bmRlZmluZWQsIHVuZGVmaW5lZCk7CisKKyAgICAgICAg ICAgICBhbGVydCgiKiBUaGUgbGluZSBiZWxvdyBzaG91bGQgaGF2ZSB0aGUgdGV4dCAnbnVsbCcg YW5kIHRoZSBkZWZhdWx0IHRleHQgbnVsbCIpOworICAgICAgICAgICAgcHJvbXB0KG51bGwsIG51 bGwpOwogICAgICAgICB9CiAgICAgPC9zY3JpcHQ+CiA8L2hlYWQ+CiA8Ym9keSBvbmxvYWQ9InJ1 blRlc3RzKCkiPgotICAgIDxwPlRoZSBhbGVydHMgdGhhdCBzaG93IHVwIChvciBpZiB0aGlzIGlz IHJ1bm5pbmcgdW5kZXIgRFJULCB0aGF0IGlzIGR1bXBlZCkgc2hvdWxkIGNvbnRhaW4gdGV4dDsg bm9uZSBzaG91bGQgYmUgZW1wdHkuCi0gICAgVGhpcyBpc24ndCBlbnRpcmVseSBjb25zaXN0ZW50 IHdpdGggb3RoZXIgYnJvd3NlcnMgaW4gZXZlcnkgY2FzZSwgYnV0IHNpbmNlIHRoZXJlJ3Mgbm8g cmVhbCB1c2UgY2FzZSBmb3IgdGhpcywKLSAgICBpdCdzIGJlc3QgdG8gYmUgZXhwbGljaXQgcmF0 aGVyIHRoYW4gc3VidGxlIGFuZCBlbXB0eS48L3A+CiA8L2JvZHk+CiA8L2h0bWw+Cg== 284360 2016-07-22 12:13:55 -0700 2016-07-22 13:35:18 -0700 Patch bug-160085-20160722121253.patch text/plain 6845 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWVkZTFhYTY1ODg1ZTI5 NDIwNDVlMDk1NzU2MThmZGI1OTczNzQ5Mi4uODNmZDMzNjhiZjNlMGNjYTA5NzcxOTY1MWFjODE0 OTgyODRhMzRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA3LTIyICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGRlZmF1bHQgcGFyYW1l dGVyIHZhbHVlcyBmb3Igd2luZG93LmFsZXJ0KCkgLyBwcm9tcHQoKSAvIGNvbmZpcm0oKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMDg1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGRlZmF1bHQg cGFyYW1ldGVyIHZhbHVlcyBmb3Igd2luZG93LmFsZXJ0KCkgLyBwcm9tcHQoKSAvIGNvbmZpcm0o KSB0bworICAgICAgICBtYXRjaCB0aGUgc3BlY2lmaWNhdGlvbjoKKyAgICAgICAgLSBodHRwczov L2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9icm93c2Vycy5odG1sI3RoZS13aW5kb3ct b2JqZWN0CisKKyAgICAgICAgVGhleSBzaG91bGQgZGVmYXVsdCB0byB0aGUgZW1wdHkgc3RyaW5n LCBub3QgdGhlIHN0cmluZyAidW5kZWZpbmVkIi4KKworICAgICAgICBGaXJlZm94IGFuZCBjaHJv bWUgYWdyZWUgd2l0aCB0aGUgc3BlY2lmaWNhdGlvbi4KKworICAgICAgICBObyBuZXcgdGVzdHMs IHVwZGF0ZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIHBhZ2UvRE9NV2luZG93Lmg6Cisg ICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorCiAyMDE2LTA3LTIyICBTYWlkIEFib3UtSGFs bGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUkVHUkVTU0lP TigyMDMzNzgpOiBQREZEb2N1bWVudEltYWdlOjp1cGRhdGVDYWNoZWRJbWFnZUlmTmVlZGVkKCkg dXNlcyB0aGUgdW5zY2FsZWQgc2l6ZSB3aGVuIGRlY2lkaW5nIHdoZXRoZXIgdG8gY2FjaGUgdGhl IFBERiBpbWFnZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaCBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKaW5kZXggOWVhZmIwODY4ODJiNTEzYzI2 NmU0YzhjY2JmODAwYzNiZDE3MzM0MC4uODdhMTExODU2ZTRlNTk4ZGE3NzA4YWMxZGVlZDczMGIx YzdmOGY2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCkBAIC0xNzUsNyArMTc1LDcgQEAgbmFt ZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgc2hvd01vZGFsRGlhbG9nKGNvbnN0IFN0 cmluZyYgdXJsU3RyaW5nLCBjb25zdCBTdHJpbmcmIGRpYWxvZ0ZlYXR1cmVzU3RyaW5nLCBET01X aW5kb3cmIGFjdGl2ZVdpbmRvdywgRE9NV2luZG93JiBmaXJzdFdpbmRvdywgc3RkOjpmdW5jdGlv bjx2b2lkIChET01XaW5kb3cmKT4gcHJlcGFyZURpYWxvZ0Z1bmN0aW9uKTsKIAotICAgICAgICB2 b2lkIGFsZXJ0KGNvbnN0IFN0cmluZyYgbWVzc2FnZSk7CisgICAgICAgIHZvaWQgYWxlcnQoY29u c3QgU3RyaW5nJiBtZXNzYWdlID0gZW1wdHlTdHJpbmcoKSk7CiAgICAgICAgIGJvb2wgY29uZmly bShjb25zdCBTdHJpbmcmIG1lc3NhZ2UpOwogICAgICAgICBTdHJpbmcgcHJvbXB0KGNvbnN0IFN0 cmluZyYgbWVzc2FnZSwgY29uc3QgU3RyaW5nJiBkZWZhdWx0VmFsdWUpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L0RPTVdpbmRvdy5pZGwKaW5kZXggYjY1OTc0Mzc5ZGE2YTZmNjI5NTUwMWE0ZGNlOTNkZTUzNDM2 ZjU3Ny4uNjMxMjY2MzViMzgwMzY4NjFmMGEzNWI1NTg1OWFkZTg5OTlmODFmZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvRE9NV2luZG93LmlkbApAQCAtNzMsMTAgKzczLDEyIEBACiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBvcHRpb25hbCBhbnkgZGlhbG9nQXJncywKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG9wdGlvbmFsIERPTVN0cmluZyBmZWF0dXJl QXJncyk7CiAKLSAgICAvLyBGSVhNRTogVXNpbmcgInVuZGVmaW5lZCIgYXMgZGVmYXVsdCBwYXJh bWV0ZXIgdmFsdWUgaXMgd3JvbmcuCi0gICAgdm9pZCBhbGVydChvcHRpb25hbCBET01TdHJpbmcg bWVzc2FnZSA9ICJ1bmRlZmluZWQiKTsKLSAgICBib29sZWFuIGNvbmZpcm0ob3B0aW9uYWwgRE9N U3RyaW5nIG1lc3NhZ2UgPSAidW5kZWZpbmVkIik7Ci0gICAgRE9NU3RyaW5nPyBwcm9tcHQob3B0 aW9uYWwgRE9NU3RyaW5nIG1lc3NhZ2UgPSAidW5kZWZpbmVkIiwgb3B0aW9uYWwgRE9NU3RyaW5n PyBkZWZhdWx0VmFsdWUgPSBudWxsKTsKKyNpZiBkZWZpbmVkKExBTkdVQUdFX0pBVkFTQ1JJUFQp ICYmIExBTkdVQUdFX0pBVkFTQ1JJUFQKKyAgICB2b2lkIGFsZXJ0KCk7CisjZW5kaWYKKyAgICB2 b2lkIGFsZXJ0KERPTVN0cmluZyBtZXNzYWdlKTsKKyAgICBib29sZWFuIGNvbmZpcm0ob3B0aW9u YWwgRE9NU3RyaW5nIG1lc3NhZ2UgPSAiIik7CisgICAgRE9NU3RyaW5nPyBwcm9tcHQob3B0aW9u YWwgRE9NU3RyaW5nIG1lc3NhZ2UgPSAiIiwgb3B0aW9uYWwgRE9NU3RyaW5nIGRlZmF1bHRWYWx1 ZSA9ICIiKTsKIAogICAgIC8vIEZJWE1FOiBVc2luZyAidW5kZWZpbmVkIiBhcyBkZWZhdWx0IHBh cmFtZXRlciB2YWx1ZSBpcyB3cm9uZy4KICAgICBib29sZWFuIGZpbmQob3B0aW9uYWwgRE9NU3Ry aW5nIHN0cmluZyA9ICJ1bmRlZmluZWQiLApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZmOTY0YWI5N2ZhNmM3MDBkZTBkYmY1 ZjYyNzlhMzUxMWE2OGE0NTQuLjFiZTIyMWFjMzQ4ZGQxMDA1NjM4MzQ3ZTY4ZDJkYTdkMzE2Nzk2 NGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAxNi0wNy0yMiAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCisgICAgICAgIEZpeCBkZWZhdWx0IHBhcmFtZXRlciB2YWx1ZXMgZm9y IHdpbmRvdy5hbGVydCgpIC8gcHJvbXB0KCkgLyBjb25maXJtKCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDA4NQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBleGlzdGluZyB0ZXN0IHRvIHJl ZmxlY3QgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogZmFzdC9kb20vV2luZG93L2FsZXJ0 LXVuZGVmaW5lZC1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9kb20vV2luZG93L2FsZXJ0 LXVuZGVmaW5lZC5odG1sOgorCisyMDE2LTA3LTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBs ZS5jb20+CisKICAgICAgICAgRmlyc3QgcGFyYW1ldGVyIHRvIGdldEVsZW1lbnRCeUlkKCkgc2hv dWxkIGJlIG1hbmRhdG9yeQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYwMDg3CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRv dy9hbGVydC11bmRlZmluZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2lu ZG93L2FsZXJ0LXVuZGVmaW5lZC1leHBlY3RlZC50eHQKaW5kZXggMzRiZWM1ZjY3Y2MzMGRkMTk5 YjEzNDkzN2UwYWMyY2M1NTIwODQ0Yy4uNWE3MTI1NDhiY2FlNmVlMjE2MDk1ZTMzNTNlZWU4Yzg4 NDIzZDY0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2FsZXJ0LXVu ZGVmaW5lZC1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L2Fs ZXJ0LXVuZGVmaW5lZC1leHBlY3RlZC50eHQKQEAgLTEsMTAgKzEsMTcgQEAKK0FMRVJUOiAqIFRo ZSBsaW5lIGJlbG93IHNob3VsZCBoYXZlIG5vIHRleHQKK0FMRVJUOiAKK0FMRVJUOiAqIFRoZSBs aW5lIGJlbG93IHNob3VsZCBoYXZlIHRoZSB0ZXh0ICd1bmRlZmluZWQnCiBBTEVSVDogdW5kZWZp bmVkCitBTEVSVDogKiBUaGUgbGluZSBiZWxvdyBzaG91bGQgaGF2ZSB0aGUgdGV4dCAnbnVsbCcK IEFMRVJUOiBudWxsCi1DT05GSVJNOiB1bmRlZmluZWQKK0FMRVJUOiAqIFRoZSBsaW5lcyBiZWxv dyBzaG91bGQgaGF2ZSBubyB0ZXh0CitDT05GSVJNOiAKK0NPTkZJUk06IAorQUxFUlQ6ICogVGhl IGxpbmUgYmVsb3cgc2hvdWxkIGhhdmUgdGhlIHRleHQgJ251bGwnCiBDT05GSVJNOiBudWxsCi1Q Uk9NUFQ6IHVuZGVmaW5lZCwgZGVmYXVsdCB0ZXh0OiAKLVBST01QVDogbnVsbCwgZGVmYXVsdCB0 ZXh0OiAKLUFMRVJUOiB1bmRlZmluZWQKLUNPTkZJUk06IHVuZGVmaW5lZAotUFJPTVBUOiB1bmRl ZmluZWQsIGRlZmF1bHQgdGV4dDogCi1UaGUgYWxlcnRzIHRoYXQgc2hvdyB1cCAob3IgaWYgdGhp cyBpcyBydW5uaW5nIHVuZGVyIERSVCwgdGhhdCBpcyBkdW1wZWQpIHNob3VsZCBjb250YWluIHRl eHQ7IG5vbmUgc2hvdWxkIGJlIGVtcHR5LiBUaGlzIGlzbid0IGVudGlyZWx5IGNvbnNpc3RlbnQg d2l0aCBvdGhlciBicm93c2VycyBpbiBldmVyeSBjYXNlLCBidXQgc2luY2UgdGhlcmUncyBubyBy ZWFsIHVzZSBjYXNlIGZvciB0aGlzLCBpdCdzIGJlc3QgdG8gYmUgZXhwbGljaXQgcmF0aGVyIHRo YW4gc3VidGxlIGFuZCBlbXB0eS4KK0FMRVJUOiAqIFRoZSBsaW5lcyBiZWxvdyBzaG91bGQgaGF2 ZSBubyB0ZXh0IGFuZCBubyBkZWZhdWx0IHRleHQKK1BST01QVDogLCBkZWZhdWx0IHRleHQ6IAor UFJPTVBUOiAsIGRlZmF1bHQgdGV4dDogCitBTEVSVDogKiBUaGUgbGluZSBiZWxvdyBzaG91bGQg aGF2ZSB0aGUgdGV4dCAnbnVsbCcgYW5kIHRoZSBkZWZhdWx0IHRleHQgbnVsbAorUFJPTVBUOiBu dWxsLCBkZWZhdWx0IHRleHQ6IG51bGwKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L2FsZXJ0LXVuZGVmaW5lZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2lu ZG93L2FsZXJ0LXVuZGVmaW5lZC5odG1sCmluZGV4IGE1NzlhOTU3MDEwOTdhY2I1ZjZmZmEwOWZm NWFiMmM0YjdlNTBjN2EuLjQwMjliMzA2ODBlOTMzZTE0Y2M0MGFhODI2Y2E3ZGFmOTgwNzQ4MTYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9hbGVydC11bmRlZmluZWQu aHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvYWxlcnQtdW5kZWZpbmVkLmh0 bWwKQEAgLTcsMjIgKzcsMzEgQEAKICAgICAgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK ICAgICAgICAgICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKIAorICAgICAgICAgICAg YWxlcnQoIiogVGhlIGxpbmUgYmVsb3cgc2hvdWxkIGhhdmUgbm8gdGV4dCIpOworICAgICAgICAg ICAgYWxlcnQoKTsKKworICAgICAgICAgICAgYWxlcnQoIiogVGhlIGxpbmUgYmVsb3cgc2hvdWxk IGhhdmUgdGhlIHRleHQgJ3VuZGVmaW5lZCciKTsKICAgICAgICAgICAgIGFsZXJ0KHVuZGVmaW5l ZCk7CisKKyAgICAgICAgICAgIGFsZXJ0KCIqIFRoZSBsaW5lIGJlbG93IHNob3VsZCBoYXZlIHRo ZSB0ZXh0ICdudWxsJyIpOwogICAgICAgICAgICAgYWxlcnQobnVsbCk7CisKKyAgICAgICAgICAg IGFsZXJ0KCIqIFRoZSBsaW5lcyBiZWxvdyBzaG91bGQgaGF2ZSBubyB0ZXh0Iik7CisgICAgICAg ICAgICBjb25maXJtKCk7CiAgICAgICAgICAgICBjb25maXJtKHVuZGVmaW5lZCk7CisKKyAgICAg ICAgICAgIGFsZXJ0KCIqIFRoZSBsaW5lIGJlbG93IHNob3VsZCBoYXZlIHRoZSB0ZXh0ICdudWxs JyIpOwogICAgICAgICAgICAgY29uZmlybShudWxsKTsKLSAgICAgICAgICAgIHByb21wdCh1bmRl ZmluZWQpOwotICAgICAgICAgICAgcHJvbXB0KG51bGwpOwogCi0gICAgICAgICAgICBhbGVydCgp OwotICAgICAgICAgICAgY29uZmlybSgpOworICAgICAgICAgICAgYWxlcnQoIiogVGhlIGxpbmVz IGJlbG93IHNob3VsZCBoYXZlIG5vIHRleHQgYW5kIG5vIGRlZmF1bHQgdGV4dCIpOwogICAgICAg ICAgICAgcHJvbXB0KCk7CisgICAgICAgICAgICBwcm9tcHQodW5kZWZpbmVkLCB1bmRlZmluZWQp OworCisgICAgICAgICAgICAgYWxlcnQoIiogVGhlIGxpbmUgYmVsb3cgc2hvdWxkIGhhdmUgdGhl IHRleHQgJ251bGwnIGFuZCB0aGUgZGVmYXVsdCB0ZXh0IG51bGwiKTsKKyAgICAgICAgICAgIHBy b21wdChudWxsLCBudWxsKTsKICAgICAgICAgfQogICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJv ZHkgb25sb2FkPSJydW5UZXN0cygpIj4KLSAgICA8cD5UaGUgYWxlcnRzIHRoYXQgc2hvdyB1cCAo b3IgaWYgdGhpcyBpcyBydW5uaW5nIHVuZGVyIERSVCwgdGhhdCBpcyBkdW1wZWQpIHNob3VsZCBj b250YWluIHRleHQ7IG5vbmUgc2hvdWxkIGJlIGVtcHR5LgotICAgIFRoaXMgaXNuJ3QgZW50aXJl bHkgY29uc2lzdGVudCB3aXRoIG90aGVyIGJyb3dzZXJzIGluIGV2ZXJ5IGNhc2UsIGJ1dCBzaW5j ZSB0aGVyZSdzIG5vIHJlYWwgdXNlIGNhc2UgZm9yIHRoaXMsCi0gICAgaXQncyBiZXN0IHRvIGJl IGV4cGxpY2l0IHJhdGhlciB0aGFuIHN1YnRsZSBhbmQgZW1wdHkuPC9wPgogPC9ib2R5PgogPC9o dG1sPgo=