160079 2016-07-22 02:04:58 -0700 [GTK] Enable threaded compositor by default 2016-07-24 23:24:05 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 154066 1 cgarcia webkit-unassigned bugs-noreply pnormand oldest_to_newest 1213528 0 cgarcia 2016-07-22 02:04:58 -0700 I think we are ready. I'll keep working on the layout tests. 1213532 1 284319 cgarcia 2016-07-22 02:44:44 -0700 Created attachment 284319 Patch 1213538 2 cgarcia 2016-07-22 03:25:11 -0700 Committed r203596: <http://trac.webkit.org/changeset/203596> 1214108 3 pnormand 2016-07-24 23:12:45 -0700 The Debug build bot doesn't like this at all. Crash example: STDERR: ASSERTION FAILED: m_useFixedLayout STDERR: ../../Source/WebKit2/WebProcess/WebPage/WebPage.cpp(1374) : void WebKit::WebPage::sendViewportAttributesChanged() STDERR: 1 0x7f09712b716f /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f09712b716f] STDERR: 2 0x7f0977bbc50c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebPage::sendViewportAttributesChanged()+0x4c) [0x7f0977bbc50c] STDERR: 3 0x7f0977bbc443 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebPage::setSize(WebCore::IntSize const&)+0xb1) [0x7f0977bbc443] STDERR: 4 0x7f0977d663ae /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::AcceleratedDrawingArea::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)+0xee) [0x7f0977d663ae] STDERR: 5 0x7f0977d68c3e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::DrawingAreaImpl::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)+0x11a) [0x7f0977d68c3e] STDERR: 6 0x7f0977e4e5b6 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::callMemberFunctionImpl<WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>, 0ul, 1ul, 2ul, 3ul, 4ul>(WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>&&, std::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul>)+0xf8) [0x7f0977e4e5b6] STDERR: 7 0x7f0977e4e12a /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::callMemberFunction<WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>, std::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul> >(std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>&&, WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&))+0x41) [0x7f0977e4e12a] STDERR: 8 0x7f0977e4ded1 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::handleMessage<Messages::DrawingArea::UpdateBackingStoreState, WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)>(IPC::MessageDecoder&, WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&))+0x9b) [0x7f0977e4ded1] STDERR: 9 0x7f0977e4daff /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::DrawingArea::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)+0x9d) [0x7f0977e4daff] STDERR: 10 0x7f09777d158f /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&)+0x125) [0x7f09777d158f] STDERR: 11 0x7f0977a456ac /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)+0x4c) [0x7f0977a456ac] STDERR: 12 0x7f09777bb88e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(IPC::MessageDecoder&)+0x3a) [0x7f09777bb88e] STDERR: 13 0x7f09777bb9f1 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >)+0x161) [0x7f09777bb9f1] STDERR: 14 0x7f09777bbbd8 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchOneMessage()+0xc8) [0x7f09777bbbd8] STDERR: 15 0x7f09777bb732 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x5265732) [0x7f09777bb732] STDERR: 16 0x7f09777c07cc /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x526a7cc) [0x7f09777c07cc] STDERR: 17 0x7f097778b21d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WTF::Function<void ()>::operator()() const+0x37) [0x7f097778b21d] STDERR: 18 0x7f09712d2a3a /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTF::RunLoop::performWork()+0xce) [0x7f09712d2a3a] STDERR: 19 0x7f0971315874 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2262874) [0x7f0971315874] STDERR: 20 0x7f0971315899 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2262899) [0x7f0971315899] STDERR: 21 0x7f0971315814 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2262814) [0x7f0971315814] STDERR: 22 0x7f0971315843 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2262843) [0x7f0971315843] STDERR: 23 0x7f096cd98a26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x53a26) [0x7f096cd98a26] STDERR: 24 0x7f096cd99854 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x7f096cd99854] STDERR: 25 0x7f096cd99a39 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x54a39) [0x7f096cd99a39] STDERR: 26 0x7f096cd99e60 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_loop_run+0x1d7) [0x7f096cd99e60] STDERR: 27 0x7f0971315e14 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTF::RunLoop::run()+0xac) [0x7f0971315e14] STDERR: 28 0x7f0977d73abc /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**)+0x82) [0x7f0977d73abc] STDERR: 29 0x7f0977d73922 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebProcessMainUnix+0x20) [0x7f0977d73922] STDERR: 30 0x400cfa /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/Debug/bin/WebKitWebProcess(main+0x34) [0x400cfa] STDERR: 31 0x7f0969bffb45 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f0969bffb45] STDERR: LEAK: 1 WebProcessPool STDERR: LEAK: 1 WebPageProxy 1214109 4 cgarcia 2016-07-24 23:24:05 -0700 (In reply to comment #3) > The Debug build bot doesn't like this at all. Crash example: Wow, so a few crashes means it doesn't like this at all? Anyway, I'm already working on this, see bug #160117. See also bug #160119, and see also the discussion in the mailing list about this. I knew there were going to be failures after enabling the threaded compositor, but we reached a point in which it was stable enough for users, that working on the remaining failures on trunk was easier, so we enabled it. Please, don't use this bug report crashes, file new bug reports and make them block bug #154066. 284319 2016-07-22 02:44:44 -0700 2016-07-22 03:20:39 -0700 Patch wk2-enable-tc.diff text/plain 2570 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhOTk4ZDYwLi4wOGY0MDJl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTYtMDctMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIEVuYWJsZSB0aHJlYWRlZCBjb21wb3NpdG9yIGJ5IGRlZmF1bHQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MDA3OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2Nt YWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTYtMDctMjAgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBKU0MgSklUIEJyb2tlbiBvbiBBUk12NyBUcmFk aXRpb25hbCAod2l0aG91dCBUaHVtYjIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IGU4YTJjYTgu LjVkM2JlMzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBi L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xNjksNiArMTY5LDcgQEAgV0VCS0lU X09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX01IVE1MIFBSSVZBVEUgT04pCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfTk9USUZJQ0FUSU9OUyBQUklWQVRF IE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1BVQkxJQ19TVUZG SVhfTElTVCBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5B QkxFX1NNT09USF9TQ1JPTExJTkcgUFJJVkFURSBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9USFJFQURFRF9DT01QT1NJVE9SIFBSSVZBVEUgT04pCiBXRUJLSVRf T1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfVVNFUlNFTEVDVF9BTEwgUFJJVkFURSBP TikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9VU0VSX01FU1NBR0Vf SEFORExFUlMgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9WSURFT19UUkFDSyBQUklWQVRFIE9OKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM3ZjFjOTMuLmJkYmM2ZDggMTAwNjQ0Ci0tLSBhL1Rv b2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAx Ni0wNy0yMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAg ICAgICAgW0dUS10gRW5hYmxlIHRocmVhZGVkIGNvbXBvc2l0b3IgYnkgZGVmYXVsdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMDc5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHBlcmwvRmVhdHVyZUxpc3QucG06CisKIDIwMTYtMDctMjEgIERhbiBCZXJuc3RlaW4gIDxtaXR6 QGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSB3ZWJraXRkaXJzLnBtIGNvbnRhaW5zIHVudXNl ZCBjb2RlIHRvIHN1cHBvcnQgb3V0ZGF0ZWQgT1MgWCBhbmQgWGNvZGUgdmVyc2lvbnMKZGlmZiAt LWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbSBiL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQppbmRleCA3ZWVlZWJmLi41ZDhkMTVmIDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KKysrIGIv VG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCkBAIC00MDEsNyArNDAxLDcg QEAgbXkgQGZlYXR1cmVzID0gKAogICAgICAgZGVmaW5lID0+ICJVU0VfU1lTVEVNX01BTExPQyIs IGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRzeXN0ZW1NYWxsb2NTdXBwb3J0IH0sCiAKICAgICB7 IG9wdGlvbiA9PiAidGhyZWFkZWQtY29tcG9zaXRvciIsIGRlc2MgPT4gIlRvZ2dsZSB0aHJlYWRl ZCBjb21wb3NpdG9yIHN1cHBvcnQiLAotICAgICAgZGVmaW5lID0+ICJFTkFCTEVfVEhSRUFERURf Q09NUE9TSVRPUiIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCR0aHJlYWRlZENvbXBvc2l0b3JT dXBwb3J0IH0sCisgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9USFJFQURFRF9DT01QT1NJVE9SIiwg ZGVmYXVsdCA9PiBpc0d0aygpLCB2YWx1ZSA9PiBcJHRocmVhZGVkQ29tcG9zaXRvclN1cHBvcnQg fSwKIAogICAgIHsgb3B0aW9uID0+ICJ0ZXh0LWF1dG9zaXppbmciLCBkZXNjID0+ICJUb2dnbGUg VGV4dCBBdXRvc2l6aW5nIHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfVEVYVF9B VVRPU0laSU5HIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9PiBcJHRleHRBdXRvc2l6aW5nU3VwcG9y dCB9LAo=