16007 2007-11-15 16:58:22 -0800 REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels 2007-11-15 22:26:08 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED Regression P1 Major --- 1 timothy timothy oldest_to_newest 61355 0 timothy 2007-11-15 16:58:22 -0800 The disclosure triangle clicking area is off by 10 pixels. This is a recent regression. 61356 1 17306 timothy 2007-11-15 17:00:25 -0800 Created attachment 17306 Patch 61358 2 17306 timothy 2007-11-15 17:04:27 -0800 Comment on attachment 17306 Patch Sam reviewed this. 61359 3 timothy 2007-11-15 17:05:11 -0800 Landed in r27833. http://trac.webkit.org/projects/webkit/changeset/27833 17306 2007-11-15 17:00:25 -0800 2007-11-15 17:04:27 -0800 Patch 16007.patch text/plain 3032 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODMy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDctMTEt MTUgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAxNjAwNzogUkVHUkVTU0lPTjog RGlzY2xvc3VyZSB0cmlhbmdsZSBjbGljayB6b25lIGZvciByZXNvdXJjZSBjYXRlZ29yaWVzIGlz IG9mZiBieSAxMCBwaXhlbHMKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYwMDcKKworICAgICAgICBNYWtlcyB0aGUgY2xpY2sgd2lkdGggYW4gb3B0aW9u IG9uIFRyZWVFbGVtZW50IGFuZCBtYWtlIFJlc291cmNlQ2F0ZWdvcnlUcmVlRWxlbWVudAorICAg ICAgICBhIHRydWUgc3ViY2xhc3Mgb2YgVHJlZUVsZW1lbnQuIFRoZSBjbGljayB3aWR0aCBmb3Ig UmVzb3VyY2VDYXRlZ29yeVRyZWVFbGVtZW50IGlzIAorICAgICAgICAyMCBwaXhlbHMsIGFuZCB0 aGUgZGVmYXVsdCBpcyAxMCBwaXhlbHMuCisKKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9SZXNv dXJjZUNhdGVnb3J5LmpzOgorICAgICAgICAqIHBhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpz OgorCiAyMDA3LTExLTE1ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgQnJhZHkuCkluZGV4OiBwYWdlL2luc3BlY3Rvci9SZXNvdXJj ZUNhdGVnb3J5LmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBhZ2UvaW5zcGVjdG9yL1Jlc291cmNlQ2F0ZWdv cnkuanMJKHJldmlzaW9uIDI3ODI2KQorKysgcGFnZS9pbnNwZWN0b3IvUmVzb3VyY2VDYXRlZ29y eS5qcwkod29ya2luZyBjb3B5KQpAQCAtOTMsNyArOTMsMTIgQEAgV2ViSW5zcGVjdG9yLlJlc291 cmNlQ2F0ZWdvcnkucHJvdG90eXBlIAogCiBXZWJJbnNwZWN0b3IuUmVzb3VyY2VDYXRlZ29yeVRy ZWVFbGVtZW50ID0gZnVuY3Rpb24oY2F0ZWdvcnkpCiB7Ci0gICAgdmFyIGl0ZW0gPSBuZXcgVHJl ZUVsZW1lbnQoY2F0ZWdvcnkudGl0bGUsIGNhdGVnb3J5LCB0cnVlKTsKLSAgICBpdGVtLnNlbGVj dGFibGUgPSBmYWxzZTsKLSAgICByZXR1cm4gaXRlbTsKKyAgICBUcmVlRWxlbWVudC5jYWxsKHRo aXMsIGNhdGVnb3J5LnRpdGxlLCBjYXRlZ29yeSwgdHJ1ZSk7CiB9CisKK1dlYkluc3BlY3Rvci5S ZXNvdXJjZUNhdGVnb3J5VHJlZUVsZW1lbnQucHJvdG90eXBlID0geworICAgIHNlbGVjdGFibGU6 IGZhbHNlLAorICAgIGFycm93VG9nZ2xlV2lkdGg6IDIwCit9CisKK1dlYkluc3BlY3Rvci5SZXNv dXJjZUNhdGVnb3J5VHJlZUVsZW1lbnQucHJvdG90eXBlLl9fcHJvdG9fXyA9IFRyZWVFbGVtZW50 LnByb3RvdHlwZTsKSW5kZXg6IHBhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIHBhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpzCShyZXZpc2lvbiAyNzgyNikKKysr IHBhZ2UvaW5zcGVjdG9yL3RyZWVvdXRsaW5lLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0zOTAsNyAr MzkwLDYgQEAgZnVuY3Rpb24gVHJlZUVsZW1lbnQodGl0bGUsIHJlcHJlc2VudGVkTwogICAgIHRo aXMuX2hpZGRlbiA9IGZhbHNlOwogICAgIHRoaXMuZXhwYW5kZWQgPSBmYWxzZTsKICAgICB0aGlz LnNlbGVjdGVkID0gZmFsc2U7Ci0gICAgdGhpcy5zZWxlY3RhYmxlID0gdHJ1ZTsKICAgICB0aGlz Lmhhc0NoaWxkcmVuID0gaGFzQ2hpbGRyZW47CiAgICAgdGhpcy5jaGlsZHJlbiA9IFtdOwogICAg IHRoaXMudHJlZU91dGxpbmUgPSBudWxsOwpAQCAtNDAxLDYgKzQwMCw5IEBAIGZ1bmN0aW9uIFRy ZWVFbGVtZW50KHRpdGxlLCByZXByZXNlbnRlZE8KIH0KIAogVHJlZUVsZW1lbnQucHJvdG90eXBl ID0geworICAgIHNlbGVjdGFibGU6IHRydWUsCisgICAgYXJyb3dUb2dnbGVXaWR0aDogMTAsCisK ICAgICBnZXQgbGlzdEl0ZW1FbGVtZW50KCkgewogICAgICAgICByZXR1cm4gdGhpcy5fbGlzdEl0 ZW1Ob2RlOwogICAgIH0sCkBAIC01MTAsNyArNTEyLDcgQEAgVHJlZUVsZW1lbnQudHJlZUVsZW1l bnRTZWxlY3RlZCA9IGZ1bmN0aQogICAgIGlmICghZWxlbWVudCB8fCAhZWxlbWVudC50cmVlRWxl bWVudCB8fCAhZWxlbWVudC50cmVlRWxlbWVudC5zZWxlY3RhYmxlKQogICAgICAgICByZXR1cm47 CiAKLSAgICBpZiAoZXZlbnQub2Zmc2V0WCA+IDEwIHx8ICFlbGVtZW50LnRyZWVFbGVtZW50Lmhh c0NoaWxkcmVuKQorICAgIGlmIChldmVudC5vZmZzZXRYID4gZWxlbWVudC50cmVlRWxlbWVudC5h cnJvd1RvZ2dsZVdpZHRoIHx8ICFlbGVtZW50LnRyZWVFbGVtZW50Lmhhc0NoaWxkcmVuKQogICAg ICAgICBlbGVtZW50LnRyZWVFbGVtZW50LnNlbGVjdCgpOwogfQogCkBAIC01MjAsNyArNTIyLDcg QEAgVHJlZUVsZW1lbnQudHJlZUVsZW1lbnRUb2dnbGVkID0gZnVuY3RpbwogICAgIGlmICghZWxl bWVudCB8fCAhZWxlbWVudC50cmVlRWxlbWVudCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYg KGV2ZW50Lm9mZnNldFggPD0gMTAgJiYgZWxlbWVudC50cmVlRWxlbWVudC5oYXNDaGlsZHJlbikg eworICAgIGlmIChldmVudC5vZmZzZXRYIDw9IGVsZW1lbnQudHJlZUVsZW1lbnQuYXJyb3dUb2dn bGVXaWR0aCAmJiBlbGVtZW50LnRyZWVFbGVtZW50Lmhhc0NoaWxkcmVuKSB7CiAgICAgICAgIGlm IChlbGVtZW50LnRyZWVFbGVtZW50LmV4cGFuZGVkKSB7CiAgICAgICAgICAgICBpZiAoZXZlbnQu YWx0S2V5KQogICAgICAgICAgICAgICAgIGVsZW1lbnQudHJlZUVsZW1lbnQuY29sbGFwc2VSZWN1 cnNpdmVseSgpOwo=