160049 2016-07-21 14:28:23 -0700 Web Inspector: Remove unused code from Debounce layout test 2016-07-22 13:37:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P5 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1213321 0 mattbaker 2016-07-21 14:28:23 -0700 The Cancel Debounce test case doesn't need to use callCount or startTime. 1213322 1 webkit-bug-importer 2016-07-21 14:28:48 -0700 <rdar://problem/27479713> 1213323 2 webkit-bug-importer 2016-07-21 14:29:08 -0700 <rdar://problem/27479718> 1213330 3 284261 mattbaker 2016-07-21 14:32:58 -0700 Created attachment 284261 [Patch] Proposed Fix 1213476 4 284261 joepeck 2016-07-21 20:11:19 -0700 Comment on attachment 284261 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=284261&action=review r=me! I could swear I had these review comments on the original! > LayoutTests/inspector/unit-tests/debounce.html:132 > - object.debounce(100).test(1, 'xyz'); > + object.debounce(100).test(); > object.test.cancelDebounce(); > > setTimeout(() => { InspectorTest.pass("Debounced function canceled."); resolve(); }, 200); It would be great to reduce these timeouts. 100 and 200 are very high for tests which typically run in 1-2 ms outside of LayoutTests/inspector. Want to change them to like 10 and 50? 1213700 5 284365 mattbaker 2016-07-22 13:07:29 -0700 Created attachment 284365 [Patch] For Landing 1213724 6 284365 commit-queue 2016-07-22 13:37:31 -0700 Comment on attachment 284365 [Patch] For Landing Clearing flags on attachment: 284365 Committed r203614: <http://trac.webkit.org/changeset/203614> 1213725 7 commit-queue 2016-07-22 13:37:35 -0700 All reviewed patches have been landed. Closing bug. 284261 2016-07-21 14:32:58 -0700 2016-07-22 13:07:26 -0700 [Patch] Proposed Fix bug-160049-20160721143158.patch text/plain 1957 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNTIwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWIzNjc0N2U3ZDgwZTdjM2UwZDRj NDEwNzhlMDY5ZGZmYjVlMGRkNC4uY2EzZjVlN2M5ZTMwMjFkMTliMTkyNzNhZDdiMWNlMDU2MDAz Njk0YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE2LTA3LTIxICBNYXR0IEJha2VyICA8bWF0 dGJha2VyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2Vk IGNvZGUgZnJvbSBEZWJvdW5jZSBsYXlvdXQgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMDQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NzQ3OTcxMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIGluc3BlY3Rvci91bml0LXRlc3RzL2RlYm91bmNlLmh0bWw6CisgICAgICAgIFJlbW92ZSB1 bnVzZWQgY29kZSB0aGF0IHdhcyBjb3B5LXBhc3RlZCBmcm9tIG90aGVyIHRlc3RzLgorCiAyMDE2 LTA3LTIxICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAg ICAgW2lQaG9uZV0gUGxheWluZyBhIHZpZGVvIG9uIHR1ZG91LmNvbSBwbGF5cyBvbmx5IHNvdW5k LCBubyB2aWRlbwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMv ZGVib3VuY2UuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL2RlYm91bmNl Lmh0bWwKaW5kZXggNTgxMzUxNWMxOGE4ZTMwNGQzZWZlN2IxODQzOGU4NDUyOTg4ZDhkZS4uYTRi YzU0OGY1NzM3NTExYjEyNmRmNTdjYWJjNzVlYWE5MjFiOTNhNCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvZGVib3VuY2UuaHRtbAorKysgYi9MYXlvdXRUZXN0 cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9kZWJvdW5jZS5odG1sCkBAIC0xMTksMjYgKzExOSwxNyBA QCBmdW5jdGlvbiB0ZXN0KCkKICAgICBzdWl0ZS5hZGRUZXN0Q2FzZSh7CiAgICAgICAgIG5hbWU6 ICJDYW5jZWwgRGVib3VuY2UiLAogICAgICAgICB0ZXN0OiBmdW5jdGlvbihyZXNvbHZlLCByZWpl Y3QpIHsKLSAgICAgICAgICAgIGxldCBjYWxsQ291bnQgPSAwOwotICAgICAgICAgICAgbGV0IHN0 YXJ0VGltZSA9IHBlcmZvcm1hbmNlLm5vdygpOwotCiAgICAgICAgICAgICBsZXQgb2JqZWN0ID0g ewotICAgICAgICAgICAgICAgIHRlc3QoZm9vLCBiYXIpIHsKKyAgICAgICAgICAgICAgICB0ZXN0 KCkgewogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmZhaWwoIkRlYm91bmNlZCBm dW5jdGlvbiBjYWxsIHNob3VsZCBoYXZlIGJlZW4gY2FuY2VsZWQuIik7CiAgICAgICAgICAgICAg ICAgICAgIHJlc29sdmUoKTsKICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9OwogCi0g ICAgICAgICAgICBvYmplY3QuZGVib3VuY2UoMTAwKS50ZXN0KDEsICd4eXonKTsKKyAgICAgICAg ICAgIG9iamVjdC5kZWJvdW5jZSgxMDApLnRlc3QoKTsKICAgICAgICAgICAgIG9iamVjdC50ZXN0 LmNhbmNlbERlYm91bmNlKCk7CiAKICAgICAgICAgICAgIHNldFRpbWVvdXQoKCkgPT4geyBJbnNw ZWN0b3JUZXN0LnBhc3MoIkRlYm91bmNlZCBmdW5jdGlvbiBjYW5jZWxlZC4iKTsgcmVzb2x2ZSgp OyB9LCAyMDApOwotCi0gICAgICAgICAgICBpZiAoIWNhbGxDb3VudCkKLSAgICAgICAgICAgICAg ICByZXR1cm47Ci0KLSAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZmFpbCgiRGVib3VuY2VkIGZ1 bmN0aW9uIGNhbGxlZCBpbW1lZGlhdGVseS4iKTsKLSAgICAgICAgICAgIHJlc29sdmUoKTsKICAg ICAgICAgfQogICAgIH0pOwogCg== 284365 2016-07-22 13:07:29 -0700 2016-07-22 13:37:31 -0700 [Patch] For Landing bug-160049-20160722130628.patch text/plain 5167 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNTIwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWIzNjc0N2U3ZDgwZTdjM2UwZDRj NDEwNzhlMDY5ZGZmYjVlMGRkNC4uNWRmMGM3ZTgwZGYwYjVhYzcwN2FjYjQxN2RkNjFiMzY5NjIx MTYxMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTIyICBNYXR0IEJha2VyICA8bWF0 dGJha2VyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgdW51c2Vk IGNvZGUgZnJvbSBEZWJvdW5jZSBsYXlvdXQgdGVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMDQ5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8y NzQ3OTcxMz4KKworICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCisKKyAgICAg ICAgKiBpbnNwZWN0b3IvdW5pdC10ZXN0cy9kZWJvdW5jZS1leHBlY3RlZC50eHQ6CisgICAgICAg IFVwZGF0ZWQgd2l0aCBuZXcgZGVsYXkgdGltZXMuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvdW5p dC10ZXN0cy9kZWJvdW5jZS5odG1sOgorICAgICAgICBSZW1vdmUgdW51c2VkIGNvZGUgdGhhdCB3 YXMgY29weS1wYXN0ZWQgZnJvbSBvdGhlciB0ZXN0cywgYW5kIHJlZHVjZWQKKyAgICAgICAgZGVs YXkgdGltZXMgZnJvbSAxMDBtcyB0byAxMG1zIHRvIHNwZWVkIHVwIHRlc3QuCisKIDIwMTYtMDct MjEgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBb aVBob25lXSBQbGF5aW5nIGEgdmlkZW8gb24gdHVkb3UuY29tIHBsYXlzIG9ubHkgc291bmQsIG5v IHZpZGVvCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9kZWJv dW5jZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9kZWJv dW5jZS1leHBlY3RlZC50eHQKaW5kZXggZTk3M2VmM2Q3Y2M1NDRjNGNiNmQ5YjdhM2E2MzJiMWJi MjU5NzFhZi4uYmQwMmU1OTFjMmJkMjJlN2YyYzM0ODgzOTRmMzAxOGFmZmIzYTAzZSAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvZGVib3VuY2UtZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3RzL2RlYm91bmNlLWV4cGVj dGVkLnR4dApAQCAtNCw3ICs0LDcgQEAgVGVzdGluZyBkZWJvdW5jZSBwcm94eSBzdXBwb3J0Lgog PT0gUnVubmluZyB0ZXN0IHN1aXRlOiBEZWJvdWNlCiAtLSBSdW5uaW5nIHRlc3QgY2FzZTogQmFz aWMgRGVib3VuY2UKIFBBU1M6IERlYm91bmNlZCBzdWNjZXNzZnVsbHkuCi1QQVNTOiBDYWxsIGRl bGF5ZWQgYXQgbGVhc3QgMTAwbXMuCitQQVNTOiBDYWxsIGRlbGF5ZWQgYXQgbGVhc3QgMTBtcy4K IFBBU1M6IGB0aGlzYCBpcyB0aGUgcmlnaHQgb2JqZWN0LgogUEFTUzogQXJndW1lbnRzIGxlbmd0 aCBpcyAyLgogUEFTUzogRmlyc3QgYXJndW1lbnQgaXMgNC4KQEAgLTEyLDcgKzEyLDcgQEAgUEFT UzogU2Vjb25kIGFyZ3VtZW50IGlzICdhYmMnLgogCiAtLSBSdW5uaW5nIHRlc3QgY2FzZTogTXVs dGlwbGUgRGVib3VuY2UgRGVsYXlzCiBQQVNTOiBEZWJvdW5jZWQgc3VjY2Vzc2Z1bGx5LgotUEFT UzogQ2FsbCBkZWxheWVkIGF0IGxlYXN0IDQwMG1zLgorUEFTUzogQ2FsbCBkZWxheWVkIGF0IGxl YXN0IDQwbXMuCiBQQVNTOiBgdGhpc2AgaXMgdGhlIHJpZ2h0IG9iamVjdC4KIFBBU1M6IEFyZ3Vt ZW50cyBsZW5ndGggaXMgMi4KIFBBU1M6IEZpcnN0IGFyZ3VtZW50IGlzIDQuCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10ZXN0cy9kZWJvdW5jZS5odG1sIGIvTGF5b3V0 VGVzdHMvaW5zcGVjdG9yL3VuaXQtdGVzdHMvZGVib3VuY2UuaHRtbAppbmRleCA1ODEzNTE1YzE4 YThlMzA0ZDNlZmU3YjE4NDM4ZTg0NTI5ODhkOGRlLi5hZTc3NTk0ZTMwMDYxZWJiODJhZDA0YTI0 MjMxYjY0N2JhYzRhMDg1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvdW5pdC10 ZXN0cy9kZWJvdW5jZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci91bml0LXRlc3Rz L2RlYm91bmNlLmh0bWwKQEAgLTIwLDcgKzIwLDcgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAg ICAgICAgICAgICAgIGVsc2UKICAgICAgICAgICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3Qu ZmFpbCgiRGVib3VuY2VkIGZ1bmN0aW9uIGNhbGxlZCBtdWx0aXBsZSB0aW1lcy4iKTsKIAotICAg ICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQocGVyZm9ybWFuY2Uubm93 KCkgLSBzdGFydFRpbWUgPj0gMTAwLCAiQ2FsbCBkZWxheWVkIGF0IGxlYXN0IDEwMG1zLiIpOwor ICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQocGVyZm9ybWFuY2Uu bm93KCkgLSBzdGFydFRpbWUgPj0gMTAsICJDYWxsIGRlbGF5ZWQgYXQgbGVhc3QgMTBtcy4iKTsK IAogICAgICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQodGhpcyA9PT0g b2JqZWN0LCAiYHRoaXNgIGlzIHRoZSByaWdodCBvYmplY3QuIik7CiAgICAgICAgICAgICAgICAg ICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdChhcmd1bWVudHMubGVuZ3RoID09PSAyLCAiQXJn dW1lbnRzIGxlbmd0aCBpcyAyLiIpOwpAQCAtMzEsNyArMzEsNyBAQCBmdW5jdGlvbiB0ZXN0KCkK ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9OwogCi0gICAgICAgICAgICBsZXQgZGVi b3VuY2VQcm94eSA9IG9iamVjdC5kZWJvdW5jZSgxMDApOworICAgICAgICAgICAgbGV0IGRlYm91 bmNlUHJveHkgPSBvYmplY3QuZGVib3VuY2UoMTApOwogICAgICAgICAgICAgZGVib3VuY2VQcm94 eS50ZXN0KDEsICd4eXonKTsKICAgICAgICAgICAgIGRlYm91bmNlUHJveHkudGVzdCgyLCAnZmdo Jyk7CiAgICAgICAgICAgICBkZWJvdW5jZVByb3h5LnRlc3QoMywgJ2VydCcpOwpAQCAtNTgsNyAr NTgsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAgICAgICAgICAgICAgICAgZWxzZQogICAgICAg ICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5mYWlsKCJEZWJvdW5jZWQgZnVuY3Rpb24g Y2FsbGVkIG11bHRpcGxlIHRpbWVzLiIpOwogCi0gICAgICAgICAgICAgICAgICAgIEluc3BlY3Rv clRlc3QuZXhwZWN0VGhhdChwZXJmb3JtYW5jZS5ub3coKSAtIHN0YXJ0VGltZSA+PSA0MDAsICJD YWxsIGRlbGF5ZWQgYXQgbGVhc3QgNDAwbXMuIik7CisgICAgICAgICAgICAgICAgICAgIEluc3Bl Y3RvclRlc3QuZXhwZWN0VGhhdChwZXJmb3JtYW5jZS5ub3coKSAtIHN0YXJ0VGltZSA+PSA0MCwg IkNhbGwgZGVsYXllZCBhdCBsZWFzdCA0MG1zLiIpOwogCiAgICAgICAgICAgICAgICAgICAgIElu c3BlY3RvclRlc3QuZXhwZWN0VGhhdCh0aGlzID09PSBvYmplY3QsICJgdGhpc2AgaXMgdGhlIHJp Z2h0IG9iamVjdC4iKTsKICAgICAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RU aGF0KGFyZ3VtZW50cy5sZW5ndGggPT09IDIsICJBcmd1bWVudHMgbGVuZ3RoIGlzIDIuIik7CkBA IC02OSwxMCArNjksMTAgQEAgZnVuY3Rpb24gdGVzdCgpCiAgICAgICAgICAgICAgICAgfQogICAg ICAgICAgICAgfTsKIAotICAgICAgICAgICAgb2JqZWN0LmRlYm91bmNlKDEwMCkudGVzdCgxLCAn eHl6Jyk7Ci0gICAgICAgICAgICBvYmplY3QuZGVib3VuY2UoMjAwKS50ZXN0KDIsICdmZ2gnKTsK LSAgICAgICAgICAgIG9iamVjdC5kZWJvdW5jZSgzMDApLnRlc3QoMywgJ2VydCcpOwotICAgICAg ICAgICAgb2JqZWN0LmRlYm91bmNlKDQwMCkudGVzdCg0LCAnYWJjJyk7CisgICAgICAgICAgICBv YmplY3QuZGVib3VuY2UoMTApLnRlc3QoMSwgJ3h5eicpOworICAgICAgICAgICAgb2JqZWN0LmRl Ym91bmNlKDIwKS50ZXN0KDIsICdmZ2gnKTsKKyAgICAgICAgICAgIG9iamVjdC5kZWJvdW5jZSgz MCkudGVzdCgzLCAnZXJ0Jyk7CisgICAgICAgICAgICBvYmplY3QuZGVib3VuY2UoNDApLnRlc3Qo NCwgJ2FiYycpOwogCiAgICAgICAgICAgICBpZiAoIWNhbGxDb3VudCkKICAgICAgICAgICAgICAg ICByZXR1cm47CkBAIC0xMTksMjYgKzExOSwxNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICBzdWl0 ZS5hZGRUZXN0Q2FzZSh7CiAgICAgICAgIG5hbWU6ICJDYW5jZWwgRGVib3VuY2UiLAogICAgICAg ICB0ZXN0OiBmdW5jdGlvbihyZXNvbHZlLCByZWplY3QpIHsKLSAgICAgICAgICAgIGxldCBjYWxs Q291bnQgPSAwOwotICAgICAgICAgICAgbGV0IHN0YXJ0VGltZSA9IHBlcmZvcm1hbmNlLm5vdygp OwotCiAgICAgICAgICAgICBsZXQgb2JqZWN0ID0gewotICAgICAgICAgICAgICAgIHRlc3QoZm9v LCBiYXIpIHsKKyAgICAgICAgICAgICAgICB0ZXN0KCkgewogICAgICAgICAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmZhaWwoIkRlYm91bmNlZCBmdW5jdGlvbiBjYWxsIHNob3VsZCBoYXZlIGJl ZW4gY2FuY2VsZWQuIik7CiAgICAgICAgICAgICAgICAgICAgIHJlc29sdmUoKTsKICAgICAgICAg ICAgICAgICB9CiAgICAgICAgICAgICB9OwogCi0gICAgICAgICAgICBvYmplY3QuZGVib3VuY2Uo MTAwKS50ZXN0KDEsICd4eXonKTsKKyAgICAgICAgICAgIG9iamVjdC5kZWJvdW5jZSgxMCkudGVz dCgpOwogICAgICAgICAgICAgb2JqZWN0LnRlc3QuY2FuY2VsRGVib3VuY2UoKTsKIAotICAgICAg ICAgICAgc2V0VGltZW91dCgoKSA9PiB7IEluc3BlY3RvclRlc3QucGFzcygiRGVib3VuY2VkIGZ1 bmN0aW9uIGNhbmNlbGVkLiIpOyByZXNvbHZlKCk7IH0sIDIwMCk7Ci0KLSAgICAgICAgICAgIGlm ICghY2FsbENvdW50KQotICAgICAgICAgICAgICAgIHJldHVybjsKLQotICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5mYWlsKCJEZWJvdW5jZWQgZnVuY3Rpb24gY2FsbGVkIGltbWVkaWF0ZWx5LiIp OwotICAgICAgICAgICAgcmVzb2x2ZSgpOworICAgICAgICAgICAgc2V0VGltZW91dCgoKSA9PiB7 IEluc3BlY3RvclRlc3QucGFzcygiRGVib3VuY2VkIGZ1bmN0aW9uIGNhbmNlbGVkLiIpOyByZXNv bHZlKCk7IH0sIDIwKTsKICAgICAgICAgfQogICAgIH0pOwogCg==