160036 2016-07-21 11:52:17 -0700 Fix null handling of HTMLFontElement.color 2016-07-21 14:26:50 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/#htmlfontelement WebExposed P2 Normal --- 1 cdumez cdumez benjamin cdumez commit-queue darin dbates esprehn+autocc gyuyoung.kim kondapallykalyan rniwa sam oldest_to_newest 1213229 0 cdumez 2016-07-21 11:52:17 -0700 Fix null handling of HTMLFontElement.color to match the specification: - https://html.spec.whatwg.org/#htmlfontelement We are supposed to treat null as the empty string. Both Firefox and Chrome agree with the specification. 1213238 1 284243 cdumez 2016-07-21 12:12:48 -0700 Created attachment 284243 Patch 1213318 2 284243 cdumez 2016-07-21 14:26:45 -0700 Comment on attachment 284243 Patch Clearing flags on attachment: 284243 Committed r203530: <http://trac.webkit.org/changeset/203530> 1213319 3 cdumez 2016-07-21 14:26:50 -0700 All reviewed patches have been landed. Closing bug. 284243 2016-07-21 12:12:48 -0700 2016-07-21 14:26:45 -0700 Patch bug-160036-20160721121149.patch text/plain 5948 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzAyNTNiMDI4YjM1NjY1 MjljNWJmMmRmMDQ2M2U1MTZjNmQ0Yjg3OC4uZjRiYmVmYThhZjg2MmI1ZWVmOWU3Y2VkMmJiMDIy OWJhM2IwZTdhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTA3LTIxICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IG51bGwgaGFuZGxpbmcg b2YgSFRNTEZvbnRFbGVtZW50LmNvbG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjAwMzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggbnVsbCBoYW5kbGluZyBvZiBIVE1MRm9udEVsZW1lbnQuY29s b3IgdG8gbWF0Y2ggdGhlIHNwZWNpZmljYXRpb246CisgICAgICAgIC0gaHR0cHM6Ly9odG1sLnNw ZWMud2hhdHdnLm9yZy8jaHRtbGZvbnRlbGVtZW50CisKKyAgICAgICAgV2UgYXJlIHN1cHBvc2Vk IHRvIHRyZWF0IG51bGwgYXMgdGhlIGVtcHR5IHN0cmluZy4gQm90aCBGaXJlZm94IGFuZAorICAg ICAgICBDaHJvbWUgYWdyZWUgd2l0aCB0aGUgc3BlY2lmaWNhdGlvbi4KKworICAgICAgICBObyBu ZXcgdGVzdHMsIHJlYmFzZWxpbmVkIGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogaHRtbC9I VE1MRm9udEVsZW1lbnQuaWRsOgorCisyMDE2LTA3LTIxICBDaHJpcyBEdW1leiAgPGNkdW1lekBh cHBsZS5jb20+CisKICAgICAgICAgS2lsbCBsZWdhY3kgdmFsdWVUb1N0cmluZ1dpdGhOdWxsQ2hl Y2soKSB1dGlsaXR5IGZ1bmN0aW9uCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTk5OTEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRm9udEVsZW1lbnQuaWRsIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9udEVsZW1lbnQu aWRsCmluZGV4IGQyZGEzYTllYjk0MTkyOTM0MzY5NmYxNzVmYjQzNGE0ZTFjMGQ0ZTEuLjIyMTUy ZTY0MmIwMTA0Nzg0N2EyMGVkNDk4NzIyNjYyMjhlNjg1ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTEZvbnRFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxGb250RWxlbWVudC5pZGwKQEAgLTE4LDcgKzE4LDcgQEAKICAqLwogCiBpbnRlcmZhY2Ug SFRNTEZvbnRFbGVtZW50IDogSFRNTEVsZW1lbnQgewotICAgIFtSZWZsZWN0XSBhdHRyaWJ1dGUg RE9NU3RyaW5nIGNvbG9yOworICAgIFtSZWZsZWN0LCBUcmVhdE51bGxBcz1FbXB0eVN0cmluZ10g YXR0cmlidXRlIERPTVN0cmluZyBjb2xvcjsKICAgICBbUmVmbGVjdF0gYXR0cmlidXRlIERPTVN0 cmluZyBmYWNlOwogICAgIFtSZWZsZWN0XSBhdHRyaWJ1dGUgRE9NU3RyaW5nIHNpemU7CiB9Owpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IGNjYzg3NjZiMGYzMWZmOTU5M2U0NjNmMzJlOWE0NmNjYzI2ZGU1ODcuLmIyYWI2MThl YWZkMTllY2FjNzE0NzI1Njg5OTU4YjcxZjhmNjgwNTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxNi0wNy0yMSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIEZp eCBudWxsIGhhbmRsaW5nIG9mIEhUTUxGb250RWxlbWVudC5jb2xvcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYwMDM2CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGV4aXN0aW5nIHRlc3QgdG8g cmVmbGVjdCBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBmYXN0L2RvbS9lbGVtZW50LWF0 dHJpYnV0ZS1qcy1udWxsLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2RvbS9lbGVtZW50 LWF0dHJpYnV0ZS1qcy1udWxsLmh0bWw6CisKIDIwMTYtMDctMjEgIENzYWJhIE9zenRyb2dvbsOh YyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBDbGFyaWZ5IHRlc3RpbmcgbW9kZSBuYW1l cyBpbiBydW4tanNjLXN0cmVzcy10ZXN0cwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0 ZWQvdzNjL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKaW5k ZXggZDcyZmNiZTE0OWZkNjJhZjRhNGM2YzFmMzBjYzliMmQ0YWU0MDY5MC4uN2Y2MjI0NTllMGE1 NzBmNGFkYjhlNDlkMmNkMmM3ZjU2MmM5ZGQ5NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDctMjEgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFw cGxlLmNvbT4KKworICAgICAgICBGaXggbnVsbCBoYW5kbGluZyBvZiBIVE1MRm9udEVsZW1lbnQu Y29sb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2 MDAzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl YmFzZWxpbmUgVzNDIHRlc3Qgbm93IHRoYXQgbW9yZSBjaGVja3MgYXJlIHBhc3NpbmcuCisKKyAg ICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vcmVmbGVjdGlvbi1vYnNvbGV0ZS1l eHBlY3RlZC50eHQ6CisKIDIwMTYtMDctMjAgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBGaXggdGltZW91dCBvZiBpbXBvcnRlZC93M2MvV2ViQ3J5cHRvQVBJ L2lkbGhhcm5lc3MuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vZWxlbWVu dC1hdHRyaWJ1dGUtanMtbnVsbC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9l bGVtZW50LWF0dHJpYnV0ZS1qcy1udWxsLWV4cGVjdGVkLnR4dAppbmRleCA1ODIzZTQzMzAyODk5 YmQ2MjM1MDZhNjA1NWQ4NzY1MTk2NTEwNzU5Li4xNTEyYzY2MmYwMDI5MjE0ZWYwMDhjZDkzODcx YmZkNTE5Y2M3ZDU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2RvbS9lbGVtZW50LWF0 dHJpYnV0ZS1qcy1udWxsLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9l bGVtZW50LWF0dHJpYnV0ZS1qcy1udWxsLWV4cGVjdGVkLnR4dApAQCAtNjQsNyArNjQsNyBAQCBU RVNUIFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0aGUgc3RyaW5nICdudWxsJy4gW3Rlc3RlZCBI VE1MRW1iZWRFbGVtZW50LmFsaWduXQogVEVTVCBTVUNDRUVERUQ6IFRoZSB2YWx1ZSB3YXMgdGhl IHN0cmluZyAnbnVsbCcuIFt0ZXN0ZWQgSFRNTEVtYmVkRWxlbWVudC5uYW1lXQogVEVTVCBTVUND RUVERUQ6IFRoZSB2YWx1ZSB3YXMgdGhlIHN0cmluZyAnbnVsbCcuIFt0ZXN0ZWQgSFRNTEVtYmVk RWxlbWVudC50eXBlXQogCi1URVNUIFNVQ0NFRURFRDogVGhlIHZhbHVlIHdhcyB0aGUgc3RyaW5n ICdudWxsJy4gW3Rlc3RlZCBIVE1MRm9udEVsZW1lbnQuY29sb3JdCitURVNUIFNVQ0NFRURFRDog VGhlIHZhbHVlIHdhcyB0aGUgZW1wdHkgc3RyaW5nLiBbdGVzdGVkIEhUTUxGb250RWxlbWVudC5j b2xvcl0KIFRFU1QgU1VDQ0VFREVEOiBUaGUgdmFsdWUgd2FzIHRoZSBzdHJpbmcgJ251bGwnLiBb dGVzdGVkIEhUTUxGb250RWxlbWVudC5mYWNlXQogVEVTVCBTVUNDRUVERUQ6IFRoZSB2YWx1ZSB3 YXMgdGhlIHN0cmluZyAnbnVsbCcuIFt0ZXN0ZWQgSFRNTEZvbnRFbGVtZW50LnNpemVdCiAKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL2VsZW1lbnQtYXR0cmlidXRlLWpzLW51bGwu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL2VsZW1lbnQtYXR0cmlidXRlLWpzLW51bGwuaHRt bAppbmRleCAxZTc3ZTAxM2RmNTdhM2RiN2E1MTU5MjIwNWZiNzEyNzUyOTNmMDQzLi43MjRkODAz YTkwYTEzZDc5ZDQxNWZmOWQyMzI5YzJiMzkxN2E2MGYwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9lbGVtZW50LWF0dHJpYnV0ZS1qcy1udWxsLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9kb20vZWxlbWVudC1hdHRyaWJ1dGUtanMtbnVsbC5odG1sCkBAIC0yMDUsNyArMjA1 LDcgQEAKICAgICAgICAgICAgICAgICAgICAgdHlwZTogJ0hUTUxGb250RWxlbWVudCcsCiAgICAg ICAgICAgICAgICAgICAgIGVsZW1lbnRUb1VzZTogZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZm9u dCcpLAogICAgICAgICAgICAgICAgICAgICBhdHRyaWJ1dGVzOiBbCi0gICAgICAgICAgICAgICAg ICAgICAgICB7bmFtZTogJ2NvbG9yJywgZXhwZWN0ZWROdWxsOiAnbnVsbCd9LAorICAgICAgICAg ICAgICAgICAgICAgICAge25hbWU6ICdjb2xvcicsIGV4cGVjdGVkTnVsbDogJyd9LAogICAgICAg ICAgICAgICAgICAgICAgICAge25hbWU6ICdmYWNlJywgZXhwZWN0ZWROdWxsOiAnbnVsbCd9LAog ICAgICAgICAgICAgICAgICAgICAgICAge25hbWU6ICdzaXplJywgZXhwZWN0ZWROdWxsOiAnbnVs bCd9CiAgICAgICAgICAgICAgICAgICAgIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vcmVmbGVjdGlvbi1vYnNvbGV0ZS1l eHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3Rz L2h0bWwvZG9tL3JlZmxlY3Rpb24tb2Jzb2xldGUtZXhwZWN0ZWQudHh0CmluZGV4IDBkNDgzMTY3 OGZhM2NiMGU2ZjJjMjFmZmM5YjQ0MGYzMzdmZjBmOTQuLmNlMzNkZGU4ZGNkN2Y3N2Q1NzFjY2Zi ZjQxMzdmMzFjZWQzZTQwZjMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy93 ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vcmVmbGVjdGlvbi1vYnNvbGV0ZS1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1s L2RvbS9yZWZsZWN0aW9uLW9ic29sZXRlLWV4cGVjdGVkLnR4dApAQCAtNjQ2MCw4ICs2NDYwLDgg QEAgUEFTUyBmb250LmNvbG9yOiBJREwgc2V0IHRvICJcMCIgc2hvdWxkIG5vdCB0aHJvdwogUEFT UyBmb250LmNvbG9yOiBJREwgc2V0IHRvICJcMCIgZm9sbG93ZWQgYnkgZ2V0QXR0cmlidXRlKCkg CiBQQVNTIGZvbnQuY29sb3I6IElETCBzZXQgdG8gIlwwIiBmb2xsb3dlZCBieSBJREwgZ2V0IAog UEFTUyBmb250LmNvbG9yOiBJREwgc2V0IHRvIG51bGwgc2hvdWxkIG5vdCB0aHJvdyAKLUZBSUwg Zm9udC5jb2xvcjogSURMIHNldCB0byBudWxsIGZvbGxvd2VkIGJ5IGdldEF0dHJpYnV0ZSgpIGFz c2VydF9lcXVhbHM6IGV4cGVjdGVkICIiIGJ1dCBnb3QgIm51bGwiCi1GQUlMIGZvbnQuY29sb3I6 IElETCBzZXQgdG8gbnVsbCBmb2xsb3dlZCBieSBJREwgZ2V0IGFzc2VydF9lcXVhbHM6IGV4cGVj dGVkICIiIGJ1dCBnb3QgIm51bGwiCitQQVNTIGZvbnQuY29sb3I6IElETCBzZXQgdG8gbnVsbCBm b2xsb3dlZCBieSBnZXRBdHRyaWJ1dGUoKSAKK1BBU1MgZm9udC5jb2xvcjogSURMIHNldCB0byBu dWxsIGZvbGxvd2VkIGJ5IElETCBnZXQgCiBQQVNTIGZvbnQuY29sb3I6IElETCBzZXQgdG8gb2Jq ZWN0ICJ0ZXN0LXRvU3RyaW5nIiBzaG91bGQgbm90IHRocm93IAogUEFTUyBmb250LmNvbG9yOiBJ REwgc2V0IHRvIG9iamVjdCAidGVzdC10b1N0cmluZyIgZm9sbG93ZWQgYnkgZ2V0QXR0cmlidXRl KCkgCiBQQVNTIGZvbnQuY29sb3I6IElETCBzZXQgdG8gb2JqZWN0ICJ0ZXN0LXRvU3RyaW5nIiBm b2xsb3dlZCBieSBJREwgZ2V0IAo=