160031 2016-07-21 10:37:03 -0700 REGRESSION(r62549): Objective-C DOM bindings sometimes fail to regenerate when CodeGenerator.pm is modified 2016-07-21 20:01:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg bburg ap bburg cdumez commit-queue darin ddkilzer lforschler mitz rniwa oldest_to_newest 1213185 0 bburg 2016-07-21 10:37:03 -0700 Ryosuke wrote: "Objective-C bindings files may fail to re-generate after https://trac.webkit.org/changeset/203337. Simply trigger clean rebuilds or delete files under DerivedSources/WebCore/ and it should go away." I hit this myself when moving past r203337. I think we have a bad dependency somewhere. Let's investigate in this bug. 1213276 1 darin 2016-07-21 13:26:57 -0700 Ryosuke’s theory was that the binding generator doesn't re-generate .cpp files when CodeGeneratorJS.pm is modified (even though that dependency is explicitly expressed in DerivedSources.make). The best way to test this is to do a build, then do another to check that nothing rebuilds (sort of a "baseline"), then touch CodeGeneratorJS.pm, and see what rebuilds. If too little rebuilds, then we could change things so make is invoked with "-d" and see why the rule that is supposed to trigger rebuilds isn’t working. 1213281 2 bburg 2016-07-21 13:30:19 -0700 (In reply to comment #1) > Ryosuke’s theory was that the binding generator doesn't re-generate .cpp > files when CodeGeneratorJS.pm is modified (even though that dependency is > explicitly expressed in DerivedSources.make). > > The best way to test this is to do a build, then do another to check that > nothing rebuilds (sort of a "baseline"), then touch CodeGeneratorJS.pm, and > see what rebuilds. > > If too little rebuilds, then we could change things so make is invoked with > "-d" and see why the rule that is supposed to trigger rebuilds isn’t working. I am going to kick off a build and see if I can repro this particular case again. 1213289 3 bburg 2016-07-21 13:50:59 -0700 (In reply to comment #1) > Ryosuke’s theory was that the binding generator doesn't re-generate .cpp > files when CodeGeneratorJS.pm is modified (even though that dependency is > explicitly expressed in DerivedSources.make). I believe the relevant Make target is for the output .h files. These are a proxy for the .cpp/.mm files. GENERATE_SCRIPTS = \ bindings/scripts/CodeGenerator.pm \ bindings/scripts/IDLParser.pm \ bindings/scripts/generate-bindings.pl \ bindings/scripts/preprocessor.pm JS_BINDINGS_SCRIPTS = $(GENERATE_SCRIPTS) bindings/scripts/CodeGeneratorJS.pm JS%.h : %.idl $(JS_BINDINGS_SCRIPTS) $(IDL_ATTRIBUTES_FILE) $(WINDOW_CONSTRUCTORS_FILE) $(WORKERGLOBALSCOPE_CONSTRUCTORS_FILE) $(PLATFORM_FEATURE_DEFINES) $(call generator_script, $(JS_BINDINGS_SCRIPTS)) $(IDL_COMMON_ARGS) --defines "$(FEATURE_DEFINES) $(ADDITIONAL_IDL_DEFINES) LANGUAGE_JAVASCRIPT" --generator JS --idlAttributesFile $(IDL_ATTRIBUTES_FILE) --supplementalDependencyFile $(SUPPLEMENTAL_DEPENDENCY_FILE) $< 1213290 4 bburg 2016-07-21 13:53:13 -0700 The build is still going, but my hunch is that we are missing $(WEBCORE) prefixes from some bindings files. 1213348 5 bburg 2016-07-21 15:09:03 -0700 Validating a fix. 1213355 6 284269 bburg 2016-07-21 15:29:34 -0700 Created attachment 284269 Proposed Fix 1213473 7 284269 commit-queue 2016-07-21 20:01:06 -0700 Comment on attachment 284269 Proposed Fix Clearing flags on attachment: 284269 Committed r203549: <http://trac.webkit.org/changeset/203549> 1213474 8 commit-queue 2016-07-21 20:01:10 -0700 All reviewed patches have been landed. Closing bug. 284269 2016-07-21 15:29:34 -0700 2016-07-21 20:01:06 -0700 Proposed Fix bug-160031-20160721152833.patch text/plain 2567 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTQxNmVjYWM1NTczMjU1 YTNhZTZjMjMzNmZkNGU4YTNlMDM2ZTZmYi4uMjM2YTRjYzIxMjI2NWQxMTMwZmI5MGFlM2E3YjYx NDA3MDFjNDVmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA3LTIxICBCcmlh biBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjYyNTQ5KTog T2JqZWN0aXZlLUMgRE9NIGJpbmRpbmdzIHNvbWV0aW1lcyBmYWlsIHRvIHJlZ2VuZXJhdGUgd2hl biBDb2RlR2VuZXJhdG9yLnBtIGlzIG1vZGlmaWVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjAwMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGJ1ZyB3YXMgY2F1c2VkIGJ5IGEgcmVmYWN0b3Jp bmcgNiB5ZWFycyBhZ28uIE5vdCBhbGwgdXNlcyBvZiBhIHZhcmlhYmxlCisgICAgICAgIHdlcmUg cmVuYW1lZCwgc28gdGhlIE9iakMgYmluZGluZ3MgdGFyZ2V0IHBhdHRlcm4gd2FzIG5vdCBzcGVj aWZ5aW5nIGFueQorICAgICAgICBidWlsZCBzY3JpcHRzIGFzIHRhcmdldCBkZXBlbmRlbmNpZXMu CisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5tYWtlOiBTdGFuZGFyZGl6ZSBvbiB7Q09NTU9O LEpTLERPTX1fQklORElOR1NfU0NSSVBUUy4KKwogMjAxNi0wNy0xNyAgUnlvc3VrZSBOaXdhICA8 cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZW5hbWUgZmFzdEhhc0F0dHJpYnV0ZSB0byBo YXNBdHRyaWJ1dGVXaXRob3V0U3luY2hyb25pemF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9EZXJpdmVkU291cmNlcy5tYWtlIGIvU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMu bWFrZQppbmRleCBhOWFiYjVlZTk2MzRlNmVlMDA1NDE0MGE4YTAyMDFjMDY1MTQ2NmU3Li5kYWI2 ODQwN2E4YTk0MTdjYjIzZmY2MGM5ZmE1NjA3NTk1NTRmZTJlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL0Rlcml2ZWRT b3VyY2VzLm1ha2UKQEAgLTExODEsNyArMTE4MSw3IEBAIE1ha2VTZXR0aW5ncy5pbnRlcm1lZGlh dGUgOiBwYWdlL21ha2Vfc2V0dGluZ3MucGwgcGFnZS9TZXR0aW5ncy5pbgogCiAjIENvbW1vbiBn ZW5lcmF0b3IgdGhpbmdzCiAKLUdFTkVSQVRFX1NDUklQVFMgPSBcCitDT01NT05fQklORElOR1Nf U0NSSVBUUyA9IFwKICAgICBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0gXAogICAg IGJpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtIFwKICAgICBiaW5kaW5ncy9zY3JpcHRzL2dl bmVyYXRlLWJpbmRpbmdzLnBsIFwKQEAgLTEyMTcsNyArMTIxNyw3IEBAIElETF9JTkNMVURFUyA9 IFwKIAogSURMX0NPTU1PTl9BUkdTID0gJChJRExfSU5DTFVERVM6JT0tLWluY2x1ZGUgJSkgLS13 cml0ZS1kZXBlbmRlbmNpZXMgLS1vdXRwdXREaXIgLgogCi1KU19CSU5ESU5HU19TQ1JJUFRTID0g JChHRU5FUkFURV9TQ1JJUFRTKSBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQor SlNfQklORElOR1NfU0NSSVBUUyA9ICQoQ09NTU9OX0JJTkRJTkdTX1NDUklQVFMpIGJpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvckpTLnBtCiAKIFNVUFBMRU1FTlRBTF9ERVBFTkRFTkNZX0ZJ TEUgPSAuL1N1cHBsZW1lbnRhbERlcGVuZGVuY2llcy50eHQKIFNVUFBMRU1FTlRBTF9NQUtFRklM RV9ERVBTID0gLi9TdXBwbGVtZW50YWxEZXBlbmRlbmNpZXMuZGVwCkBAIC0xMzYxLDcgKzEzNjEs NyBAQCBDaGFyc2V0RGF0YS5jcHAgOiBwbGF0Zm9ybS90ZXh0L21hYy9tYWtlLWNoYXJzZXQtdGFi bGUucGwgcGxhdGZvcm0vdGV4dC9tYWMvY2hhcgogCiAjIE9iamVjdGl2ZS1DIGJpbmRpbmdzCiAK LURPTV9CSU5ESU5HU19TQ1JJUFRTID0gJChHRU5FUkFURV9CSU5ESU5HX1NDUklQVFMpIGJpbmRp bmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvck9iakMucG0KK0RPTV9CSU5ESU5HU19TQ1JJUFRTID0g JChDT01NT05fQklORElOR1NfU0NSSVBUUykgYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9y T2JqQy5wbQogRE9NJS5oIDogJS5pZGwgJChET01fQklORElOR1NfU0NSSVBUUykgYmluZGluZ3Mv b2JqYy9QdWJsaWNET01JbnRlcmZhY2VzLmggJChQTEFURk9STV9GRUFUVVJFX0RFRklORVMpCiAJ JChjYWxsIGdlbmVyYXRvcl9zY3JpcHQsICQoRE9NX0JJTkRJTkdTX1NDUklQVFMpKSAkKElETF9D T01NT05fQVJHUykgLS1kZWZpbmVzICIkKEZFQVRVUkVfREVGSU5FUykgJChBRERJVElPTkFMX0lE TF9ERUZJTkVTKSBMQU5HVUFHRV9PQkpFQ1RJVkVfQyIgLS1nZW5lcmF0b3IgT2JqQyAtLXN1cHBs ZW1lbnRhbERlcGVuZGVuY3lGaWxlICQoU1VQUExFTUVOVEFMX0RFUEVOREVOQ1lfRklMRSkgJDwK IAo=