159991 2016-07-20 16:19:01 -0700 Kill legacy valueToStringWithNullCheck() utility function 2016-07-21 11:41:04 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez benjamin cdumez commit-queue darin dbates esprehn+autocc ggaren gyuyoung.kim kondapallykalyan rniwa sam youennf oldest_to_newest 1212929 0 cdumez 2016-07-20 16:19:01 -0700 Kill legacy valueToStringWithNullCheck() utility function. Treating null as a null string is legacy behavior so drop this function so that people are not tempted to use it. We should be using either: 1. JSValue::toWTFString() for non-nullable DOMStrings 2. valueToStringWithUndefinedOrNullCheck() for nullable DOMStrings 3. valueToStringTreatingNullAsEmptyString() for strings with [TreatNullAs=EmptyString] 1212934 1 284165 cdumez 2016-07-20 16:26:46 -0700 Created attachment 284165 Patch 1213139 2 284165 cdumez 2016-07-21 09:02:06 -0700 Comment on attachment 284165 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284165&action=review > Source/WebCore/bindings/js/JSHTMLFrameElementCustom.cpp:57 > + String locationValue = value.isNull() ? String() : value.toWTFString(&state); I maintained the previous behavior for this setter (treating null as the null String) even though this behavior is non-standard since the attribute is non-standard. It was never implemented in Firefox / IE and Chrome dropped it a while back after getting usage data showing this was barely used. I personally think we should try and drop this attribute as well but I did not want to do this in this patch. 1213218 3 284165 cdumez 2016-07-21 11:40:59 -0700 Comment on attachment 284165 Patch Clearing flags on attachment: 284165 Committed r203516: <http://trac.webkit.org/changeset/203516> 1213219 4 cdumez 2016-07-21 11:41:04 -0700 All reviewed patches have been landed. Closing bug. 284165 2016-07-20 16:26:46 -0700 2016-07-21 11:40:59 -0700 Patch bug-159991-20160720162548.patch text/plain 4406 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI3Y2RiZjdiZDUxODJm Yjk3ODg5NGQ4NjBiZGNjYjlhZDBkMThkNi4uZDYzMjAxZjRjNzE4OTY4YWM0MWE3MGI2YWRjOWU4 NDkzOGVkZTI2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE2LTA3LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgS2lsbCBsZWdhY3kgdmFsdWVU b1N0cmluZ1dpdGhOdWxsQ2hlY2soKSB1dGlsaXR5IGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk5OTEKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBLaWxsIGxlZ2FjeSB2YWx1ZVRvU3RyaW5n V2l0aE51bGxDaGVjaygpIHV0aWxpdHkgZnVuY3Rpb24uIFRyZWF0aW5nIG51bGwgYXMKKyAgICAg ICAgYSBudWxsIHN0cmluZyBpcyBsZWdhY3kgYmVoYXZpb3Igc28gZHJvcCB0aGlzIGZ1bmN0aW9u IHNvIHRoYXQgcGVvcGxlIGFyZQorICAgICAgICBub3QgdGVtcHRlZCB0byB1c2UgaXQuIFdlIHNo b3VsZCBiZSB1c2luZyBlaXRoZXI6CisgICAgICAgIDEuIEpTVmFsdWU6OnRvV1RGU3RyaW5nKCkg Zm9yIG5vbi1udWxsYWJsZSBET01TdHJpbmdzCisgICAgICAgIDIuIHZhbHVlVG9TdHJpbmdXaXRo VW5kZWZpbmVkT3JOdWxsQ2hlY2soKSBmb3IgbnVsbGFibGUgRE9NU3RyaW5ncworICAgICAgICAz LiB2YWx1ZVRvU3RyaW5nVHJlYXRpbmdOdWxsQXNFbXB0eVN0cmluZygpIGZvciBzdHJpbmdzIHdp dGggW1RyZWF0TnVsbEFzPUVtcHR5U3RyaW5nXQorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgbm8g d2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNE T01CaW5kaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnZhbHVlVG9TdHJpbmdXaXRoTnVsbENo ZWNrKTogRGVsZXRlZC4KKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaDoKKyAg ICAgICAgKiBiaW5kaW5ncy9qcy9KU0hUTUxGcmFtZUVsZW1lbnRDdXN0b20uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6SlNIVE1MRnJhbWVFbGVtZW50OjpzZXRMb2NhdGlvbik6CisgICAgICAgICog aHRtbC9IVE1MRnJhbWVFbGVtZW50LmlkbDoKKworMjAxNi0wNy0yMCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIFN0b3AgdXNpbmcgdmFsdWVUb1N0cmluZ1dpdGhO dWxsQ2hlY2soKSBpbiBKU0NTU1N0eWxlRGVjbGFyYXRpb246OnB1dERlbGVnYXRlKCkKICAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTk4MgogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNET01CaW5kaW5nLmNwcAppbmRleCA1ZTJhZjAyYzk4 ZTAxNGNlODQ4Mjg0MTNmOTI5OGE2Y2ZmMDFiM2RlLi5kZGY0OWJlYWI4YjQ2M2JhYWY0M2ZhNWNm NzA2NDE0OTA4MWVkNTRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U0RPTUJpbmRpbmcuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmlu ZGluZy5jcHAKQEAgLTEwMywxMyArMTAzLDYgQEAgSlNWYWx1ZSBqc1N0cmluZ09yVW5kZWZpbmVk KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgVVJMJiB1cmwpCiAgICAgcmV0dXJuIGpzU3RyaW5nV2l0 aENhY2hlKGV4ZWMsIHVybC5zdHJpbmcoKSk7CiB9CiAKLVN0cmluZyB2YWx1ZVRvU3RyaW5nV2l0 aE51bGxDaGVjayhFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgdmFsdWUpCi17Ci0gICAgaWYgKHZh bHVlLmlzTnVsbCgpKQotICAgICAgICByZXR1cm4gU3RyaW5nKCk7Ci0gICAgcmV0dXJuIHZhbHVl LnRvU3RyaW5nKGV4ZWMpLT52YWx1ZShleGVjKTsKLX0KLQogU3RyaW5nIHZhbHVlVG9TdHJpbmdU cmVhdGluZ051bGxBc0VtcHR5U3RyaW5nKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSB2YWx1ZSkK IHsKICAgICBpZiAodmFsdWUuaXNOdWxsKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT RE9NQmluZGluZy5oCmluZGV4IDQ1ZDlmOTdjNWZmZGVkMzlkZGU1YTJmYmIyOWY1YWY4ZmE4NmFl ZTUuLjcyNmZhNzI5MjM1YjYwYzZmNDNhOGYzNmQxOGE0YTA2NmM2ZWU2NDMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCkBAIC0xOTYsOSArMTk2LDYgQEAgU3Ry aW5nIHByb3BlcnR5TmFtZVRvU3RyaW5nKEpTQzo6UHJvcGVydHlOYW1lKTsKIAogQXRvbWljU3Ry aW5nIHByb3BlcnR5TmFtZVRvQXRvbWljU3RyaW5nKEpTQzo6UHJvcGVydHlOYW1lKTsKIAotLy8g RklYTUU6IFRoaXMgaXMgb25seSB1c2VkIGJ5IGxlZ2FjeSBjb2RlIGFuZCBzaG91bGQgZ28gYXdh eS4gVXNlIHZhbHVlVG9TdHJpbmdUcmVhdGluZ051bGxBc0VtcHR5U3RyaW5nKCkgaW5zdGVhZC4K LVN0cmluZyB2YWx1ZVRvU3RyaW5nV2l0aE51bGxDaGVjayhKU0M6OkV4ZWNTdGF0ZSosIEpTQzo6 SlNWYWx1ZSk7IC8vIG51bGwgaWYgdGhlIHZhbHVlIGlzIG51bGwKLQogU3RyaW5nIHZhbHVlVG9T dHJpbmdUcmVhdGluZ051bGxBc0VtcHR5U3RyaW5nKEpTQzo6RXhlY1N0YXRlKiwgSlNDOjpKU1Zh bHVlKTsKIFN0cmluZyB2YWx1ZVRvU3RyaW5nV2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKEpTQzo6 RXhlY1N0YXRlKiwgSlNDOjpKU1ZhbHVlKTsgLy8gbnVsbCBpZiB0aGUgdmFsdWUgaXMgbnVsbCBv ciB1bmRlZmluZWQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNI VE1MRnJhbWVFbGVtZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT SFRNTEZyYW1lRWxlbWVudEN1c3RvbS5jcHAKaW5kZXggNmZkNWE5N2IyNTdjNjA4NThmODkyOWIy ZTlhMjk5MWI1N2RmMWUyOS4uZGMyOTkwNWEzMmFlMjNiOGIyODQ4NGM0NjZiYzJlZmQxYTBhMmNk MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNIVE1MRnJhbWVFbGVt ZW50Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0hUTUxGcmFt ZUVsZW1lbnRDdXN0b20uY3BwCkBAIC01NCw3ICs1NCw3IEBAIHN0YXRpYyBpbmxpbmUgYm9vbCBh bGxvd1NldHRpbmdKYXZhc2NyaXB0VVJMKEV4ZWNTdGF0ZSYgc3RhdGUsIEhUTUxGcmFtZUVsZW1l bnQqCiB2b2lkIEpTSFRNTEZyYW1lRWxlbWVudDo6c2V0TG9jYXRpb24oRXhlY1N0YXRlJiBzdGF0 ZSwgSlNWYWx1ZSB2YWx1ZSkKIHsKICAgICBIVE1MRnJhbWVFbGVtZW50JiBpbXAgPSB3cmFwcGVk KCk7Ci0gICAgU3RyaW5nIGxvY2F0aW9uVmFsdWUgPSB2YWx1ZVRvU3RyaW5nV2l0aE51bGxDaGVj aygmc3RhdGUsIHZhbHVlKTsKKyAgICBTdHJpbmcgbG9jYXRpb25WYWx1ZSA9IHZhbHVlLmlzTnVs bCgpID8gU3RyaW5nKCkgOiB2YWx1ZS50b1dURlN0cmluZygmc3RhdGUpOwogCiAgICAgaWYgKCFh bGxvd1NldHRpbmdKYXZhc2NyaXB0VVJMKHN0YXRlLCAmaW1wLCBsb2NhdGlvblZhbHVlKSkKICAg ICAgICAgcmV0dXJuOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRnJhbWVF bGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZyYW1lRWxlbWVudC5pZGwKaW5k ZXggNzVjY2FlZDAwOTI3MDNhOTQ3ODViMjY0OTQzNGI0YTkzODc4NGQ0Mi4uODI0MjM1YTMyNjky MDA3MzkwMTJhNDVkMWI2OTczMGIxNjAwZTc3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MRnJhbWVFbGVtZW50LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxG cmFtZUVsZW1lbnQuaWRsCkBAIC00MSw2ICs0MSw3IEBAIGludGVyZmFjZSBIVE1MRnJhbWVFbGVt ZW50IDogSFRNTEVsZW1lbnQgewogICAgIFtDaGVja1NlY3VyaXR5Rm9yTm9kZSwgUmFpc2VzRXhj ZXB0aW9uXSBTVkdEb2N1bWVudCBnZXRTVkdEb2N1bWVudCgpOwogI2VuZGlmCiAKKyAgICAvLyBG SVhNRTogTm8gb3RoZXIgYnJvd3NlciBoYXMgdGhpcyBhdHRyaWJ1dGUuCiAgICAgW0N1c3RvbVNl dHRlcl0gYXR0cmlidXRlIERPTVN0cmluZyBsb2NhdGlvbjsKIAogICAgIHJlYWRvbmx5IGF0dHJp YnV0ZSBsb25nIHdpZHRoOwo=