159990 2016-07-20 15:54:28 -0700 REGRESSION(r148588): ews classes might get garbage collected 2016-07-20 17:29:03 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=114558 https://bugs.webkit.org/show_bug.cgi?id=160001 https://bugs.webkit.org/show_bug.cgi?id=159539 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue glenn lforschler rniwa oldest_to_newest 1212911 0 aakash_jain 2016-07-20 15:54:28 -0700 sometimes running webkit-patch command for ews queues fails with below error. buildbot$ ./Tools/Scripts/webkit-patch ios-ews --bot-id=bot110 --exit-after-iteration 1 Usage: webkit-patch [options] COMMAND [ARGS] webkit-patch: error: no such option: --exit-after-iteration It happens because webkit-patch sometimes do not know about ews classes. This happens because AbstractEarlyWarningSystem.load_ews_classes() is called in webkitpy/tool/commands/__init__.py, but the result is not stored in a variable and it might get garbage collected. 1212918 1 aakash_jain 2016-07-20 16:05:44 -0700 This issue got exposed by a recent commit <http://trac.webkit.org/r203386>, and we did a temporary fix <http://trac.webkit.org/r203417>. 1212919 2 284162 aakash_jain 2016-07-20 16:06:07 -0700 Created attachment 284162 Proposed patch 1212938 3 284162 commit-queue 2016-07-20 16:29:20 -0700 Comment on attachment 284162 Proposed patch Clearing flags on attachment: 284162 Committed r203479: <http://trac.webkit.org/changeset/203479> 1212939 4 commit-queue 2016-07-20 16:29:25 -0700 All reviewed patches have been landed. Closing bug. 1212951 5 284162 ap 2016-07-20 17:08:56 -0700 Comment on attachment 284162 Proposed patch Aakash, could you please revert the temporary fix? 1212968 6 aakash_jain 2016-07-20 17:28:23 -0700 sure, reverting it in https://bugs.webkit.org/show_bug.cgi?id=160001 284162 2016-07-20 16:06:07 -0700 2016-07-20 16:29:20 -0700 Proposed patch ews-load-classes text/plain 1171 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwMzQ3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE2LTA3LTIwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxNDg1ODgpOiBld3MgY2xhc3NlcyBtaWdodCBnZXQg Z2FyYmFnZSBjb2xsZWN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE1OTk5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL19faW5pdF9fLnB5OiBT dG9yZSB0aGUgbG9hZGVkIGV3cyBjbGFzc2VzCisgICAgICAgIGluIGEgdmFyaWFibGUgc28gdGhh dCB0aGV5IGRvIG5vdCBnZXQgZ2FyYmFnZSBjb2xsZWN0ZWQuCisKIDIwMTYtMDctMjAgIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCBp T1MgYnVpbGQgZml4LgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L19faW5pdF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j b21tYW5kcy9fX2luaXRfXy5weQkocmV2aXNpb24gMjAzNDczKQorKysgVG9vbHMvU2NyaXB0cy93 ZWJraXRweS90b29sL2NvbW1hbmRzL19faW5pdF9fLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMiw0 ICsyMiw0IEBAIGZyb20gd2Via2l0cHkudG9vbC5jb21tYW5kcy5zaGVyaWZmYm90IGkKIGZyb20g d2Via2l0cHkudG9vbC5jb21tYW5kcy51cGxvYWQgaW1wb3J0ICoKIGZyb20gd2Via2l0cHkudG9v bC5jb21tYW5kcy5zdWdnZXN0bm9taW5hdGlvbnMgaW1wb3J0ICoKIAotQWJzdHJhY3RFYXJseVdh cm5pbmdTeXN0ZW0ubG9hZF9ld3NfY2xhc3NlcygpCitjbGFzc2VzID0gQWJzdHJhY3RFYXJseVdh cm5pbmdTeXN0ZW0ubG9hZF9ld3NfY2xhc3NlcygpCg==