159984 2016-07-20 13:46:22 -0700 Get rid of custom bindings code for XMLHttpRequest.open() 2016-07-20 15:04:40 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://xhr.spec.whatwg.org/#xmlhttprequest P2 Normal --- 1 cdumez cdumez ap cdumez commit-queue darin dbates esprehn+autocc kondapallykalyan rniwa oldest_to_newest 1212866 0 cdumez 2016-07-20 13:46:22 -0700 Get rid of custom bindings code for XMLHttpRequest.open() as the bindings generator is able to generate it. Relevant specification: - https://xhr.spec.whatwg.org/#xmlhttprequest The issue is that legacy content prevents treating the 'async' argument being undefined identical from it being omitted. However, this can be achieved by using overloading in IDL, like in the specification. 1212875 1 284147 cdumez 2016-07-20 14:08:11 -0700 Created attachment 284147 Patch 1212892 2 284147 cdumez 2016-07-20 15:04:35 -0700 Comment on attachment 284147 Patch Clearing flags on attachment: 284147 Committed r203470: <http://trac.webkit.org/changeset/203470> 1212893 3 cdumez 2016-07-20 15:04:40 -0700 All reviewed patches have been landed. Closing bug. 284147 2016-07-20 14:08:11 -0700 2016-07-20 15:04:35 -0700 Patch bug-159984-20160720140713.patch text/plain 7470 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE3M2EzMDA5ZmFkYjNl ZjI0MjI3MDhhN2M0Y2QwNTM3NGQ1MWE3ZS4uMmM0YzA2Mzg5NGQ4ZGMwNDg3ZDc2NDA3NWE2YTY3 ZmU0YWY3YjExOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDE2LTA3LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiBjdXN0b20g YmluZGluZ3MgY29kZSBmb3IgWE1MSHR0cFJlcXVlc3Qub3BlbigpCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk5ODQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXQgcmlkIG9mIGN1c3RvbSBiaW5kaW5n cyBjb2RlIGZvciBYTUxIdHRwUmVxdWVzdC5vcGVuKCkgYXMgdGhlCisgICAgICAgIGJpbmRpbmdz IGdlbmVyYXRvciBpcyBhYmxlIHRvIGdlbmVyYXRlIGl0LgorCisgICAgICAgIFJlbGV2YW50IHNw ZWNpZmljYXRpb246CisgICAgICAgIC0gaHR0cHM6Ly94aHIuc3BlYy53aGF0d2cub3JnLyN4bWxo dHRwcmVxdWVzdAorCisgICAgICAgIFRoZSBpc3N1ZSBpcyB0aGF0IGxlZ2FjeSBjb250ZW50IHBy ZXZlbnRzIHRyZWF0aW5nIHRoZSAnYXN5bmMnIGFyZ3VtZW50CisgICAgICAgIGJlaW5nIHVuZGVm aW5lZCBpZGVudGljYWwgZnJvbSBpdCBiZWluZyBvbWl0dGVkLiBIb3dldmVyLCB0aGlzIGNhbiBi ZQorICAgICAgICBhY2hpZXZlZCBieSB1c2luZyBvdmVybG9hZGluZyBpbiBJREwsIGxpa2UgaW4g dGhlIHNwZWNpZmljYXRpb24uCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbHJlYWR5IGNvdmVy ZWQgYnkgdGhlIGZvbGxvd2luZyB0ZXN0czoKKyAgICAgICAgLSBodHRwL3Rlc3RzL3htbGh0dHBy ZXF1ZXN0L2Jhc2ljLWF1dGguaHRtbAorICAgICAgICAtIGh0dHAvdGVzdHMveG1saHR0cHJlcXVl c3Qvb3Blbi1hc3luYy1vdmVybG9hZC5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU1hN TEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNlbmRGdW5jdG9yOjpT ZW5kRnVuY3Rvcik6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTZW5kRnVuY3Rvcjo6bGlu ZSk6IERlbGV0ZWQuCisgICAgICAgIChXZWJDb3JlOjpTZW5kRnVuY3Rvcjo6Y29sdW1uKTogRGVs ZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlNlbmRGdW5jdG9yOjp1cmwpOiBEZWxldGVkLgorICAg ICAgICAoV2ViQ29yZTo6U2VuZEZ1bmN0b3I6Om9wZXJhdG9yKCkpOiBEZWxldGVkLgorICAgICAg ICAqIHhtbC9YTUxIdHRwUmVxdWVzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVx dWVzdDo6b3Blbik6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0Lmg6CisgICAgICAgICog eG1sL1hNTEh0dHBSZXF1ZXN0LmlkbDoKKwogMjAxNi0wNy0yMCAgQnJhZHkgRWlkc29uICA8YmVp ZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVHJhbnNpdGlvbiBtb3N0IElEQiBpbnRlcmZhY2Vz IGZyb20gU2NyaXB0RXhlY3V0aW9uQ29udGV4dCB0byBFeGVjU3RhdGUuCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1hNTEh0dHBSZXF1ZXN0Q3VzdG9tLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCmluZGV4 IDc0Y2NiOTYzZGJlNGU1ZmVkM2FjM2NmMWVkOTc4Yzk3NWFmMjEyZWYuLjQ0MjI1ZjMwZjZkZDQz NGU2ODlkZDkzMWM4YWJiMDE2YmQ5MmQ0ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTWE1MSHR0cFJlcXVlc3RDdXN0b20uY3BwCkBAIC03MSwzNSArNzEsNiBA QCB2b2lkIEpTWE1MSHR0cFJlcXVlc3Q6OnZpc2l0QWRkaXRpb25hbENoaWxkcmVuKFNsb3RWaXNp dG9yJiB2aXNpdG9yKQogICAgICAgICB2aXNpdG9yLmFkZE9wYXF1ZVJvb3QocmVzcG9uc2VCbG9i KTsKIH0KIAotLy8gQ3VzdG9tIGZ1bmN0aW9ucwotSlNWYWx1ZSBKU1hNTEh0dHBSZXF1ZXN0Ojpv cGVuKEV4ZWNTdGF0ZSYgc3RhdGUpCi17Ci0gICAgaWYgKHN0YXRlLmFyZ3VtZW50Q291bnQoKSA8 IDIpCi0gICAgICAgIHJldHVybiBzdGF0ZS52bSgpLnRocm93RXhjZXB0aW9uKCZzdGF0ZSwgY3Jl YXRlTm90RW5vdWdoQXJndW1lbnRzRXJyb3IoJnN0YXRlKSk7Ci0KLSAgICBjb25zdCBVUkwmIHVy bCA9IHdyYXBwZWQoKS5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPmNvbXBsZXRlVVJMKHN0YXRl LnVuY2hlY2tlZEFyZ3VtZW50KDEpLnRvU3RyaW5nKCZzdGF0ZSktPnZhbHVlKCZzdGF0ZSkpOwot ICAgIFN0cmluZyBtZXRob2QgPSBzdGF0ZS51bmNoZWNrZWRBcmd1bWVudCgwKS50b1N0cmluZygm c3RhdGUpLT52YWx1ZSgmc3RhdGUpOwotCi0gICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7Ci0gICAg aWYgKHN0YXRlLmFyZ3VtZW50Q291bnQoKSA+PSAzKSB7Ci0gICAgICAgIGJvb2wgYXN5bmMgPSBz dGF0ZS51bmNoZWNrZWRBcmd1bWVudCgyKS50b0Jvb2xlYW4oJnN0YXRlKTsKLSAgICAgICAgaWYg KCFzdGF0ZS5hcmd1bWVudCgzKS5pc1VuZGVmaW5lZCgpKSB7Ci0gICAgICAgICAgICBTdHJpbmcg dXNlciA9IHZhbHVlVG9TdHJpbmdXaXRoTnVsbENoZWNrKCZzdGF0ZSwgc3RhdGUudW5jaGVja2Vk QXJndW1lbnQoMykpOwotCi0gICAgICAgICAgICBpZiAoIXN0YXRlLmFyZ3VtZW50KDQpLmlzVW5k ZWZpbmVkKCkpIHsKLSAgICAgICAgICAgICAgICBTdHJpbmcgcGFzc3dvcmQgPSB2YWx1ZVRvU3Ry aW5nV2l0aE51bGxDaGVjaygmc3RhdGUsIHN0YXRlLnVuY2hlY2tlZEFyZ3VtZW50KDQpKTsKLSAg ICAgICAgICAgICAgICB3cmFwcGVkKCkub3BlbihtZXRob2QsIHVybCwgYXN5bmMsIHVzZXIsIHBh c3N3b3JkLCBlYyk7Ci0gICAgICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICB3cmFwcGVk KCkub3BlbihtZXRob2QsIHVybCwgYXN5bmMsIHVzZXIsIGVjKTsKLSAgICAgICAgfSBlbHNlCi0g ICAgICAgICAgICB3cmFwcGVkKCkub3BlbihtZXRob2QsIHVybCwgYXN5bmMsIGVjKTsKLSAgICB9 IGVsc2UKLSAgICAgICAgd3JhcHBlZCgpLm9wZW4obWV0aG9kLCB1cmwsIGVjKTsKLQotICAgIHNl dERPTUV4Y2VwdGlvbigmc3RhdGUsIGVjKTsKLSAgICByZXR1cm4ganNVbmRlZmluZWQoKTsKLX0K LQogY2xhc3MgU2VuZEZ1bmN0b3IgewogcHVibGljOgogICAgIFNlbmRGdW5jdG9yKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3BwCmluZGV4IGU3MTlkZjJiYzAzMTFhYzBjZWY1YzZm MzhmZDU2ZDc3ZjU3ZThkMzkuLmVmNDk0MzNlYzliOTE5MzA0MjcwZjllZDM0M2NlNTA3YjU2ZTIy MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcApAQCAtNDIxLDkgKzQyMSwx MCBAQCBib29sIFhNTEh0dHBSZXF1ZXN0Ojppc0FsbG93ZWRIVFRQSGVhZGVyKGNvbnN0IFN0cmlu ZyYgbmFtZSkKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAotdm9pZCBYTUxIdHRwUmVxdWVzdDo6b3Bl bihjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgVVJMJiB1cmwsIEV4Y2VwdGlvbkNvZGUmIGVj KQordm9pZCBYTUxIdHRwUmVxdWVzdDo6b3Blbihjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3Qg U3RyaW5nJiB1cmwsIEV4Y2VwdGlvbkNvZGUmIGVjKQogewotICAgIG9wZW4obWV0aG9kLCB1cmws IHRydWUsIGVjKTsKKyAgICAvLyBJZiB0aGUgYXN5bmMgYXJndW1lbnQgaXMgb21pdHRlZCwgc2V0 IGFzeW5jIHRvIHRydWUuCisgICAgcmV0dXJuIG9wZW4obWV0aG9kLCBzY3JpcHRFeGVjdXRpb25D b250ZXh0KCktPmNvbXBsZXRlVVJMKHVybCksIHRydWUsIGVjKTsKIH0KIAogdm9pZCBYTUxIdHRw UmVxdWVzdDo6b3Blbihjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgVVJMJiB1cmwsIGJvb2wg YXN5bmMsIEV4Y2VwdGlvbkNvZGUmIGVjKQpAQCAtNDk1LDE5ICs0OTYsMTQgQEAgdm9pZCBYTUxI dHRwUmVxdWVzdDo6b3Blbihjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgVVJMJiB1cmwsIGJv b2wgYXN5bmMsIEV4Y2UKICAgICAgICAgbV9zdGF0ZSA9IE9QRU5FRDsKIH0KIAotdm9pZCBYTUxI dHRwUmVxdWVzdDo6b3Blbihjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgVVJMJiB1cmwsIGJv b2wgYXN5bmMsIGNvbnN0IFN0cmluZyYgdXNlciwgRXhjZXB0aW9uQ29kZSYgZWMpCit2b2lkIFhN TEh0dHBSZXF1ZXN0OjpvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBTdHJpbmcmIHVy bCwgYm9vbCBhc3luYywgY29uc3QgU3RyaW5nJiB1c2VyLCBjb25zdCBTdHJpbmcmIHBhc3N3b3Jk LCBFeGNlcHRpb25Db2RlJiBlYykKIHsKLSAgICBVUkwgdXJsV2l0aENyZWRlbnRpYWxzKHVybCk7 Ci0gICAgdXJsV2l0aENyZWRlbnRpYWxzLnNldFVzZXIodXNlcik7Ci0KLSAgICBvcGVuKG1ldGhv ZCwgdXJsV2l0aENyZWRlbnRpYWxzLCBhc3luYywgZWMpOwotfQotCi12b2lkIFhNTEh0dHBSZXF1 ZXN0OjpvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBVUkwmIHVybCwgYm9vbCBhc3lu YywgY29uc3QgU3RyaW5nJiB1c2VyLCBjb25zdCBTdHJpbmcmIHBhc3N3b3JkLCBFeGNlcHRpb25D b2RlJiBlYykKLXsKLSAgICBVUkwgdXJsV2l0aENyZWRlbnRpYWxzKHVybCk7Ci0gICAgdXJsV2l0 aENyZWRlbnRpYWxzLnNldFVzZXIodXNlcik7Ci0gICAgdXJsV2l0aENyZWRlbnRpYWxzLnNldFBh c3MocGFzc3dvcmQpOworICAgIFVSTCB1cmxXaXRoQ3JlZGVudGlhbHMgPSBzY3JpcHRFeGVjdXRp b25Db250ZXh0KCktPmNvbXBsZXRlVVJMKHVybCk7CisgICAgaWYgKCF1c2VyLmlzTnVsbCgpKSB7 CisgICAgICAgIHVybFdpdGhDcmVkZW50aWFscy5zZXRVc2VyKHVzZXIpOworICAgICAgICBpZiAo IXBhc3N3b3JkLmlzTnVsbCgpKQorICAgICAgICAgICAgdXJsV2l0aENyZWRlbnRpYWxzLnNldFBh c3MocGFzc3dvcmQpOworICAgIH0KIAogICAgIG9wZW4obWV0aG9kLCB1cmxXaXRoQ3JlZGVudGlh bHMsIGFzeW5jLCBlYyk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0 cFJlcXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oCmluZGV4IDli MzNmYjYxOTBmNWFkN2ZhY2Q1NDgyMTE2Nzg4OTdiMTkzYmQ5NzguLmU0OWZmZDUxMzkxMzY4MjEz YzNjMWI1MmE0Zjc0Yzc0MjM1OGM5N2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3htbC9Y TUxIdHRwUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5o CkBAIC02OSwxMCArNjksOSBAQCBwdWJsaWM6CiAgICAgU3RhdGUgcmVhZHlTdGF0ZSgpIGNvbnN0 OwogICAgIGJvb2wgd2l0aENyZWRlbnRpYWxzKCkgY29uc3QgeyByZXR1cm4gbV9pbmNsdWRlQ3Jl ZGVudGlhbHM7IH0KICAgICB2b2lkIHNldFdpdGhDcmVkZW50aWFscyhib29sLCBFeGNlcHRpb25D b2RlJik7Ci0gICAgdm9pZCBvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBVUkwmLCBF eGNlcHRpb25Db2RlJik7CisgICAgdm9pZCBvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25z dCBTdHJpbmcmIHVybCwgRXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgb3Blbihjb25zdCBTdHJp bmcmIG1ldGhvZCwgY29uc3QgVVJMJiwgYm9vbCBhc3luYywgRXhjZXB0aW9uQ29kZSYpOwotICAg IHZvaWQgb3Blbihjb25zdCBTdHJpbmcmIG1ldGhvZCwgY29uc3QgVVJMJiwgYm9vbCBhc3luYywg Y29uc3QgU3RyaW5nJiB1c2VyLCBFeGNlcHRpb25Db2RlJik7Ci0gICAgdm9pZCBvcGVuKGNvbnN0 IFN0cmluZyYgbWV0aG9kLCBjb25zdCBVUkwmLCBib29sIGFzeW5jLCBjb25zdCBTdHJpbmcmIHVz ZXIsIGNvbnN0IFN0cmluZyYgcGFzc3dvcmQsIEV4Y2VwdGlvbkNvZGUmKTsKKyAgICB2b2lkIG9w ZW4oY29uc3QgU3RyaW5nJiBtZXRob2QsIGNvbnN0IFN0cmluZyYsIGJvb2wgYXN5bmMsIGNvbnN0 IFN0cmluZyYgdXNlciwgY29uc3QgU3RyaW5nJiBwYXNzd29yZCwgRXhjZXB0aW9uQ29kZSYpOwog ICAgIHZvaWQgc2VuZChFeGNlcHRpb25Db2RlJik7CiAgICAgdm9pZCBzZW5kKERvY3VtZW50Kiwg RXhjZXB0aW9uQ29kZSYpOwogICAgIHZvaWQgc2VuZChjb25zdCBTdHJpbmcmLCBFeGNlcHRpb25D b2RlJik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaWRs IGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmlkbAppbmRleCBmYTg5NDY2ZjJi Y2U5NDliZGE2ZGVkYTY0MTRjZTM5NGJmZmI4YTBhLi5lZTUxZjM3ZmE1MzQyZTlkNzY0OTc5OGYw YjViNzNiNjk3Y2Q5MzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJl cXVlc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5pZGwKQEAg LTU5LDcgKzU5LDkgQEAgZW51bSBYTUxIdHRwUmVxdWVzdFJlc3BvbnNlVHlwZSB7CiAKICAgICBb U2V0dGVyUmFpc2VzRXhjZXB0aW9uXSBhdHRyaWJ1dGUgYm9vbGVhbiB3aXRoQ3JlZGVudGlhbHM7 CiAKLSAgICBbQ3VzdG9tLCBSYWlzZXNFeGNlcHRpb25dIHZvaWQgb3BlbihET01TdHJpbmcgbWV0 aG9kLCBET01TdHJpbmcgdXJsLCBvcHRpb25hbCBib29sZWFuIGFzeW5jLCBvcHRpb25hbCBET01T dHJpbmcgdXNlciwgb3B0aW9uYWwgRE9NU3RyaW5nIHBhc3N3b3JkKTsKKyAgICAvLyBVc2Ugb3Zl cmxvYWRpbmcgcmF0aGVyIHRoYW4gImJvb2xlYW4gYXN5bmMgPSB0cnVlIiBiZWNhdXNlIGxlZ2Fj eSBjb250ZW50IHByZXZlbnRzIHRyZWF0aW5nIHRoZSAnYXN5bmMnIGFyZ3VtZW50IGJlaW5nIHVu ZGVmaW5lZCBpZGVudGljYWwgZnJvbSBpdCBiZWluZyBvbWl0dGVkLgorICAgIFtSYWlzZXNFeGNl cHRpb25dIHZvaWQgb3BlbihET01TdHJpbmcgbWV0aG9kLCBET01TdHJpbmcgdXJsKTsKKyAgICBb UmFpc2VzRXhjZXB0aW9uXSB2b2lkIG9wZW4oRE9NU3RyaW5nIG1ldGhvZCwgRE9NU3RyaW5nIHVy bCwgYm9vbGVhbiBhc3luYywgb3B0aW9uYWwgRE9NU3RyaW5nPyB1c2VyID0gbnVsbCwgb3B0aW9u YWwgRE9NU3RyaW5nPyBwYXNzd29yZCA9IG51bGwpOwogCiAgICAgW1JhaXNlc0V4Y2VwdGlvbl0g dm9pZCBzZXRSZXF1ZXN0SGVhZGVyKERPTVN0cmluZyBoZWFkZXIsIERPTVN0cmluZyB2YWx1ZSk7 CiAK