159982 2016-07-20 13:01:53 -0700 Stop using valueToStringWithNullCheck() in JSCSSStyleDeclaration::putDelegate() 2016-07-20 16:08:33 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-camel-cased-attribute P2 Normal --- 1 cdumez cdumez benjamin darin dino rniwa oldest_to_newest 1212848 0 cdumez 2016-07-20 13:01:53 -0700 valueToStringWithNullCheck() treats null as the null String() which is legacy / non standard behavior. The specification says we should treat null as the empty string: - https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-camel-cased-attribute Therefore, we should be using valueToStringTreatingNullAsEmptyString() instead. In practice, there will be no web-exposed behavior change because MutableStyleProperties::setProperty() removes the property wether the value is the null String or the empty String. The specification says that we should remove the property if the value is the empty string: - https://drafts.csswg.org/cssom/#dom-cssstyledeclaration-setproperty (step 4) So our behavior is correct. 1212854 1 284141 cdumez 2016-07-20 13:14:13 -0700 Created attachment 284141 Patch 1212877 2 284149 cdumez 2016-07-20 14:21:36 -0700 Created attachment 284149 Patch 1212895 3 cdumez 2016-07-20 15:06:07 -0700 The Mac-wk2 EWS build error is unrelated: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:809:10: error: no member named 'setAllowsInlineMediaPlaybackWithPlaysInlineAttribute' in 'WebCore::InternalSettingsGenerated'; did you mean 'setInlineMediaPlaybackRequiresPlaysInlineAttribute'? impl.setAllowsInlineMediaPlaybackWithPlaysInlineAttribute(WTFMove(allowsInlineMediaPlaybackWithPlaysInlineAttribute)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ setInlineMediaPlaybackRequiresPlaysInlineAttribute In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:22: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.h:23: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/InternalSettingsGenerated.h:112:10: note: 'setInlineMediaPlaybackRequiresPlaysInlineAttribute' declared here void setInlineMediaPlaybackRequiresPlaysInlineAttribute(bool inlineMediaPlaybackRequiresPlaysInlineAttribute); ^ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:826:10: error: no member named 'setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute' in 'WebCore::InternalSettingsGenerated'; did you mean 'setInlineMediaPlaybackRequiresPlaysInlineAttribute'? impl.setAllowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute(WTFMove(allowsInlineMediaPlaybackWithWebKitPlaysInlineAttribute)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ setInlineMediaPlaybackRequiresPlaysInlineAttribute In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.cpp:22: In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/JSInternalSettingsGenerated.h:23: /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/InternalSettingsGenerated.h:112:10: note: 'setInlineMediaPlaybackRequiresPlaysInlineAttribute' declared here void setInlineMediaPlaybackRequiresPlaysInlineAttribute(bool inlineMediaPlaybackRequiresPlaysInlineAttribute); ^ 2 errors generated. CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebCore.build/Release/WebCoreTestSupport.build/Objects-normal/x86_64/WebCoreTestSupport.o testing/js/WebCoreTestSupport.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler 1212923 4 284149 cdumez 2016-07-20 16:08:28 -0700 Comment on attachment 284149 Patch Clearing flags on attachment: 284149 Committed r203475: <http://trac.webkit.org/changeset/203475> 1212924 5 cdumez 2016-07-20 16:08:33 -0700 All reviewed patches have been landed. Closing bug. 284141 2016-07-20 13:14:13 -0700 2016-07-20 14:21:31 -0700 Patch bug-159982-20160720131315.patch text/plain 6657 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzA1ZWFhMmExNDcwZjJi M2ZjMzQyMWEwN2NlYjFkNTgyM2ZmZGIxYy4uZThhNTcwNDJiNWYyZmE5MDIyYjliMzdlYzUyMmJj MDExOTgyOTk2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM2IEBACiAyMDE2LTA3LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgU3RvcCB1c2luZyB2YWx1ZVRv U3RyaW5nV2l0aE51bGxDaGVjaygpIGluIEpTQ1NTU3R5bGVEZWNsYXJhdGlvbjo6cHV0RGVsZWdh dGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5 OTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdmFs dWVUb1N0cmluZ1dpdGhOdWxsQ2hlY2soKSB0cmVhdHMgbnVsbCBhcyB0aGUgbnVsbCBTdHJpbmco KSB3aGljaCBpcworICAgICAgICBsZWdhY3kgLyBub24gc3RhbmRhcmQgYmVoYXZpb3IuIFRoZSBz cGVjaWZpY2F0aW9uIHNheXMgd2Ugc2hvdWxkIHRyZWF0CisgICAgICAgIG51bGwgYXMgdGhlIGVt cHR5IHN0cmluZzoKKyAgICAgICAgLSBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3Nzb20vI2Rv bS1jc3NzdHlsZWRlY2xhcmF0aW9uLWNhbWVsLWNhc2VkLWF0dHJpYnV0ZQorCisgICAgICAgIFRo ZXJlZm9yZSwgd2Ugc2hvdWxkIGJlIHVzaW5nIHZhbHVlVG9TdHJpbmdUcmVhdGluZ051bGxBc0Vt cHR5U3RyaW5nKCkgaW5zdGVhZC4KKworICAgICAgICBJbiBwcmFjdGljZSwgdGhlcmUgaXMgbm8g d2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdlIGJlY2F1c2UKKyAgICAgICAgTXV0YWJsZVN0eWxl UHJvcGVydGllczo6c2V0UHJvcGVydHkoKSByZW1vdmVzIHRoZSBwcm9wZXJ0eSB3ZXRoZXIgdGhl CisgICAgICAgIHZhbHVlIGlzIHRoZSBudWxsIFN0cmluZyBvciB0aGUgZW1wdHkgU3RyaW5nLgor CisgICAgICAgIFRoaXMgYmVoYXZpb3IgaXMgY29ycmVjdCBzaW5jZSB0aGUgc3BlY2lmaWNhdGlv biBzYXlzIHRoYXQgd2Ugc2hvdWxkCisgICAgICAgIHJlbW92ZSB0aGUgcHJvcGVydHkgaWYgdGhl IHZhbHVlIGlzIHRoZSBlbXB0eSBzdHJpbmc6CisgICAgICAgIC0gaHR0cHM6Ly9kcmFmdHMuY3Nz d2cub3JnL2Nzc29tLyNkb20tY3Nzc3R5bGVkZWNsYXJhdGlvbi1zZXRwcm9wZXJ0eSAoc3RlcCA0 KQorCisgICAgICAgIEkgYWRkZWQgdGVzdCBjb3ZlcmFnZSB0byBtYWtlIHN1cmUgd2UgYmVoYXZl IGFjY29yZGluZyB0byBzcGVjaWZpY2F0aW9uLgorICAgICAgICBUaGlzIHRlc3QgaXMgcGFzc2lu ZyBpbiBGaXJlZm94LCBDaHJvbWUgYW5kIGluIFdlYktpdCAoYmVmb3JlIGFuZCBhZnRlcgorICAg ICAgICBteSBjaGFuZ2UpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL0NTU1N0eWxlRGVjbGFy YXRpb24tcHJvcGVydHktc2V0dGVyLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NT U3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0NTU1N0eWxl RGVjbGFyYXRpb246OnB1dERlbGVnYXRlKToKKworMjAxNi0wNy0yMCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIEZpeCBudWxsIGhhbmRsaW5nIG9mIEhUTUxTZWxl Y3RFbGVtZW50LnZhbHVlIGF0dHJpYnV0ZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTU5OTI1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTQ1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwCmluZGV4IGU3YjFm ZWNlY2ZmMjRjMzhlOGQwMjY2ZTcyZWUyNTgxZjA2OTJhMDIuLjk0OGYyODU0MWZiMTkxMTc5ODVj NDI1ZDUwZTlkMWRiZDdkYTczNmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTQ1NTU3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvanMvSlNDU1NTdHlsZURlY2xhcmF0aW9uQ3VzdG9tLmNwcApAQCAtMzI2LDcgKzMy Niw3IEBAIGJvb2wgSlNDU1NTdHlsZURlY2xhcmF0aW9uOjpwdXREZWxlZ2F0ZShFeGVjU3RhdGUq IGV4ZWMsIFByb3BlcnR5TmFtZSBwcm9wZXJ0eU5hCiAgICAgaWYgKCFwcm9wZXJ0eUluZm8ucHJv cGVydHlJRCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgU3RyaW5nIHByb3BWYWx1ZSA9 IHZhbHVlVG9TdHJpbmdXaXRoTnVsbENoZWNrKGV4ZWMsIHZhbHVlKTsKKyAgICBTdHJpbmcgcHJv cFZhbHVlID0gdmFsdWVUb1N0cmluZ1RyZWF0aW5nTnVsbEFzRW1wdHlTdHJpbmcoZXhlYywgdmFs dWUpOwogICAgIGlmIChwcm9wZXJ0eUluZm8uaGFkUGl4ZWxPclBvc1ByZWZpeCkKICAgICAgICAg cHJvcFZhbHVlLmFwcGVuZCgicHgiKTsKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGUwOTgyMmI0MzE0NTc4NGE5OGJlOWIx OTQwOWYwNzQ5ZjM0OGZiMWEuLjgzYTBjZjc1NjRmMjRiM2RlMWNhZjAzMDJiOTE3N2Q2NzJjMTE5 YjcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsNSArMSwxOSBAQAogMjAxNi0wNy0yMCAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCisgICAgICAgIFN0b3AgdXNpbmcgdmFsdWVUb1N0cmluZ1dpdGhOdWxs Q2hlY2soKSBpbiBKU0NTU1N0eWxlRGVjbGFyYXRpb246OnB1dERlbGVnYXRlKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTk4MgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBsYXlvdXQgdGVzdCBj b3ZlcmFnZSBmb3IgSlNDU1NTdHlsZURlY2xhcmF0aW9uOjpwdXREZWxlZ2F0ZSgpLAorICAgICAg ICBjb3ZlcmluZyBjYXNlcyBsaWtlIHNldHRpbmcgdG8gbnVsbCBvciB0aGUgZW1wdHkgU3RyaW5n LCB0byBtYWtlCisgICAgICAgIHN1cmUgd2UgYmVoYXZlIGFjY29yZGluZyB0byBzcGVjaWZpY2F0 aW9uLgorCisgICAgICAgICogZmFzdC9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1z ZXR0ZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy9DU1NTdHlsZURl Y2xhcmF0aW9uLXByb3BlcnR5LXNldHRlci5odG1sOiBBZGRlZC4KKworMjAxNi0wNy0yMCAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIEZpeCBudWxsIGhhbmRsaW5n IG9mIEhUTUxTZWxlY3RFbGVtZW50LnZhbHVlIGF0dHJpYnV0ZQogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5OTI1CiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24tcHJvcGVydHktc2V0dGVyLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24tcHJvcGVy dHktc2V0dGVyLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kZjA0ODEwZmU4Nzc2NGU0NGNiODVk ZTg1YTAxYTg5NWY5OGI1YjBiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9j c3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1zZXR0ZXItZXhwZWN0ZWQudHh0CkBAIC0w LDAgKzEsMjkgQEAKK1Rlc3QgdGhhdCBzZXR0aW5nIENTUyBwcm9wZXJ0aWVzIHZpYSBDU1NTdHls ZURlY2xhcmF0aW9uIGJlaGF2ZXMgYXMgZXhwZWN0ZWQKKworT24gc3VjY2VzcywgeW91IHdpbGwg c2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExF VEUiLgorCisKK1BBU1MgZGl2LnN0eWxlLmNzc1RleHQgaXMgIiIKK2Rpdi5zdHlsZS5iYWNrZ3Jv dW5kQ29sb3IgPSAncmVkJworUEFTUyBkaXYuc3R5bGUuY3NzVGV4dCBpcyAiYmFja2dyb3VuZC1j b2xvcjogcmVkOyIKK1BBU1MgZGl2LnN0eWxlLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91bmQt Y29sb3InKSBpcyAicmVkIgorUEFTUyBkaXYuc3R5bGUubGVuZ3RoIGlzIDEKKworZGl2LnN0eWxl LmJhY2tncm91bmRDb2xvciA9ICcnCitQQVNTIGRpdi5zdHlsZS5jc3NUZXh0IGlzICIiCitQQVNT IGRpdi5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykgaXMgIiIKK1BB U1MgZGl2LnN0eWxlLmxlbmd0aCBpcyAwCisKK2Rpdi5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAn cmVkJworUEFTUyBkaXYuc3R5bGUuY3NzVGV4dCBpcyAiYmFja2dyb3VuZC1jb2xvcjogcmVkOyIK K1BBU1MgZGl2LnN0eWxlLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSBpcyAi cmVkIgorUEFTUyBkaXYuc3R5bGUubGVuZ3RoIGlzIDEKKworZGl2LnN0eWxlLmJhY2tncm91bmRD b2xvciA9IG51bGwKK1BBU1MgZGl2LnN0eWxlLmNzc1RleHQgaXMgIiIKK1BBU1MgZGl2LnN0eWxl LmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSBpcyAiIgorUEFTUyBkaXYuc3R5 bGUubGVuZ3RoIGlzIDAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBD T01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9DU1NTdHlsZURlY2xh cmF0aW9uLXByb3BlcnR5LXNldHRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvQ1NTU3R5 bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1zZXR0ZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43OGU5ZTcyYTkz N2IzODViMDdkODMzNjMxNTdjMTg4NjI4ODIyNjg3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1zZXR0ZXIuaHRtbApA QCAtMCwwICsxLDM3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0 IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+ CitkZXNjcmlwdGlvbigiVGVzdCB0aGF0IHNldHRpbmcgQ1NTIHByb3BlcnRpZXMgdmlhIENTU1N0 eWxlRGVjbGFyYXRpb24gYmVoYXZlcyBhcyBleHBlY3RlZCIpOworCit2YXIgZGl2ID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHls ZS5jc3NUZXh0IiwgIiIpOworZXZhbEFuZExvZygiZGl2LnN0eWxlLmJhY2tncm91bmRDb2xvciA9 ICdyZWQnIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5jc3NUZXh0IiwgImJh Y2tncm91bmQtY29sb3I6IHJlZDsiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZGl2LnN0eWxl LmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSIsICJyZWQiKTsKK3Nob3VsZEJl KCJkaXYuc3R5bGUubGVuZ3RoIiwgIjEiKTsKKworZGVidWcoIiIpOworLy8gU2V0dGluZyB0byBl bXB0eSBzdHJpbmcgc2hvdWxkIGRlbGV0ZSB0aGUgcHJvcGVydHkuCitldmFsQW5kTG9nKCJkaXYu c3R5bGUuYmFja2dyb3VuZENvbG9yID0gJyciKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZGl2 LnN0eWxlLmNzc1RleHQiLCAiIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5n ZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAiIik7CitzaG91bGRCZSgiZGl2 LnN0eWxlLmxlbmd0aCIsICIwIik7CisKK2RlYnVnKCIiKTsKK2V2YWxBbmRMb2coImRpdi5zdHls ZS5iYWNrZ3JvdW5kQ29sb3IgPSAncmVkJyIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJkaXYu c3R5bGUuY3NzVGV4dCIsICJiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Iik7CitzaG91bGRCZUVxdWFs VG9TdHJpbmcoImRpdi5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJyki LCAicmVkIik7CitzaG91bGRCZSgiZGl2LnN0eWxlLmxlbmd0aCIsICIxIik7CisKK2RlYnVnKCIi KTsKKy8vIFNldHRpbmcgdG8gbnVsbCBzaG91bGQgZGVsZXRlIHRoZSBwcm9wZXJ0eSAobnVsbCBp cyB0cmVhdGVkIGFzIHRoZSBlbXB0eSBzdHJpbmcpLgorZXZhbEFuZExvZygiZGl2LnN0eWxlLmJh Y2tncm91bmRDb2xvciA9IG51bGwiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZGl2LnN0eWxl LmNzc1RleHQiLCAiIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5nZXRQcm9w ZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAiIik7CitzaG91bGRCZSgiZGl2LnN0eWxl Lmxlbmd0aCIsICIwIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMv anMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K 284149 2016-07-20 14:21:36 -0700 2016-07-20 16:08:28 -0700 Patch bug-159982-20160720142038.patch text/plain 6648 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE3M2EzMDA5ZmFkYjNl ZjI0MjI3MDhhN2M0Y2QwNTM3NGQ1MWE3ZS4uNzA2OWI5Yjc4YTdjYTdlOWI4MDc3MjljYmQ1MmRj NTJmYjhiYmNiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDE2LTA3LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyB2YWx1ZVRv U3RyaW5nV2l0aE51bGxDaGVjaygpIGluIEpTQ1NTU3R5bGVEZWNsYXJhdGlvbjo6cHV0RGVsZWdh dGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5 OTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgdmFs dWVUb1N0cmluZ1dpdGhOdWxsQ2hlY2soKSB0cmVhdHMgbnVsbCBhcyB0aGUgbnVsbCBTdHJpbmco KSB3aGljaCBpcworICAgICAgICBsZWdhY3kgLyBub24gc3RhbmRhcmQgYmVoYXZpb3IuIFRoZSBz cGVjaWZpY2F0aW9uIHNheXMgd2Ugc2hvdWxkIHRyZWF0CisgICAgICAgIG51bGwgYXMgdGhlIGVt cHR5IHN0cmluZzoKKyAgICAgICAgLSBodHRwczovL2RyYWZ0cy5jc3N3Zy5vcmcvY3Nzb20vI2Rv bS1jc3NzdHlsZWRlY2xhcmF0aW9uLWNhbWVsLWNhc2VkLWF0dHJpYnV0ZQorCisgICAgICAgIFRo ZXJlZm9yZSwgd2Ugc2hvdWxkIGJlIHVzaW5nIHZhbHVlVG9TdHJpbmdUcmVhdGluZ051bGxBc0Vt cHR5U3RyaW5nKCkgaW5zdGVhZC4KKworICAgICAgICBJbiBwcmFjdGljZSwgdGhlcmUgaXMgbm8g d2ViLWV4cG9zZWQgYmVoYXZpb3IgY2hhbmdlIGJlY2F1c2UKKyAgICAgICAgTXV0YWJsZVN0eWxl UHJvcGVydGllczo6c2V0UHJvcGVydHkoKSByZW1vdmVzIHRoZSBwcm9wZXJ0eSB3ZXRoZXIgdGhl CisgICAgICAgIHZhbHVlIGlzIHRoZSBudWxsIFN0cmluZyBvciB0aGUgZW1wdHkgU3RyaW5nLgor CisgICAgICAgIFRoaXMgYmVoYXZpb3IgaXMgY29ycmVjdCBzaW5jZSB0aGUgc3BlY2lmaWNhdGlv biBzYXlzIHRoYXQgd2Ugc2hvdWxkCisgICAgICAgIHJlbW92ZSB0aGUgcHJvcGVydHkgaWYgdGhl IHZhbHVlIGlzIHRoZSBlbXB0eSBzdHJpbmc6CisgICAgICAgIC0gaHR0cHM6Ly9kcmFmdHMuY3Nz d2cub3JnL2Nzc29tLyNkb20tY3Nzc3R5bGVkZWNsYXJhdGlvbi1zZXRwcm9wZXJ0eSAoc3RlcCA0 KQorCisgICAgICAgIEkgYWRkZWQgdGVzdCBjb3ZlcmFnZSB0byBtYWtlIHN1cmUgd2UgYmVoYXZl IGFjY29yZGluZyB0byBzcGVjaWZpY2F0aW9uLgorICAgICAgICBUaGlzIHRlc3QgaXMgcGFzc2lu ZyBpbiBGaXJlZm94LCBDaHJvbWUgYW5kIGluIFdlYktpdCAoYmVmb3JlIGFuZCBhZnRlcgorICAg ICAgICBteSBjaGFuZ2UpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL0NTU1N0eWxlRGVjbGFy YXRpb24tcHJvcGVydHktc2V0dGVyLmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NT U3R5bGVEZWNsYXJhdGlvbkN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpKU0NTU1N0eWxl RGVjbGFyYXRpb246OnB1dERlbGVnYXRlKToKKwogMjAxNi0wNy0yMCAgQnJhZHkgRWlkc29uICA8 YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVHJhbnNpdGlvbiBtb3N0IElEQiBpbnRlcmZh Y2VzIGZyb20gU2NyaXB0RXhlY3V0aW9uQ29udGV4dCB0byBFeGVjU3RhdGUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlRGVjbGFyYXRpb25DdXN0b20u Y3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNDU1NTdHlsZURlY2xhcmF0aW9uQ3Vz dG9tLmNwcAppbmRleCBlN2IxZmVjZWNmZjI0YzM4ZThkMDI2NmU3MmVlMjU4MWYwNjkyYTAyLi45 NDhmMjg1NDFmYjE5MTE3OTg1YzQyNWQ1MGU5ZDFkYmQ3ZGE3MzZmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlRGVjbGFyYXRpb25DdXN0b20uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVEZWNsYXJhdGlvbkN1c3Rv bS5jcHAKQEAgLTMyNiw3ICszMjYsNyBAQCBib29sIEpTQ1NTU3R5bGVEZWNsYXJhdGlvbjo6cHV0 RGVsZWdhdGUoRXhlY1N0YXRlKiBleGVjLCBQcm9wZXJ0eU5hbWUgcHJvcGVydHlOYQogICAgIGlm ICghcHJvcGVydHlJbmZvLnByb3BlcnR5SUQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAg IFN0cmluZyBwcm9wVmFsdWUgPSB2YWx1ZVRvU3RyaW5nV2l0aE51bGxDaGVjayhleGVjLCB2YWx1 ZSk7CisgICAgU3RyaW5nIHByb3BWYWx1ZSA9IHZhbHVlVG9TdHJpbmdUcmVhdGluZ051bGxBc0Vt cHR5U3RyaW5nKGV4ZWMsIHZhbHVlKTsKICAgICBpZiAocHJvcGVydHlJbmZvLmhhZFBpeGVsT3JQ b3NQcmVmaXgpCiAgICAgICAgIHByb3BWYWx1ZS5hcHBlbmQoInB4Iik7CiAKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA3NWQ2 Nzc1YmRhYTUyYmQ1MTFmMzhjNDBjOTJjMjU1NDJmNmY3Y2NhLi41MzNmMDhhZWQ3ZGNjZmM1NzBm NDI3YmJlYTNiZWM1ZTc1YmVkZDEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK KysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTYtMDctMjAg IENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAorICAgICAgICBTdG9wIHVzaW5nIHZh bHVlVG9TdHJpbmdXaXRoTnVsbENoZWNrKCkgaW4gSlNDU1NTdHlsZURlY2xhcmF0aW9uOjpwdXRE ZWxlZ2F0ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTk5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgbGF5b3V0IHRlc3QgY292ZXJhZ2UgZm9yIEpTQ1NTU3R5bGVEZWNsYXJhdGlvbjo6cHV0 RGVsZWdhdGUoKSwKKyAgICAgICAgY292ZXJpbmcgY2FzZXMgbGlrZSBzZXR0aW5nIHRvIG51bGwg b3IgdGhlIGVtcHR5IFN0cmluZywgdG8gbWFrZQorICAgICAgICBzdXJlIHdlIGJlaGF2ZSBhY2Nv cmRpbmcgdG8gc3BlY2lmaWNhdGlvbi4KKworICAgICAgICAqIGZhc3QvY3NzL0NTU1N0eWxlRGVj bGFyYXRpb24tcHJvcGVydHktc2V0dGVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog ZmFzdC9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1zZXR0ZXIuaHRtbDogQWRkZWQu CisKKzIwMTYtMDctMjAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKwogICAgICAg ICBDU1NTdHlsZURlY2xhcmF0aW9uLnNldFByb3BlcnR5KCkgc2hvdWxkIGJlIGFibGUgdG8gdW5z ZXQgImltcG9ydGFudCIgb24gYSBwcm9wZXJ0eQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5OTU5CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24tcHJvcGVydHktc2V0dGVyLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24tcHJvcGVydHktc2V0dGVy LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kZjA0ODEwZmU4Nzc2NGU0NGNiODVkZTg1YTAxYTg5 NWY5OGI1YjBiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvQ1NTU3R5 bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1zZXR0ZXItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjkg QEAKK1Rlc3QgdGhhdCBzZXR0aW5nIENTUyBwcm9wZXJ0aWVzIHZpYSBDU1NTdHlsZURlY2xhcmF0 aW9uIGJlaGF2ZXMgYXMgZXhwZWN0ZWQKKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2Vy aWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisK K1BBU1MgZGl2LnN0eWxlLmNzc1RleHQgaXMgIiIKK2Rpdi5zdHlsZS5iYWNrZ3JvdW5kQ29sb3Ig PSAncmVkJworUEFTUyBkaXYuc3R5bGUuY3NzVGV4dCBpcyAiYmFja2dyb3VuZC1jb2xvcjogcmVk OyIKK1BBU1MgZGl2LnN0eWxlLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSBp cyAicmVkIgorUEFTUyBkaXYuc3R5bGUubGVuZ3RoIGlzIDEKKworZGl2LnN0eWxlLmJhY2tncm91 bmRDb2xvciA9ICcnCitQQVNTIGRpdi5zdHlsZS5jc3NUZXh0IGlzICIiCitQQVNTIGRpdi5zdHls ZS5nZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykgaXMgIiIKK1BBU1MgZGl2LnN0 eWxlLmxlbmd0aCBpcyAwCisKK2Rpdi5zdHlsZS5iYWNrZ3JvdW5kQ29sb3IgPSAncmVkJworUEFT UyBkaXYuc3R5bGUuY3NzVGV4dCBpcyAiYmFja2dyb3VuZC1jb2xvcjogcmVkOyIKK1BBU1MgZGl2 LnN0eWxlLmdldFByb3BlcnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSBpcyAicmVkIgorUEFT UyBkaXYuc3R5bGUubGVuZ3RoIGlzIDEKKworZGl2LnN0eWxlLmJhY2tncm91bmRDb2xvciA9IG51 bGwKK1BBU1MgZGl2LnN0eWxlLmNzc1RleHQgaXMgIiIKK1BBU1MgZGl2LnN0eWxlLmdldFByb3Bl cnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSBpcyAiIgorUEFTUyBkaXYuc3R5bGUubGVuZ3Ro IGlzIDAKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9DU1NTdHlsZURlY2xhcmF0aW9uLXBy b3BlcnR5LXNldHRlci5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MvQ1NTU3R5bGVEZWNsYXJh dGlvbi1wcm9wZXJ0eS1zZXR0ZXIuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43OGU5ZTcyYTkzN2IzODViMDdk ODMzNjMxNTdjMTg4NjI4ODIyNjg3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz dC9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi1wcm9wZXJ0eS1zZXR0ZXIuaHRtbApAQCAtMCwwICsx LDM3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0iLi4v Li4vcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CitkZXNjcmlw dGlvbigiVGVzdCB0aGF0IHNldHRpbmcgQ1NTIHByb3BlcnRpZXMgdmlhIENTU1N0eWxlRGVjbGFy YXRpb24gYmVoYXZlcyBhcyBleHBlY3RlZCIpOworCit2YXIgZGl2ID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiZGl2Iik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5jc3NUZXh0 IiwgIiIpOworZXZhbEFuZExvZygiZGl2LnN0eWxlLmJhY2tncm91bmRDb2xvciA9ICdyZWQnIik7 CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5jc3NUZXh0IiwgImJhY2tncm91bmQt Y29sb3I6IHJlZDsiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZGl2LnN0eWxlLmdldFByb3Bl cnR5VmFsdWUoJ2JhY2tncm91bmQtY29sb3InKSIsICJyZWQiKTsKK3Nob3VsZEJlKCJkaXYuc3R5 bGUubGVuZ3RoIiwgIjEiKTsKKworZGVidWcoIiIpOworLy8gU2V0dGluZyB0byBlbXB0eSBzdHJp bmcgc2hvdWxkIGRlbGV0ZSB0aGUgcHJvcGVydHkuCitldmFsQW5kTG9nKCJkaXYuc3R5bGUuYmFj a2dyb3VuZENvbG9yID0gJyciKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZGl2LnN0eWxlLmNz c1RleHQiLCAiIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5nZXRQcm9wZXJ0 eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAiIik7CitzaG91bGRCZSgiZGl2LnN0eWxlLmxl bmd0aCIsICIwIik7CisKK2RlYnVnKCIiKTsKK2V2YWxBbmRMb2coImRpdi5zdHlsZS5iYWNrZ3Jv dW5kQ29sb3IgPSAncmVkJyIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJkaXYuc3R5bGUuY3Nz VGV4dCIsICJiYWNrZ3JvdW5kLWNvbG9yOiByZWQ7Iik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmco ImRpdi5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVlKCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAicmVkIik7 CitzaG91bGRCZSgiZGl2LnN0eWxlLmxlbmd0aCIsICIxIik7CisKK2RlYnVnKCIiKTsKKy8vIFNl dHRpbmcgdG8gbnVsbCBzaG91bGQgZGVsZXRlIHRoZSBwcm9wZXJ0eSAobnVsbCBpcyB0cmVhdGVk IGFzIHRoZSBlbXB0eSBzdHJpbmcpLgorZXZhbEFuZExvZygiZGl2LnN0eWxlLmJhY2tncm91bmRD b2xvciA9IG51bGwiKTsKK3Nob3VsZEJlRXF1YWxUb1N0cmluZygiZGl2LnN0eWxlLmNzc1RleHQi LCAiIik7CitzaG91bGRCZUVxdWFsVG9TdHJpbmcoImRpdi5zdHlsZS5nZXRQcm9wZXJ0eVZhbHVl KCdiYWNrZ3JvdW5kLWNvbG9yJykiLCAiIik7CitzaG91bGRCZSgiZGl2LnN0eWxlLmxlbmd0aCIs ICIwIik7Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1w b3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K