159962 2016-07-19 19:50:34 -0700 PostResolutionCallbackDisabler can resume pending requests while a ResourceLoadSuspender is alive 2016-07-20 06:03:31 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ddkilzer esprehn+autocc japhet kangil.han kling koivisto simon.fraser webkit-bug-importer oldest_to_newest 1212638 0 cdumez 2016-07-19 19:50:34 -0700 PostResolutionCallbackDisabler can resume pending requests while a ResourceLoadSuspender is alive. We have both PostResolutionCallbackDisabler and ResourceLoadSuspender that call LoaderStrategy::suspendPendingRequests() / LoaderStrategy::resumePendingRequests(). However, PostResolutionCallbackDisabler and ResourceLoadSuspender are not aware of each other. It is therefore possible for a PostResolutionCallbackDisabler object to get destroyed and for LoaderStrategy::resumePendingRequests() to be called while a ResourceLoadSuspender object is alive. This leads to hard to investigate crashes where we end up re-entering WebKit and killing the style resolver. My proposal is to drop ResourceLoadSuspender and use PostResolutionCallbackDisabler instead. There is only one user of ResourceLoadSuspender and PostResolutionCallbackDisabler is better because it manages a resolutionNestingDepth counter internally to make sure it only calls LoaderStrategy::resumePendingRequests() once all PostResolutionCallbackDisabler instances are destroyed. 1212639 1 cdumez 2016-07-19 19:50:57 -0700 <rdar://problem/21439264> 1212640 2 284079 cdumez 2016-07-19 19:54:40 -0700 Created attachment 284079 Patch 1212714 3 284079 ddkilzer 2016-07-20 05:42:23 -0700 Comment on attachment 284079 Patch r=me 1212716 4 284079 commit-queue 2016-07-20 06:03:26 -0700 Comment on attachment 284079 Patch Clearing flags on attachment: 284079 Committed r203450: <http://trac.webkit.org/changeset/203450> 1212717 5 commit-queue 2016-07-20 06:03:31 -0700 All reviewed patches have been landed. Closing bug. 284079 2016-07-19 19:54:40 -0700 2016-07-20 06:03:26 -0700 Patch bug-159962-20160719195343.patch text/plain 4213 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWI1YjFhYTQwMzEyNWI1 OTc2NWQxMWQ2YjAzZTM1ZjA0NmIzZTNkYi4uNzMwMjBkMzk2NGE5NGZkMmU5YzllZjkzOTk5YzA3 ODE5YjAyYzM3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDM5IEBACiAyMDE2LTA3LTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgUG9zdFJlc29sdXRpb25DYWxs YmFja0Rpc2FibGVyIGNhbiByZXN1bWUgcGVuZGluZyByZXF1ZXN0cyB3aGlsZSBhIFJlc291cmNl TG9hZFN1c3BlbmRlciBpcyBhbGl2ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU5OTYyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yMTQzOTI2ND4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQb3N0UmVz b2x1dGlvbkNhbGxiYWNrRGlzYWJsZXIgY2FuIHJlc3VtZSBwZW5kaW5nIHJlcXVlc3RzIHdoaWxl IGEgUmVzb3VyY2VMb2FkU3VzcGVuZGVyCisgICAgICAgIGlzIGFsaXZlLiBXZSBoYXZlIGJvdGgg UG9zdFJlc29sdXRpb25DYWxsYmFja0Rpc2FibGVyIGFuZCBSZXNvdXJjZUxvYWRTdXNwZW5kZXIg dGhhdAorICAgICAgICBjYWxsIExvYWRlclN0cmF0ZWd5OjpzdXNwZW5kUGVuZGluZ1JlcXVlc3Rz KCkgLyBMb2FkZXJTdHJhdGVneTo6cmVzdW1lUGVuZGluZ1JlcXVlc3RzKCkuCisgICAgICAgIEhv d2V2ZXIsIFBvc3RSZXNvbHV0aW9uQ2FsbGJhY2tEaXNhYmxlciBhbmQgUmVzb3VyY2VMb2FkU3Vz cGVuZGVyIGFyZSBub3QgYXdhcmUgb2YgZWFjaAorICAgICAgICBvdGhlci4gSXQgaXMgdGhlcmVm b3JlIHBvc3NpYmxlIGZvciBhIFBvc3RSZXNvbHV0aW9uQ2FsbGJhY2tEaXNhYmxlciBvYmplY3Qg dG8gZ2V0CisgICAgICAgIGRlc3Ryb3llZCwgY2F1c2luZyBMb2FkZXJTdHJhdGVneTo6cmVzdW1l UGVuZGluZ1JlcXVlc3RzKCkgdG8gYmUgY2FsbGVkIHdoaWxlIGEKKyAgICAgICAgUmVzb3VyY2VM b2FkU3VzcGVuZGVyIG9iamVjdCBpcyBhbGl2ZS4KKworICAgICAgICBUaGlzIGxlYWRzIHRvIGhh cmQgdG8gaW52ZXN0aWdhdGUgY3Jhc2hlcyB3aGVyZSB3ZSBlbmQgdXAgcmUtZW50ZXJpbmcgV2Vi S2l0IGFuZCBraWxsaW5nCisgICAgICAgIHRoZSBzdHlsZSByZXNvbHZlci4KKworICAgICAgICBU aGlzIHBhdGNoIGRyb3BzIFJlc291cmNlTG9hZFN1c3BlbmRlciBhbmQgdXNlcyBQb3N0UmVzb2x1 dGlvbkNhbGxiYWNrRGlzYWJsZXIgaW5zdGVhZC4KKyAgICAgICAgVGhlcmUgd2FzIG9ubHkgb25l IHVzZXIgb2YgUmVzb3VyY2VMb2FkU3VzcGVuZGVyIGFuZCBQb3N0UmVzb2x1dGlvbkNhbGxiYWNr RGlzYWJsZXIKKyAgICAgICAgaXMgYmV0dGVyIGJlY2F1c2UgaXQgbWFuYWdlcyBhIHJlc29sdXRp b25OZXN0aW5nRGVwdGggY291bnRlciBpbnRlcm5hbGx5IHRvIG1ha2Ugc3VyZQorICAgICAgICBp dCBvbmx5IGNhbGxzIExvYWRlclN0cmF0ZWd5OjpyZXN1bWVQZW5kaW5nUmVxdWVzdHMoKSBvbmNl IGFsbAorICAgICAgICBQb3N0UmVzb2x1dGlvbkNhbGxiYWNrRGlzYWJsZXIgaW5zdGFuY2VzIGFy ZSBkZXN0cm95ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCB0aGVyZSBpcyBubyBlYXN5IHdh eSB0byByZXByb2R1Y2UgdGhlIGNyYXNoZXMuCisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnN0eWxlRm9yRWxlbWVudElnbm9yaW5nUGVu ZGluZ1N0eWxlc2hlZXRzKToKKyAgICAgICAgKiBsb2FkZXIvTG9hZGVyU3RyYXRlZ3kuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkU3VzcGVuZGVyOjpSZXNvdXJjZUxvYWRTdXNw ZW5kZXIpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkU3VzcGVuZGVy Ojp+UmVzb3VyY2VMb2FkU3VzcGVuZGVyKTogRGVsZXRlZC4KKyAgICAgICAgKiBsb2FkZXIvTG9h ZGVyU3RyYXRlZ3kuaDoKKworMjAxNi0wNy0xOSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUu Y29tPgorCiAgICAgICAgIERvY3VtZW50LmNyZWF0ZUVsZW1lbnROUygpIC8gY3JlYXRlQXR0cmli dXRlTlMoKSBwYXJhbWV0ZXJzIHNob3VsZCBiZSBtYW5kYXRvcnkKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTkzOAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50 LmNwcAppbmRleCA1NjRhOTYxMmM0YWJkYTA1MTgzOGY3Y2M5NGY3N2IyMWYzNGFhNWRmLi42OTMw NTQwODI0ZGU3Njk4MDBiNDgxNjk0YjA5OTIyOTE2YmEzZTExIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVu dC5jcHAKQEAgLTIwNDMsNyArMjA0Myw3IEBAIHN0ZDo6dW5pcXVlX3B0cjxSZW5kZXJTdHlsZT4g RG9jdW1lbnQ6OnN0eWxlRm9yRWxlbWVudElnbm9yaW5nUGVuZGluZ1N0eWxlc2hlZXRzCiAgICAg QVNTRVJUKCZlbGVtZW50LmRvY3VtZW50KCkgPT0gdGhpcyk7CiAKICAgICAvLyBPbiBpT1MgcmVx dWVzdCBkZWxlZ2F0ZXMgY2FsbGVkIGR1cmluZyBzdHlsZUZvckVsZW1lbnQgbWF5IHJlc3VsdCBp biByZS1lbnRlcmluZyBXZWJLaXQgYW5kIGtpbGxpbmcgdGhlIHN0eWxlIHJlc29sdmVyLgotICAg IFJlc291cmNlTG9hZFN1c3BlbmRlciBzdXNwZW5kZXI7CisgICAgU3R5bGU6OlBvc3RSZXNvbHV0 aW9uQ2FsbGJhY2tEaXNhYmxlciBkaXNhYmxlcigqdGhpcyk7CiAKICAgICBUZW1wb3JhcnlDaGFu Z2U8Ym9vbD4gY2hhbmdlKG1faWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzLCB0cnVlKTsKICAgICBh dXRvIGVsZW1lbnRTdHlsZSA9IGVsZW1lbnQucmVzb2x2ZVN0eWxlKHBhcmVudFN0eWxlKTsKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Mb2FkZXJTdHJhdGVneS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvTG9hZGVyU3RyYXRlZ3kuY3BwCmluZGV4IDdmZTc2MzFhMjkwNGY5 ZTFiZmIxNjA0MTdmODVjMjU2YTg4MTBiMjMuLjc1YWFlNDI4NTNiZTRjNjAwYWM1NmM1OTk1OWFm YTQyZmUyOWE2MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Mb2FkZXJTdHJh dGVneS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0xvYWRlclN0cmF0ZWd5LmNwcApA QCAtMzQsMTYgKzM0LDYgQEAgTG9hZGVyU3RyYXRlZ3k6On5Mb2FkZXJTdHJhdGVneSgpCiB7CiB9 CiAKLVJlc291cmNlTG9hZFN1c3BlbmRlcjo6UmVzb3VyY2VMb2FkU3VzcGVuZGVyKCkKLXsKLSAg ICBwbGF0Zm9ybVN0cmF0ZWdpZXMoKS0+bG9hZGVyU3RyYXRlZ3koKS0+c3VzcGVuZFBlbmRpbmdS ZXF1ZXN0cygpOwotfQotCi1SZXNvdXJjZUxvYWRTdXNwZW5kZXI6On5SZXNvdXJjZUxvYWRTdXNw ZW5kZXIoKQotewotICAgIHBsYXRmb3JtU3RyYXRlZ2llcygpLT5sb2FkZXJTdHJhdGVneSgpLT5y ZXN1bWVQZW5kaW5nUmVxdWVzdHMoKTsKLX0KLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Mb2FkZXJTdHJhdGVneS5oIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0xvYWRlclN0cmF0ZWd5LmgKaW5kZXggNjIxZWYwZGM4MjdlOTEx N2RhZWQ1NTI2NGFlNjM4ZGE5NDIwNDY2ZS4uNzdjZDVjMzc3NGM2NTEwNTc3YmExMjY5MzgyMDUx MDA0ZjU0ZjFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0xvYWRlclN0cmF0 ZWd5LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0xvYWRlclN0cmF0ZWd5LmgKQEAgLTY1 LDEyICs2NSw2IEBAIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5Mb2FkZXJTdHJhdGVneSgpOwog fTsKIAotY2xhc3MgUmVzb3VyY2VMb2FkU3VzcGVuZGVyIHsKLXB1YmxpYzoKLSAgICBSZXNvdXJj ZUxvYWRTdXNwZW5kZXIoKTsKLSAgICB+UmVzb3VyY2VMb2FkU3VzcGVuZGVyKCk7Ci19OwotCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBMb2FkZXJTdHJhdGVneV9oCg==