159961 2016-07-19 16:51:11 -0700 Remove unnecessary if check from ParkingLot.cpp 2016-07-20 13:01:06 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rajeevmisraforapple webkit-unassigned achristensen benjamin cdumez cmarcelo commit-queue fpizlo oldest_to_newest 1212596 0 rajeevmisraforapple 2016-07-19 16:51:11 -0700 Remove unnecessary if check from ParkingLot.cpp 1212635 1 284078 rajeevmisraforapple 2016-07-19 19:36:35 -0700 Created attachment 284078 Patch 1212636 2 rajeevmisraforapple 2016-07-19 19:38:55 -0700 Just learning the checkin process. A simple patch to reorder the case to avoid "if" statement which seems unnecessary as switch/case has already given us info if result is to stop or continue. 1212667 3 achristensen 2016-07-19 23:23:07 -0700 Great! This patch needs a ChangeLog entry to go with it. Use Tools/Scripts/prepare-ChangeLog to generate a template, and then fill it in with a description like you see on trac.webkit.org 1212676 4 284089 rajeevmisraforapple 2016-07-20 00:29:24 -0700 Created attachment 284089 Patch 1212846 5 284089 commit-queue 2016-07-20 13:01:01 -0700 Comment on attachment 284089 Patch Clearing flags on attachment: 284089 Committed r203466: <http://trac.webkit.org/changeset/203466> 1212847 6 commit-queue 2016-07-20 13:01:06 -0700 All reviewed patches have been landed. Closing bug. 284078 2016-07-19 19:36:35 -0700 2016-07-20 00:29:19 -0700 Patch bug-159961-20160719193538.patch text/plain 1102 rajeevmisraforapple SW5kZXg6IFNvdXJjZS9XVEYvd3RmL1BhcmtpbmdMb3QuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XVEYvd3RmL1BhcmtpbmdMb3QuY3BwCShyZXZpc2lvbiAyMDMzOTkpCisrKyBTb3VyY2UvV1RG L3d0Zi9QYXJraW5nTG90LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDggKzE1NCwxMCBAQCBw dWJsaWM6CiAgICAgICAgICAgICAgICAgcHJldmlvdXMgPSBjdXJyZW50OwogICAgICAgICAgICAg ICAgIGN1cnJlbnRQdHIgPSAmKCpjdXJyZW50UHRyKS0+bmV4dEluUXVldWU7CiAgICAgICAgICAg ICAgICAgYnJlYWs7Ci0gICAgICAgICAgICBjYXNlIERlcXVldWVSZXN1bHQ6OlJlbW92ZUFuZENv bnRpbnVlOgogICAgICAgICAgICAgY2FzZSBEZXF1ZXVlUmVzdWx0OjpSZW1vdmVBbmRTdG9wOgor ICAgICAgICAgICAgICAgIHNob3VsZENvbnRpbnVlID0gZmFsc2U7CisgICAgICAgICAgICAgICAg RkFMTFRIUk9VR0g7CisgICAgICAgICAgICBjYXNlIERlcXVldWVSZXN1bHQ6OlJlbW92ZUFuZENv bnRpbnVlOgogICAgICAgICAgICAgICAgIGlmICh2ZXJib3NlKQogICAgICAgICAgICAgICAgICAg ICBkYXRhTG9nKHRvU3RyaW5nKGN1cnJlbnRUaHJlYWQoKSwgIjogZGVxdWV1ZWluZyAiLCBSYXdQ b2ludGVyKGN1cnJlbnQpLCAiIGZyb20gIiwgUmF3UG9pbnRlcih0aGlzKSwgIlxuIikpOwogICAg ICAgICAgICAgICAgIGlmIChjdXJyZW50ID09IHF1ZXVlVGFpbCkKQEAgLTE2Myw4ICsxNjUsNiBA QCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgZGlkRGVxdWV1ZSA9IHRydWU7CiAgICAgICAgICAg ICAgICAgKmN1cnJlbnRQdHIgPSBjdXJyZW50LT5uZXh0SW5RdWV1ZTsKICAgICAgICAgICAgICAg ICBjdXJyZW50LT5uZXh0SW5RdWV1ZSA9IG51bGxwdHI7Ci0gICAgICAgICAgICAgICAgaWYgKHJl c3VsdCA9PSBEZXF1ZXVlUmVzdWx0OjpSZW1vdmVBbmRTdG9wKQotICAgICAgICAgICAgICAgICAg ICBzaG91bGRDb250aW51ZSA9IGZhbHNlOwogICAgICAgICAgICAgICAgIGJyZWFrOwogICAgICAg ICAgICAgfQogICAgICAgICB9Cg== 284089 2016-07-20 00:29:24 -0700 2016-07-20 13:01:01 -0700 Patch bug-159961-20160720002827.patch text/plain 1955 rajeevmisraforapple SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMDM0NDUpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTIwICBSYWplZXYgTWlzcmEgIDxyYWpl ZXZtaXNyYWZvcmFwcGxlQGdtYWlsLmNvbT4KKworICAgICAgICBSZW1vdmUgdW5uZWNlc3Nhcnkg aWYgY2hlY2sgZnJvbSBQYXJraW5nTG90LmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5OTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQSBnb29kIHByYWN0aWNlIGlzIHRvIGhhdmUgYXMgbGVzcyBj b25kaXRpb25hbCBzdGF0ZW1lbnQKKyAgICAgICAgb3Igc3BlY2lhbCBjYXNlcyBhcyBwb3NzaWJs ZSBpbiBjb2RlLiBUaGlzIGNoYW5nZQorICAgICAgICBzaW1wbHkgcmVtb3ZlcyBhIHVubmVjZXNz YXJ5ICJpZiIgc3RhdGVtZW50IGZvcgorICAgICAgICBjb25kaXRpb24gd2hpY2ggd2FzIGFscmVh ZHkgZXZhbHVhdGVkIGJ5IHN3aXRjaC9jYXNlCisgICAgICAgIGFuZCB0aHVzIHRoZXJlIHdhcyBu byBuZWVkIHRvIGV2YWx1YXRlIGFnYWluLgorCisgICAgICAgICogd3RmL1BhcmtpbmdMb3QuY3Bw OgorCiAyMDE2LTA3LTE4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViS2l0IG5pZ2h0bHkgZmFpbHMgdG8gYnVpbGQgb24gbWFjT1MgU2llcnJhCklu ZGV4OiBTb3VyY2UvV1RGL3d0Zi9QYXJraW5nTG90LmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V1RGL3d0Zi9QYXJraW5nTG90LmNwcAkocmV2aXNpb24gMjAzNDQ0KQorKysgU291cmNlL1dURi93 dGYvUGFya2luZ0xvdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE1NCw4ICsxNTQsMTAgQEAgcHVi bGljOgogICAgICAgICAgICAgICAgIHByZXZpb3VzID0gY3VycmVudDsKICAgICAgICAgICAgICAg ICBjdXJyZW50UHRyID0gJigqY3VycmVudFB0ciktPm5leHRJblF1ZXVlOwogICAgICAgICAgICAg ICAgIGJyZWFrOwotICAgICAgICAgICAgY2FzZSBEZXF1ZXVlUmVzdWx0OjpSZW1vdmVBbmRDb250 aW51ZToKICAgICAgICAgICAgIGNhc2UgRGVxdWV1ZVJlc3VsdDo6UmVtb3ZlQW5kU3RvcDoKKyAg ICAgICAgICAgICAgICBzaG91bGRDb250aW51ZSA9IGZhbHNlOworICAgICAgICAgICAgICAgIEZB TExUSFJPVUdIOworICAgICAgICAgICAgY2FzZSBEZXF1ZXVlUmVzdWx0OjpSZW1vdmVBbmRDb250 aW51ZToKICAgICAgICAgICAgICAgICBpZiAodmVyYm9zZSkKICAgICAgICAgICAgICAgICAgICAg ZGF0YUxvZyh0b1N0cmluZyhjdXJyZW50VGhyZWFkKCksICI6IGRlcXVldWVpbmcgIiwgUmF3UG9p bnRlcihjdXJyZW50KSwgIiBmcm9tICIsIFJhd1BvaW50ZXIodGhpcyksICJcbiIpKTsKICAgICAg ICAgICAgICAgICBpZiAoY3VycmVudCA9PSBxdWV1ZVRhaWwpCkBAIC0xNjMsOCArMTY1LDYgQEAg cHVibGljOgogICAgICAgICAgICAgICAgIGRpZERlcXVldWUgPSB0cnVlOwogICAgICAgICAgICAg ICAgICpjdXJyZW50UHRyID0gY3VycmVudC0+bmV4dEluUXVldWU7CiAgICAgICAgICAgICAgICAg Y3VycmVudC0+bmV4dEluUXVldWUgPSBudWxscHRyOwotICAgICAgICAgICAgICAgIGlmIChyZXN1 bHQgPT0gRGVxdWV1ZVJlc3VsdDo6UmVtb3ZlQW5kU3RvcCkKLSAgICAgICAgICAgICAgICAgICAg c2hvdWxkQ29udGludWUgPSBmYWxzZTsKICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAg ICAgIH0KICAgICAgICAgfQo=