15994 2007-11-14 19:17:12 -0800 REGRESSION: Incomplete repaint of CSS image substitution 2026-03-03 14:52:57 -0800 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) All All RESOLVED CONFIGURATION CHANGED http://www.duema.de/haeuser/index.shtml HasReduction, Regression P1 Major --- 1 pepto webkit-unassigned abarth benjamin bfulgham eric gsherloc hamaji hausmann hyatt jamesr mitz simon.fraser webkit oldest_to_newest 61260 0 pepto 2007-11-14 19:17:12 -0800 This URL contains CSS image-substitution on hover in the navigation-bar on top of the page and on the images of houses further down the page (just check in any other browser to see how it should look)... The hover-effect works correctly in virtually any browser: IE5 (even IE5:mac), IE6, IE7, Firefox 1+, Opera, Netscape 6+ (etc.) and Safari-versions before Safari 3... The image-substitution basically works by changing the upper padding of a fixed size <a> (display:block) containing an <img>, on hover. This <a> has overflow:hidden properties, so by changing its upper padding, the contained image gets shifted into the hidden overflow-area, revealing an image below it (layering is done via negative margins)... This might sound a little complicated for simple image-substitution, but avoids flicker in old IE versions, doesn't need preloading, is css-only and works in virtually any browser except for Safari 3... 61261 1 dev+webkit 2007-11-14 20:06:08 -0800 The actual image substitution works, but it isn't repainted. It seems to repaint the first link you hover over fine, but from there you need to force a repaint. 61262 2 17286 dev+webkit 2007-11-14 21:02:56 -0800 Created attachment 17286 Reduction This is partly fixed in ToT from Safari 3, but is still a definite regression from Safari 2. In Safari 2, both squares change to blue when hovered over. In Safari 3.0.4 (Tiger), the green square changes to blue on hover, the red square never becomes blue unless a repaint is forced. In ToT (r27761), the green square changes to blue on hover, as does the red square, but if you move the cursor from red square -> green square, the red square stays blue until a repaint is forced. 61309 3 mitz 2007-11-15 10:51:19 -0800 WebKit actually repaints the wrong rectangle because it applies a translated clip. The reason for that is that the repainting happens under a non-zero layoutDelta but clip computation ignores that. I have a one-line fix for the LayoutState code path - when pushing state and adding clipping, translate the additional clip by the current layout delta. But I don't know what to do in the non-LayoutState code path. 61314 4 17299 mitz 2007-11-15 11:38:21 -0800 Created attachment 17299 Fix for the LayoutState-enabled code path 61437 5 17299 darin 2007-11-16 20:09:10 -0800 Comment on attachment 17299 Fix for the LayoutState-enabled code path r=me 61442 6 17299 mitz 2007-11-16 21:11:26 -0800 Comment on attachment 17299 Fix for the LayoutState-enabled code path Landed in r27869. Clearing the review flag. 61480 7 pepto 2007-11-17 14:19:08 -0800 'just checked r27875... looks great to me... thanks guys... looking forward to the next safari release-update... 69098 8 webkit 2008-02-01 14:00:03 -0800 The test case works fine. I suppose this bug is fixed, isn't it? 69101 9 mitz 2008-02-01 14:05:58 -0800 (In reply to comment #8) > The test case works fine. I suppose this bug is fixed, isn't it? Not completely. 148476 10 gsherloc 2009-09-19 01:55:27 -0700 The test case seems to work correctly now (in r48518, and Safari 4.03), so maybe this can be closed? 201220 11 benjamin 2010-03-18 01:45:48 -0700 (In reply to comment #9) > (In reply to comment #8) > > The test case works fine. I suppose this bug is fixed, isn't it? > > Not completely. What do you mean? What is missing? 201224 12 mitz 2010-03-18 02:02:29 -0700 (In reply to comment #11) > (In reply to comment #9) > > (In reply to comment #8) > > > The test case works fine. I suppose this bug is fixed, isn't it? > > > > Not completely. > > What do you mean? What is missing? At the time, what I meant was that the bug was still present in the unoptimized code path (where LayoutState is not used). I don’t know if that’s still the case—someone could make a version of the test that take the unoptimized code path in order to find out. 201308 13 51025 benjamin 2010-03-18 08:24:11 -0700 Created attachment 51025 Reduction without LayoutState > At the time, what I meant was that the bug was still present in the unoptimized > code path (where LayoutState is not used). I don’t know if that’s still the > case—someone could make a version of the test that take the unoptimized code > path in order to find out. You are right, the bug is still there for the unoptimized code path. I have attached a test case, I will try to have a look at the problem today. 201497 14 51080 benjamin 2010-03-18 13:02:16 -0700 Created attachment 51080 Fix the issue First attempt to fix the issue. It think there is still a missing case. If I understand correctly, the layoutDelta is relative to the enclosing layer(?). If in the slow path, but with a layer(), layoutDelta should be transformed before applied to the clipping rect. Is that right? 202428 15 51272 benjamin 2010-03-22 03:38:34 -0700 Created attachment 51272 Patch and test Here is a patch that can be integrated. I am surprised by the two little white rects on the expected image. Someone might know where they come from. 202782 16 hausmann 2010-03-22 14:57:23 -0700 (In reply to comment #15) > Created an attachment (id=51272) [details] > Patch and test You may want to skip the newly added test on the other platforms until they have pixel test results :) 225182 17 abarth 2010-05-13 00:22:58 -0700 This patch has been up for review for almost two months and Hyatt isn't even CCed. According to my understanding, he's one of the few people on earth who can review repainting patches. 240452 18 51272 abarth 2010-06-20 09:03:26 -0700 Comment on attachment 51272 Patch and test I'm sorry to have to r- your patch. In order to make changes like this the codebase, you need to socialize your change with folks who can review them. In this case, there are only a handful of people who can (or are willing to) review repainting bugs, mostly because the code is subtle, fragile, and poorly tested. If current trends continue, your patch will be up for review indefinitely, which is bad for the project. Feel free to renominate your patch for review (or to post an updated patch) when you've found someone who is willing and able to review your patch. Again, my apologies that you're running up against some of the brokenness in our review system. Hopefully this won't discourage you from contributing more patches in the future. 2186755 19 bfulgham 2026-03-03 14:52:57 -0800 I can't see a rendering difference with the attached test case when I try it in Safari STP 236, Chrome, and Firefox. They appear to have the same behavior (including hover behavior). 17286 2007-11-14 21:02:56 -0800 2007-11-14 21:02:56 -0800 Reduction Bug15994.html text/html 406 dev+webkit PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KICAgIGRpdiB7CiAgICAgICAgb3ZlcmZsb3c6IGhpZGRl bjsKICAgIH0KICAgIGRpdiwgc3BhbiB7CiAgICAgICAgaGVpZ2h0OiAxMDBweDsKICAgICAgICB3 aWR0aDogMTAwcHg7CiAgICAgICAgZGlzcGxheTogYmxvY2s7CiAgICB9CiAgICBzcGFuOmhvdmVy IHsKICAgICAgICBwYWRkaW5nOiAxMDBweCAwIDAgMDsKICAgICAgICBiYWNrZ3JvdW5kOiBibHVl OwogICAgfQo8L3N0eWxlPgoKPGRpdiBzdHlsZT0iYmFja2dyb3VuZDogZ3JlZW47Ij48c3Bhbj4m bmJzcDs8L3NwYW4+PC9kaXY+CjxkaXYgc3R5bGU9InBvc2l0aW9uOiByZWxhdGl2ZTsgbWFyZ2lu OiAtMTAwcHggMCAwIDEwMHB4OyBiYWNrZ3JvdW5kOiByZWQ7Ij48c3Bhbj4mbmJzcDs8L3NwYW4+ PC9kaXY+Cg== 17299 2007-11-15 11:38:21 -0800 2007-11-16 21:11:26 -0800 Fix for the LayoutState-enabled code path 15994_r1.diff text/plain 9678 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzgxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDctMTEtMTUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZp eCB0aGUgY29tbW9uIGNhc2Ugb2YgPGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1OTk0PgorICAgICAgICAgIFJFR1JFU1NJT046IEluY29tcGxldGUgcmVwYWludCBvZiBD U1MgaW1hZ2Ugc3Vic3RpdHV0aW9uCisKKyAgICAgICAgVGVzdDogZmFzdC9yZXBhaW50L2NsaXAt d2l0aC1sYXlvdXQtZGVsdGEuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL0xheW91dFN0YXRl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dFN0YXRlOjpMYXlvdXRTdGF0ZSk6IEFjY291 bnQgZm9yIGxheW91dCBkZWx0YSB3aGVuCisgICAgICAgIHB1c2hpbmcgYWRkaXRpb25hbCBjbGlw LgorCiAyMDA3LTExLTE0ICBCcmFkeSBFaWRzb24gPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAg ICAgIFJ1YmJlcnN0YW1wZWQgYnkgU2FtCkluZGV4OiBXZWJDb3JlL3JlbmRlcmluZy9MYXlvdXRT dGF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9yZW5kZXJpbmcvTGF5b3V0U3RhdGUuY3Bw CShyZXZpc2lvbiAyNzgxMSkKKysrIFdlYkNvcmUvcmVuZGVyaW5nL0xheW91dFN0YXRlLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjcsNiArNjcsNyBAQCBMYXlvdXRTdGF0ZTo6TGF5b3V0U3RhdGUo TGF5b3V0U3RhdGUqIHByCiAgICAgICAgIGludCB5ID0gbV9vZmZzZXQuaGVpZ2h0KCk7CiAgICAg ICAgIFJlbmRlckxheWVyKiBsYXllciA9IHJlbmRlcmVyLT5sYXllcigpOwogICAgICAgICBJbnRS ZWN0IGNsaXBSZWN0KHgsIHksIGxheWVyLT53aWR0aCgpLCBsYXllci0+aGVpZ2h0KCkpOworICAg ICAgICBjbGlwUmVjdC5tb3ZlKHJlbmRlcmVyLT52aWV3KCktPmxheW91dERlbHRhKCkpOwogICAg ICAgICBpZiAobV9jbGlwcGVkKQogICAgICAgICAgICAgbV9jbGlwUmVjdC5pbnRlcnNlY3QoY2xp cFJlY3QpOwogICAgICAgICBlbHNlIHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3ODEyKQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDct MTEtMTUgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHJlcGFpbnQgdGVzdCBmb3IgPGh0dHA6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTk0PgorICAgICAgICAgIFJFR1JF U1NJT046IEluY29tcGxldGUgcmVwYWludCBvZiBDU1MgaW1hZ2Ugc3Vic3RpdHV0aW9uCisKKyAg ICAgICAgKiBmYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS5odG1sOiBBZGRlZC4K KyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2NsaXAtd2l0aC1sYXlvdXQtZGVs dGEtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0 L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAg ICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1l eHBlY3RlZC50eHQ6IEFkZGVkLgorCiAyMDA3LTExLTE0ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8 YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKdXN0aW4gR2FyY2lhLgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L2NsaXAtd2l0aC1sYXlvdXQtZGVsdGEuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1k ZWx0YS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9yZXBhaW50L2NsaXAt d2l0aC1sYXlvdXQtZGVsdGEuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzMSBAQAorPGh0 bWw+Cis8aGVhZD4KKyAgICA8dGl0bGU+VGVzdCBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTU5OTQ8L3RpdGxlPgorICAgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+ CisgICAgICAgIGRpdiB7CisgICAgICAgICAgICBvdmVyZmxvdzogaGlkZGVuOworICAgICAgICB9 CisgICAgICAgIGRpdiwgc3BhbiB7CisgICAgICAgICAgICBoZWlnaHQ6IDEwMHB4OworICAgICAg ICAgICAgd2lkdGg6IDEwMHB4OworICAgICAgICAgICAgZGlzcGxheTogYmxvY2s7CisgICAgICAg IH0KKyAgICAgICAgc3Bhbi5ibHVlIHsKKyAgICAgICAgICAgIHBhZGRpbmc6IDEwMHB4IDAgMCAw OworICAgICAgICAgICAgYmFja2dyb3VuZDogYmx1ZTsKKyAgICAgICAgfQorICAgIDwvc3R5bGU+ CisJPHNjcmlwdCBzcmM9InJlcGFpbnQuanMiIHR5cGU9InRleHQvamF2YXNjcmlwdCI+PC9zY3Jp cHQ+CisJPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCSAgIGZ1bmN0aW9uIHJlcGFp bnRUZXN0KCkKKwkgICB7CisgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCd0MScp LnJlbW92ZUF0dHJpYnV0ZSgiY2xhc3MiKTsKKyAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ3QyJykuc2V0QXR0cmlidXRlKCJjbGFzcyIsICJibHVlIik7CisJICAgfQorCTwvc2Ny aXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5SZXBhaW50VGVzdCgpIj4KKyAgICA8ZGl2 IHN0eWxlPSJiYWNrZ3JvdW5kOiBncmVlbjsiPjxzcGFuIGlkPSJ0MSIgY2xhc3M9ImJsdWUiPiZu YnNwOzwvc3Bhbj48L2Rpdj4KKyAgICA8ZGl2IHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7IG1h cmdpbjogLTEwMHB4IDAgMCAxMDBweDsgYmFja2dyb3VuZDogcmVkOyI+PHNwYW4gaWQ9InQyIj4m bmJzcDs8L3NwYW4+PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2NsaXAtd2l0aC1sYXlvdXQtZGVsdGEtZXhwZWN0ZWQu Y2hlY2tzdW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVw YWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAw KQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5 b3V0LWRlbHRhLWV4cGVjdGVkLmNoZWNrc3VtCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxIEBACitj ZWE5NTY1MDEwNWNjOGVkMjg5MGI1NGNhNzVlNzZlMApcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZp bGUKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2xpcC13aXRo LWxheW91dC1kZWx0YS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQv Y2xpcC13aXRoLWxheW91dC1kZWx0YS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsMTUgQEAKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgw LDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJs b2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBh dCAoOCw4KSBzaXplIDc4NHg1ODQKK2xheWVyIGF0ICg4LDgpIHNpemUgMTAweDEwMAorICBSZW5k ZXJCbG9jayB7RElWfSBhdCAoMCwwKSBzaXplIDEwMHgxMDAgW2JnY29sb3I9IzAwODAwMF0KKyAg ICBSZW5kZXJCbG9jayB7U1BBTn0gYXQgKDAsMCkgc2l6ZSAxMDB4MTAwCisgICAgICBSZW5kZXJU ZXh0IHsjdGV4dH0gYXQgKDAsMCkgc2l6ZSA0eDE4CisgICAgICAgIHRleHQgcnVuIGF0ICgwLDAp IHdpZHRoIDQ6ICIgIgorbGF5ZXIgYXQgKDEwOCw4KSBzaXplIDEwMHgxMDAgc2Nyb2xsSGVpZ2h0 IDIwMAorICBSZW5kZXJCbG9jayAocmVsYXRpdmUgcG9zaXRpb25lZCkge0RJVn0gYXQgKDEwMCww KSBzaXplIDEwMHgxMDAgW2JnY29sb3I9I0ZGMDAwMF0KKyAgICBSZW5kZXJCbG9jayB7U1BBTn0g YXQgKDAsMCkgc2l6ZSAxMDB4MjAwIFtiZ2NvbG9yPSMwMDAwRkZdCisgICAgICBSZW5kZXJUZXh0 IHsjdGV4dH0gYXQgKDAsMTAwKSBzaXplIDR4MTgKKyAgICAgICAgdGV4dCBydW4gYXQgKDAsMTAw KSB3aWR0aCA0OiAiICIKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFp bnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1leHBlY3RlZC5wbmcKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpDYW5ub3Qg ZGlzcGxheTogZmlsZSBtYXJrZWQgYXMgYSBiaW5hcnkgdHlwZS4Kc3ZuOm1pbWUtdHlwZSA9IGFw cGxpY2F0aW9uL29jdGV0LXN0cmVhbQoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLWV4cGVjdGVk LnBuZwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCk5hbWU6IHN2bjptaW1lLXR5cGUKICAgKyBhcHBsaWNhdGlvbi9vY3Rl dC1zdHJlYW0KCgppVkJPUncwS0dnb0FBQUFOU1VoRVVnQUFBeUFBQUFKWUNBWUFBQUNhZG9Kd0FB QU1qa2xFUVZSNG5PM2RzUkhDUUJBRVFVU1JEQkVkCjRTZ2RSU2xDQUdzZVN0MzJHK3RPbmZIYnpK dzNBQUNBd0gzMUFBQUE0RG9FQ0FBQWtCRWdBQUJBUm9BQUFBQVpBUUlBQUdRRUNBQUEKa0JFZ0FB QkE1dkhwd2ZFOGloMThhL2R0eXkrWmVhMmVBQUR3VjF4QUFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFB QUlDTkFBQUNBakFBQgpBQUF5QWdRQUFNZ0lFQUFBSUNOQUFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFB QUlDTkFBQUNBakFBQkFBQXlBZ1FBQU1nSUVBQUFJQ05BCkFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFB QUlDTkFBQUNBakFBQkFBQXlBZ1FBQU1nSUVBQUFJQ05BQUFDQWpBQUJBQUF5QWdRQUFNZ0kKRUFB QUlDTkFBQUNBakFBQkFBQXlBZ1FBQU1nSUVBQUFJQ05BQUFDQWpBQUJBQUF5QWdRQUFNZ0lFQUFB SUNOQUFBQ0FqQUFCQUFBeQpBZ1FBQU1nSUVBQUFJQ05BQUFDQWpBQUJBQUF5QWdRQUFNZ0lFQUFB SUNOQUFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFBQUlDTkFBQUNBCmpBQUJBQUF5QWdRQUFNZ0lFQUFB SUNOQUFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFBQUlDTkFBQUNBakFBQkFBQXlBZ1FBQU1nSUVBQUEK SUNOQUFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFBQUlDTkFBQUNBakFBQkFBQXlBZ1FBQU1nSUVBQUFJ Q05BQUFDQWpBQUJBQUF5QWdRQQpBTWdJRUFBQUlDTkFBQUNBakFBQkFBQXlBZ1FBQU1nSUVBQUFJ Q05BQUFDQWpBQUJBQUF5QWdRQUFNZ0lFQUFBSUNOQUFBQ0FqQUFCCkFBQXlBZ1FBQU1nSUVBQUFJ Q05BQUFDQWpBQUJBQUF5QWdRQUFNZ0lFQUFBSUNOQUFBQ0FqQUFCQUFBeUFnUUFBTWdJRUFBQUlD TkEKQUFDQWpBQUJBQUF5QWdRQUFNZ0lFQUFBSUNOQUFBQ0FqQUFCQUFBeUFnUUFBTWhzTTNPdUhn RUFBRnlEQ3dnQUFKQVJJQUFBUUVhQQpBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdR RUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSCklBQUFRRWFBQUFBQUdR RUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FF Q0FBQmsKQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FF Q0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQQpHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FF Q0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBClFFYUFBQUFBR1FF Q0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVD QUFCa0JBZ0EKQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVD QUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQwpBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVD QUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBCkFBQUFHUUVD QUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNB QUJrQkFnQUFKQVIKSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNB QUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCawpCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNB QUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBCkdRRUNB QUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FB QmtCQWdBQUpBUklBQUEKUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FB QmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQQpBSkFSSUFBQVFFYUFBQUFBR1FFQ0FB QmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDCkFB QmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFC a0JBZ0FBSkFSSUFBQVFFYUEKQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFC a0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUgpJQUFBUUVhQUFBQUFHUUVDQUFC a0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJr CkJBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJr QkFnQUFKQVJJQUFBUUVhQUFBQUEKR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJr QkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQQpRRWFBQUFBQUdRRUNBQUJr QkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtC QWdBCkFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtC QWdBQUpBUklBQUFRRWFBQUFBQUdRRUMKQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtC QWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQQpBQUFBR1FFQ0FBQmtC QWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JB Z0FBSkFSCklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JB Z0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmsKQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JB Z0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQQpHUUVDQUFCa0JB Z0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFn QUFKQVJJQUFBClFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFn QUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0EKQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFn QUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQwpBQUJrQkFn QUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdB QUpBUklBQUFRRWFBCkFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdB QUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVIKSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdB QUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCawpCQWdB QUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FB SkFSSUFBQVFFYUFBQUFBCkdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FB SkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUEKUUVhQUFBQUFHUUVDQUFCa0JBZ0FB SkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQQpB SkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFK QVJJQUFBUUVhQUFBQUFHUUVDCkFBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFK QVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUEKQUFBQUdRRUNBQUJrQkFnQUFK QVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpB UgpJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpB UklBQUFRRWFBQUFBQUdRRUNBQUJrCkJBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpB UklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUEKR1FFQ0FBQmtCQWdBQUpB UklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFS SUFBQQpRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFS SUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBCkFKQVJJQUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFS SUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUMKQUFCa0JBZ0FBSkFS SUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJ QUFBUUVhQQpBQUFBR1FFQ0FBQmtCQWdBQUpBUklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJ QUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSCklBQUFRRWFBQUFBQUdRRUNBQUJrQkFnQUFKQVJJ QUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmsKQkFnQUFKQVJJ QUFBUUVhQUFBQUFHUUVDQUFCa0JBZ0FBSkFSSUFBQVFFYUFBQUFBR1FFQ0FBQmtCQWdBQUpBUklB QUFRRWFBQUFBQQptVGZhUEF5NWtRRG5qQUFBQUFCSlJVNUVya0pnZ2c9PQoK 51025 2010-03-18 08:24:11 -0700 2010-03-22 03:38:34 -0700 Reduction without LayoutState clip-with-layout-delta-nolayoutstate.html text/html 1032 benjamin PGh0bWw+CjxoZWFkPgogICAgPHRpdGxlPlRlc3QgZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE1OTk0PC90aXRsZT4KICAgIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyI+ CiAgICAgICAgZGl2IHsKICAgICAgICAgICAgb3ZlcmZsb3c6IGhpZGRlbjsKICAgICAgICB9CiAg ICAgICAgZGl2LCBzcGFuIHsKICAgICAgICAgICAgaGVpZ2h0OiAxMDBweDsKICAgICAgICAgICAg d2lkdGg6IDEwMHB4OwogICAgICAgICAgICBkaXNwbGF5OiBibG9jazsKICAgICAgICB9CiAgICAg ICAgc3Bhbi5ibHVlIHsKICAgICAgICAgICAgcGFkZGluZzogMTAwcHggMCAwIDA7CiAgICAgICAg ICAgIGJhY2tncm91bmQ6IGJsdWU7CiAgICAgICAgfQogICAgPC9zdHlsZT4KICAgIDxzY3JpcHQg c3JjPSJyZXNvdXJjZXMvcmVwYWludC5qcyIgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij48L3Njcmlw dD4KICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KICAgICAgIGZ1bmN0aW9uIHJl cGFpbnRUZXN0KCkKICAgICAgIHsKICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn dDEnKS5yZW1vdmVBdHRyaWJ1dGUoImNsYXNzIik7CiAgICAgICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3QyJykuc2V0QXR0cmlidXRlKCJjbGFzcyIsICJibHVlIik7CiAgICAgICB9CiAg ICA8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keSBvbmxvYWQ9InJ1blJlcGFpbnRUZXN0KCkiPgo8ZGl2 IHN0eWxlPSJ3aWR0aDoyMDBweDsgaGVpZ2h0OjEwMHB4OyAtd2Via2l0LXRyYW5zZm9ybTpyb3Rh dGUoMTgwZGVnKTsiPgogICAgPGRpdiBzdHlsZT0iYmFja2dyb3VuZDogZ3JlZW47Ij48c3BhbiBp ZD0idDEiIGNsYXNzPSJibHVlIj4mbmJzcDs8L3NwYW4+PC9kaXY+CiAgICA8ZGl2IHN0eWxlPSJw b3NpdGlvbjogcmVsYXRpdmU7IG1hcmdpbjogLTEwMHB4IDAgMCAxMDBweDsgYmFja2dyb3VuZDog cmVkOyI+PHNwYW4gaWQ9InQyIj4mbmJzcDs8L3NwYW4+PC9kaXY+CjwvZGl2Pgo8L2JvZHk+Cjwv aHRtbD4K 51080 2010-03-18 13:02:16 -0700 2010-03-22 03:38:34 -0700 Fix the issue 15994a.patch text/plain 2710 benjamin ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCb3guY3BwCmluZGV4IDFjMGU4MzcuLjFkZGY5N2MgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQm94LmNwcApAQCAtMTE0NiwyNSArMTE0NiwyNiBAQCBJbnRSZWN0IFJlbmRlckJveDo6 Y2xpcHBlZE92ZXJmbG93UmVjdEZvclJlcGFpbnQoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFp bnRDbwogCiB2b2lkIFJlbmRlckJveDo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KFJlbmRlckJveE1v ZGVsT2JqZWN0KiByZXBhaW50Q29udGFpbmVyLCBJbnRSZWN0JiByZWN0LCBib29sIGZpeGVkKQog ewotICAgIGlmIChSZW5kZXJWaWV3KiB2ID0gdmlldygpKSB7Ci0gICAgICAgIC8vIExheW91dFN0 YXRlIGlzIG9ubHkgdmFsaWQgZm9yIHJvb3QtcmVsYXRpdmUgcmVwYWludGluZwotICAgICAgICBp ZiAodi0+bGF5b3V0U3RhdGVFbmFibGVkKCkgJiYgIXJlcGFpbnRDb250YWluZXIpIHsKLSAgICAg ICAgICAgIExheW91dFN0YXRlKiBsYXlvdXRTdGF0ZSA9IHYtPmxheW91dFN0YXRlKCk7CisgICAg UmVuZGVyVmlldyogdiA9IHZpZXcoKTsKIAotICAgICAgICAgICAgaWYgKGxheWVyKCkgJiYgbGF5 ZXIoKS0+dHJhbnNmb3JtKCkpCi0gICAgICAgICAgICAgICAgcmVjdCA9IGxheWVyKCktPnRyYW5z Zm9ybSgpLT5tYXBSZWN0KHJlY3QpOworICAgIC8vIExheW91dFN0YXRlIGlzIG9ubHkgdmFsaWQg Zm9yIHJvb3QtcmVsYXRpdmUgcmVwYWludGluZworICAgIGlmICh2ICYmIHYtPmxheW91dFN0YXRl RW5hYmxlZCgpICYmICFyZXBhaW50Q29udGFpbmVyKSB7CisgICAgICAgIExheW91dFN0YXRlKiBs YXlvdXRTdGF0ZSA9IHYtPmxheW91dFN0YXRlKCk7CiAKLSAgICAgICAgICAgIGlmIChzdHlsZSgp LT5wb3NpdGlvbigpID09IFJlbGF0aXZlUG9zaXRpb24gJiYgbGF5ZXIoKSkKLSAgICAgICAgICAg ICAgICByZWN0Lm1vdmUobGF5ZXIoKS0+cmVsYXRpdmVQb3NpdGlvbk9mZnNldCgpKTsKKyAgICAg ICAgaWYgKGxheWVyKCkgJiYgbGF5ZXIoKS0+dHJhbnNmb3JtKCkpCisgICAgICAgICAgICByZWN0 ID0gbGF5ZXIoKS0+dHJhbnNmb3JtKCktPm1hcFJlY3QocmVjdCk7CiAKLSAgICAgICAgICAgIHJl Y3QubW92ZSh4KCksIHkoKSk7Ci0gICAgICAgICAgICByZWN0Lm1vdmUobGF5b3V0U3RhdGUtPm1f b2Zmc2V0KTsKLSAgICAgICAgICAgIGlmIChsYXlvdXRTdGF0ZS0+bV9jbGlwcGVkKQotICAgICAg ICAgICAgICAgIHJlY3QuaW50ZXJzZWN0KGxheW91dFN0YXRlLT5tX2NsaXBSZWN0KTsKLSAgICAg ICAgICAgIHJldHVybjsKLSAgICAgICAgfQorICAgICAgICBpZiAoc3R5bGUoKS0+cG9zaXRpb24o KSA9PSBSZWxhdGl2ZVBvc2l0aW9uICYmIGxheWVyKCkpCisgICAgICAgICAgICByZWN0Lm1vdmUo bGF5ZXIoKS0+cmVsYXRpdmVQb3NpdGlvbk9mZnNldCgpKTsKKworICAgICAgICByZWN0Lm1vdmUo eCgpLCB5KCkpOworICAgICAgICByZWN0Lm1vdmUobGF5b3V0U3RhdGUtPm1fb2Zmc2V0KTsKKyAg ICAgICAgaWYgKGxheW91dFN0YXRlLT5tX2NsaXBwZWQpCisgICAgICAgICAgICByZWN0LmludGVy c2VjdChsYXlvdXRTdGF0ZS0+bV9jbGlwUmVjdCk7CisgICAgICAgIHJldHVybjsKICAgICB9CiAK KwogICAgIGlmIChoYXNSZWZsZWN0aW9uKCkpCiAgICAgICAgIHJlY3QudW5pdGUocmVmbGVjdGVk UmVjdChyZWN0KSk7CiAKQEAgLTEyMTEsNyArMTIxMiw3IEBAIHZvaWQgUmVuZGVyQm94Ojpjb21w dXRlUmVjdEZvclJlcGFpbnQoUmVuZGVyQm94TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIs IEluCiAgICAgICAgIC8vIGZsYWcgb24gdGhlIFJlbmRlck9iamVjdCBoYXMgYmVlbiBjbGVhcmVk LCBzbyB1c2UgdGhlIG9uZSBvbiB0aGUgc3R5bGUoKS4KICAgICAgICAgdG9wTGVmdCArPSBsYXll cigpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCk7CiAgICAgfQotICAgIAorCiAgICAgLy8gRklY TUU6IFdlIGlnbm9yZSB0aGUgbGlnaHR3ZWlnaHQgY2xpcHBpbmcgcmVjdCB0aGF0IGNvbnRyb2xz IHVzZSwgc2luY2UgaWYgfG98IGlzIGluIG1pZC1sYXlvdXQsCiAgICAgLy8gaXRzIGNvbnRyb2xD bGlwUmVjdCB3aWxsIGJlIHdyb25nLiBGb3Igb3ZlcmZsb3cgY2xpcCB3ZSB1c2UgdGhlIHZhbHVl cyBjYWNoZWQgYnkgdGhlIGxheWVyLgogICAgIGlmIChvLT5oYXNPdmVyZmxvd0NsaXAoKSkgewpA QCAtMTIyNCw2ICsxMjI1LDkgQEAgdm9pZCBSZW5kZXJCb3g6OmNvbXB1dGVSZWN0Rm9yUmVwYWlu dChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW5lciwgSW4KIAogICAgICAgICBJ bnRSZWN0IHJlcGFpbnRSZWN0KHRvcExlZnQsIHJlY3Quc2l6ZSgpKTsKICAgICAgICAgSW50UmVj dCBib3hSZWN0KDAsIDAsIGNvbnRhaW5lckJveC0+bGF5ZXIoKS0+d2lkdGgoKSwgY29udGFpbmVy Qm94LT5sYXllcigpLT5oZWlnaHQoKSk7CisgICAgICAgIGlmICh2ICYmICFsYXllcigpKQorICAg ICAgICAgICAgYm94UmVjdC5tb3ZlKHYtPmxheW91dERlbHRhKCkpOworCiAgICAgICAgIHJlY3Qg PSBpbnRlcnNlY3Rpb24ocmVwYWludFJlY3QsIGJveFJlY3QpOwogICAgICAgICBpZiAocmVjdC5p c0VtcHR5KCkpCiAgICAgICAgICAgICByZXR1cm47Cg== 51272 2010-03-22 03:38:34 -0700 2010-06-20 09:03:26 -0700 Patch and test 15994_nolayoutstate.patch text/plain 7557 benjamin ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzNzIzODIxLi45MTliOTY3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDMt MjIgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OOiBJ bmNvbXBsZXRlIHJlcGFpbnQgb2YgQ1NTIGltYWdlIHN1YnN0aXR1dGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5OTQKKworICAgICAgICAqIGZh c3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLW5vbGF5b3V0c3RhdGUuaHRtbDogQWRk ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0 LWRlbHRhLW5vbGF5b3V0c3RhdGUtZXhwZWN0ZWQuY2hlY2tzdW06IEFkZGVkLgorICAgICAgICAq IHBsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1ub2xheW91 dHN0YXRlLWV4cGVjdGVkLnBuZzogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2Zhc3Qv cmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLW5vbGF5b3V0c3RhdGUtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKwogMjAxMC0wMy0xOCAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNv bT4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1ub2xheW91dHN0YXRlLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1ub2xheW91dHN0YXRl Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMjQzZDJhNgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRl bHRhLW5vbGF5b3V0c3RhdGUuaHRtbApAQCAtMCwwICsxLDM1IEBACis8aHRtbD4KKzxoZWFkPgor ICAgIDx0aXRsZT5UZXN0IGZvciBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNTk5NDwvdGl0bGU+CisgICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyAgICAgICAgZGl2 IHsKKyAgICAgICAgICAgIG92ZXJmbG93OiBoaWRkZW47CisgICAgICAgIH0KKyAgICAgICAgZGl2 LCBzcGFuIHsKKyAgICAgICAgICAgIGhlaWdodDogMTAwcHg7CisgICAgICAgICAgICB3aWR0aDog MTAwcHg7CisgICAgICAgICAgICBkaXNwbGF5OiBibG9jazsKKyAgICAgICAgfQorICAgICAgICBz cGFuLmJsdWUgeworICAgICAgICAgICAgcGFkZGluZzogMTAwcHggMCAwIDA7CisgICAgICAgICAg ICBiYWNrZ3JvdW5kOiBibHVlOworICAgICAgICB9CisgICAgPC9zdHlsZT4KKyAgICA8c2NyaXB0 IHNyYz0icmVzb3VyY2VzL3JlcGFpbnQuanMiIHR5cGU9InRleHQvamF2YXNjcmlwdCI+PC9zY3Jp cHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorICAgICAgIGZ1bmN0aW9u IHJlcGFpbnRUZXN0KCkKKyAgICAgICB7CisgICAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCd0MScpLnJlbW92ZUF0dHJpYnV0ZSgiY2xhc3MiKTsKKyAgICAgICAgICAgZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3QyJykuc2V0QXR0cmlidXRlKCJjbGFzcyIsICJibHVlIik7CisgICAg ICAgfQorICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5SZXBhaW50VGVz dCgpIj4KKzxkaXYgc3R5bGU9IndpZHRoOjIwMHB4OyBoZWlnaHQ6MTAwcHg7IC13ZWJraXQtdHJh bnNmb3JtOnJvdGF0ZSgxODBkZWcpOyI+CisKKyAgICA8ZGl2IHN0eWxlPSJiYWNrZ3JvdW5kOiBn cmVlbjsiPjxzcGFuIGlkPSJ0MSIgY2xhc3M9ImJsdWUiPiZuYnNwOzwvc3Bhbj48L2Rpdj4KKyAg ICA8ZGl2IHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmU7IG1hcmdpbjogLTEwMHB4IDAgMCAxMDBw eDsgYmFja2dyb3VuZDogcmVkOyI+PHNwYW4gaWQ9InQyIj4mbmJzcDs8L3NwYW4+PC9kaXY+Cis8 L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLW5vbGF5b3V0c3RhdGUt ZXhwZWN0ZWQuY2hlY2tzdW0gYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50 L2NsaXAtd2l0aC1sYXlvdXQtZGVsdGEtbm9sYXlvdXRzdGF0ZS1leHBlY3RlZC5jaGVja3N1bQpu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi45NDQ2Y2I3Ci0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5 b3V0LWRlbHRhLW5vbGF5b3V0c3RhdGUtZXhwZWN0ZWQuY2hlY2tzdW0KQEAgLTAsMCArMSBAQAor NzIyZjdkMmY3NGExNDU3OGIwNjc4YjgzZjAwZjRhY2YKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBm aWxlCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2Ns aXAtd2l0aC1sYXlvdXQtZGVsdGEtbm9sYXlvdXRzdGF0ZS1leHBlY3RlZC5wbmcgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9yZXBhaW50L2NsaXAtd2l0aC1sYXlvdXQtZGVsdGEtbm9s YXlvdXRzdGF0ZS1leHBlY3RlZC5wbmcKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MC4uNjU5OGE3ZQpCaW5hcnkgZmlsZXMgL2Rldi9udWxsIGFuZCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1ub2xheW91dHN0YXRl LWV4cGVjdGVkLnBuZyBkaWZmZXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9mYXN0L3JlcGFpbnQvY2xpcC13aXRoLWxheW91dC1kZWx0YS1ub2xheW91dHN0YXRlLWV4cGVj dGVkLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L3JlcGFpbnQvY2xpcC13aXRo LWxheW91dC1kZWx0YS1ub2xheW91dHN0YXRlLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwLi5kNDUzMmYzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vbWFjL2Zhc3QvcmVwYWludC9jbGlwLXdpdGgtbGF5b3V0LWRlbHRhLW5vbGF5 b3V0c3RhdGUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTcgQEAKK2xheWVyIGF0ICgwLDApIHNp emUgODAweDYwMAorICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQg KDAsMCkgc2l6ZSA4MDB4NjAwCisgIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgw MHg2MDAKKyAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKK2xheWVy IGF0ICg4LDgpIHNpemUgMjAweDEwMAorICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMCwwKSBzaXpl IDIwMHgxMDAKK2xheWVyIGF0ICg4LDgpIHNpemUgMTAweDEwMAorICBSZW5kZXJCbG9jayB7RElW fSBhdCAoMCwwKSBzaXplIDEwMHgxMDAgW2JnY29sb3I9IzAwODAwMF0KKyAgICBSZW5kZXJCbG9j ayB7U1BBTn0gYXQgKDAsMCkgc2l6ZSAxMDB4MTAwCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0g YXQgKDAsMCkgc2l6ZSA0eDE4CisgICAgICAgIHRleHQgcnVuIGF0ICgwLDApIHdpZHRoIDQ6ICIg IgorbGF5ZXIgYXQgKDEwOCw4KSBzaXplIDEwMHgxMDAgc2Nyb2xsSGVpZ2h0IDIwMAorICBSZW5k ZXJCbG9jayAocmVsYXRpdmUgcG9zaXRpb25lZCkge0RJVn0gYXQgKDEwMCwwKSBzaXplIDEwMHgx MDAgW2JnY29sb3I9I0ZGMDAwMF0KKyAgICBSZW5kZXJCbG9jayB7U1BBTn0gYXQgKDAsMCkgc2l6 ZSAxMDB4MjAwIFtiZ2NvbG9yPSMwMDAwRkZdCisgICAgICBSZW5kZXJUZXh0IHsjdGV4dH0gYXQg KDAsMTAwKSBzaXplIDR4MTgKKyAgICAgICAgdGV4dCBydW4gYXQgKDAsMTAwKSB3aWR0aCA0OiAi ICIKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggMWQ0ZjM2Ny4uNWYxNTZmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wMy0yMiAgQmVuamFtaW4g UG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJFR1JFU1NJT046IEluY29tcGxldGUgcmVw YWludCBvZiBDU1MgaW1hZ2Ugc3Vic3RpdHV0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk5NAorCisgICAgICAgIE9mZnNldCB0aGUgY2xpcCBy ZWdpb24gYnkgdGhlIExheW91dERlbHRhIGluIG9yZGVyIHRvIGhhdmUgaXQKKyAgICAgICAgaW4g dGhlIHNwYWNlIGNvb3JkaW5hdGUgc3BhY2UgYXMgdGhlIHJlY3QuCisKKyAgICAgICAgVGVzdDog ZmFzdC9yZXBhaW50L2NsaXAtd2l0aC1sYXlvdXQtZGVsdGEtbm9sYXlvdXRzdGF0ZS5odG1sCisK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckJveDo6Y29tcHV0ZVJlY3RGb3JSZXBhaW50KToKKwogMjAxMC0wMy0xMiAgT2phbiBWYWZh aSAgPG9qYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmlu LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcCBiL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXggMWMwZTgzNy4uMWRkZjk3YyAxMDA2NDQKLS0t IGEvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCb3guY3BwCkBAIC0xMTQ2LDI1ICsxMTQ2LDI2IEBAIEludFJlY3QgUmVuZGVyQm94 OjpjbGlwcGVkT3ZlcmZsb3dSZWN0Rm9yUmVwYWludChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVw YWludENvCiAKIHZvaWQgUmVuZGVyQm94Ojpjb21wdXRlUmVjdEZvclJlcGFpbnQoUmVuZGVyQm94 TW9kZWxPYmplY3QqIHJlcGFpbnRDb250YWluZXIsIEludFJlY3QmIHJlY3QsIGJvb2wgZml4ZWQp CiB7Ci0gICAgaWYgKFJlbmRlclZpZXcqIHYgPSB2aWV3KCkpIHsKLSAgICAgICAgLy8gTGF5b3V0 U3RhdGUgaXMgb25seSB2YWxpZCBmb3Igcm9vdC1yZWxhdGl2ZSByZXBhaW50aW5nCi0gICAgICAg IGlmICh2LT5sYXlvdXRTdGF0ZUVuYWJsZWQoKSAmJiAhcmVwYWludENvbnRhaW5lcikgewotICAg ICAgICAgICAgTGF5b3V0U3RhdGUqIGxheW91dFN0YXRlID0gdi0+bGF5b3V0U3RhdGUoKTsKKyAg ICBSZW5kZXJWaWV3KiB2ID0gdmlldygpOwogCi0gICAgICAgICAgICBpZiAobGF5ZXIoKSAmJiBs YXllcigpLT50cmFuc2Zvcm0oKSkKLSAgICAgICAgICAgICAgICByZWN0ID0gbGF5ZXIoKS0+dHJh bnNmb3JtKCktPm1hcFJlY3QocmVjdCk7CisgICAgLy8gTGF5b3V0U3RhdGUgaXMgb25seSB2YWxp ZCBmb3Igcm9vdC1yZWxhdGl2ZSByZXBhaW50aW5nCisgICAgaWYgKHYgJiYgdi0+bGF5b3V0U3Rh dGVFbmFibGVkKCkgJiYgIXJlcGFpbnRDb250YWluZXIpIHsKKyAgICAgICAgTGF5b3V0U3RhdGUq IGxheW91dFN0YXRlID0gdi0+bGF5b3V0U3RhdGUoKTsKIAotICAgICAgICAgICAgaWYgKHN0eWxl KCktPnBvc2l0aW9uKCkgPT0gUmVsYXRpdmVQb3NpdGlvbiAmJiBsYXllcigpKQotICAgICAgICAg ICAgICAgIHJlY3QubW92ZShsYXllcigpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCkpOworICAg ICAgICBpZiAobGF5ZXIoKSAmJiBsYXllcigpLT50cmFuc2Zvcm0oKSkKKyAgICAgICAgICAgIHJl Y3QgPSBsYXllcigpLT50cmFuc2Zvcm0oKS0+bWFwUmVjdChyZWN0KTsKIAotICAgICAgICAgICAg cmVjdC5tb3ZlKHgoKSwgeSgpKTsKLSAgICAgICAgICAgIHJlY3QubW92ZShsYXlvdXRTdGF0ZS0+ bV9vZmZzZXQpOwotICAgICAgICAgICAgaWYgKGxheW91dFN0YXRlLT5tX2NsaXBwZWQpCi0gICAg ICAgICAgICAgICAgcmVjdC5pbnRlcnNlY3QobGF5b3V0U3RhdGUtPm1fY2xpcFJlY3QpOwotICAg ICAgICAgICAgcmV0dXJuOwotICAgICAgICB9CisgICAgICAgIGlmIChzdHlsZSgpLT5wb3NpdGlv bigpID09IFJlbGF0aXZlUG9zaXRpb24gJiYgbGF5ZXIoKSkKKyAgICAgICAgICAgIHJlY3QubW92 ZShsYXllcigpLT5yZWxhdGl2ZVBvc2l0aW9uT2Zmc2V0KCkpOworCisgICAgICAgIHJlY3QubW92 ZSh4KCksIHkoKSk7CisgICAgICAgIHJlY3QubW92ZShsYXlvdXRTdGF0ZS0+bV9vZmZzZXQpOwor ICAgICAgICBpZiAobGF5b3V0U3RhdGUtPm1fY2xpcHBlZCkKKyAgICAgICAgICAgIHJlY3QuaW50 ZXJzZWN0KGxheW91dFN0YXRlLT5tX2NsaXBSZWN0KTsKKyAgICAgICAgcmV0dXJuOwogICAgIH0K IAorCiAgICAgaWYgKGhhc1JlZmxlY3Rpb24oKSkKICAgICAgICAgcmVjdC51bml0ZShyZWZsZWN0 ZWRSZWN0KHJlY3QpKTsKIApAQCAtMTIxMSw3ICsxMjEyLDcgQEAgdm9pZCBSZW5kZXJCb3g6OmNv bXB1dGVSZWN0Rm9yUmVwYWludChSZW5kZXJCb3hNb2RlbE9iamVjdCogcmVwYWludENvbnRhaW5l ciwgSW4KICAgICAgICAgLy8gZmxhZyBvbiB0aGUgUmVuZGVyT2JqZWN0IGhhcyBiZWVuIGNsZWFy ZWQsIHNvIHVzZSB0aGUgb25lIG9uIHRoZSBzdHlsZSgpLgogICAgICAgICB0b3BMZWZ0ICs9IGxh eWVyKCktPnJlbGF0aXZlUG9zaXRpb25PZmZzZXQoKTsKICAgICB9Ci0gICAgCisKICAgICAvLyBG SVhNRTogV2UgaWdub3JlIHRoZSBsaWdodHdlaWdodCBjbGlwcGluZyByZWN0IHRoYXQgY29udHJv bHMgdXNlLCBzaW5jZSBpZiB8b3wgaXMgaW4gbWlkLWxheW91dCwKICAgICAvLyBpdHMgY29udHJv bENsaXBSZWN0IHdpbGwgYmUgd3JvbmcuIEZvciBvdmVyZmxvdyBjbGlwIHdlIHVzZSB0aGUgdmFs dWVzIGNhY2hlZCBieSB0aGUgbGF5ZXIuCiAgICAgaWYgKG8tPmhhc092ZXJmbG93Q2xpcCgpKSB7 CkBAIC0xMjI0LDYgKzEyMjUsOSBAQCB2b2lkIFJlbmRlckJveDo6Y29tcHV0ZVJlY3RGb3JSZXBh aW50KFJlbmRlckJveE1vZGVsT2JqZWN0KiByZXBhaW50Q29udGFpbmVyLCBJbgogCiAgICAgICAg IEludFJlY3QgcmVwYWludFJlY3QodG9wTGVmdCwgcmVjdC5zaXplKCkpOwogICAgICAgICBJbnRS ZWN0IGJveFJlY3QoMCwgMCwgY29udGFpbmVyQm94LT5sYXllcigpLT53aWR0aCgpLCBjb250YWlu ZXJCb3gtPmxheWVyKCktPmhlaWdodCgpKTsKKyAgICAgICAgaWYgKHYgJiYgIWxheWVyKCkpCisg ICAgICAgICAgICBib3hSZWN0Lm1vdmUodi0+bGF5b3V0RGVsdGEoKSk7CisKICAgICAgICAgcmVj dCA9IGludGVyc2VjdGlvbihyZXBhaW50UmVjdCwgYm94UmVjdCk7CiAgICAgICAgIGlmIChyZWN0 LmlzRW1wdHkoKSkKICAgICAgICAgICAgIHJldHVybjsK