159925 2016-07-19 10:29:47 -0700 Fix null handling of HTMLSelectElement.value attribute 2016-07-20 10:42:44 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 cdumez cdumez benjamin cdumez darin dbates rniwa oldest_to_newest 1212419 0 cdumez 2016-07-19 10:29:47 -0700 Fix null handling of HTMLSelectElement.value attribute: https://html.spec.whatwg.org/multipage/forms.html#htmlselectelement We currently treat null as the null String which ends up setting selectedIndex to -1. However, we should treat null as the String "null" which would set the selectedIndex to the Index of the <option> element whose value is "null". Firefox and Chrome match the specification. 1212421 1 284019 cdumez 2016-07-19 10:32:35 -0700 Created attachment 284019 Patch 1212652 2 284019 benjamin 2016-07-19 21:46:51 -0700 Comment on attachment 284019 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284019&action=review > LayoutTests/fast/dom/HTMLSelectElement/value-null-handling.html:19 > +evalAndLog("select.value = null"); > +shouldBeEqualToString("select.value", "null"); > +shouldBe("select.selectedIndex", "1"); You are missing a case. Setting the value to null and not having a value==="null" in the select element. 1212762 3 cdumez 2016-07-20 09:38:39 -0700 Committed r203456: <http://trac.webkit.org/changeset/203456> 1212800 4 cdumez 2016-07-20 10:42:44 -0700 (In reply to comment #2) > Comment on attachment 284019 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284019&action=review > > > LayoutTests/fast/dom/HTMLSelectElement/value-null-handling.html:19 > > +evalAndLog("select.value = null"); > > +shouldBeEqualToString("select.value", "null"); > > +shouldBe("select.selectedIndex", "1"); > > You are missing a case. Setting the value to null and not having a > value==="null" in the select element. I added it before landing, thanks. 284019 2016-07-19 10:32:35 -0700 2016-07-20 10:42:10 -0700 Patch bug-159925-20160719103139.patch text/plain 5342 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzNDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDAwOTQ5ZWU0YzQyNmYx YzNkYTllNDVjOWY2ZTE0M2ZmMDkyZWVkYS4uZGJhZjZiN2Y2ZmUxOWRmZmRmMmVjYTYzMzY4MjYz YWZmYmRiNDk5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA3LTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IG51bGwgaGFuZGxpbmcg b2YgSFRNTFNlbGVjdEVsZW1lbnQudmFsdWUgYXR0cmlidXRlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk5MjUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggbnVsbCBoYW5kbGluZyBvZiBIVE1MU2Vs ZWN0RWxlbWVudC52YWx1ZSBhdHRyaWJ1dGU6CisgICAgICAgIC0gaHR0cHM6Ly9odG1sLnNwZWMu d2hhdHdnLm9yZy9tdWx0aXBhZ2UvZm9ybXMuaHRtbCNodG1sc2VsZWN0ZWxlbWVudAorCisgICAg ICAgIFdlIHdlcmUgdHJlYXRpbmcgbnVsbCBhcyB0aGUgbnVsbCBTdHJpbmcgd2hpY2ggd291bGQg ZW5kIHVwIHNldHRpbmcKKyAgICAgICAgc2VsZWN0ZWRJbmRleCB0byAtMS4gSG93ZXZlciwgd2Ug c2hvdWxkIHRyZWF0IG51bGwgYXMgdGhlIFN0cmluZyAibnVsbCIKKyAgICAgICAgd2hpY2ggd291 bGQgc2V0IHRoZSBzZWxlY3RlZEluZGV4IHRvIHRoZSBpbmRleCBvZiB0aGUgPG9wdGlvbj4gZWxl bWVudAorICAgICAgICB3aG9zZSB2YWx1ZSBpcyAibnVsbCIuCisKKyAgICAgICAgRmlyZWZveCBh bmQgQ2hyb21lIG1hdGNoIHRoZSBzcGVjaWZpY2F0aW9uLgorCisgICAgICAgIFRlc3Q6IGZhc3Qv ZG9tL0hUTUxTZWxlY3RFbGVtZW50L3ZhbHVlLW51bGwtaGFuZGxpbmcuaHRtbAorCisgICAgICAg ICogaHRtbC9IVE1MU2VsZWN0RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MU2Vs ZWN0RWxlbWVudDo6c2V0VmFsdWUpOgorICAgICAgICAqIGh0bWwvSFRNTFNlbGVjdEVsZW1lbnQu aWRsOgorCiAyMDE2LTA3LTE5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29t PgogCiAgICAgICAgIEJ1YmJsZXMgYXBwZWFyIHNwbGl0IGZvciBhIGJyaWVmIG1vbWVudCBpbiBN ZXNzYWdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MU2VsZWN0RWxlbWVu dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxlY3RFbGVtZW50LmNwcAppbmRleCAy ODcxOWRkZjdhMTFiOWNkODBmM2MyMmY4NTA3MzFkMDBmMGRhNGUzLi5kZDQwMTIzNjUzYmRkMTk4 OTNlMDYwZWZlYThkMmM3OGY0MjNiNzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxTZWxlY3RFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTZWxl Y3RFbGVtZW50LmNwcApAQCAtMjYyLDE0ICsyNjIsOCBAQCBTdHJpbmcgSFRNTFNlbGVjdEVsZW1l bnQ6OnZhbHVlKCkgY29uc3QKICAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKIH0KIAotdm9pZCBI VE1MU2VsZWN0RWxlbWVudDo6c2V0VmFsdWUoY29uc3QgU3RyaW5nICZ2YWx1ZSkKK3ZvaWQgSFRN TFNlbGVjdEVsZW1lbnQ6OnNldFZhbHVlKGNvbnN0IFN0cmluZyYgdmFsdWUpCiB7Ci0gICAgLy8g V2UgY2xlYXIgdGhlIHByZXZpb3VzbHkgc2VsZWN0ZWQgb3B0aW9uKHMpIHdoZW4gbmVlZGVkLCB0 byBndWFyYW50ZWUgY2FsbGluZyBzZXRTZWxlY3RlZEluZGV4KCkgb25seSBvbmNlLgotICAgIGlm ICh2YWx1ZS5pc051bGwoKSkgewotICAgICAgICBzZXRTZWxlY3RlZEluZGV4KC0xKTsKLSAgICAg ICAgcmV0dXJuOwotICAgIH0KLQogICAgIC8vIEZpbmQgdGhlIG9wdGlvbiB3aXRoIHZhbHVlKCkg bWF0Y2hpbmcgdGhlIGdpdmVuIHBhcmFtZXRlciBhbmQgbWFrZSBpdCB0aGUgY3VycmVudCBzZWxl Y3Rpb24uCiAgICAgdW5zaWduZWQgb3B0aW9uSW5kZXggPSAwOwogICAgIGZvciAoYXV0byogaXRl bSA6IGxpc3RJdGVtcygpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxT ZWxlY3RFbGVtZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQu aWRsCmluZGV4IDFkYTZhODI5ZmQzNWM0MGQxYzc2OWRiN2ZjMWZjM2NhNmZkYjY2YTIuLjA0NDY5 MmYwOGE0NDc5Nzc3OTM0ZWU5OWYzYTQ0NDQ0ZmEwMWM1NTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvSFRNTFNlbGVjdEVsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFNlbGVjdEVsZW1lbnQuaWRsCkBAIC02OCw3ICs2OCw3IEBACiAgICAgcmVhZG9ubHkg YXR0cmlidXRlIEhUTUxDb2xsZWN0aW9uIHNlbGVjdGVkT3B0aW9uczsKICAgICBhdHRyaWJ1dGUg bG9uZyBzZWxlY3RlZEluZGV4OwogCi0gICAgW1RyZWF0TnVsbEFzPUxlZ2FjeU51bGxTdHJpbmdd IGF0dHJpYnV0ZSBET01TdHJpbmcgdmFsdWU7IC8vIEZJWE1FOiBUaGlzIHNob3VsZCBub3QgdXNl IFtUcmVhdE51bGxBcz1MZWdhY3lOdWxsU3RyaW5nXS4KKyAgICBhdHRyaWJ1dGUgRE9NU3RyaW5n IHZhbHVlOwogCiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gd2lsbFZhbGlkYXRlOwog ICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBWYWxpZGl0eVN0YXRlIHZhbGlkaXR5OwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDEw OWJmNTczYjRkOTAzNjc3OTBlZjMxOWI0Yjg3MjRmZGU5N2U5NWEuLjU3MzA2ZjVhODNkYjhiYWZh ZTM5YzFiOGViZjJmMzlkMTJhZDQ5MTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNi0wNy0x OSAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBudWxsIGhh bmRsaW5nIG9mIEhUTUxTZWxlY3RFbGVtZW50LnZhbHVlIGF0dHJpYnV0ZQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5OTI1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGxheW91dCB0ZXN0IGNvdmVy YWdlLiBJIGhhdmUgdmVyaWZpZWQgdGhhdCB0aGlzIHRlc3QgaXMgcGFzc2luZyBpbgorICAgICAg ICBib3RoIEZpcmVmb3ggYW5kIENocm9tZS4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxTZWxl Y3RFbGVtZW50L3ZhbHVlLW51bGwtaGFuZGxpbmctZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2RvbS9IVE1MU2VsZWN0RWxlbWVudC92YWx1ZS1udWxsLWhhbmRsaW5nLmh0bWw6 IEFkZGVkLgorCiAyMDE2LTA3LTE5ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgogCiAgICAgICAgIEJ1YmJsZXMgYXBwZWFyIHNwbGl0IGZvciBhIGJyaWVmIG1vbWVudCBp biBNZXNzYWdlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVs ZW1lbnQvdmFsdWUtbnVsbC1oYW5kbGluZy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2RvbS9IVE1MU2VsZWN0RWxlbWVudC92YWx1ZS1udWxsLWhhbmRsaW5nLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5lNWVlMmRlMzdkY2I0YWE2YTA0NjBlOGM5ZWRlOTVmMTg2ZjM4ZDY1Ci0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvdmFs dWUtbnVsbC1oYW5kbGluZy1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNSBAQAorVGVzdHMgbnVs bCBoYW5kbGluZyBvZiBIVE1MU2VsZWN0RWxlbWVudC52YWx1ZSBhdHRyaWJ1dGUKKworT24gc3Vj Y2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQg YnkgIlRFU1QgQ09NUExFVEUiLgorCisKK3NlbGVjdC52YWx1ZSA9ICdhJworUEFTUyBzZWxlY3Qu dmFsdWUgaXMgImEiCitQQVNTIHNlbGVjdC5zZWxlY3RlZEluZGV4IGlzIDAKK3NlbGVjdC52YWx1 ZSA9IG51bGwKK1BBU1Mgc2VsZWN0LnZhbHVlIGlzICJudWxsIgorUEFTUyBzZWxlY3Quc2VsZWN0 ZWRJbmRleCBpcyAxCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N UExFVEUKKyAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxTZWxlY3RFbGVt ZW50L3ZhbHVlLW51bGwtaGFuZGxpbmcuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxT ZWxlY3RFbGVtZW50L3ZhbHVlLW51bGwtaGFuZGxpbmcuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iODQzNDU3 NjJmMjg2YzY3YjAzYjI0ODZlNWQ1YWJiZmU4ZmQwYTUxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9kb20vSFRNTFNlbGVjdEVsZW1lbnQvdmFsdWUtbnVsbC1oYW5kbGluZy5o dG1sCkBAIC0wLDAgKzEsMjMgQEAKKzxET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNj cmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8 c2VsZWN0IGlkPSJ0ZXN0U2VsZWN0Ij4KKzxvcHRpb24gdmFsdWU9ImEiLz4KKzxvcHRpb24gdmFs dWU9Im51bGwiLz4KKzwvc2VsZWN0PgorPHNjcmlwdD4KK2Rlc2NyaXB0aW9uKCJUZXN0cyBudWxs IGhhbmRsaW5nIG9mIEhUTUxTZWxlY3RFbGVtZW50LnZhbHVlIGF0dHJpYnV0ZSIpOworCit2YXIg c2VsZWN0ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRlc3RTZWxlY3QiKTsKK2V2YWxBbmRM b2coInNlbGVjdC52YWx1ZSA9ICdhJyIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5nKCJzZWxlY3Qu dmFsdWUiLCAiYSIpOworc2hvdWxkQmUoInNlbGVjdC5zZWxlY3RlZEluZGV4IiwgIjAiKTsKKwor ZXZhbEFuZExvZygic2VsZWN0LnZhbHVlID0gbnVsbCIpOworc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCJzZWxlY3QudmFsdWUiLCAibnVsbCIpOworc2hvdWxkQmUoInNlbGVjdC5zZWxlY3RlZEluZGV4 IiwgIjEiKTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgo=