159884 2016-07-18 11:45:49 -0700 LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2 2017-11-15 13:11:04 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad achristensen achristensen ap beidson darin webkit-bug-importer youennf oldest_to_newest 1212032 0 ryanhaddad 2016-07-18 11:45:49 -0700 LayoutTest http/tests/loading/basic-auth-resend-wrong-credentials.html is flaky on WK2 This test is a flaky failure on El Cap Debug WK2, Yosemite Debug/Release WK2, and iOS Simulator Debug WK2 https://build.webkit.org/builders/Apple%20iOS%209%20Simulator%20Debug%20WK2%20(Tests)/builds/3513 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Floading%2Fbasic-auth-resend-wrong-credentials.html --- /Volumes/Data/slave/ios-simulator-9-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt +++ /Volumes/Data/slave/ios-simulator-9-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-actual.txt @@ -1,8 +1,8 @@ main frame - didStartProvisionalLoadForFrame main frame - didCommitLoadForFrame frame "-->" - didStartProvisionalLoadForFrame +127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword main frame - didFinishDocumentLoadForFrame -127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with wrongusername:wrongpassword frame "-->" - didCommitLoadForFrame frame "-->" - didFinishDocumentLoadForFrame frame "-->" - didStartProvisionalLoadForFrame 1212051 1 ryanhaddad 2016-07-18 12:16:54 -0700 Marked as flaky in <http://trac.webkit.org/projects/webkit/changeset/203357> 1367643 2 ryanhaddad 2017-11-02 17:16:43 -0700 The test is still flaky even after https://bugs.webkit.org/show_bug.cgi?id=178370 and https://bugs.webkit.org/show_bug.cgi?id=178467 1368111 3 ryanhaddad 2017-11-03 13:27:36 -0700 Diff from recent failure: --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/http/tests/loading/basic-auth-resend-wrong-credentials-actual.txt @@ -9,8 +9,8 @@ frame "-->" - didFinishDocumentLoadForFrame frame "-->" - didStartProvisionalLoadForFrame frame "-->" - didHandleOnloadEventsForFrame +127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword frame "-->" - didFinishLoadForFrame -127.0.0.1:8000 - didReceiveAuthenticationChallenge - Responding with correctusername:correctpassword frame "-->" - didCommitLoadForFrame frame "-->" - didFinishDocumentLoadForFrame This test makes sure that once WebCore preemptively sends out Basic credentials it thinks apply to a new resource, and that resource response with a 401 challenge, that it doesn't try to send the same wrong credentials a second time. 1368135 4 325959 achristensen 2017-11-03 14:00:40 -0700 Created attachment 325959 Patch 1368150 5 325959 darin 2017-11-03 14:27:00 -0700 Comment on attachment 325959 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325959&action=review > LayoutTests/http/tests/loading/basic-auth-resend-wrong-credentials.html:14 > function firstFrameLoaded() { Could also have just done iframe.onload="setTimeout(firstFrameLoaded, 0)" ? 1368155 6 achristensen 2017-11-03 14:30:26 -0700 That could accomplish the same thing. http://trac.webkit.org/r224432 1372387 7 webkit-bug-importer 2017-11-15 13:11:04 -0800 <rdar://problem/35568933> 325959 2017-11-03 14:00:40 -0700 2017-11-03 14:27:00 -0700 Patch bug-159884-20171103140039.patch text/plain 5587 achristensen SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIyNDQyNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTExLTAzICBBbGV4IENocmlzdGVuc2Vu ICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTGF5b3V0VGVzdCBodHRwL3Rl c3RzL2xvYWRpbmcvYmFzaWMtYXV0aC1yZXNlbmQtd3JvbmctY3JlZGVudGlhbHMuaHRtbCBpcyBm bGFreSBvbiBXSzIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE1OTg4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogaHR0cC90ZXN0cy9sb2FkaW5nL2Jhc2ljLWF1dGgtcmVzZW5kLXdyb25nLWNyZWRlbnRp YWxzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL2xvYWRpbmcvYmFzaWMtYXV0 aC1yZXNlbmQtd3JvbmctY3JlZGVudGlhbHMuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS93azIv aHR0cC90ZXN0cy9sb2FkaW5nL2Jhc2ljLWF1dGgtcmVzZW5kLXdyb25nLWNyZWRlbnRpYWxzLWV4 cGVjdGVkLnR4dDoKKwogMjAxNy0xMS0wMyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSBZb3NlbWl0ZSB0ZXN0IGV4cGVjdGF0aW9u cwpJbmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9sb2FkaW5nL2Jhc2ljLWF1dGgtcmVzZW5k LXdyb25nLWNyZWRlbnRpYWxzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2xvYWRpbmcvYmFzaWMtYXV0aC1yZXNlbmQtd3JvbmctY3JlZGVudGlhbHMt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMjQ0MjUpCisrKyBMYXlvdXRUZXN0cy9odHRwL3Rlc3Rz L2xvYWRpbmcvYmFzaWMtYXV0aC1yZXNlbmQtd3JvbmctY3JlZGVudGlhbHMtZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC03LDEyICs3LDE0IEBAIGZyYW1lICI8IS0tZnJhbWVQYXRoIC8v PCEtLWZyYW1lMC0tPi0tPiIKIGh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9sb2FkaW5nL3Jlc291cmNl cy90ZXN0Mi9wcm90ZWN0ZWQtcmVzb3VyY2UucGhwIC0gZGlkUmVjZWl2ZUF1dGhlbnRpY2F0aW9u Q2hhbGxlbmdlIC0gUmVzcG9uZGluZyB3aXRoIHdyb25ndXNlcm5hbWU6d3JvbmdwYXNzd29yZAog ZnJhbWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IiAtIGRpZENvbW1pdExvYWRG b3JGcmFtZQogZnJhbWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IiAtIGRpZEZp bmlzaERvY3VtZW50TG9hZEZvckZyYW1lCi1mcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFt ZTEtLT4tLT4iIC0gZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZQogZnJhbWUgIjwhLS1m cmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IiAtIGRpZEhhbmRsZU9ubG9hZEV2ZW50c0ZvckZy YW1lCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4tLT4iIC0gZGlkRmluaXNo TG9hZEZvckZyYW1lCitmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTEtLT4tLT4iIC0g ZGlkU3RhcnRQcm92aXNpb25hbExvYWRGb3JGcmFtZQogaHR0cDovLzEyNy4wLjAuMTo4MDAwL2xv YWRpbmcvcmVzb3VyY2VzL3Rlc3QyL2Jhc2ljLWF1dGgtdGVzdGluZy5waHA/dXNlcm5hbWU9Y29y cmVjdHVzZXJuYW1lJnBhc3N3b3JkPWNvcnJlY3RwYXNzd29yZCAtIGRpZFJlY2VpdmVBdXRoZW50 aWNhdGlvbkNoYWxsZW5nZSAtIFJlc3BvbmRpbmcgd2l0aCBjb3JyZWN0dXNlcm5hbWU6Y29ycmVj dHBhc3N3b3JkCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTEtLT4tLT4iIC0gZGlk Q29tbWl0TG9hZEZvckZyYW1lCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTEtLT4t LT4iIC0gZGlkRmluaXNoRG9jdW1lbnRMb2FkRm9yRnJhbWUKK2ZyYW1lICI8IS0tZnJhbWVQYXRo IC8vPCEtLWZyYW1lMS0tPi0tPiIgLSBkaWRIYW5kbGVPbmxvYWRFdmVudHNGb3JGcmFtZQorZnJh bWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUxLS0+LS0+IiAtIGRpZEZpbmlzaExvYWRGb3JG cmFtZQogVGhpcyB0ZXN0IG1ha2VzIHN1cmUgdGhhdCBvbmNlIFdlYkNvcmUgcHJlZW1wdGl2ZWx5 IHNlbmRzIG91dCBCYXNpYyBjcmVkZW50aWFscyBpdCB0aGlua3MgYXBwbHkgdG8gYSBuZXcgcmVz b3VyY2UsIGFuZCB0aGF0IHJlc291cmNlIHJlc3BvbnNlIHdpdGggYSA0MDEgY2hhbGxlbmdlLCB0 aGF0IGl0IGRvZXNuJ3QgdHJ5IHRvIHNlbmQgdGhlIHNhbWUgd3JvbmcgY3JlZGVudGlhbHMgYSBz ZWNvbmQgdGltZS4KIAogCkluZGV4OiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvYmFz aWMtYXV0aC1yZXNlbmQtd3JvbmctY3JlZGVudGlhbHMuaHRtbAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2xvYWRpbmcvYmFzaWMtYXV0aC1yZXNlbmQtd3JvbmctY3JlZGVu dGlhbHMuaHRtbAkocmV2aXNpb24gMjI0NDI1KQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9s b2FkaW5nL2Jhc2ljLWF1dGgtcmVzZW5kLXdyb25nLWNyZWRlbnRpYWxzLmh0bWwJKHdvcmtpbmcg Y29weSkKQEAgLTEyLDE0ICsxMiwxNiBAQCBpZiAod2luZG93LnRlc3RSdW5uZXIpIHsKIH0KIAog ZnVuY3Rpb24gZmlyc3RGcmFtZUxvYWRlZCgpIHsKLSAgICBpZiAod2luZG93LnRlc3RSdW5uZXIp IHsKLSAgICAgICAgdGVzdFJ1bm5lci5zZXRBdXRoZW50aWNhdGlvblVzZXJuYW1lKCJjb3JyZWN0 dXNlcm5hbWUiKTsKLSAgICAgICAgdGVzdFJ1bm5lci5zZXRBdXRoZW50aWNhdGlvblBhc3N3b3Jk KCJjb3JyZWN0cGFzc3dvcmQiKTsKLSAgICB9Ci0gICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiaWZyYW1lIik7Ci0gICAgZnJhbWUuc2V0QXR0cmlidXRlKCJzcmMiLCAiaHR0 cDovLzEyNy4wLjAuMTo4MDAwL2xvYWRpbmcvcmVzb3VyY2VzL3Rlc3QyL2Jhc2ljLWF1dGgtdGVz dGluZy5waHA/dXNlcm5hbWU9Y29ycmVjdHVzZXJuYW1lJnBhc3N3b3JkPWNvcnJlY3RwYXNzd29y ZCIpOwotICAgIGZyYW1lLnNldEF0dHJpYnV0ZSgib25sb2FkIiwgInNlY29uZEZyYW1lTG9hZGVk KCkiKTsKLSAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGZyYW1lKTsKKyAgICBzZXRUaW1l b3V0KCgpPT57CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgICAgICAgICAg dGVzdFJ1bm5lci5zZXRBdXRoZW50aWNhdGlvblVzZXJuYW1lKCJjb3JyZWN0dXNlcm5hbWUiKTsK KyAgICAgICAgICAgIHRlc3RSdW5uZXIuc2V0QXV0aGVudGljYXRpb25QYXNzd29yZCgiY29ycmVj dHBhc3N3b3JkIik7CisgICAgICAgIH0KKyAgICAgICAgdmFyIGZyYW1lID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiaWZyYW1lIik7CisgICAgICAgIGZyYW1lLnNldEF0dHJpYnV0ZSgic3JjIiwg Imh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9sb2FkaW5nL3Jlc291cmNlcy90ZXN0Mi9iYXNpYy1hdXRo LXRlc3RpbmcucGhwP3VzZXJuYW1lPWNvcnJlY3R1c2VybmFtZSZwYXNzd29yZD1jb3JyZWN0cGFz c3dvcmQiKTsKKyAgICAgICAgZnJhbWUuc2V0QXR0cmlidXRlKCJvbmxvYWQiLCAic2Vjb25kRnJh bWVMb2FkZWQoKSIpOworICAgICAgICBkb2N1bWVudC5ib2R5LmFwcGVuZENoaWxkKGZyYW1lKTsK KyAgICB9LCAwKTsKIH0KIAogZnVuY3Rpb24gc2Vjb25kRnJhbWVMb2FkZWQoKSB7CkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvaHR0cC90ZXN0cy9sb2FkaW5nL2Jhc2ljLWF1dGgtcmVz ZW5kLXdyb25nLWNyZWRlbnRpYWxzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS93azIvaHR0cC90ZXN0cy9sb2FkaW5nL2Jhc2ljLWF1dGgtcmVzZW5kLXdy b25nLWNyZWRlbnRpYWxzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjI0NDI1KQorKysgTGF5b3V0 VGVzdHMvcGxhdGZvcm0vd2syL2h0dHAvdGVzdHMvbG9hZGluZy9iYXNpYy1hdXRoLXJlc2VuZC13 cm9uZy1jcmVkZW50aWFscy1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTcsMTIgKzcs MTQgQEAgZnJhbWUgIjwhLS1mcmFtZVBhdGggLy88IS0tZnJhbWUwLS0+LS0+IgogMTI3LjAuMC4x OjgwMDAgLSBkaWRSZWNlaXZlQXV0aGVudGljYXRpb25DaGFsbGVuZ2UgLSBSZXNwb25kaW5nIHdp dGggd3Jvbmd1c2VybmFtZTp3cm9uZ3Bhc3N3b3JkCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwh LS1mcmFtZTAtLT4tLT4iIC0gZGlkQ29tbWl0TG9hZEZvckZyYW1lCiBmcmFtZSAiPCEtLWZyYW1l UGF0aCAvLzwhLS1mcmFtZTAtLT4tLT4iIC0gZGlkRmluaXNoRG9jdW1lbnRMb2FkRm9yRnJhbWUK LWZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEtLWZyYW1lMS0tPi0tPiIgLSBkaWRTdGFydFByb3Zp c2lvbmFsTG9hZEZvckZyYW1lCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4t LT4iIC0gZGlkSGFuZGxlT25sb2FkRXZlbnRzRm9yRnJhbWUKIGZyYW1lICI8IS0tZnJhbWVQYXRo IC8vPCEtLWZyYW1lMC0tPi0tPiIgLSBkaWRGaW5pc2hMb2FkRm9yRnJhbWUKK2ZyYW1lICI8IS0t ZnJhbWVQYXRoIC8vPCEtLWZyYW1lMS0tPi0tPiIgLSBkaWRTdGFydFByb3Zpc2lvbmFsTG9hZEZv ckZyYW1lCiAxMjcuMC4wLjE6ODAwMCAtIGRpZFJlY2VpdmVBdXRoZW50aWNhdGlvbkNoYWxsZW5n ZSAtIFJlc3BvbmRpbmcgd2l0aCBjb3JyZWN0dXNlcm5hbWU6Y29ycmVjdHBhc3N3b3JkCiBmcmFt ZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTEtLT4tLT4iIC0gZGlkQ29tbWl0TG9hZEZvckZy YW1lCiBmcmFtZSAiPCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTEtLT4tLT4iIC0gZGlkRmluaXNo RG9jdW1lbnRMb2FkRm9yRnJhbWUKK2ZyYW1lICI8IS0tZnJhbWVQYXRoIC8vPCEtLWZyYW1lMS0t Pi0tPiIgLSBkaWRIYW5kbGVPbmxvYWRFdmVudHNGb3JGcmFtZQorZnJhbWUgIjwhLS1mcmFtZVBh dGggLy88IS0tZnJhbWUxLS0+LS0+IiAtIGRpZEZpbmlzaExvYWRGb3JGcmFtZQogVGhpcyB0ZXN0 IG1ha2VzIHN1cmUgdGhhdCBvbmNlIFdlYkNvcmUgcHJlZW1wdGl2ZWx5IHNlbmRzIG91dCBCYXNp YyBjcmVkZW50aWFscyBpdCB0aGlua3MgYXBwbHkgdG8gYSBuZXcgcmVzb3VyY2UsIGFuZCB0aGF0 IHJlc291cmNlIHJlc3BvbnNlIHdpdGggYSA0MDEgY2hhbGxlbmdlLCB0aGF0IGl0IGRvZXNuJ3Qg dHJ5IHRvIHNlbmQgdGhlIHNhbWUgd3JvbmcgY3JlZGVudGlhbHMgYSBzZWNvbmQgdGltZS4KIAog Cg==