159877 2016-07-18 04:54:13 -0700 All-in-one buildfix after r202439 2016-07-18 23:51:49 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159875 P2 Normal --- 158354 1 ossy ossy andersca cdumez commit-queue ossy oldest_to_newest 1211953 0 ossy 2016-07-18 04:54:13 -0700 https://trac.webkit.org/changeset/202439 broke the all-in-one build: In file included from ../../Source/WebCore/Modules/webaudio/AudioContext.h:31:0, from DerivedSources/WebCore/JSAudioContext.h:25, from ../../Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:43, from ../../Source/WebCore/bindings/js/JSBindingsAllInOne.cpp:63: ../../Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62:25: error: reference to 'Function' is ambiguous ... ../../Source/WTF/wtf/Forward.h:28:28: note: candidates are: template<class T> class WTF::Function ../../Source/JavaScriptCore/runtime/PropertySlot.h:46:5: note: JSC::Attribute Function similar bug: https://bugs.webkit.org/show_bug.cgi?id=159875 1211954 1 283900 ossy 2016-07-18 04:57:14 -0700 Created attachment 283900 Patch 1211955 2 commit-queue 2016-07-18 04:59:27 -0700 Attachment 283900 did not pass style-queue: ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:62: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:63: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/Modules/webaudio/AudioDestinationNode.h:64: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 3 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1212285 3 283900 commit-queue 2016-07-18 23:51:45 -0700 Comment on attachment 283900 Patch Clearing flags on attachment: 283900 Committed r203399: <http://trac.webkit.org/changeset/203399> 1212286 4 commit-queue 2016-07-18 23:51:49 -0700 All reviewed patches have been landed. Closing bug. 283900 2016-07-18 04:57:14 -0700 2016-07-18 23:51:45 -0700 Patch bug-159877-20160718135620.patch text/plain 1683 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkzM2JhY2NiYzQ2NGJi NGI3ODg2ZDA1YWJiZjE3NzYyMzAzMDRhOC4uNGQ1OWMzNmUwOWRiOTI4YjI0MTU2OTAxMWM4NGRj MmVlY2YyZjBhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA3LTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWxsLWluLW9uZSBi dWlsZGZpeCBhZnRlciByMjAyNDM5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTk4NzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9EZXN0aW5hdGlvbk5vZGUuaDoK KyAgICAgICAgKFdlYkNvcmU6OkF1ZGlvRGVzdGluYXRpb25Ob2RlOjpyZXN1bWUpOgorICAgICAg ICAoV2ViQ29yZTo6QXVkaW9EZXN0aW5hdGlvbk5vZGU6OnN1c3BlbmQpOgorICAgICAgICAoV2Vi Q29yZTo6QXVkaW9EZXN0aW5hdGlvbk5vZGU6OmNsb3NlKToKKwogMjAxNi0wNy0xOCAgQ2FybG9z IEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgTWVtb3J5UHJl c3N1cmVIYW5kbGVyIGRvZXNuJ3Qgd29yayBpZiBjZ3JvdXBzIGFyZW4ndCBwcmVzZW50IGluIExp bnV4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvRGVz dGluYXRpb25Ob2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvRGVz dGluYXRpb25Ob2RlLmgKaW5kZXggODhhN2Y3MTEzNmMwZDM2MWJmNzIzZTk4NzhiYWJmM2FlZWY2 MGFkZS4uMjcyNTYyNWZhNzVlNzAzY2E5ZThiYmI2MTRmMGNiMDBlMjA5N2ZlZSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9BdWRpb0Rlc3RpbmF0aW9uTm9kZS5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9EZXN0aW5hdGlvbk5v ZGUuaApAQCAtNTksOSArNTksOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGVuYWJsZUlu cHV0KGNvbnN0IFN0cmluZyYgaW5wdXREZXZpY2VJZCkgPSAwOwogCiAgICAgdmlydHVhbCB2b2lk IHN0YXJ0UmVuZGVyaW5nKCkgPSAwOwotICAgIHZpcnR1YWwgdm9pZCByZXN1bWUoRnVuY3Rpb248 dm9pZCAoKT4mJikgeyB9Ci0gICAgdmlydHVhbCB2b2lkIHN1c3BlbmQoRnVuY3Rpb248dm9pZCAo KT4mJikgeyB9Ci0gICAgdmlydHVhbCB2b2lkIGNsb3NlKEZ1bmN0aW9uPHZvaWQgKCk+JiYpIHsg fQorICAgIHZpcnR1YWwgdm9pZCByZXN1bWUoV1RGOjpGdW5jdGlvbjx2b2lkICgpPiYmKSB7IH0K KyAgICB2aXJ0dWFsIHZvaWQgc3VzcGVuZChXVEY6OkZ1bmN0aW9uPHZvaWQgKCk+JiYpIHsgfQor ICAgIHZpcnR1YWwgdm9pZCBjbG9zZShXVEY6OkZ1bmN0aW9uPHZvaWQgKCk+JiYpIHsgfQogCiAg ICAgdmlydHVhbCBib29sIGlzUGxheWluZygpIHsgcmV0dXJuIGZhbHNlOyB9CiAgICAgdm9pZCBp c1BsYXlpbmdEaWRDaGFuZ2UoKSBvdmVycmlkZTsK