159875 2016-07-18 04:17:27 -0700 Windows buildfix after r203338 2016-07-18 05:43:34 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159877 P1 Blocker --- 159856 1 ossy ossy achristensen bfulgham cdumez commit-queue esprehn+autocc kangil.han mitz ossy pvollan sam oldest_to_newest 1211947 0 ossy 2016-07-18 04:17:27 -0700 ... 1211948 1 283898 ossy 2016-07-18 04:21:02 -0700 Created attachment 283898 Patch speculative fix, let Windows EWS check it 1211949 2 ossy 2016-07-18 04:21:43 -0700 build log: c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\dom\UserGestureIndicator.h(58): error C2872: 'Function': ambiguous symbol (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp) [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj] C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\DerivedSources\ForwardingHeaders\wtf/Function.h(33): note: could be 'WTF::Function' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp) c:\cygwin\home\buildbot\slave\win-release\build\webkitbuild\release\derivedsources\forwardingheaders\javascriptcore\PropertySlot.h(46): note: or 'JSC::Attribute Function' (compiling source file C:\cygwin\home\buildbot\slave\win-release\build\Source\WebCore\bindings\js\JSBindingsAllInOne.cpp) 1211950 3 commit-queue 2016-07-18 04:23:51 -0700 Attachment 283898 did not pass style-queue: ERROR: Source/WebCore/dom/UserGestureIndicator.h:58: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/dom/UserGestureIndicator.h:70: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1211961 4 ossy 2016-07-18 05:42:43 -0700 Committed r203346: <http://trac.webkit.org/changeset/203346> 283898 2016-07-18 04:21:02 -0700 2016-07-18 05:43:34 -0700 Patch bug-159875-20160718132007.patch text/plain 1767 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMzQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjkzM2JhY2NiYzQ2NGJi NGI3ODg2ZDA1YWJiZjE3NzYyMzAzMDRhOC4uNWQzYjk0MGQxNDg1OWFjZjc4MWQ5ODQ3Y2U2NjBl NDM0ZjExZjZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA3LTE4ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgV2luZG93cyBidWls ZGZpeCBhZnRlciByMjAzMzM4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNTk4NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGRvbS9Vc2VyR2VzdHVyZUluZGljYXRvci5oOgorICAgICAgICAoV2ViQ29y ZTo6VXNlckdlc3R1cmVUb2tlbjo6YWRkRGVzdHJ1Y3Rpb25PYnNlcnZlcik6CisKIDIwMTYtMDct MTggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IE1lbW9yeVByZXNzdXJlSGFuZGxlciBkb2Vzbid0IHdvcmsgaWYgY2dyb3VwcyBhcmVuJ3QgcHJl c2VudCBpbiBMaW51eApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1VzZXJHZXN0dXJl SW5kaWNhdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0b3IuaApp bmRleCBkZTQ1ODk1ZTMwMmYzM2YzZDg2ZGQ3MTRhYzZjODE0NzhlYzY4MDM0Li4wYWIwNzg0NTZm M2MxNzBkOTlmY2M3ZTdmMGVkNmY1NGZkZmJjNTYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9kb20vVXNlckdlc3R1cmVJbmRpY2F0b3IuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vVXNl ckdlc3R1cmVJbmRpY2F0b3IuaApAQCAtNTUsNyArNTUsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBw cm9jZXNzaW5nVXNlckdlc3R1cmUoKSBjb25zdCB7IHJldHVybiBtX3N0YXRlID09IFByb2Nlc3Np bmdVc2VyR2VzdHVyZTsgfQogICAgIGJvb2wgcHJvY2Vzc2luZ1VzZXJHZXN0dXJlRm9yTWVkaWEo KSBjb25zdCB7IHJldHVybiBtX3N0YXRlID09IFByb2Nlc3NpbmdVc2VyR2VzdHVyZSB8fCBtX3N0 YXRlID09IFByb2Nlc3NpbmdQb3RlbnRpYWxVc2VyR2VzdHVyZTsgfQogCi0gICAgdm9pZCBhZGRE ZXN0cnVjdGlvbk9ic2VydmVyKEZ1bmN0aW9uPHZvaWQgKFVzZXJHZXN0dXJlVG9rZW4mKT4mJiBv YnNlcnZlcikKKyAgICB2b2lkIGFkZERlc3RydWN0aW9uT2JzZXJ2ZXIoV1RGOjpGdW5jdGlvbjx2 b2lkIChVc2VyR2VzdHVyZVRva2VuJik+JiYgb2JzZXJ2ZXIpCiAgICAgewogICAgICAgICBtX2Rl c3RydWN0aW9uT2JzZXJ2ZXJzLmFwcGVuZChXVEZNb3ZlKG9ic2VydmVyKSk7CiAgICAgfQpAQCAt NjcsNyArNjcsNyBAQCBwcml2YXRlOgogICAgIH0KIAogICAgIFByb2Nlc3NpbmdVc2VyR2VzdHVy ZVN0YXRlIG1fc3RhdGUgPSBOb3RQcm9jZXNzaW5nVXNlckdlc3R1cmU7Ci0gICAgVmVjdG9yPEZ1 bmN0aW9uPHZvaWQgKFVzZXJHZXN0dXJlVG9rZW4mKT4+IG1fZGVzdHJ1Y3Rpb25PYnNlcnZlcnM7 CisgICAgVmVjdG9yPFdURjo6RnVuY3Rpb248dm9pZCAoVXNlckdlc3R1cmVUb2tlbiYpPj4gbV9k ZXN0cnVjdGlvbk9ic2VydmVyczsKIH07CiAKIGNsYXNzIFVzZXJHZXN0dXJlSW5kaWNhdG9yIHsK