159867 2016-07-17 22:47:01 -0700 "make ARCHS=x86_64" fails to build 2016-08-20 08:02:49 -0700 1 1 1 Unclassified WebKit WebKit Misc. Safari 9 Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap Annies84 commit-queue mitz oldest_to_newest 1211904 0 ap 2016-07-17 22:47:01 -0700 Makefile.shared sets ONLY_ACTIVE_ARCH=NO whenever ARCHS is set, and Plugin.32 cannot build when ARCHS=x86_64. This is different from what happens for "set-wevbkit-configuration --64-bit; make". In the latter case, the makefile doesn't do special custom for architectures (unless OVERRIDE_ARCHS is set, which is only done in LayoutTestRelay/Makefile). So ONLY_ACTIVE_ARCH remains at YES, and xcconfig files do their magic to override VALID_ARCHS and have Plugin.32 build as 64-bit. 1211905 1 283885 ap 2016-07-17 22:50:11 -0700 Created attachment 283885 proposed fix 1211982 2 283885 commit-queue 2016-07-18 09:18:45 -0700 Comment on attachment 283885 proposed fix Clearing flags on attachment: 283885 Committed r203348: <http://trac.webkit.org/changeset/203348> 1211983 3 commit-queue 2016-07-18 09:18:49 -0700 All reviewed patches have been landed. Closing bug. 283885 2016-07-17 22:50:11 -0700 2016-07-18 09:18:45 -0700 proposed fix Makefile.shared.txt text/plain 1188 ap SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzMz OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE2LTA3 LTE3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgICJtYWtl IEFSQ0hTPXg4Nl82NCIgZmFpbHMgdG8gYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTg2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWFrZWZpbGUuc2hhcmVkOiBPdmVycmlkZSBWQUxJRF9B UkNIUyB3aGVuIEFSQ0hTIGlzIHNldCwgc28gdGhhdCBldmVuIHByb2plY3RzCisgICAgICAgIHRo YXQgbm9ybWFsbHkgY3VzdG9taXplIFZBTElEX0FSQ0hTIHdvdWxkbid0IGZhaWwgdG8gYnVpbGQu CisKIDIwMTYtMDctMTMgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAg ICAgICAgIFtXaW5dIERMTHMgYXJlIG1pc3NpbmcgdmVyc2lvbiBpbmZvcm1hdGlvbi4KSW5kZXg6 IE1ha2VmaWxlLnNoYXJlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBNYWtlZmlsZS5zaGFyZWQJKHJldmlzaW9u IDIwMjg0NikKKysrIE1ha2VmaWxlLnNoYXJlZAkod29ya2luZyBjb3B5KQpAQCAtMjQsNiArMjQs MTMgQEAgaWZuZXEgKCwkKEFSQ0hTKSkKIAllbHNlCiAJCVhDT0RFX09QVElPTlMgOj0gJChYQ09E RV9PUFRJT05TKSBBUkNIUz0iJChBUkNIUykiCiAJCVhDT0RFX09QVElPTlMgKz0gT05MWV9BQ1RJ VkVfQVJDSD1OTworCQkjIE1ha2UgUGx1Z2luLjMyIGFuZCBQbHVnaW4uNjQgYnVpbGQgZXZlbiB3 aGVuIHRoZXkgY2FuJ3QgYmUgYnVpbHQgZm9yIHRoZSBzcGVjaWZpZWQgYXJjaGl0ZWN0dXJlLgor CQlpZmVxICgkKEFSQ0hTKSxpMzg2KQorCQkJWENPREVfT1BUSU9OUyArPSBWQUxJRF9BUkNIUz1p Mzg2CisJCWVuZGlmCisJCWlmZXEgKCQoQVJDSFMpLHg4Nl82NCkKKwkJCVhDT0RFX09QVElPTlMg Kz0gVkFMSURfQVJDSFM9eDg2XzY0CisJCWVuZGlmCiAJZW5kaWYKIGVuZGlmCiAK