159851 2016-07-15 17:01:54 -0700 Web Automation: Fix element and event coord space issues 2016-07-15 18:21:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy bburg joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1211674 0 timothy 2016-07-15 17:01:54 -0700 rdar://problem/27375780 1211675 1 webkit-bug-importer 2016-07-15 17:03:01 -0700 <rdar://problem/27383442> 1211676 2 283818 timothy 2016-07-15 17:04:21 -0700 Created attachment 283818 Patch 1211687 3 283818 bburg 2016-07-15 17:14:30 -0700 Comment on attachment 283818 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283818&action=review r=me > Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp:503 > rect = coreFrameView->rootViewToContents(rect); I see, so in this case the topContentInset is eventually subtracted here: ScrollPosition ScrollView::documentScrollPositionRelativeToViewOrigin() const { return scrollPosition() - IntSize( shouldPlaceBlockDirectionScrollbarOnLeft() && m_verticalScrollbar ? m_verticalScrollbar->occupiedWidth() : 0, headerHeight() + topContentInset(TopContentInsetType::WebCoreOrPlatformContentInset)); } But otherwise we get the clientRect in raw window space, which is why we have to deduct topContentInset in the other case. You may want to add a comment or note in the changelog about this, as I thought it was a bug when reviewing. 1211709 4 283818 timothy 2016-07-15 18:21:05 -0700 Comment on attachment 283818 Patch https://trac.webkit.org/changeset/203316 283818 2016-07-15 17:04:21 -0700 2016-07-15 18:21:05 -0700 Patch bug-159851-20160715170332.patch text/plain 3871 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjQzMjBkY2RiYTVkZWQx MWQ5MmRiNmZlOGVjZDI2M2I4ZmEzMDk5NS4uMDU2M2ZmODVkNWYxMTQzMmRjNWJmODliYTczYjIx NTk4YTIzNmM1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA3LTE1ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgQXV0b21hdGlv bjogRml4IGVsZW1lbnQgYW5kIGV2ZW50IGNvb3JkIHNwYWNlIGlzc3VlcworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5ODUxCisgICAgICAgIHJkYXI6 Ly9wcm9ibGVtLzI3Mzc1NzgwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lvbi5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkF1dG9tYXRpb25TZXNzaW9uOjpwZXJmb3JtTW91c2VJ bnRlcmFjdGlvbik6IFN1YnRyYWN0IHRvcENvbnRlbnRJbnNldCgpIGJlZm9yZQorICAgICAgICBp dCBnb2VzIGJhY2sgb3V0IHRvIFdlYkRyaXZlci4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0F1dG9t YXRpb24vV2ViQXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YkF1dG9tYXRpb25TZXNzaW9uUHJveHk6OmNvbXB1dGVFbGVtZW50TGF5b3V0KTogV2hlbiB1c2lu ZyB1c2VWaWV3cG9ydENvb3JkaW5hdGVzLAorICAgICAgICBzdWJ0cmFjdCB0b3BDb250ZW50SW5z ZXQoKSBzbyBpdCBtYXRjaGVzIGV4cGVjdGF0aW9ucy4KKwogMjAxNi0wNy0xNSAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBGdWxsIHNjcmVlbiBlUHViIGVtYmVk ZGVkIHZpZGVvIGlzIHBsYXlpbmcgb24gMS80IHNjcmVlbiwgY3V0IG9mZgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNlc3Npb24u Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0F1dG9tYXRpb24vV2ViQXV0b21hdGlvblNl c3Npb24uY3BwCmluZGV4IDczNWQzZGJiM2Y5OTM2MTlkN2ViN2JlZDFhY2MxMTRkOWJjNWYzNDIu LjFiNGE3MmVkZjMxOWJlZTI1NTY0NzRmYTZmOTgxMDQzOTkwZTNmMGYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9u U2Vzc2lvbi5jcHAKQEAgLTkxOCw3ICs5MTgsNyBAQCB2b2lkIFdlYkF1dG9tYXRpb25TZXNzaW9u OjpwZXJmb3JtTW91c2VJbnRlcmFjdGlvbihJbnNwZWN0b3I6OkVycm9yU3RyaW5nJiBlcnJvcgog CiAgICAgdXBkYXRlZFBvc2l0aW9uT2JqZWN0ID0gSW5zcGVjdG9yOjpQcm90b2NvbDo6QXV0b21h dGlvbjo6UG9pbnQ6OmNyZWF0ZSgpCiAgICAgICAgIC5zZXRYKHgpCi0gICAgICAgIC5zZXRZKHkp CisgICAgICAgIC5zZXRZKHkgLSBwYWdlLT50b3BDb250ZW50SW5zZXQoKSkKICAgICAgICAgLnJl bGVhc2UoKTsKICNlbmRpZiAvLyBVU0UoQVBQS0lUKQogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNzaW9uUHJveHkuY3Bw IGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9BdXRvbWF0aW9uL1dlYkF1dG9tYXRpb25TZXNz aW9uUHJveHkuY3BwCmluZGV4IGUyYzg2ODA5ZjI3NDEyNTJlZGEwYjcxYzFjNzQzODRhY2RkNzdh YTkuLjIyYTAxMjRmMjQzYjc3NWU5ZTc1MGQ0YjJkODE4ZjgwMTIxZGVkODMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvQXV0b21hdGlvbi9XZWJBdXRvbWF0aW9uU2Vzc2lv blByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0F1dG9tYXRpb24vV2Vi QXV0b21hdGlvblNlc3Npb25Qcm94eS5jcHAKQEAgLTQ4NywyMSArNDg3LDIyIEBAIHZvaWQgV2Vi QXV0b21hdGlvblNlc3Npb25Qcm94eTo6Y29tcHV0ZUVsZW1lbnRMYXlvdXQodWludDY0X3QgcGFn ZUlELCB1aW50NjRfdCBmCiAKICAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QgPSBjb3JlRWxlbWVu dC0+Y2xpZW50UmVjdCgpOwogCi0gICAgaWYgKCF1c2VWaWV3cG9ydENvb3JkaW5hdGVzKSB7Ci0g ICAgICAgIFdlYkNvcmU6OkZyYW1lKiBjb3JlRnJhbWUgPSBmcmFtZS0+Y29yZUZyYW1lKCk7Ci0g ICAgICAgIGlmICghY29yZUZyYW1lKSB7Ci0gICAgICAgICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0 b24oKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigpLT5zZW5kKE1lc3NhZ2VzOjpXZWJBdXRvbWF0 aW9uU2Vzc2lvbjo6RGlkQ29tcHV0ZUVsZW1lbnRMYXlvdXQoY2FsbGJhY2tJRCwgV2ViQ29yZTo6 SW50UmVjdCgpLCBmcmFtZU5vdEZvdW5kRXJyb3JUeXBlKSwgMCk7Ci0gICAgICAgICAgICByZXR1 cm47Ci0gICAgICAgIH0KKyAgICBXZWJDb3JlOjpGcmFtZSogY29yZUZyYW1lID0gZnJhbWUtPmNv cmVGcmFtZSgpOworICAgIGlmICghY29yZUZyYW1lKSB7CisgICAgICAgIFdlYlByb2Nlc3M6OnNp bmdsZXRvbigpLnBhcmVudFByb2Nlc3NDb25uZWN0aW9uKCktPnNlbmQoTWVzc2FnZXM6OldlYkF1 dG9tYXRpb25TZXNzaW9uOjpEaWRDb21wdXRlRWxlbWVudExheW91dChjYWxsYmFja0lELCBXZWJD b3JlOjpJbnRSZWN0KCksIGZyYW1lTm90Rm91bmRFcnJvclR5cGUpLCAwKTsKKyAgICAgICAgcmV0 dXJuOworICAgIH0KIAotICAgICAgICBXZWJDb3JlOjpGcmFtZVZpZXcgKmNvcmVGcmFtZVZpZXcg PSBjb3JlRnJhbWUtPnZpZXcoKTsKLSAgICAgICAgaWYgKCFjb3JlRnJhbWVWaWV3KSB7Ci0gICAg ICAgICAgICBXZWJQcm9jZXNzOjpzaW5nbGV0b24oKS5wYXJlbnRQcm9jZXNzQ29ubmVjdGlvbigp LT5zZW5kKE1lc3NhZ2VzOjpXZWJBdXRvbWF0aW9uU2Vzc2lvbjo6RGlkQ29tcHV0ZUVsZW1lbnRM YXlvdXQoY2FsbGJhY2tJRCwgV2ViQ29yZTo6SW50UmVjdCgpLCBmcmFtZU5vdEZvdW5kRXJyb3JU eXBlKSwgMCk7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KKyAgICBXZWJDb3JlOjpG cmFtZVZpZXcgKmNvcmVGcmFtZVZpZXcgPSBjb3JlRnJhbWUtPnZpZXcoKTsKKyAgICBpZiAoIWNv cmVGcmFtZVZpZXcpIHsKKyAgICAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJv Y2Vzc0Nvbm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViQXV0b21hdGlvblNlc3Npb246OkRp ZENvbXB1dGVFbGVtZW50TGF5b3V0KGNhbGxiYWNrSUQsIFdlYkNvcmU6OkludFJlY3QoKSwgZnJh bWVOb3RGb3VuZEVycm9yVHlwZSksIDApOworICAgICAgICByZXR1cm47CisgICAgfQogCisgICAg aWYgKCF1c2VWaWV3cG9ydENvb3JkaW5hdGVzKQogICAgICAgICByZWN0ID0gY29yZUZyYW1lVmll dy0+cm9vdFZpZXdUb0NvbnRlbnRzKHJlY3QpOwotICAgIH0KKyAgICBlbHNlCisgICAgICAgIHJl Y3QubW92ZUJ5KFdlYkNvcmU6OkludFBvaW50KDAsIC1jb3JlRnJhbWVWaWV3LT50b3BDb250ZW50 SW5zZXQoKSkpOwogCiAgICAgV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkucGFyZW50UHJvY2Vzc0Nv bm5lY3Rpb24oKS0+c2VuZChNZXNzYWdlczo6V2ViQXV0b21hdGlvblNlc3Npb246OkRpZENvbXB1 dGVFbGVtZW50TGF5b3V0KGNhbGxiYWNrSUQsIHJlY3QsIFN0cmluZygpKSwgMCk7CiB9Cg==