15983 2007-11-14 01:51:55 -0800 run-sunspider needs a --shark-cache option for L2 Cache miss profiling 2007-11-14 12:38:29 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric eric darin ggaren oldest_to_newest 61193 0 eric 2007-11-14 01:51:55 -0800 run-sunspider needs a --shark-cache option for L2 Cache miss profiling 61194 1 17265 eric 2007-11-14 01:52:15 -0800 Created attachment 17265 the fix 61222 2 17265 sam 2007-11-14 11:38:42 -0800 Comment on attachment 17265 the fix Your indentation is off, we like to use 4 spaces, not 2. Other than that. r=me. Please also remember to add a changelog. 61228 3 eric 2007-11-14 12:38:21 -0800 Landed as r27790. Hopefully the other --shark users will find this useful. 17265 2007-11-14 01:52:15 -0800 2007-11-14 11:38:42 -0800 the fix cache.patch text/plain 4394 eric ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2ogYi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJv amVjdC5wYnhwcm9qCmRpZmYgLS1naXQgYS9TdW5TcGlkZXIvc3Vuc3BpZGVyIGIvU3VuU3BpZGVy L3N1bnNwaWRlcgppbmRleCBiZDY0MzZlLi5lMjRhNDcwIDEwMDc1NQotLS0gYS9TdW5TcGlkZXIv c3Vuc3BpZGVyCisrKyBiL1N1blNwaWRlci9zdW5zcGlkZXIKQEAgLTM0LDYgKzM0LDcgQEAgdXNl IFBPU0lYIHF3KHN0cmZ0aW1lKTsKIG15ICRzaG93SGVscCA9IDA7CiBteSAkcnVuU2hhcmsgPSAw OwogbXkgJHJ1blNoYXJrMjAgPSAwOworbXkgJHJ1blNoYXJrQ2FjaGUgPSAwOwogbXkgJGpzU2hl bGxQYXRoOwogbXkgJHNldEJhc2VsaW5lID0gMDsKIG15ICR0ZXN0c1BhdHRlcm47CkBAIC00Nyw4 ICs0OCw5IEBAIFVzYWdlOiAkcHJvZ3JhbU5hbWUgLS1zaGVsbD1bcGF0aF0gW29wdGlvbnNdCiAg IC0tc2hlbGwgICAgICAgICAgIFBhdGggdG8gSmF2YVNjcmlwdCBzaGVsbAogICAtLXJ1bnMgICAg ICAgICAgICBOdW1iZXIgb2YgdGltZXMgdG8gcnVuIHRlc3RzIChkZWZhdWx0OiAkdGVzdFJ1bnMp CiAgIC0tdGVzdHMgICAgICAgICAgIE9ubHkgcnVuIHRlc3RzIG1hdGNoaW5nIHByb3ZpZGVkIHBh dHRlcm4KLSAgLS1zaGFyayAgICAgICAgICAgU2FtcGxlIHdpdGggdGhlIE1hYyBPUyBYICJTaGFy ayIgcGVyZm9ybWFuY2UgdGVzdGluZyB0b29sIChpbXBsaWVzIC0tcnVucz0xKQorICAtLXNoYXJr ICAgICAgICAgICBTYW1wbGUgZXhlY3V0aW9uIHRpbWUgd2l0aCB0aGUgTWFjIE9TIFggIlNoYXJr IiBwZXJmb3JtYW5jZSB0ZXN0aW5nIHRvb2wgKGltcGxpZXMgLS1ydW5zPTEpCiAgIC0tc2hhcmsy MCAgICAgICAgIExpa2UgLS1zaGFyaywgYnV0IHdpdGggYSAyMCBtaWNyb3NlY29uZCBzYW1wbGlu ZyBpbnRlcnZhbAorICAtLXNoYXJrLWNhY2hlICAgICBMaWtlIC0tc2hhcmssIGJ1dCBwZXJmb3Jt cyBhIEwyIGNhY2hlLW1pc3Mgc2FtcGxlIGluc3RlYWQgb2YgdGltZSBzYW1wbGUKIEVPRgogCiBH ZXRPcHRpb25zKCdydW5zPWknID0+IFwkdGVzdFJ1bnMsCkBAIC01NiwxNSArNTgsMzQgQEAgR2V0 T3B0aW9ucygncnVucz1pJyA9PiBcJHRlc3RSdW5zLAogICAgICAgICAgICAnc2hlbGw9cycgPT4g XCRqc1NoZWxsUGF0aCwKICAgICAgICAgICAgJ3NoYXJrJyA9PiBcJHJ1blNoYXJrLAogICAgICAg ICAgICAnc2hhcmsyMCcgPT4gXCRydW5TaGFyazIwLAorICAgICAgICAgICAnc2hhcmstY2FjaGUn ID0+IFwkcnVuU2hhcmtDYWNoZSwKICAgICAgICAgICAgJ3Rlc3RzPXMnID0+IFwkdGVzdHNQYXR0 ZXJuLAogICAgICAgICAgICAnaGVscCcgPT4gXCRzaG93SGVscCk7CiAKKyRydW5TaGFyayA9IDEg aWYgJHJ1blNoYXJrQ2FjaGU7CiAkcnVuU2hhcmsgPSAyMCBpZiAkcnVuU2hhcmsyMDsKICR0ZXN0 UnVucyA9IDEgaWYgJHJ1blNoYXJrOwogaWYgKCRydW5TaGFyayAmJiAhIC14ICIvdXNyL2Jpbi9z aGFyayIpIHsKICAgICBkaWUgIlBsZWFzZSBpbnN0YWxsIENIVUQgdG9vbHMgZnJvbSBodHRwOi8v ZGV2ZWxvcGVyLmFwcGxlLmNvbS90b29scy9kb3dubG9hZC9cbiI7CiB9CiAKK215ICRzaGFya0Nh Y2hlUHJvZmlsZUluZGV4ID0gMDsKK2lmICgkcnVuU2hhcmtDYWNoZSkgeworICBteSAkc2hhcmtQ cm9maWxlTGlzdCA9IGBzaGFyayAtbCAyPiYxYDsKKyAgZm9yIG15ICRwcm9maWxlIChzcGxpdCgv XG4vLCAkc2hhcmtQcm9maWxlTGlzdCkpIHsKKyAgICAkcHJvZmlsZSA9fiAvKFxkKykgLSAoLisp LzsKKyAgICBuZXh0ICB1bmxlc3MgKGRlZmluZWQgJDEpOworICAgIG15ICRwcm9maWxlSW5kZXgg PSAkMTsKKyAgICBteSAkcHJvZmlsZU5hbWUgPSAkMjsKKyAgICBpZiAoJHByb2ZpbGVOYW1lID1+ IC9MMiBDYWNoZS8pIHsKKyAgICAgICRzaGFya0NhY2hlUHJvZmlsZUluZGV4ID0gJHByb2ZpbGVJ bmRleDsKKyAgICAgIHByaW50ICJVc2luZyBTaGFyayBMMiBDYWNoZSBNaXNzIFByb2ZpbGU6ICIg LiAkcHJvZmlsZSAuICJcbiI7CisgICAgICBsYXN0OworICAgIH0KKyAgfQorICBkaWUgIkZhaWxl ZCB0byBmaW5kIEwyIENhY2hlIE1pc3MgUHJvZmlsZSBmb3IgLS1zaGFyay1jYWNoZVxuIiAgdW5s ZXNzICgkc2hhcmtDYWNoZVByb2ZpbGVJbmRleCk7Cit9CisKIGlmICghJGpzU2hlbGxQYXRoIHx8 ICRzaG93SGVscCkgewogICAgcHJpbnQgU1RERVJSICR1c2FnZTsKICAgIGV4aXQgMTsKQEAgLTEy MCw3ICsxNDEsOCBAQCBzdWIgcnVuVGVzdHNPbmNlKCQpCiAgICAgbXkgJG91dHB1dDsKICAgICBp ZiAoJHVzZVNoYXJrKSB7CiAgICAgICAgIG15ICRpbnRlcnZhbEFyZyA9ICR1c2VTaGFyayA9PSAy MCA/ICItSSAyMHUiIDogIiI7Ci0gICAgICAgICRvdXRwdXQgPSBgc2hhcmsgJGludGVydmFsQXJn IC1pIC0xLXEgIiRqc1NoZWxsUGF0aCIgJHNoZWxsQXJnc2A7CisgICAgICAgIG15ICRjYWNoZUFy ZyA9ICRydW5TaGFya0NhY2hlID8gIi1jICRzaGFya0NhY2hlUHJvZmlsZUluZGV4IiA6ICIiOwor ICAgICAgICAkb3V0cHV0ID0gYHNoYXJrICRpbnRlcnZhbEFyZyAkY2FjaGVBcmcgLWkgLTEtcSAi JGpzU2hlbGxQYXRoIiAkc2hlbGxBcmdzYDsKICAgICB9IGVsc2UgewogICAgICAgICAkb3V0cHV0 ID0gYCIkanNTaGVsbFBhdGgiICRzaGVsbEFyZ3MgfCBncmVwIC12IGJyZWFrYDsKICAgICB9CmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi1zdW5zcGlkZXIgYi9XZWJLaXRUb29s cy9TY3JpcHRzL3J1bi1zdW5zcGlkZXIKaW5kZXggNzA4NzhlOS4uMjNjMDQzMyAxMDA3NTUKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4tc3Vuc3BpZGVyCisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvcnVuLXN1bnNwaWRlcgpAQCAtNDAsNiArNDAsNyBAQCBteSAkcm9vdDsKIG15ICR0ZXN0 UnVucyA9IDU7ICMgVGhpcyBudW1iZXIgbWF5IGJlIGRpZmZlcmVudCBmcm9tIHdoYXQgc3Vuc3Bp ZGVyIGRlZmF1bHRzIHRvICh0aGF0J3MgT0spCiBteSAkcnVuU2hhcmsgPSAwOwogbXkgJHJ1blNo YXJrMjAgPSAwOworbXkgJHJ1blNoYXJrQ2FjaGUgPSAwOwogbXkgJHNldEJhc2VsaW5lID0gMDsK IG15ICRzaG93SGVscCA9IDA7CiBteSAkdGVzdHNQYXR0ZXJuOwpAQCAtNTQsNiArNTUsNyBAQCBV c2FnZTogJHByb2dyYW1OYW1lIFtvcHRpb25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5 c3RlbV0KICAgLS10ZXN0cyAgICAgICAgICAgT25seSBydW4gdGVzdHMgbWF0Y2hpbmcgcHJvdmlk ZWQgcGF0dGVybgogICAtLXNoYXJrICAgICAgICAgICBTYW1wbGUgd2l0aCB0aGUgTWFjIE9TIFgg IlNoYXJrIiBwZXJmb3JtYW5jZSB0ZXN0aW5nIHRvb2wgKGltcGxpZXMgLS1ydW5zPTEpCiAgIC0t c2hhcmsyMCAgICAgICAgIExpa2UgLS1zaGFyaywgYnV0IHdpdGggYSAyMCBtaWNyb3NlY29uZCBz YW1wbGluZyBpbnRlcnZhbAorICAtLXNoYXJrLWNhY2hlICAgICBMaWtlIC0tc2hhcmssIGJ1dCBw ZXJmb3JtcyBhIEwyIGNhY2hlLW1pc3Mgc2FtcGxlIGluc3RlYWQgb2YgdGltZSBzYW1wbGUKIEVP RgogCiBHZXRPcHRpb25zKCdyb290PXMnID0+IHN1YiB7IG15ICgkYXJnTmFtZSwgJHZhbHVlKTsg c2V0Q29uZmlndXJhdGlvblByb2R1Y3REaXIoQ3dkOjphYnNfcGF0aCgkdmFsdWUpKTsgfSwKQEAg LTYxLDYgKzYzLDcgQEAgR2V0T3B0aW9ucygncm9vdD1zJyA9PiBzdWIgeyBteSAoJGFyZ05hbWUs ICR2YWx1ZSk7IHNldENvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyKEMKICAgICAgICAgICAgJ3NldC1i YXNlbGluZScgPT4gXCRzZXRCYXNlbGluZSwKICAgICAgICAgICAgJ3NoYXJrJyA9PiBcJHJ1blNo YXJrLAogICAgICAgICAgICAnc2hhcmsyMCcgPT4gXCRydW5TaGFyazIwLAorICAgICAgICAgICAn c2hhcmstY2FjaGUnID0+IFwkcnVuU2hhcmtDYWNoZSwKICAgICAgICAgICAgJ3Rlc3RzPXMnID0+ IFwkdGVzdHNQYXR0ZXJuLAogICAgICAgICAgICAnaGVscCcgPT4gXCRzaG93SGVscCk7CiAKQEAg LTExNCw2ICsxMTcsNyBAQCBteSBAYXJncyA9ICgiLS1zaGVsbCIsIHRlc3RLSlNQYXRoKCRwcm9k dWN0RGlyKSwgIi0tcnVucyIsICR0ZXN0UnVucyk7CiBwdXNoIEBhcmdzLCAiLS1zZXQtYmFzZWxp bmUiIGlmICRzZXRCYXNlbGluZTsKIHB1c2ggQGFyZ3MsICItLXNoYXJrIiBpZiAkcnVuU2hhcms7 CiBwdXNoIEBhcmdzLCAiLS1zaGFyazIwIiBpZiAkcnVuU2hhcmsyMDsKK3B1c2ggQGFyZ3MsICIt LXNoYXJrLWNhY2hlIiBpZiAkcnVuU2hhcmtDYWNoZTsKIHB1c2ggQGFyZ3MsICItLXRlc3RzIiwg JHRlc3RzUGF0dGVybiBpZiAkdGVzdHNQYXR0ZXJuOwogCiBleGVjICIuL3N1bnNwaWRlciIsIEBh cmdzOwo=