159828 2016-07-15 13:52:43 -0700 FunctionOverride's parseClause() needs to keep the CString instance in scope while its data is being used. 2016-07-15 14:17:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mark.lam mark.lam commit-queue keith_miller msaboff saam oldest_to_newest 1211543 0 mark.lam 2016-07-15 13:52:43 -0700 Otherwise, we'll have a use after free. 1211548 1 283788 mark.lam 2016-07-15 13:56:43 -0700 Created attachment 283788 proposed patch. 1211565 2 283788 commit-queue 2016-07-15 14:17:51 -0700 Comment on attachment 283788 proposed patch. Clearing flags on attachment: 283788 Committed r203299: <http://trac.webkit.org/changeset/203299> 1211566 3 commit-queue 2016-07-15 14:17:55 -0700 All reviewed patches have been landed. Closing bug. 283788 2016-07-15 13:56:43 -0700 2016-07-15 14:17:51 -0700 proposed patch. bug-159828.patch text/plain 1457 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzMjk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE2LTA3LTE1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBG dW5jdGlvbk92ZXJyaWRlJ3MgcGFyc2VDbGF1c2UoKSBuZWVkcyB0byBrZWVwIHRoZSBDU3RyaW5n IGluc3RhbmNlIGluIHNjb3BlIHdoaWxlIGl0cyBkYXRhIGlzIGJlaW5nIHVzZWQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk4MjgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPdGhlcndpc2UsIHdlJ2xs IGhhdmUgYSB1c2UgYWZ0ZXIgZnJlZS4gIFRoaXMgaXNzdWUgd2FzIGNhdWdodCB3aGVuIHJ1bm5p bmcgYW4KKyAgICAgICAgQVNhbiBkZWJ1ZyBidWlsZCBvZiB0ZXN0YXBpLgorCisgICAgICAgICog dG9vbHMvRnVuY3Rpb25PdmVycmlkZXMuY3BwOgorICAgICAgICAoSlNDOjpwYXJzZUNsYXVzZSk6 CisKIDIwMTYtMDctMTUgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAog ICAgICAgICBBZGQgbmV3IGZ1bmN0aW9ucyB0byBBUk1Bc3NlbWJsZXIgYWZ0ZXIgcjIwMjIxNApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rvb2xzL0Z1bmN0aW9uT3ZlcnJpZGVzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMvRnVuY3Rpb25PdmVycmlk ZXMuY3BwCShyZXZpc2lvbiAyMDMyODQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdG9vbHMv RnVuY3Rpb25PdmVycmlkZXMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMDUsNyArMjA1LDggQEAg c3RhdGljIFN0cmluZyBwYXJzZUNsYXVzZShjb25zdCBjaGFyKiBrZQogICAgIHRlcm1pbmF0b3JT dHJpbmcuYXBwZW5kKCJ9Iik7CiAgICAgdGVybWluYXRvclN0cmluZy5hcHBlbmQoZGVsaW1pdGVy KTsKIAotICAgIGNvbnN0IGNoYXIqIHRlcm1pbmF0b3IgPSB0ZXJtaW5hdG9yU3RyaW5nLmFzY2lp KCkuZGF0YSgpOworICAgIENTdHJpbmcgdGVybWluYXRvckNTdHJpbmcgPSB0ZXJtaW5hdG9yU3Ry aW5nLmFzY2lpKCk7CisgICAgY29uc3QgY2hhciogdGVybWluYXRvciA9IHRlcm1pbmF0b3JDU3Ry aW5nLmRhdGEoKTsKICAgICBsaW5lID0gZGVsaW1pdGVyRW5kOyAvLyBTdGFydCBmcm9tIHRoZSB7 LgogCiAgICAgU3RyaW5nQnVpbGRlciBidWlsZGVyOwo=