159813 2016-07-15 07:35:22 -0700 [MSE] Increase the SourceBuffer "fudge factor" 2017-03-14 01:22:56 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue dino ivlev.igor webkit-bug-importer oldest_to_newest 1211409 0 eric.carlson 2016-07-15 07:35:22 -0700 Some media encoding/conversion pipelines are sloppy when doing sample time/timescale math, and the error accumulation results in small gaps in the media timeline. r202641 increased the maximum allowable gap from 0.01 second to one 24fps frame, but it turns out that at least one large provider has a significant amount of content encoded with up to two 24fps frames. 1211410 1 webkit-bug-importer 2016-07-15 07:36:04 -0700 <rdar://problem/27372033> 1211423 2 283763 eric.carlson 2016-07-15 08:49:12 -0700 Created attachment 283763 Proposed patch. 1211424 3 283763 jonlee 2016-07-15 09:12:38 -0700 Comment on attachment 283763 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=283763&action=review > LayoutTests/media/media-source/media-source-small-gap.html:41 > + makeASample(7, 7, 1, 1, SAMPLE_FLAG.NONE), The spacing is odd here. 1211425 4 283763 eric.carlson 2016-07-15 09:21:42 -0700 Comment on attachment 283763 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=283763&action=review >> LayoutTests/media/media-source/media-source-small-gap.html:41 >> + makeASample(7, 7, 1, 1, SAMPLE_FLAG.NONE), > > The spacing is odd here. I originally used one space after each comma, but found that it was difficult to see exactly what was different in each sample. 1211438 5 283763 commit-queue 2016-07-15 09:43:12 -0700 Comment on attachment 283763 Proposed patch. Clearing flags on attachment: 283763 Committed r203277: <http://trac.webkit.org/changeset/203277> 1211439 6 commit-queue 2016-07-15 09:43:16 -0700 All reviewed patches have been landed. Closing bug. 1285289 7 ivlev.igor 2017-03-09 05:44:46 -0800 I think we should have different allowable gaps for Audio and Video tracks, and they should be calculated based on the current frame duration. Otherwise AudioWithLargeGap test from http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2016.html fails. 1287553 8 ivlev.igor 2017-03-14 01:22:56 -0700 A note on my previous comment: the test failure is reportedly not reproducible with the latest (2017) MSE test cases http://yt-dash-mse-test.commondatastorage.googleapis.com/unit-tests/2017.html 283763 2016-07-15 08:49:12 -0700 2016-07-15 09:43:12 -0700 Proposed patch. maximum_gap_patch.txt text/plain 6074 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzIyNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA3LTE1ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNU0VdIEluY3JlYXNl IHRoZSBTb3VyY2VCdWZmZXIgImZ1ZGdlIGZhY3RvciIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTgxMworICAgICAgICA8cmRhcjovL3Byb2JsZW0v MjczNzIwMzM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBTb21lIG1lZGlhIGVuY29kaW5nL2NvbnZlcnNpb24gcGlwZWxpbmVzIGFyZSBz bG9wcHkgd2hlbiBkb2luZyBzYW1wbGUgdGltZS90aW1lc2NhbGUKKyAgICAgICAgbWF0aCwgYW5k IHRoZSBlcnJvciBhY2N1bXVsYXRpb24gcmVzdWx0cyBpbiBzbWFsbCBnYXBzIGluIHRoZSBtZWRp YSB0aW1lbGluZS4gcjIwMjY0MQorICAgICAgICBpbmNyZWFzZWQgdGhlIG1heGltdW0gYWxsb3dh YmxlIGdhcCBmcm9tIDAuMDEgc2Vjb25kIHRvIG9uZSAyNGZwcyBmcmFtZSwgYnV0IGl0IHR1cm5z CisgICAgICAgIG91dCB0aGF0IGF0IGxlYXN0IG9uZSBsYXJnZSBwcm92aWRlciBoYXMgYSBzaWdu aWZpY2FudCBhbW91bnQgb2YgY29udGVudCBlbmNvZGVkIHdpdGgKKyAgICAgICAgdXAgdG8gdHdv IDI0ZnBzIGZyYW1lcy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHVwZGF0ZWQgbWVkaWEvbWVk aWEtc291cmNlL21lZGlhLXNvdXJjZS1zbWFsbC1nYXAuaHRtbC4KKworICAgICAgICAqIE1vZHVs ZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmN1cnJl bnRUaW1lRnVkZ2VGYWN0b3IpOiBJbmNyZWFzZSBtYXhpbXVtIGdhcCB0byAyMDAyIC8gMjQwMDAg ZnJhbWVzLgorCiAyMDE2LTA3LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR0xpYl0gVXNlIGEgR1NvdXJjZSBpbnN0ZWFkIG9mIGEgdGhy ZWFkIHRvIHBvbGwgbWVtb3J5IHByZXNzdXJlIGV2ZW50RkQgaW4gbGludXggaW1wbGVtZW50YXRp b24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVy LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1Nv dXJjZUJ1ZmZlci5jcHAJKHJldmlzaW9uIDIwMzIyNCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjUsMTAg KzY1LDEwIEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIGNvbnN0IGRvdWJsZSBFeHBv bmVudGlhbE1vdmluZ0F2ZXJhZ2VDb2VmZmljaWVudCA9IDAuMTsKIAotLy8gQWxsb3cgaGFzQ3Vy cmVudFRpbWUoKSB0byBiZSBvZmYgYnkgYXMgbXVjaCBhcyB0aGUgbGVuZ3RoIG9mIGEgMjRmcHMg dmlkZW8gZnJhbWUKKy8vIEFsbG93IGhhc0N1cnJlbnRUaW1lKCkgdG8gYmUgb2ZmIGJ5IGFzIG11 Y2ggYXMgdGhlIGxlbmd0aCBvZiB0d28gMjRmcHMgdmlkZW8gZnJhbWVzCiBzdGF0aWMgY29uc3Qg TWVkaWFUaW1lJiBjdXJyZW50VGltZUZ1ZGdlRmFjdG9yKCkKIHsKLSAgICBzdGF0aWMgTmV2ZXJE ZXN0cm95ZWQ8TWVkaWFUaW1lPiBmdWRnZUZhY3RvcigxLCAyNCk7CisgICAgc3RhdGljIE5ldmVy RGVzdHJveWVkPE1lZGlhVGltZT4gZnVkZ2VGYWN0b3IoMjAwMiwgMjQwMDApOwogICAgIHJldHVy biBmdWRnZUZhY3RvcjsKIH0KIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzMjI0KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTYtMDct MTUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgW01T RV0gSW5jcmVhc2UgdGhlIFNvdXJjZUJ1ZmZlciAiZnVkZ2UgZmFjdG9yIgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5ODEzCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yNzM3MjAzMz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIG1lZGlhL21lZGlhLXNvdXJjZS9tZWRpYS1zb3VyY2Utc21hbGwtZ2Fw LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBtZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNl LXNtYWxsLWdhcC5odG1sOgorCiAyMDE2LTA3LTE0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFw cGxlLmNvbT4KIAogICAgICAgICBET00gdmFsdWUgaXRlcmFibGUgaW50ZXJmYWNlcyBzaG91bGQg dXNlIEFycmF5IHByb3RvdHlwZSBtZXRob2RzCkluZGV4OiBMYXlvdXRUZXN0cy9tZWRpYS9tZWRp YS1zb3VyY2UvbWVkaWEtc291cmNlLXNtYWxsLWdhcC1leHBlY3RlZC50eHQKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gTGF5b3V0VGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1zbWFsbC1nYXAt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMDMyMjQpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9tZWRp YS1zb3VyY2UvbWVkaWEtc291cmNlLXNtYWxsLWdhcC1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29w eSkKQEAgLTEsNCArMSw0IEBACi1UaGlzIHRlc3RzIHRoZSBTb3VyY2VCdWZmZXIuYnVmZmVyZWQo KSBBUEkuIFRoaXMgdGVzdCB3aWxsIGFkZCA4IHNhbXBsZXMgd2l0aCBhIHNtYWxsIGdhcCAoMC4w MXMpIGJldHdlZW4gZWFjaCBzYW1wbGUuIFRoZSBTb3VyY2VCdWZmZXIgc2hvdWxkIGNvYWxlc2Nl IHN1Y2ggc21hbGwgZ2FwcyB0byBtYWtlIGEgc2luZ2xlIGNvbnRpZ3VvdXMgcmFuZ2UuIFRoZSB2 aWRlbyBlbGVtZW50IHNob3VsZCBhbHNvIHBsYXkgY29udGludW91c2x5IGZyb20gdGhlIGJlZ2lu bmluZyB0byB0aGUgZW5kLgorVGhpcyB0ZXN0cyB0aGUgU291cmNlQnVmZmVyLmJ1ZmZlcmVkKCkg QVBJLiBUaGlzIHRlc3Qgd2lsbCBhZGQgOCBzYW1wbGVzIHdpdGggYSBzbWFsbCBnYXAgKDAuMDFz IC4uIDAuMDgzcykgYmV0d2VlbiBlYWNoIHNhbXBsZS4gVGhlIFNvdXJjZUJ1ZmZlciBzaG91bGQg Y29hbGVzY2Ugc3VjaCBzbWFsbCBnYXBzIHRvIG1ha2UgYSBzaW5nbGUgY29udGlndW91cyByYW5n ZS4gVGhlIHZpZGVvIGVsZW1lbnQgc2hvdWxkIGFsc28gcGxheSBjb250aW51b3VzbHkgZnJvbSB0 aGUgYmVnaW5uaW5nIHRvIHRoZSBlbmQuCiAKIFJVTih2aWRlby5zcmMgPSBVUkwuY3JlYXRlT2Jq ZWN0VVJMKHNvdXJjZSkpCiBFVkVOVChzb3VyY2VvcGVuKQpJbmRleDogTGF5b3V0VGVzdHMvbWVk aWEvbWVkaWEtc291cmNlL21lZGlhLXNvdXJjZS1zbWFsbC1nYXAuaHRtbAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvbWVkaWEtc291cmNlLXNtYWxsLWdhcC5o dG1sCShyZXZpc2lvbiAyMDMyMjQpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2Uv bWVkaWEtc291cmNlLXNtYWxsLWdhcC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yOCwxNiArMjgs MTkgQEAKICAgICB9CiAKICAgICBmdW5jdGlvbiBsb2FkU2FtcGxlcygpIHsKKyAgICAgICAgY29u c3QgbWF4aW11bUdhcCA9IE1hdGguZmxvb3IoMjAwMiAvIDI0MDAwICogMTAwMCkgLyAxMDAwOwor CiAgICAgICAgIHNhbXBsZXMgPSBjb25jYXRlbmF0ZVNhbXBsZXMoWwotICAgICAgICAgICAgbWFr ZUFTYW1wbGUoMCwgMCwgMC45OSwgMSwgU0FNUExFX0ZMQUcuU1lOQyksCi0gICAgICAgICAgICBt YWtlQVNhbXBsZSgxLCAxLCAwLjk5LCAxLCBTQU1QTEVfRkxBRy5OT05FKSwKLSAgICAgICAgICAg IG1ha2VBU2FtcGxlKDIsIDIsIDAuOTksIDEsIFNBTVBMRV9GTEFHLk5PTkUpLAotICAgICAgICAg ICAgbWFrZUFTYW1wbGUoMywgMywgMC45OSwgMSwgU0FNUExFX0ZMQUcuTk9ORSksCi0gICAgICAg ICAgICBtYWtlQVNhbXBsZSg0LCA0LCAwLjk5LCAxLCBTQU1QTEVfRkxBRy5TWU5DKSwKLSAgICAg ICAgICAgIG1ha2VBU2FtcGxlKDUsIDUsIDAuOTksIDEsIFNBTVBMRV9GTEFHLk5PTkUpLAotICAg ICAgICAgICAgbWFrZUFTYW1wbGUoNiwgNiwgMC45OSwgMSwgU0FNUExFX0ZMQUcuTk9ORSksCi0g ICAgICAgICAgICBtYWtlQVNhbXBsZSg3LCA3LCAxLCAxLCBTQU1QTEVfRkxBRy5OT05FKSwKKyAg ICAgICAgICAgIG1ha2VBU2FtcGxlKDAsIDAsIDEgLSBtYXhpbXVtR2FwLCAgICAgIDEsIFNBTVBM RV9GTEFHLlNZTkMpLAorICAgICAgICAgICAgbWFrZUFTYW1wbGUoMSwgMSwgMSAtIG1heGltdW1H YXAgLyAyLCAgMSwgU0FNUExFX0ZMQUcuTk9ORSksCisgICAgICAgICAgICBtYWtlQVNhbXBsZSgy LCAyLCAxIC0gbWF4aW11bUdhcCAvIDMsICAxLCBTQU1QTEVfRkxBRy5OT05FKSwKKyAgICAgICAg ICAgIG1ha2VBU2FtcGxlKDMsIDMsIDEsICAgICAgICAgICAgICAgICAgIDEsIFNBTVBMRV9GTEFH Lk5PTkUpLAorICAgICAgICAgICAgbWFrZUFTYW1wbGUoNCwgNCwgMSAtIG1heGltdW1HYXAsICAg ICAgMSwgU0FNUExFX0ZMQUcuU1lOQyksCisgICAgICAgICAgICBtYWtlQVNhbXBsZSg1LCA1LCAx IC0gbWF4aW11bUdhcCAvIDEwLCAxLCBTQU1QTEVfRkxBRy5OT05FKSwKKyAgICAgICAgICAgIG1h a2VBU2FtcGxlKDYsIDYsIDAuOTksICAgICAgICAgICAgICAgIDEsIFNBTVBMRV9GTEFHLk5PTkUp LAorICAgICAgICAgICAgbWFrZUFTYW1wbGUoNywgNywgMSwgICAgICAgICAgICAgICAgICAgMSwg U0FNUExFX0ZMQUcuTk9ORSksCiAgICAgICAgIF0pOworCiAgICAgICAgIHdhaXRGb3JFdmVudE9u KHNvdXJjZUJ1ZmZlciwgJ3VwZGF0ZWVuZCcsIGNoZWNrQnVmZmVyZWQsIGZhbHNlLCB0cnVlKTsK ICAgICAgICAgcnVuKCdzb3VyY2VCdWZmZXIuYXBwZW5kQnVmZmVyKHNhbXBsZXMpJyk7CiAgICAg fQpAQCAtNTksNyArNjIsNyBAQAogICAgIDwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHkgb25sb2Fk PSJydW5UZXN0KCkiPgotICAgIDxkaXY+VGhpcyB0ZXN0cyB0aGUgU291cmNlQnVmZmVyLmJ1ZmZl cmVkKCkgQVBJLiBUaGlzIHRlc3Qgd2lsbCBhZGQgOCBzYW1wbGVzIHdpdGggYSBzbWFsbCBnYXAg KDAuMDFzKSBiZXR3ZWVuIGVhY2ggc2FtcGxlLiBUaGUgU291cmNlQnVmZmVyIHNob3VsZCBjb2Fs ZXNjZSBzdWNoIHNtYWxsIGdhcHMgdG8gbWFrZSBhIHNpbmdsZSBjb250aWd1b3VzIHJhbmdlLiBU aGUgdmlkZW8gZWxlbWVudCBzaG91bGQgYWxzbyBwbGF5IGNvbnRpbnVvdXNseSBmcm9tIHRoZSBi ZWdpbm5pbmcgdG8gdGhlIGVuZC48L2Rpdj4KKyAgICA8ZGl2PlRoaXMgdGVzdHMgdGhlIFNvdXJj ZUJ1ZmZlci5idWZmZXJlZCgpIEFQSS4gVGhpcyB0ZXN0IHdpbGwgYWRkIDggc2FtcGxlcyB3aXRo IGEgc21hbGwgZ2FwICgwLjAxcyAuLiAwLjA4M3MpIGJldHdlZW4gZWFjaCBzYW1wbGUuIFRoZSBT b3VyY2VCdWZmZXIgc2hvdWxkIGNvYWxlc2NlIHN1Y2ggc21hbGwgZ2FwcyB0byBtYWtlIGEgc2lu Z2xlIGNvbnRpZ3VvdXMgcmFuZ2UuIFRoZSB2aWRlbyBlbGVtZW50IHNob3VsZCBhbHNvIHBsYXkg Y29udGludW91c2x5IGZyb20gdGhlIGJlZ2lubmluZyB0byB0aGUgZW5kLjwvZGl2PgogICAgIDx2 aWRlbz48L3ZpZGVvPgogPC9ib2R5PgogPC9odG1sPgo=