159811 2016-07-15 06:23:32 -0700 Fix expectedFailErrorHandler in run-jsc-stress-tests 2016-07-20 01:51:17 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159810 P2 Normal --- 1 ossy ossy benjamin commit-queue fpizlo keith_miller mark.lam msaboff ossy oldest_to_newest 1211398 0 ossy 2016-07-15 06:23:32 -0700 Tools/Scripts/run-jsc-stress-tests ----------------------------------- # Error handler for tests that fail exactly when they return zero exit status. def expectedFailErrorHandler Proc.new { | outp, plan | outp.puts "if test -e #{plan.failFile}" outp.puts "then" outp.puts " " + plan.successCommand outp.puts "else" outp.puts " (echo ERROR: Unexpected exit code: `cat #{plan.failFile}`) | " + redirectAndPrefixCommand(plan.name) outp.puts " " + plan.failCommand outp.puts "fi" } end When a test expected to have a non zero exit code, it uses expectedFailErrorHandler function. But its else case is buggy: plan.failFile doesn't exist in the else case, cat command fails now. (note: discovered during running test262 tests and preparing patch to bug159810) 1211400 1 283757 ossy 2016-07-15 06:24:26 -0700 Created attachment 283757 Patch 1211943 2 ossy 2016-07-18 04:03:31 -0700 ping? 1212673 3 ossy 2016-07-20 00:08:30 -0700 Ping? 1212675 4 283757 ysuzuki 2016-07-20 00:25:48 -0700 Comment on attachment 283757 Patch r=me 1212697 5 283757 commit-queue 2016-07-20 01:51:12 -0700 Comment on attachment 283757 Patch Clearing flags on attachment: 283757 Committed r203448: <http://trac.webkit.org/changeset/203448> 1212698 6 commit-queue 2016-07-20 01:51:17 -0700 All reviewed patches have been landed. Closing bug. 283757 2016-07-15 06:24:26 -0700 2016-07-20 01:51:12 -0700 Patch bug-159811-20160715152337.patch text/plain 1312 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMjcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE1NTkxNmJjNjM2OWJhNzRmMjA5OGEyOTUzYzI2MTI0 OWY3NGNjOS4uYTFhNjUzYWZhMmMzN2YwZjY0NjMwYThiYjU5ZWQyNzQ2MTkzZjExMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDE2LTA3LTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgRml4IGV4cGVjdGVkRmFpbEVycm9ySGFuZGxlciBpbiBydW4tanNjLXN0cmVzcy10 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5 ODExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzOgorCiAyMDE2LTA3LTE0ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWxsb3cgUmVmUHRycyBv ZiBjb25zdCBSZWZDb3VudGVkIHR5cGVzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1q c2Mtc3RyZXNzLXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVzcy10ZXN0cwppbmRl eCAwZDkyMmNiZGEwYmRiODk3ZmQ3YjBlNDE1NWRkYmMwYzQyOWMzNmU1Li41ZGNmN2M3N2UxZjNj Y2VmMDJhMjFkZDEzYTU1MjNlNTEzNDg1MjMxIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1 bi1qc2Mtc3RyZXNzLXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3MtdGVz dHMKQEAgLTUxNCw3ICs1MTQsNyBAQCBkZWYgZXhwZWN0ZWRGYWlsRXJyb3JIYW5kbGVyCiAgICAg ICAgIG91dHAucHV0cyAidGhlbiIKICAgICAgICAgb3V0cC5wdXRzICIgICAgIiArIHBsYW4uc3Vj Y2Vzc0NvbW1hbmQKICAgICAgICAgb3V0cC5wdXRzICJlbHNlIgotICAgICAgICBvdXRwLnB1dHMg IiAgICAoZWNobyBFUlJPUjogVW5leHBlY3RlZCBleGl0IGNvZGU6IGBjYXQgI3twbGFuLmZhaWxG aWxlfWApIHwgIiArIHJlZGlyZWN0QW5kUHJlZml4Q29tbWFuZChwbGFuLm5hbWUpCisgICAgICAg IG91dHAucHV0cyAiICAgIChlY2hvIEVSUk9SOiBVbmV4cGVjdGVkIGV4aXQgY29kZTogMCkgfCAi ICsgcmVkaXJlY3RBbmRQcmVmaXhDb21tYW5kKHBsYW4ubmFtZSkKICAgICAgICAgb3V0cC5wdXRz ICIgICAgIiArIHBsYW4uZmFpbENvbW1hbmQKICAgICAgICAgb3V0cC5wdXRzICJmaSIKICAgICB9 Cg==