159807 2016-07-15 04:08:47 -0700 js/stringimpl-to-jsstring-on-large-strings tests consume huge memory 2016-09-15 04:20:22 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P1 Critical --- 158793 1 ossy ossy ap benjamin fpizlo ggaren ossy ryanhaddad saam oldest_to_newest 1211382 0 ossy 2016-07-15 04:08:47 -0700 https://bugs.webkit.org/show_bug.cgi?id=158793#c6 (In reply to comment #4) > Comment on attachment 281956 [details] > Patch > > Clearing flags on attachment: 281956 > > Committed r202415: <http://trac.webkit.org/changeset/202415> These new tests consume huge memory, my PC with 8Gb memory started to swap and became unresponsible for long time when I exectuted run-javascriptcore-tests. :( It would be good not adding tests need 16-32-64Gb memory to be able to run. :( 1211730 1 ap 2016-07-15 20:45:09 -0700 > when I exectuted run-javascriptcore-tests. :( This should affect run-webkit-tests too, correct? 1211821 2 saam 2016-07-16 22:21:31 -0700 (In reply to comment #0) > https://bugs.webkit.org/show_bug.cgi?id=158793#c6 > > (In reply to comment #4) > > Comment on attachment 281956 [details] > > Patch > > > > Clearing flags on attachment: 281956 > > > > Committed r202415: <http://trac.webkit.org/changeset/202415> > > These new tests consume huge memory, my PC with 8Gb memory > started to swap and became unresponsible for long time > when I exectuted run-javascriptcore-tests. :( > > It would be good not adding tests need 16-32-64Gb memory to be able to run. > :( I agree. Ben, is there a way to write a similar test for the original bug without consuming as much memory? 1211959 3 ossy 2016-07-18 05:35:29 -0700 (In reply to comment #1) > > when I exectuted run-javascriptcore-tests. :( > > This should affect run-webkit-tests too, correct? It could, but the problem is bigger with run-javascriptcore-tests, because it runs each test with different configurations parallel, for example: Running jsc-layout-tests.yaml/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js.layout Running jsc-layout-tests.yaml/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js.layout-no-llint Running jsc-layout-tests.yaml/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js.layout-no-cjit Running jsc-layout-tests.yaml/js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js.layout-dfg-eager-no-cjit It means that 4 copy of the same memory consuming test can run in the same time. 1212520 4 benjamin 2016-07-19 14:10:26 -0700 The problem is this bug only crashed JSC when dealing with strings larger than 2gb. We need bugs like this to be covered but we can't have these tests break other tests. Ossy, is there any way to make some tests sequential instead of running in parallel with everything else? Any other idea to solve this? 1212729 5 ossy 2016-07-20 07:44:38 -0700 (In reply to comment #4) > The problem is this bug only crashed JSC when dealing with strings larger > than 2gb. > > We need bugs like this to be covered but we can't have these tests break > other tests. > > Ossy, is there any way to make some tests sequential instead of running in > parallel with everything else? Any other idea to solve this? run-jsc-stress-tests uses GNU make (-jXXX) to run tests parallel, there is no way to prevent running them parallel without giant hacks in prepareMakeTestRunner: https://trac.webkit.org/browser/trunk/Tools/Scripts/run-jsc-stress-tests#L1697 Do we really need to run these test in all configurations? - default - no-llint - no-cjit - dfg-eager-no-cjit I suggest skipping them until we find a better fix. 1229522 6 288803 ossy 2016-09-14 04:01:37 -0700 Created attachment 288803 Patch 1229824 7 288803 saam 2016-09-14 16:52:40 -0700 Comment on attachment 288803 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=288803&action=review r=me > Tools/Scripts/run-javascriptcore-tests:137 > + Skip tests tagged with //\@large-heap @largeHeap not @large-heap 1229979 8 ossy 2016-09-15 04:15:43 -0700 (In reply to comment #7) > Comment on attachment 288803 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=288803&action=review > > r=me > > > Tools/Scripts/run-javascriptcore-tests:137 > > + Skip tests tagged with //\@large-heap > > @largeHeap not @large-heap Good catch, I copied this typo from run-jsc-stress-tests script. I'll fix there too before landing. 1229980 9 ossy 2016-09-15 04:20:22 -0700 Committed r205967: <http://trac.webkit.org/changeset/205967> 288803 2016-09-14 04:01:37 -0700 2016-09-14 16:52:40 -0700 Patch bug-159807-20160914125900.patch text/plain 5999 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA1OTAxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTUxZGM3NGE0M2RlYjQzMGQxZGZiYjBkZjhiMDlkMDY0 ZmExZDRlMi4uZDhlZmJmMzczYzNiNzg5N2ZkZTA5OWViMjZjNTY1MzE2ZjI0MjI0YiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE2LTA5LTE0ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAganMvc3RyaW5naW1wbC10by1qc3N0cmluZy1vbi1sYXJnZS1zdHJpbmdzIHRlc3Rz IGNvbnN1bWUgaHVnZSBtZW1vcnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTgwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv bWFzdGVyLmNmZzoKKyAgICAgICAgKFJ1blJlbW90ZUphdmFTY3JpcHRDb3JlVGVzdHMuc3RhcnQp OiBKU0NPbmx5IGJvdHMgYXJlIG1lbW9yeSBsaW1pdGVkIGRldmljZXMsIHRlc3RzIHNob3VsZCBy dW4gd2l0aCAtLW1lbW9yeS1saW1pdGVkIG9wdGlvbi4KKyAgICAgICAgKiBTY3JpcHRzL3J1bi1q YXZhc2NyaXB0Y29yZS10ZXN0czoKKyAgICAgICAgKHJ1bkpTQ1N0cmVzc1Rlc3RzKTogUGFzcyB0 aHJvdWdoIC0tbWVtb3J5LWxpbWl0ZWQgb3B0aW9uIHRvIHJ1bi1qc2Mtc3RyZXNzLXRlc3RzLgor CiAyMDE2LTA5LTEzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAg ICAgIExhbmRpbmcgb3B0aW1pemVkIC5wbmcgZmlsZXMsIGZvcmdvdCB0byBkbyBpdCBpbml0aWFs bHkuCmRpZmYgLS1naXQgYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9tYXN0ZXIuY2ZnIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0 Lm9yZy1jb25maWcvbWFzdGVyLmNmZwppbmRleCA5NGRhN2UyOWNjNjkxODE5NWRkYjdmOWI5OTk4 MWJiY2Q3YmEzYzNiLi4zYjc1ZjAzYTUyOTgzODkyNjkzY2FiZjg1NjY2NjAzNzIxZWQzMTgwIDEw MDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9tYXN0ZXIuY2ZnCisrKyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL21hc3Rlci5jZmcKQEAgLTMyNSw3ICszMjUsNyBAQCBjbGFzcyBSdW5KYXZhU2Ny aXB0Q29yZVRlc3RzKFRlc3RXaXRoRmFpbHVyZUNvdW50KToKIAogY2xhc3MgUnVuUmVtb3RlSmF2 YVNjcmlwdENvcmVUZXN0cyhSdW5KYXZhU2NyaXB0Q29yZVRlc3RzKToKICAgICBkZWYgc3RhcnQo c2VsZik6Ci0gICAgICAgIHNlbGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQgKyBbIi0tcmVtb3Rl LWNvbmZpZy1maWxlIiwgIi4uLy4uL3JlbW90ZS1qc2MtdGVzdHMtY29uZmlnLmpzb24iXSkKKyAg ICAgICAgc2VsZi5zZXRDb21tYW5kKHNlbGYuY29tbWFuZCArIFsiLS1tZW1vcnktbGltaXRlZCIs ICItLXJlbW90ZS1jb25maWctZmlsZSIsICIuLi8uLi9yZW1vdGUtanNjLXRlc3RzLWNvbmZpZy5q c29uIl0pCiAgICAgICAgIHJldHVybiBSdW5KYXZhU2NyaXB0Q29yZVRlc3RzLnN0YXJ0KHNlbGYp CiAKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tamF2YXNjcmlwdGNvcmUtdGVzdHMg Yi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwppbmRleCA1NTUxOWUwMGI3 YTVmMTRmNmE0M2RmN2UzZDMzZTVmNDUwOWM5OWNmLi42Nzk3ZTVmNzQzNGVmMjJjODliMGJiZWFj NTM1ZmMzMjMwOWVjMDllIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0 Y29yZS10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qYXZhc2NyaXB0Y29yZS10ZXN0cwpA QCAtNTIsNiArNTIsNyBAQCBteSAkanNEcml2ZXJBcmdzOwogbXkgJGNoaWxkUHJvY2Vzc2VzOwog bXkgJHNoZWxsUnVubmVyOwogbXkgJG1ha2VSdW5uZXI7CitteSAkbWVtb3J5TGltaXRlZDsKIAog bXkgJGJ1aWxkSlNDID0gMTsKIApAQCAtMTMxLDYgKzEzMiwxMCBAQCBVc2FnZTogJHByb2dyYW1O YW1lIFtvcHRpb25zXSBbb3B0aW9ucyB0byBwYXNzIHRvIGJ1aWxkIHN5c3RlbV0KICAgLS1zaGVs bC1ydW5uZXIgICAgICAgICAgICAgICAgVXNlcyB0aGUgc2hlbGwtYmFzZWQgdGVzdCBydW5uZXIg aW5zdGVhZCBvZiB0aGUgZGVmYXVsdCBtYWtlLWJhc2VkIHJ1bm5lci4KICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgSW4gZ2VuZXJhbCB0aGUgc2hlbGwgcnVubmVyIGlzIHNsb3dlciB0 aGFuIHRoZSBtYWtlIHJ1bm5lci4KICAgLS1tYWtlLXJ1bm5lciAgICAgICAgICAgICAgICAgVXNl cyB0aGUgZmFzdGVyIG1ha2UtYmFzZWQgcnVubmVyLgorCisgIC0tbWVtb3J5LWxpbWl0ZWQgICAg ICAgICAgICAgIEluZGljYXRlIHRoYXQgd2UgYXJlIHRhcmdldGluZyB0aGUgdGVzdCBmb3IgYSBt ZW1vcnkgbGltaXRlZCBkZXZpY2UuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNr aXAgdGVzdHMgdGFnZ2VkIHdpdGggLy9cQGxhcmdlLWhlYXAKKwogICAtLWZpbHRlciAgICAgICAg ICAgICAgICAgICAgICBPbmx5IHJ1biB0ZXN0cyB3aG9zZSBuYW1lIG1hdGNoZXMgdGhlIGdpdmVu IHJlZ3VsYXIgZXhwcmVzc2lvbi4KICAgLS1lbnYtdmFycyAgICAgICAgICAgICAgICAgICAgUGFz cyBhIGxpc3Qgb2YgZW52aXJvbm1lbnQgdmFyaWFibGVzIHRvIHNldCBiZWZvcmUgcnVubmluZyB0 ZXN0cy4KICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgRWFjaCBlbnZpcm9ubWVudCB2 YXJpYWJsZSBzaG91bGQgYmUgc2VwYXJhdGVkIGJ5IGEgc3BhY2UuCkBAIC0xNjAsNiArMTY1LDcg QEAgR2V0T3B0aW9ucygKICAgICAnY2hpbGQtcHJvY2Vzc2VzPXMnID0+IFwkY2hpbGRQcm9jZXNz ZXMsCiAgICAgJ3NoZWxsLXJ1bm5lcicgPT4gXCRzaGVsbFJ1bm5lciwKICAgICAnbWFrZS1ydW5u ZXInID0+IFwkbWFrZVJ1bm5lciwKKyAgICAnbWVtb3J5LWxpbWl0ZWQnID0+IFwkbWVtb3J5TGlt aXRlZCwKICAgICAnZmlsdGVyPXMnID0+IFwkZmlsdGVyLAogICAgICdoZWxwJyA9PiBcJHNob3dI ZWxwLAogICAgICdlbnYtdmFycz1zJyA9PiBcJGVudlZhcnMsCkBAIC0zMzgsNiArMzQ0LDEwIEBA IHN1YiBydW5KU0NTdHJlc3NUZXN0cwogICAgICAgICBwdXNoKEBqc2NTdHJlc3NEcml2ZXJDbWQs ICItLW1ha2UtcnVubmVyIik7CiAgICAgfQogCisgICAgaWYgKCRtZW1vcnlMaW1pdGVkKSB7Cisg ICAgICAgIHB1c2goQGpzY1N0cmVzc0RyaXZlckNtZCwgIi0tbWVtb3J5LWxpbWl0ZWQiKTsKKyAg ICB9CisKICAgICBpZiAoJGZpbHRlcikgewogICAgICAgICBwdXNoKEBqc2NTdHJlc3NEcml2ZXJD bWQsICItLWZpbHRlciIpOwogICAgICAgICBwdXNoKEBqc2NTdHJlc3NEcml2ZXJDbWQsICRmaWx0 ZXIpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IDhjZTc2ZGY2ODc5MDY4MzU0NGU5NThiMGUwZmY2NzlkMjUwZTZiZjQuLjgw NTNmZjA4NjUzY2NlYjUyMzQ0ZWM3ODAzMDllMjhlZDM4ZmU3YjYgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NCBAQAorMjAxNi0wOS0xNCAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgor CisgICAgICAgIGpzL3N0cmluZ2ltcGwtdG8tanNzdHJpbmctb24tbGFyZ2Utc3RyaW5ncyB0ZXN0 cyBjb25zdW1lIGh1Z2UgbWVtb3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNTk4MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9u LWxhcmdlLXN0cmluZ3MtMS5qczogU2tpcHBlZCBvbiBtZW1vcnkgbGltaXRlZCBkZXZpY2VzLgor ICAgICAgICAqIGpzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9uLWxhcmdl LXN0cmluZ3MtMi5qczogU2tpcHBlZCBvbiBtZW1vcnkgbGltaXRlZCBkZXZpY2VzLgorICAgICAg ICAqIGpzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9uLWxhcmdlLXN0cmlu Z3MtMy5qczogU2tpcHBlZCBvbiBtZW1vcnkgbGltaXRlZCBkZXZpY2VzLgorCiAyMDE2LTA5LTEz ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIE1hcmtpbmcg aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9YTUxIdHRwUmVxdWVzdC9yZXNwb25zZS1t ZXRob2QuaHRtIGFzIGZhaWxpbmcgb24gaW9zLXNpbXVsYXRvci4KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9uLWxhcmdlLXN0 cmluZ3MtMS5qcyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpz c3RyaW5nLW9uLWxhcmdlLXN0cmluZ3MtMS5qcwppbmRleCA3ZTlmODQwNmU3ZTU1ZDFmZTZkNjJm MjkyZDVhOGRhN2QyNzk3MTY2Li4zYjY5MjdlYTRmZWI0MjFkNGNhNDUwODRlNzYwODM5MzY3ODFj MTZlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvc3RyaW5naW1wbC10 by1qc3N0cmluZy1vbi1sYXJnZS1zdHJpbmdzLTEuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2Ny aXB0LXRlc3RzL3N0cmluZ2ltcGwtdG8tanNzdHJpbmctb24tbGFyZ2Utc3RyaW5ncy0xLmpzCkBA IC0xLDMgKzEsNSBAQAorLy9AbGFyZ2VIZWFwCisKICJ1c2Ugc3RyaWN0IgogCiAvLyBCYXNlZCBv biBBbmRyw6kgQmFyZ3VsbCdzIHRlc3QgY2FzZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pz L3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9uLWxhcmdlLXN0cmluZ3MtMi5q cyBiL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9u LWxhcmdlLXN0cmluZ3MtMi5qcwppbmRleCAwZDJhNmY2ZTljNTQ1YjVkNGI0NjhhMWM0NDRhNGMw MTJjYjA1NTE1Li4wYmUyNzYxYmU2ZDZlNGE4NTA4YmQzYWIxNWYwMTE1ZjEzNzY1YzU3IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvc3RyaW5naW1wbC10by1qc3N0cmlu Zy1vbi1sYXJnZS1zdHJpbmdzLTIuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3Rz L3N0cmluZ2ltcGwtdG8tanNzdHJpbmctb24tbGFyZ2Utc3RyaW5ncy0yLmpzCkBAIC0xLDMgKzEs NSBAQAorLy9AbGFyZ2VIZWFwCisKICJ1c2Ugc3RyaWN0IgogCiAvLyBCYXNlZCBvbiBBbmRyw6kg QmFyZ3VsbCdzIHRlc3QgY2FzZS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10 ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9uLWxhcmdlLXN0cmluZ3MtMy5qcyBiL0xheW91 dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9zdHJpbmdpbXBsLXRvLWpzc3RyaW5nLW9uLWxhcmdlLXN0 cmluZ3MtMy5qcwppbmRleCBkNTU1NWE3MmZhNGYyMzlhZTdlOWIyMGZjNTVhNjA1ZDFmZGI3Mjhm Li5hNTlhOGNkMDllOGNmMWNlZjFmMWZjYjcyMDQ0NGE5MDM3NzE1YThiIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvc3RyaW5naW1wbC10by1qc3N0cmluZy1vbi1sYXJn ZS1zdHJpbmdzLTMuanMKKysrIGIvTGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3N0cmluZ2lt cGwtdG8tanNzdHJpbmctb24tbGFyZ2Utc3RyaW5ncy0zLmpzCkBAIC0xLDMgKzEsNSBAQAorLy9A bGFyZ2VIZWFwCisKICJ1c2Ugc3RyaWN0IgogCiAvLyBUaGlzIHRlc3QgcGFzc2VzIGlmIGl0IGRv ZXMgbm90IGNyYXNoLgo=