159806 2016-07-15 03:52:15 -0700 REGRESSION(r202855): [GTK] ASSERTION FAILED: m_webPage.bounds().contains(bounds) 2016-07-17 23:54:54 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, Regression P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply zan oldest_to_newest 1211379 0 cgarcia 2016-07-15 03:52:15 -0700 This is happening in GTK+ debug bot after r202855. The problem is that since r202855, in case of non accelerated mode, the dirty region is updated too late when updating backing store state. STDERR: ASSERTION FAILED: m_webPage.bounds().contains(bounds) STDERR: ../../Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp(422) : void WebKit::DrawingAreaImpl::display(WebKit::UpdateInfo&) STDERR: 1 0x7f5ab989bacf /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x1e) [0x7f5ab989bacf] STDERR: 2 0x7f5ac02395b2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::DrawingAreaImpl::display(WebKit::UpdateInfo&)+0x210) [0x7f5ac02395b2] STDERR: 3 0x7f5ac0238a2c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::DrawingAreaImpl::sendDidUpdateBackingStoreState()+0xe4) [0x7f5ac0238a2c] STDERR: 4 0x7f5ac023620b /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::AcceleratedDrawingArea::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)+0x22f) [0x7f5ac023620b] STDERR: 5 0x7f5ac0238885 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::DrawingAreaImpl::updateBackingStoreState(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)+0xb1) [0x7f5ac0238885] STDERR: 6 0x7f5ac02e5800 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::callMemberFunctionImpl<WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>, 0ul, 1ul, 2ul, 3ul, 4ul>(WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>&&, std::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul>)+0xf8) [0x7f5ac02e5800] STDERR: 7 0x7f5ac02e5374 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::callMemberFunction<WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&), std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>, std::integer_sequence<unsigned long, 0ul, 1ul, 2ul, 3ul, 4ul> >(std::tuple<unsigned long, bool, float, WebCore::IntSize, WebCore::IntSize>&&, WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&))+0x41) [0x7f5ac02e5374] STDERR: 8 0x7f5ac02e511b /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(void IPC::handleMessage<Messages::DrawingArea::UpdateBackingStoreState, WebKit::DrawingArea, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&)>(IPC::MessageDecoder&, WebKit::DrawingArea*, void (WebKit::DrawingArea::*)(unsigned long, bool, float, WebCore::IntSize const&, WebCore::IntSize const&))+0x9b) [0x7f5ac02e511b] STDERR: 9 0x7f5ac02e4d49 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::DrawingArea::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)+0x9d) [0x7f5ac02e4d49] STDERR: 10 0x7f5abfca7419 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::MessageDecoder&)+0x125) [0x7f5abfca7419] STDERR: 11 0x7f5abff1b922 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::MessageDecoder&)+0x4c) [0x7f5abff1b922] STDERR: 12 0x7f5abfc91760 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(IPC::MessageDecoder&)+0x3a) [0x7f5abfc91760] STDERR: 13 0x7f5abfc918c3 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchMessage(std::unique_ptr<IPC::MessageDecoder, std::default_delete<IPC::MessageDecoder> >)+0x161) [0x7f5abfc918c3] STDERR: 14 0x7f5abfc91aaa /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(IPC::Connection::dispatchOneMessage()+0xc8) [0x7f5abfc91aaa] STDERR: 15 0x7f5abfc91604 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x5162604) [0x7f5abfc91604] STDERR: 16 0x7f5abfc9669e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0x516769e) [0x7f5abfc9669e] STDERR: 17 0x7f5abfc6119d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WTF::Function<void ()>::operator()() const+0x37) [0x7f5abfc6119d] STDERR: 18 0x7f5ab98b6df2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTF::RunLoop::performWork()+0xce) [0x7f5ab98b6df2] STDERR: 19 0x7f5ab98f9c18 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2245c18) [0x7f5ab98f9c18] STDERR: 20 0x7f5ab98f9c3d /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2245c3d) [0x7f5ab98f9c3d] STDERR: 21 0x7f5ab98f9bb8 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2245bb8) [0x7f5ab98f9bb8] STDERR: 22 0x7f5ab98f9be7 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x2245be7) [0x7f5ab98f9be7] STDERR: 23 0x7f5ab5399a26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x53a26) [0x7f5ab5399a26] STDERR: 24 0x7f5ab539a854 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_context_dispatch+0x33) [0x7f5ab539a854] STDERR: 25 0x7f5ab539aa39 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x54a39) [0x7f5ab539aa39] STDERR: 26 0x7f5ab539ae60 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_loop_run+0x1d7) [0x7f5ab539ae60] STDERR: 27 0x7f5ab98fa1b8 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTF::RunLoop::run()+0xac) [0x7f5ab98fa1b8] STDERR: 28 0x7f5ac024375c /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(int WebKit::ChildProcessMain<WebKit::WebProcess, WebKit::WebProcessMain>(int, char**)+0x82) [0x7f5ac024375c] STDERR: 29 0x7f5ac02435c8 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(WebProcessMainUnix+0x20) [0x7f5ac02435c8] STDERR: 30 0x400cfa /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/Debug/bin/WebKitWebProcess(main+0x34) [0x400cfa] STDERR: 31 0x7f5ab2200b45 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5) [0x7f5ab2200b45] STDERR: LEAK: 1 WebProcessPool STDERR: LEAK: 1 WebPageProxy 1211380 1 283752 cgarcia 2016-07-15 03:59:17 -0700 Created attachment 283752 Patch 1211911 2 cgarcia 2016-07-17 23:54:54 -0700 Committed r203341: <http://trac.webkit.org/changeset/203341> 283752 2016-07-15 03:59:17 -0700 2016-07-17 23:52:06 -0700 Patch wk2-dirty-region.diff text/plain 3075 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkOGRkZGUxLi4xYzBhZGEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTYtMDctMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjIwMjg1NSk6IFtHVEtdIEFTU0VSVElPTiBGQUlMRUQ6 IG1fd2ViUGFnZS5ib3VuZHMoKS5jb250YWlucyhib3VuZHMpCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk4MDYKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgcHJvYmxlbSBpcyB0aGF0IHNpbmNlIHIy MDI4NTUsIGluIGNhc2Ugb2Ygbm9uIGFjY2VsZXJhdGVkIG1vZGUsIHRoZSBkaXJ0eSByZWdpb24g aXMgdXBkYXRlZCB0b28gbGF0ZSB3aGVuCisgICAgICAgIHVwZGF0aW5nIGJhY2tpbmcgc3RvcmUg c3RhdGUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNw cDoKKyAgICAgICAgKFdlYktpdDo6RHJhd2luZ0FyZWFJbXBsOjp1cGRhdGVCYWNraW5nU3RvcmVT dGF0ZSk6IFVwZGF0ZSB0aGUgZGlydHkgcmVnaW9uIHRvIHRoZSBuZXcgc2l6ZSB3aGVuIG5vdCBp bgorICAgICAgICBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBtb2RlLgorICAgICAgICAqIFdlYlBy b2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6c2V0 U2l6ZSk6IFVwZGF0ZSB0aGUgV2ViUGFnZSBzaXplIGJlZm9yZSByZXNpemluZyB0aGUgZnJhbWUg YW5kIGNhbGxpbmcgc2V0TmVlZHNEaXNwbGF5KCkgdG8KKyAgICAgICAgZW5zdXJlIHRoYXQgYW55 IGNhbGwgdG8gc2V0TmVlZHNEaXNwbGF5KCkgdXNlcyB0aGUgbmV3IHdlYiBwYWdlIGJvdW5kcy4g VGhpcyBpcyBhY3R1YWxseSBhIHJlZ3Jlc3Npb24gaW50cm9kdWNlZAorICAgICAgICBpbiByMTQz NDcyLCB3aGVyZSBzZXROZWVkc0Rpc3BsYXkgd2FzIGNoYW5nZWQgdG8gdXNlIHRoZSB3ZWIgcGFn ZSBib3VuZHMgYXMgZGlyZWN0eSByZWN0YW5nbGUuIEJlZm9yZSByMTQzNDcyCisgICAgICAgIHRo ZSBkaXJ0eSByZWN0YW5nbGUgd2FzIHBhc3NlZCB0byBzZXROZWVkc0Rpc3BsYXkgYW5kIGl0IHBh c3NlZCB0aGUgcmlnaHQgb25lLgorCiAyMDE2LTA3LTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtUaHJlYWRlZCBDb21wb3NpdG9y XSBXZWIgdmlldyBiYWNrZ3JvdW5kIGNvbG9ycyBkb24ndCB3b3JrCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvRHJhd2luZ0FyZWFJbXBsLmNwcCBiL1NvdXJj ZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwCmluZGV4IGM2 OGEzZTkuLjU0YjRlYWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9EcmF3aW5nQXJlYUltcGwuY3BwCkBAIC0yMTIsMTAgKzIxMiwxMCBAQCB2b2lkIERy YXdpbmdBcmVhSW1wbDo6c2V0Um9vdENvbXBvc2l0aW5nTGF5ZXIoR3JhcGhpY3NMYXllciogZ3Jh cGhpY3NMYXllcikKIAogdm9pZCBEcmF3aW5nQXJlYUltcGw6OnVwZGF0ZUJhY2tpbmdTdG9yZVN0 YXRlKHVpbnQ2NF90IHN0YXRlSUQsIGJvb2wgcmVzcG9uZEltbWVkaWF0ZWx5LCBmbG9hdCBkZXZp Y2VTY2FsZUZhY3RvciwgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgc2l6ZSwgY29uc3QgV2ViQ29y ZTo6SW50U2l6ZSYgc2Nyb2xsT2Zmc2V0KQogewotICAgIGJvb2wgc2hvdWxkVXBkYXRlRGlydHlS ZWdpb24gPSBzdGF0ZUlEICE9IG1fYmFja2luZ1N0b3JlU3RhdGVJRCAmJiAhbV9sYXllclRyZWVI b3N0OworICAgIGlmIChzdGF0ZUlEICE9IG1fYmFja2luZ1N0b3JlU3RhdGVJRCAmJiAhbV9sYXll clRyZWVIb3N0KQorICAgICAgICBtX2RpcnR5UmVnaW9uID0gSW50UmVjdChJbnRQb2ludCgpLCBz aXplKTsKKwogICAgIEFjY2VsZXJhdGVkRHJhd2luZ0FyZWE6OnVwZGF0ZUJhY2tpbmdTdG9yZVN0 YXRlKHN0YXRlSUQsIHJlc3BvbmRJbW1lZGlhdGVseSwgZGV2aWNlU2NhbGVGYWN0b3IsIHNpemUs IHNjcm9sbE9mZnNldCk7Ci0gICAgaWYgKHNob3VsZFVwZGF0ZURpcnR5UmVnaW9uKQotICAgICAg ICBtX2RpcnR5UmVnaW9uID0gbV93ZWJQYWdlLmJvdW5kcygpOwogCiAgICAgaWYgKG1fZm9yY2VS ZXBhaW50QWZ0ZXJCYWNraW5nU3RvcmVTdGF0ZVVwZGF0ZSkKICAgICAgICAgZm9yY2VSZXBhaW50 KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5k ZXggZDFmYjc2ZC4uMDE2N2M0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9XZWJQYWdlL1dlYlBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJQYWdlLmNwcApAQCAtMTM0OSwxMSArMTM0OSwxMCBAQCB2b2lkIFdlYlBhZ2U6OnNl dFNpemUoY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgdmlld1NpemUpCiAgICAgaWYgKG1fdmlld1Np emUgPT0gdmlld1NpemUpCiAgICAgICAgIHJldHVybjsKIAorICAgIG1fdmlld1NpemUgPSB2aWV3 U2l6ZTsKICAgICBGcmFtZVZpZXcqIHZpZXcgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLnZpZXcoKTsK ICAgICB2aWV3LT5yZXNpemUodmlld1NpemUpOwogICAgIG1fZHJhd2luZ0FyZWEtPnNldE5lZWRz RGlzcGxheSgpOwotICAgIAotICAgIG1fdmlld1NpemUgPSB2aWV3U2l6ZTsKIAogI2lmIFVTRShD T09SRElOQVRFRF9HUkFQSElDUykKICAgICBpZiAodmlldy0+dXNlRml4ZWRMYXlvdXQoKSkK