159770 2016-07-14 09:11:15 -0700 Fix the --minimal build fail in InjectedBundle.cpp 2016-07-18 23:51:01 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy achristensen commit-queue darin ossy rniwa oldest_to_newest 1211009 0 ossy 2016-07-14 09:11:15 -0700 build-webkit --minimal fails with the following error message: ../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:197:9: error: 'RuntimeEnabledFeatures' has not been declared ../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:200:9: error: 'RuntimeEnabledFeatures' has not been declared The problem is that RuntimeEnabledFeatures.h is included inside if guards, but used unconditionally in these lines. I can't see any good reason to include any header unconditionally, let's remove these guards to fix the build. 1211010 1 283651 ossy 2016-07-14 09:14:36 -0700 Created attachment 283651 Patch 1211402 2 ossy 2016-07-15 06:37:25 -0700 note: revealed by http://trac.webkit.org/changeset/202091 : -#if ENABLE(SHADOW_DOM) if (preference == "WebKitShadowDOMEnabled") RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled); -#endif Now shadow DOM is used unconditionally and we need to include RuntimeEnabledFeatures.h always. 1212283 3 283651 commit-queue 2016-07-18 23:50:57 -0700 Comment on attachment 283651 Patch Clearing flags on attachment: 283651 Committed r203398: <http://trac.webkit.org/changeset/203398> 1212284 4 commit-queue 2016-07-18 23:51:01 -0700 All reviewed patches have been landed. Closing bug. 283651 2016-07-14 09:14:36 -0700 2016-07-18 23:50:57 -0700 Patch bug-159770-20160714181349.patch text/plain 1589 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTY2Y2RlMWQ2MzljZmQx NzcxZWNhYjg2MGM5M2NhYjBjODJiZTk0YS4uZWI0NjU4ZGM5ZTMwZjBlMGJhZTQzZDExZjI0YTlk MTk3NzljN2UxZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA3LTE0ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSAtLW1p bmltYWwgYnVpbGQgZmFpbCBpbiBJbmplY3RlZEJ1bmRsZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTc3MAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRs ZS9JbmplY3RlZEJ1bmRsZS5jcHA6CisKIDIwMTYtMDctMTQgIEh5dW5qdW4gS28gIDx6em9vbkBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtUaHJlYWRlZENvbXBvc2l0b3JdIEJ1aWxkIGZhaWxzIGlu IGRlYnVnIG1vZGUgYWZ0ZXIgcjIwMjA0MApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAppbmRleCA2ZjNh N2NhNzhjZmQ3YjVhMTZmNTk1YTE3MzExYmE5MWMzMzQ1NTcwLi45MzU3NWY0NGMyZGNiZGVkZmJm NjU3MGE1MTEzNGM0OGE2MjI4YzMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlLmNwcApAQCAtNjYsNiAr NjYsNyBAQAogI2luY2x1ZGUgPFdlYkNvcmUvUGFnZUdyb3VwLmg+CiAjaW5jbHVkZSA8V2ViQ29y ZS9QcmludENvbnRleHQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Jlc291cmNlSGFuZGxlLmg+Cisj aW5jbHVkZSA8V2ViQ29yZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmg+CiAjaW5jbHVkZSA8V2Vi Q29yZS9TY3JpcHRDb250cm9sbGVyLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9TZWN1cml0eU9yaWdp bi5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2VjdXJpdHlQb2xpY3kuaD4KQEAgLTc1LDkgKzc2LDYg QEAKICNpbmNsdWRlIDxXZWJDb3JlL1VzZXJTY3JpcHQuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1Vz ZXJTdHlsZVNoZWV0Lmg+CiAKLSNpZiBFTkFCTEUoQ1NTX1JFR0lPTlMpIHx8IEVOQUJMRShDU1Nf Q09NUE9TSVRJTkcpCi0jaW5jbHVkZSA8V2ViQ29yZS9SdW50aW1lRW5hYmxlZEZlYXR1cmVzLmg+ Ci0jZW5kaWYKIAogI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKSB8fCBFTkFCTEUoTEVHQUNZX05P VElGSUNBVElPTlMpCiAjaW5jbHVkZSAiV2ViTm90aWZpY2F0aW9uTWFuYWdlci5oIgo=