15977 2007-11-13 22:09:34 -0800 match firefox's preference for resizing images 2010-06-10 15:50:07 -0700 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Mac OS X 10.4 UNCONFIRMED P2 Normal --- 0 solushex webkit-unassigned andersca mrowe webkit oldest_to_newest 61168 0 solushex 2007-11-13 22:09:34 -0800 WebKitShrinksStandaloneImagesToFitKey (from bug 5400) is an all or none preference; setting it to 0 removes resizing altogether. i suggest matching firefox's behavior, where the pref. controls whether the image is resized by default, but the option to resize via left-click is always present. 61169 1 17257 solushex 2007-11-13 22:13:10 -0800 Created attachment 17257 patch v1 simple patch. 61184 2 mrowe 2007-11-13 23:23:13 -0800 Can you please fill in the ChangeLog rather than leaving it empty. Name, email address and a description of the change is required. 61191 3 17264 solushex 2007-11-14 00:50:32 -0800 Created attachment 17264 patch v1 w/better changelog 61665 4 mrowe 2007-11-19 05:44:14 -0800 Landed in r27903. 61720 5 solushex 2007-11-19 16:08:21 -0800 i can't verify this. safari 3.0.4 calls setShrinksStandaloneImagesToFit: which sets WebKitShrinksStandaloneImagesToFitKey to 1 on launch regardless of its previous value. i don't understand this. is setShrinksStandaloneImagesToFit: getting called with no parameter? 74448 6 solushex 2008-03-19 10:08:29 -0700 r28200 undid this patch. http://trac.webkit.org/projects/webkit/changeset/28200 if this was intentional, then "fixed" is the wrong resolution. 74827 7 17264 mrowe 2008-03-22 15:22:29 -0700 Comment on attachment 17264 patch v1 w/better changelog Clearing review flag since the patch was landed. 74828 8 mrowe 2008-03-22 15:23:38 -0700 Anders, can you comment on why <http://trac.webkit.org/projects/webkit/changeset/28200> reverted this behaviour? 74976 9 andersca 2008-03-24 09:11:46 -0700 Because of backwards compatibility. There might be apps that rely on images not being autoresized, which is why we added the preference in the first place. 87175 10 webkit 2008-07-28 11:10:19 -0700 (In reply to comment #9) > Because of backwards compatibility. There might be apps that rely on images not > being autoresized, which is why we added the preference in the first place. > So, is it impossible to fix the bug? If yes, it should be marked as WONTFIX. 17257 2007-11-13 22:13:10 -0800 2007-11-14 00:50:32 -0800 patch v1 patch.txt text/plain 1582 solushex SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3Nzgy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTEt MTMgIHJhaHVsICA8c2V0IEVNQUlMX0FERFJFU1MgZW52aXJvbm1lbnQgdmFyaWFibGU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV0FSTklORzogTk8g VEVTVCBDQVNFUyBBRERFRCBPUiBDSEFOR0VECisKKyAgICAgICAgKiBsb2FkZXIvSW1hZ2VEb2N1 bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbWFnZURvY3VtZW50OjpJbWFnZURvY3VtZW50 KToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OmNyZWF0ZURvY3VtZW50U3RydWN0 dXJlKToKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OmltYWdlQ2hhbmdlZCk6CisK IDIwMDctMTEtMTMgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbmRlcnMuCkluZGV4OiBsb2FkZXIvSW1hZ2VEb2N1bWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gbG9hZGVyL0ltYWdlRG9jdW1lbnQuY3BwCShyZXZpc2lvbiAyNzY4MCkKKysrIGxv YWRlci9JbWFnZURvY3VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI4LDcgKzEyOCw3IEBA IEltYWdlRG9jdW1lbnQ6OkltYWdlRG9jdW1lbnQoRE9NSW1wbGVtZW4KICAgICAsIG1faW1hZ2VF bGVtZW50KDApCiAgICAgLCBtX2ltYWdlU2l6ZUlzS25vd24oZmFsc2UpCiAgICAgLCBtX2RpZFNo cmlua0ltYWdlKGZhbHNlKQotICAgICwgbV9zaG91bGRTaHJpbmtJbWFnZSh0cnVlKQorICAgICwg bV9zaG91bGRTaHJpbmtJbWFnZShzaG91bGRTaHJpbmtUb0ZpdCgpKQogewogICAgIHNldFBhcnNl TW9kZShDb21wYXQpOwogfQpAQCAtMTU5LDkgKzE1OSw2IEBAIHZvaWQgSW1hZ2VEb2N1bWVudDo6 Y3JlYXRlRG9jdW1lbnRTdHJ1Y3QKICAgICAKICAgICBib2R5LT5hcHBlbmRDaGlsZChpbWFnZUVs ZW1lbnQsIGVjKTsKICAgICAKLSAgICBpZiAoIXNob3VsZFNocmlua1RvRml0KCkpCi0gICAgICAg IHJldHVybjsKLSAgICAKICAgICAvLyBBZGQgZXZlbnQgbGlzdGVuZXJzCiAgICAgUmVmUHRyPEV2 ZW50TGlzdGVuZXI+IGxpc3RlbmVyID0gbmV3IEltYWdlRXZlbnRMaXN0ZW5lcih0aGlzKTsKICAg ICBhZGRXaW5kb3dFdmVudExpc3RlbmVyKCJyZXNpemUiLCBsaXN0ZW5lciwgZmFsc2UpOwpAQCAt MjI2LDkgKzIyMyw2IEBAIHZvaWQgSW1hZ2VEb2N1bWVudDo6aW1hZ2VDaGFuZ2VkKCkKICAgICAK ICAgICBtX2ltYWdlU2l6ZUlzS25vd24gPSB0cnVlOwogICAgIAotICAgIGlmICghc2hvdWxkU2hy aW5rVG9GaXQoKSkKLSAgICAgICAgcmV0dXJuOwotICAgIAogICAgIC8vIEZvcmNlIHJlc2l6aW5n IG9mIHRoZSBpbWFnZQogICAgIHdpbmRvd1NpemVDaGFuZ2VkKCk7CiB9Cg== 17264 2007-11-14 00:50:32 -0800 2010-06-10 15:50:07 -0700 patch v1 w/better changelog patch.txt text/plain 1641 solushex SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3Nzgy KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTEt MTMgIFJhaHVsIEFicm9sICA8cmE1dWxAY29tY2FzdC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTU5NzcKKyAgICAgICAgUmVzaXppbmcgaW1hZ2VzIHByZWZlcmVuY2Ugbm93 IHRvZ2dsZXMgZGVmYXVsdCBpbWFnZSBzdGF0ZS4KKworICAgICAgICAqIGxvYWRlci9JbWFnZURv Y3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRG9jdW1lbnQ6OkltYWdlRG9jdW1l bnQpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEb2N1bWVudDo6Y3JlYXRlRG9jdW1lbnRTdHJ1 Y3R1cmUpOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VEb2N1bWVudDo6aW1hZ2VDaGFuZ2VkKToK KwogMjAwNy0xMS0xMyAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFuZGVycy4KSW5kZXg6IGxvYWRlci9JbWFnZURvY3VtZW50LmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBsb2FkZXIvSW1hZ2VEb2N1bWVudC5jcHAJKHJldmlzaW9uIDI3NjgwKQorKysg bG9hZGVyL0ltYWdlRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjgsNyArMTI4LDcg QEAgSW1hZ2VEb2N1bWVudDo6SW1hZ2VEb2N1bWVudChET01JbXBsZW1lbgogICAgICwgbV9pbWFn ZUVsZW1lbnQoMCkKICAgICAsIG1faW1hZ2VTaXplSXNLbm93bihmYWxzZSkKICAgICAsIG1fZGlk U2hyaW5rSW1hZ2UoZmFsc2UpCi0gICAgLCBtX3Nob3VsZFNocmlua0ltYWdlKHRydWUpCisgICAg LCBtX3Nob3VsZFNocmlua0ltYWdlKHNob3VsZFNocmlua1RvRml0KCkpCiB7CiAgICAgc2V0UGFy c2VNb2RlKENvbXBhdCk7CiB9CkBAIC0xNTksOSArMTU5LDYgQEAgdm9pZCBJbWFnZURvY3VtZW50 OjpjcmVhdGVEb2N1bWVudFN0cnVjdAogICAgIAogICAgIGJvZHktPmFwcGVuZENoaWxkKGltYWdl RWxlbWVudCwgZWMpOwogICAgIAotICAgIGlmICghc2hvdWxkU2hyaW5rVG9GaXQoKSkKLSAgICAg ICAgcmV0dXJuOwotICAgIAogICAgIC8vIEFkZCBldmVudCBsaXN0ZW5lcnMKICAgICBSZWZQdHI8 RXZlbnRMaXN0ZW5lcj4gbGlzdGVuZXIgPSBuZXcgSW1hZ2VFdmVudExpc3RlbmVyKHRoaXMpOwog ICAgIGFkZFdpbmRvd0V2ZW50TGlzdGVuZXIoInJlc2l6ZSIsIGxpc3RlbmVyLCBmYWxzZSk7CkBA IC0yMjYsOSArMjIzLDYgQEAgdm9pZCBJbWFnZURvY3VtZW50OjppbWFnZUNoYW5nZWQoKQogICAg IAogICAgIG1faW1hZ2VTaXplSXNLbm93biA9IHRydWU7CiAgICAgCi0gICAgaWYgKCFzaG91bGRT aHJpbmtUb0ZpdCgpKQotICAgICAgICByZXR1cm47Ci0gICAgCiAgICAgLy8gRm9yY2UgcmVzaXpp bmcgb2YgdGhlIGltYWdlCiAgICAgd2luZG93U2l6ZUNoYW5nZWQoKTsKIH0K