159749 2016-07-13 17:07:26 -0700 Addressing post-review comments after r203119 2021-05-10 09:38:37 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mmaxfield mmaxfield 11a_wgpj aadilkhan9409 ap benjamin cdumez cmarcelo commit-queue yoken66706 oldest_to_newest 1210790 0 mmaxfield 2016-07-13 17:07:26 -0700 Addressing post-review comments after r203119 1210791 1 283590 mmaxfield 2016-07-13 17:07:49 -0700 Created attachment 283590 Patch 1210832 2 283590 commit-queue 2016-07-13 19:02:20 -0700 Comment on attachment 283590 Patch Clearing flags on attachment: 283590 Committed r203208: <http://trac.webkit.org/changeset/203208> 1210834 3 commit-queue 2016-07-13 19:02:26 -0700 All reviewed patches have been landed. Closing bug. 283590 2016-07-13 17:07:49 -0700 2016-07-13 19:02:20 -0700 Patch bug-159749-20160713170703.patch text/plain 3007 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDEzOWRkOWZkYzU4MTdjYTFjMDc3YzBm ODU4NGY4ZDNiODg5ZjNkNzIuLjM4M2ZmZGZlNDRmNTEwM2MxODE5MWNiZDQ0ZWIyYzMzNTg1ODRm YzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDctMTMgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBBZGRyZXNzaW5nIHBvc3QtcmV2aWV3IGNv bW1lbnRzIGFmdGVyIHIyMDMxMTkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTc0OQorCisgICAgICAgIFVucmV2aWV3ZWQuCisKKyAgICAgICAgKiB3 dGYvdGV4dC9TdHJpbmdWaWV3Lmg6CisgICAgICAgIChXVEY6OlN0cmluZ1ZpZXc6OkNvZGVQb2lu dHM6Okl0ZXJhdG9yOjpJdGVyYXRvcik6CisgICAgICAgIChXVEY6OlN0cmluZ1ZpZXc6OkNvZGVQ b2ludHM6Okl0ZXJhdG9yOjpvcGVyYXRvciopOgorICAgICAgICAoV1RGOjpTdHJpbmdWaWV3OjpD b2RlUG9pbnRzOjpJdGVyYXRvcjo6b3BlcmF0b3I9PSk6CisKIDIwMTYtMDctMTMgIEVucmljYSBD YXN1Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgc3VwcG9ydGVkIHBs YXRmb3JtcyBpbiB4Y2NvbmZpZyBmaWxlcyB0byBtYXRjaCB0aGUgc2RrIG5hbWVzLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdWaWV3LmggYi9Tb3VyY2UvV1RGL3d0Zi90 ZXh0L1N0cmluZ1ZpZXcuaAppbmRleCAzOWFhMDMyMzE2MzQ3NDZhMjA2MDgwNzMzOGJmNmZhZmVm MWUzMzE5Li45OTE2MzcxMWRlMjk4ZWYyMmU4Yjc2YmNmNTY2YjQxYmEzN2Q5MWNlIDEwMDY0NAot LS0gYS9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ1ZpZXcuaAorKysgYi9Tb3VyY2UvV1RGL3d0 Zi90ZXh0L1N0cmluZ1ZpZXcuaApAQCAtNjU0LDggKzY1NCw3IEBAIHB1YmxpYzoKIAogcHJpdmF0 ZToKICAgICBjb25zdCBTdHJpbmdWaWV3JiBtX3N0cmluZ1ZpZXc7Ci0gICAgdW5zaWduZWQgbV9p bmRleDsKLSAgICB1bnNpZ25lZCBtX2luZGV4RW5kOworICAgIE9wdGlvbmFsPHVuc2lnbmVkPiBt X25leHRDb2RlUG9pbnRPZmZzZXQ7CiAgICAgVUNoYXIzMiBtX2NvZGVQb2ludDsKIH07CiAKQEAg LTcxMSwzNyArNzEwLDM2IEBAIGlubGluZSBTdHJpbmdWaWV3OjpDb2RlUG9pbnRzOjpDb2RlUG9p bnRzKGNvbnN0IFN0cmluZ1ZpZXcmIHN0cmluZ1ZpZXcpCiAKIGlubGluZSBTdHJpbmdWaWV3OjpD b2RlUG9pbnRzOjpJdGVyYXRvcjo6SXRlcmF0b3IoY29uc3QgU3RyaW5nVmlldyYgc3RyaW5nVmll dywgdW5zaWduZWQgaW5kZXgpCiAgICAgOiBtX3N0cmluZ1ZpZXcoc3RyaW5nVmlldykKLSAgICAs IG1faW5kZXgoaW5kZXgpCi0gICAgLCBtX2luZGV4RW5kKGluZGV4KQorICAgICwgbV9uZXh0Q29k ZVBvaW50T2Zmc2V0KGluZGV4KQogewogICAgIG9wZXJhdG9yKysoKTsKIH0KIAogaW5saW5lIGF1 dG8gU3RyaW5nVmlldzo6Q29kZVBvaW50czo6SXRlcmF0b3I6Om9wZXJhdG9yKysoKSAtPiBJdGVy YXRvciYKIHsKLSAgICBBU1NFUlQobV9pbmRleEVuZCA8PSBtX3N0cmluZ1ZpZXcubGVuZ3RoKCkp OwotICAgIG1faW5kZXggPSBtX2luZGV4RW5kOwotICAgIGlmIChtX2luZGV4RW5kID09IG1fc3Ry aW5nVmlldy5sZW5ndGgoKSkgewotICAgICAgICBtX2NvZGVQb2ludCA9IDA7CisgICAgQVNTRVJU KG1fbmV4dENvZGVQb2ludE9mZnNldCk7CisgICAgaWYgKG1fbmV4dENvZGVQb2ludE9mZnNldC52 YWx1ZSgpID09IG1fc3RyaW5nVmlldy5sZW5ndGgoKSkgeworICAgICAgICBtX25leHRDb2RlUG9p bnRPZmZzZXQgPSBOdWxsb3B0OwogICAgICAgICByZXR1cm4gKnRoaXM7CiAgICAgfQogICAgIGlm IChtX3N0cmluZ1ZpZXcuaXM4Qml0KCkpCi0gICAgICAgIG1fY29kZVBvaW50ID0gbV9zdHJpbmdW aWV3LmNoYXJhY3RlcnM4KClbbV9pbmRleEVuZCsrXTsKKyAgICAgICAgbV9jb2RlUG9pbnQgPSBt X3N0cmluZ1ZpZXcuY2hhcmFjdGVyczgoKVttX25leHRDb2RlUG9pbnRPZmZzZXQudmFsdWUoKSsr XTsKICAgICBlbHNlCi0gICAgICAgIFUxNl9ORVhUKG1fc3RyaW5nVmlldy5jaGFyYWN0ZXJzMTYo KSwgbV9pbmRleEVuZCwgbV9zdHJpbmdWaWV3Lmxlbmd0aCgpLCBtX2NvZGVQb2ludCk7CisgICAg ICAgIFUxNl9ORVhUKG1fc3RyaW5nVmlldy5jaGFyYWN0ZXJzMTYoKSwgbV9uZXh0Q29kZVBvaW50 T2Zmc2V0LnZhbHVlKCksIG1fc3RyaW5nVmlldy5sZW5ndGgoKSwgbV9jb2RlUG9pbnQpOworICAg IEFTU0VSVChtX25leHRDb2RlUG9pbnRPZmZzZXQudmFsdWUoKSA8PSBtX3N0cmluZ1ZpZXcubGVu Z3RoKCkpOwogICAgIHJldHVybiAqdGhpczsKIH0KIAogaW5saW5lIFVDaGFyMzIgU3RyaW5nVmll dzo6Q29kZVBvaW50czo6SXRlcmF0b3I6Om9wZXJhdG9yKigpIGNvbnN0CiB7Ci0gICAgQVNTRVJU KG1faW5kZXhFbmQgPD0gbV9zdHJpbmdWaWV3Lmxlbmd0aCgpKTsKKyAgICBBU1NFUlQobV9uZXh0 Q29kZVBvaW50T2Zmc2V0KTsKICAgICByZXR1cm4gbV9jb2RlUG9pbnQ7CiB9CiAKIGlubGluZSBi b29sIFN0cmluZ1ZpZXc6OkNvZGVQb2ludHM6Okl0ZXJhdG9yOjpvcGVyYXRvcj09KGNvbnN0IEl0 ZXJhdG9yJiBvdGhlcikgY29uc3QKIHsKICAgICBBU1NFUlQoJm1fc3RyaW5nVmlldyA9PSAmb3Ro ZXIubV9zdHJpbmdWaWV3KTsKLSAgICByZXR1cm4gbV9pbmRleCA9PSBvdGhlci5tX2luZGV4Owor ICAgIHJldHVybiBtX25leHRDb2RlUG9pbnRPZmZzZXQgPT0gb3RoZXIubV9uZXh0Q29kZVBvaW50 T2Zmc2V0OwogfQogCiBpbmxpbmUgYm9vbCBTdHJpbmdWaWV3OjpDb2RlUG9pbnRzOjpJdGVyYXRv cjo6b3BlcmF0b3IhPShjb25zdCBJdGVyYXRvciYgb3RoZXIpIGNvbnN0Cg==