159738 2016-07-13 14:43:03 -0700 [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it 2016-07-13 19:39:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates ap lforschler mitz ryanhaddad oldest_to_newest 1210712 0 dbates 2016-07-13 14:43:03 -0700 We should copy WebKitTestRunnerInjectedBundle.bundle to the PlugIn subdirectory of the WebKitTestRunnerApp.app bundle so as to make the bundle hierarchy of WebKitTestRunnerApp.app more closely conform to the bundle hierarchy of an iOS app. We should also code sign WebKitTestRunnerInjectedBundle.bundle because it contains executable code and is loaded by WebKitTestRunnerApp.app, which may be code signed. 1210721 1 283568 dbates 2016-07-13 14:49:33 -0700 Created attachment 283568 Patch 1210723 2 dbates 2016-07-13 14:50:19 -0700 <rdar://problem/27304649> 1210725 3 283568 mitz 2016-07-13 14:51:12 -0700 Comment on attachment 283568 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283568&action=review > Tools/ChangeLog:10 > + code signed should WebKitTestRunnerApp be code signed. We should also copy this bundle “should WebKitTestRunnerApp be code signed”? > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:68 > + NSString *nsBundlePath = [[[NSBundle mainBundle] builtInPlugInsPath] stringByAppendingPathComponent:@"WebKitTestRunnerInjectedBundle.bundle"]; You can use property syntax here. 1210837 4 dbates 2016-07-13 19:38:12 -0700 (In reply to comment #3) > > Tools/ChangeLog:10 > > + code signed should WebKitTestRunnerApp be code signed. We should also copy this bundle > > “should WebKitTestRunnerApp be code signed”? > I changed this sentence to read: The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be code signed if applicable. > > Tools/WebKitTestRunner/ios/TestControllerIOS.mm:68 > > + NSString *nsBundlePath = [[[NSBundle mainBundle] builtInPlugInsPath] stringByAppendingPathComponent:@"WebKitTestRunnerInjectedBundle.bundle"]; > > You can use property syntax here. Will fix before landing. 1210838 5 dbates 2016-07-13 19:39:08 -0700 Committed r203209: <http://trac.webkit.org/changeset/203209> 283568 2016-07-13 14:49:33 -0700 2016-07-13 14:51:12 -0700 Patch bug-159738-20160713144848.patch text/plain 5597 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTY2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTlmNmFkYTVlYjMzYTkxZGIxNjI2MjZlOWM4MDA5YTA3 ZGMyMzc1OS4uN2RmOTFmNjRkYjBjOGE0MDI3YTc3M2QyODE1ZWFjNzQwNzAzNzA2NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDE2LTA3LTEzICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBDb3B5IFdlYktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRsZS5idW5kbGUgaW50 byBQbHVnSW5zIHN1YmRpcmVjdG9yeSBhbmQgY29kZSBzaWduIGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk3MzgKKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzI3MzA0NjQ5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSBidW5kbGUgV2ViS2l0VGVzdFJ1bm5lckluamVjdGVkQnVuZGxlLmJ1bmRs ZSBjb250YWlucyBleGVjdXRhYmxlIGNvZGUgYW5kIHNob3VsZCBiZQorICAgICAgICBjb2RlIHNp Z25lZCBzaG91bGQgV2ViS2l0VGVzdFJ1bm5lckFwcCBiZSBjb2RlIHNpZ25lZC4gV2Ugc2hvdWxk IGFsc28gY29weSB0aGlzIGJ1bmRsZQorICAgICAgICBpbnRvIHRoZSBQbHVnSW5zIHN1YmRpcmVj dG9yeSBvZiB0aGUgV2ViS2l0VGVzdFJ1bm5lckFwcC5hcHAgYnVuZGxlIGluc3RlYWQgb2YgdGhl IHRvcC0KKyAgICAgICAgbGV2ZWwgYnVuZGxlIGRpcmVjdG9yeSBhcyB0aGUgUGx1Z0lucyBzdWJk aXJlY3RvcnkgaXMgdGhlIGRpcmVjdG9yeSB3aGVyZSBsb2FkYWJsZQorICAgICAgICBidW5kbGVz IG9mIGFuIGFwcCBhcmUgZXhwZWN0ZWQgdG8gbGl2ZS4KKworICAgICAgICAqIFdlYktpdFRlc3RS dW5uZXIvV2ViS2l0VGVzdFJ1bm5lci54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tOgorICAgICAgICAo V1RSOjpUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZUluamVjdGVkQnVuZGxlUGF0aCk6IE1vZGlm aWVkIGNvZGUgdG8gbG9vayBmb3IgdGhlCisgICAgICAgIGJ1bmRsZSBXZWJLaXRUZXN0UnVubmVy SW5qZWN0ZWRCdW5kbGUuYnVuZGxlIGluIHRoZSBwbHVnaW4gZGlyZWN0b3J5IG9mIHRoZSBtYWlu IGJ1bmRsZS4KKwogMjAxNi0wNy0xMyAgQ2FybG9zIEFsYmVydG8gTG9wZXogUGVyZXogIDxjbG9w ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbRUZMXSBbR1RLXSBFbmFibGUgYmFjayBjcnlwdG8g c3VidGxlIG9uIGRldmVsb3BtZW50IGJ1aWxkcy4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRl c3RSdW5uZXIvV2ViS2l0VGVzdFJ1bm5lci54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qIGIvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9XZWJLaXRUZXN0UnVubmVyLnhjb2RlcHJvai9wcm9qZWN0LnBi eHByb2oKaW5kZXggNGFmNjE1Njc1ZDMyMmYyMTkwNzAxMjJhOTcxMTY5ZjVmNjA1ZTY5OS4uMmIw YjZkNDVhMjIzY2JiN2U4MTVlNjg5N2ZiYzkxYWUzYzA1NzljMSAxMDA2NDQKLS0tIGEvVG9vbHMv V2ViS2l0VGVzdFJ1bm5lci9XZWJLaXRUZXN0UnVubmVyLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9XZWJLaXRUZXN0UnVubmVyLnhjb2RlcHJv ai9wcm9qZWN0LnBieHByb2oKQEAgLTYxLDcgKzYxLDcgQEAKIAkJMjlBOEZDREQxNDVGMDMzNzAw OTA0NUE2IC8qIEpTQWNjZXNzaWJpbGl0eVRleHRNYXJrZXJSYW5nZS5jcHAgaW4gU291cmNlcyAq LyA9IHtpc2EgPSBQQlhCdWlsZEZpbGU7IGZpbGVSZWYgPSAyOUE4RkNFMTM0NUU3MDIxMDA2QUE1 QTYgLyogSlNBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlclJhbmdlLmNwcCAqLzsgfTsKIAkJMjlBOEZD RTIxNDVGMDM3QjAwOTA0NUE2IC8qIEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2UuY3BwIGlu IFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gMjlBOEZDRTExNDVG MDM3QjAwOTA0NUE2IC8qIEFjY2Vzc2liaWxpdHlUZXh0TWFya2VyUmFuZ2UuY3BwICovOyB9Owog CQkyOUE4RkNFNTE0NUYwNDY0MDA5MDQ1QTYgLyogQWNjZXNzaWJpbGl0eVRleHRNYXJrZXJSYW5n ZU1hYy5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9IDI5 QThGQ0U0MTQ1RjA0NjQwMDkwNDVBNiAvKiBBY2Nlc3NpYmlsaXR5VGV4dE1hcmtlclJhbmdlTWFj Lm1tICovOyB9OwotCQkyRTM0QzkwMDE4QjY4ODA4MDAwMDY3QkIgLyogV2ViS2l0VGVzdFJ1bm5l ckluamVjdGVkQnVuZGxlLmJ1bmRsZSBpbiBSZXNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRG aWxlOyBmaWxlUmVmID0gQkMyNTE4NjIxMUQxNUQ1NDAwMkVCQzAxIC8qIFdlYktpdFRlc3RSdW5u ZXJJbmplY3RlZEJ1bmRsZS5idW5kbGUgKi87IH07CisJCTJFMzRDOTAwMThCNjg4MDgwMDAwNjdC QiAvKiBXZWJLaXRUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUuYnVuZGxlIGluIENvcHkgUGx1Zy1J bnMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxlUmVmID0gQkMyNTE4NjIxMUQxNUQ1NDAw MkVCQzAxIC8qIFdlYktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRsZS5idW5kbGUgKi87IHNldHRp bmdzID0ge0FUVFJJQlVURVMgPSAoQ29kZVNpZ25PbkNvcHksIFJlbW92ZUhlYWRlcnNPbkNvcHks ICk7IH07IH07CiAJCTJFNjNFRDhBMTg5MUFEN0UwMDJBN0FGQyAvKiBBY2Nlc3NpYmlsaXR5Q29u dHJvbGxlcklPUy5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJl ZiA9IDJFNjNFRDc1MTg5MUFDRTkwMDJBN0FGQyAvKiBBY2Nlc3NpYmlsaXR5Q29udHJvbGxlcklP Uy5tbSAqLzsgfTsKIAkJMkU2M0VEOEIxODkxQUQ3RTAwMkE3QUZDIC8qIEFjY2Vzc2liaWxpdHlU ZXh0TWFya2VySU9TLm1tIGluIFNvdXJjZXMgKi8gPSB7aXNhID0gUEJYQnVpbGRGaWxlOyBmaWxl UmVmID0gMkU2M0VENzcxODkxQUNFOTAwMkE3QUZDIC8qIEFjY2Vzc2liaWxpdHlUZXh0TWFya2Vy SU9TLm1tICovOyB9OwogCQkyRTYzRUQ4RTE4OTFBRDdFMDAyQTdBRkMgLyogRXZlbnRTZW5kZXJQ cm94eUlPUy5tbSBpbiBTb3VyY2VzICovID0ge2lzYSA9IFBCWEJ1aWxkRmlsZTsgZmlsZVJlZiA9 IDJFNjNFRDdBMTg5MUFDRTkwMDJBN0FGQyAvKiBFdmVudFNlbmRlclByb3h5SU9TLm1tICovOyB9 OwpAQCAtMTcxLDYgKzE3MSwyMCBAQAogCQl9OwogLyogRW5kIFBCWENvbnRhaW5lckl0ZW1Qcm94 eSBzZWN0aW9uICovCiAKKy8qIEJlZ2luIFBCWENvcHlGaWxlc0J1aWxkUGhhc2Ugc2VjdGlvbiAq LworCQlDRUMyMDkwMzFEMzZFMzZBMDAyNjE1OTYgLyogQ29weSBQbHVnLUlucyAqLyA9IHsKKwkJ CWlzYSA9IFBCWENvcHlGaWxlc0J1aWxkUGhhc2U7CisJCQlidWlsZEFjdGlvbk1hc2sgPSAyMTQ3 NDgzNjQ3OworCQkJZHN0UGF0aCA9ICIiOworCQkJZHN0U3ViZm9sZGVyU3BlYyA9IDEzOworCQkJ ZmlsZXMgPSAoCisJCQkJMkUzNEM5MDAxOEI2ODgwODAwMDA2N0JCIC8qIFdlYktpdFRlc3RSdW5u ZXJJbmplY3RlZEJ1bmRsZS5idW5kbGUgaW4gQ29weSBQbHVnLUlucyAqLywKKwkJCSk7CisJCQlu YW1lID0gIkNvcHkgUGx1Zy1JbnMiOworCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vz c2luZyA9IDA7CisJCX07CisvKiBFbmQgUEJYQ29weUZpbGVzQnVpbGRQaGFzZSBzZWN0aW9uICov CisKIC8qIEJlZ2luIFBCWEZpbGVSZWZlcmVuY2Ugc2VjdGlvbiAqLwogCQkwRjIxMDlDNzE4OUM2 NTBEMDBGODc5QTMgLyogQmFzZVRhcmdldC54Y2NvbmZpZyAqLyA9IHtpc2EgPSBQQlhGaWxlUmVm ZXJlbmNlOyBsYXN0S25vd25GaWxlVHlwZSA9IHRleHQueGNjb25maWc7IHBhdGggPSBCYXNlVGFy Z2V0LnhjY29uZmlnOyBzb3VyY2VUcmVlID0gIjxncm91cD4iOyB9OwogCQkwRjUxNjlDQTE0NDUy MjJEMDBFMEE5RDcgLyogV2ViS2l0LmZyYW1ld29yayAqLyA9IHtpc2EgPSBQQlhGaWxlUmVmZXJl bmNlOyBsYXN0S25vd25GaWxlVHlwZSA9IHdyYXBwZXIuZnJhbWV3b3JrOyBwYXRoID0gV2ViS2l0 LmZyYW1ld29yazsgc291cmNlVHJlZSA9IEJVSUxUX1BST0RVQ1RTX0RJUjsgfTsKQEAgLTc2Nyw2 ICs3ODEsNyBAQAogCQkJCTJFRTUyQ0RDMTg5MEE5QTgwMDEwRUQyMSAvKiBTb3VyY2VzICovLAog CQkJCTJFRTUyQ0REMTg5MEE5QTgwMDEwRUQyMSAvKiBGcmFtZXdvcmtzICovLAogCQkJCTJFRTUy Q0RFMTg5MEE5QTgwMDEwRUQyMSAvKiBSZXNvdXJjZXMgKi8sCisJCQkJQ0VDMjA5MDMxRDM2RTM2 QTAwMjYxNTk2IC8qIENvcHkgUGx1Zy1JbnMgKi8sCiAJCQkpOwogCQkJYnVpbGRSdWxlcyA9ICgK IAkJCSk7CkBAIC04NzgsNyArODkzLDYgQEAKIAkJCWlzYSA9IFBCWFJlc291cmNlc0J1aWxkUGhh c2U7CiAJCQlidWlsZEFjdGlvbk1hc2sgPSAyMTQ3NDgzNjQ3OwogCQkJZmlsZXMgPSAoCi0JCQkJ MkUzNEM5MDAxOEI2ODgwODAwMDA2N0JCIC8qIFdlYktpdFRlc3RSdW5uZXJJbmplY3RlZEJ1bmRs ZS5idW5kbGUgaW4gUmVzb3VyY2VzICovLAogCQkJCTJFRTUyQ0VEMTg5MEE5QTgwMDEwRUQyMSAv KiBJbmZvUGxpc3Quc3RyaW5ncyBpbiBSZXNvdXJjZXMgKi8sCiAJCQkJMEY4N0I2MTkxQkFDQzU1 ODAwNEVDNTcyIC8qIExhdW5jaC5zdG9yeWJvYXJkIGluIFJlc291cmNlcyAqLywKIAkJCSk7CmRp ZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJvbGxlcklPUy5t bSBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCmluZGV4 IDNkOTBkYTZmZjI1MzY5ZGZhMmJlOTVhYjViMzQ3ZTFiYjJiMDFlNjEuLjhhMTA1ZGI5ZGQ2Y2Ix ZWZjOTk3NDFiZmE1NTA3ZGNlMTRjYjQ4MjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvaW9zL1Rlc3RDb250cm9sbGVySU9TLm1tCkBAIC02NSw3ICs2NSw3IEBAIHZvaWQgVGVzdENv bnRyb2xsZXI6OnBsYXRmb3JtRGVzdHJveSgpCiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRp YWxpemVJbmplY3RlZEJ1bmRsZVBhdGgoKQogewotICAgIE5TU3RyaW5nICpuc0J1bmRsZVBhdGgg PSBbW1tOU0J1bmRsZSBtYWluQnVuZGxlXSBidW5kbGVQYXRoXSBzdHJpbmdCeUFwcGVuZGluZ1Bh dGhDb21wb25lbnQ6QCJXZWJLaXRUZXN0UnVubmVySW5qZWN0ZWRCdW5kbGUuYnVuZGxlIl07Cisg ICAgTlNTdHJpbmcgKm5zQnVuZGxlUGF0aCA9IFtbW05TQnVuZGxlIG1haW5CdW5kbGVdIGJ1aWx0 SW5QbHVnSW5zUGF0aF0gc3RyaW5nQnlBcHBlbmRpbmdQYXRoQ29tcG9uZW50OkAiV2ViS2l0VGVz dFJ1bm5lckluamVjdGVkQnVuZGxlLmJ1bmRsZSJdOwogICAgIG1faW5qZWN0ZWRCdW5kbGVQYXRo LmFkb3B0KFdLU3RyaW5nQ3JlYXRlV2l0aENGU3RyaW5nKChDRlN0cmluZ1JlZiluc0J1bmRsZVBh dGgpKTsKIH0KIAo=