159737 2016-07-13 14:27:51 -0700 Full screen ePub embedded video is playing on 1/4 screen, cut off 2016-07-15 13:43:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar InRadar P2 Normal --- 1 jer.noble jer.noble dino jonlee thorton webkit-bug-importer oldest_to_newest 1210691 0 jer.noble 2016-07-13 14:27:51 -0700 Full screen ePub embedded video is playing on 1/4 screen, cut off 1210692 1 jer.noble 2016-07-13 14:28:10 -0700 <rdar://problem/26259404> 1210693 2 webkit-bug-importer 2016-07-13 14:28:33 -0700 <rdar://problem/27332427> 1210703 3 283566 jer.noble 2016-07-13 14:34:47 -0700 Created attachment 283566 Patch 1210706 4 283566 thorton 2016-07-13 14:38:09 -0700 Comment on attachment 283566 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283566&action=review > Source/WebKit2/UIProcess/Cocoa/WebViewImpl.mm:1010 > + setFixedLayoutSize(CGSizeZero); Somewhat surprising that WKViewFixedSizeLayoutStrategy doesn't do this in willChangeLayoutStrategy. Maybe it should be there? I don't know. 1210708 5 thorton 2016-07-13 14:38:45 -0700 Also somewhat concerned that something is using the fixed layout size when fixed layout is off... seems bad. 1211130 6 jonlee 2016-07-14 14:01:32 -0700 <rdar://problem/26259404> 1211541 7 dino 2016-07-15 13:43:34 -0700 Committed r203295: <http://trac.webkit.org/changeset/203295> 283566 2016-07-13 14:34:47 -0700 2016-07-13 14:38:09 -0700 Patch bug-159737-20160713143402.patch text/plain 3787 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggYTAwNzk4ZWEwNmMxZWQ0 MjMzYTI3OTQ1YWIxNmQ3MWJlY2UyNTY5Ni4uZGVhNTRlZWE2NzkxMmVhZDlhMmE2OGViMGQ1Mzlm OGE3N2E1MmM0MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE2LTA3LTEzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIEZ1bGwgc2NyZWVuIGVQdWIg ZW1iZWRkZWQgdmlkZW8gaXMgcGxheWluZyBvbiAxLzQgc2NyZWVuLCBjdXQgb2ZmCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk3MzcKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzI2MjU5NDA0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFNldCB0aGUgZml4ZWRMYXlvdXRTaXplIHRvIENHU2l6ZVplcm8g d2hlbiBkaXNhYmxpbmcgZml4ZWQgbGF5b3V0IGR1ZSB0byB0aGUgCisgICAgICAgIFdlYlZpZXcg bm90IHN1cHBvcnRpbmcgYXJiaXRyYXJ5IGxheW91dCBtb2RlcywgYW5kIHJlc2V0IHRvIHRoZSBz YXZlZCB2YWx1ZQorICAgICAgICB3aGVuIHRoZSB2aWV3IGRvZXMgYmVnaW4gc3VwcG9ydGluZyBh cmJpdHJhcnkgbGF5b3V0IG1vZGVzLgorCisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZp ZXdJbXBsLmg6CisgICAgICAgICogVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLm1tOgorICAg ICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0Rml4ZWRMYXlvdXRTaXplKToKKyAgICAgICAg KFdlYktpdDo6V2ViVmlld0ltcGw6OnVwZGF0ZVN1cHBvcnRzQXJiaXRyYXJ5TGF5b3V0TW9kZXMp OgorCisyMDE2LTA3LTEzICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCiAgICAg ICAgIFJFR1JFU1NJT04gKHIxOTE5MDcpOiBNYXh0aG9uIEJyb3dzZXIgLUFmdGVyIGV4aXQgZnVs bCBzY3JlZW4gdmlkZW8gcGxheWJhY2sgdGhlIGJyb3dzZXIgd2luZG93IGlzIGJsYW5rIHdpdGgg YXVkaW8gcnVubmluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTU5NzMxCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yNjY3NDAwMz4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5oIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZpZXdJbXBsLmgKaW5kZXggMDdjZjljOTM1MGE0 MzI5ZjY1NmQ3MjA3MmZiMGRhZGY0NDk2NjU1ZC4uM2UwMjA5NGM4MjE0MTQzZTM3YWEzOTEzYTFi ZDgzZGY1MGZhMjRiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29h L1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZp ZXdJbXBsLmgKQEAgLTU1OSw2ICs1NTksNyBAQCBwcml2YXRlOgogICAgIFJldGFpblB0cjxXS1Zp ZXdMYXlvdXRTdHJhdGVneT4gbV9sYXlvdXRTdHJhdGVneTsKICAgICBXS0xheW91dE1vZGUgbV9s YXN0UmVxdWVzdGVkTGF5b3V0TW9kZSB7IGtXS0xheW91dE1vZGVWaWV3U2l6ZSB9OwogICAgIENH RmxvYXQgbV9sYXN0UmVxdWVzdGVkVmlld1NjYWxlIHsgMSB9OworICAgIENHU2l6ZSBtX2xhc3RS ZXF1ZXN0ZWRGaXhlZExheW91dFNpemUgeyAwLCAwIH07CiAKICAgICBib29sIG1faW5TZWN1cmVJ bnB1dFN0YXRlIHsgZmFsc2UgfTsKICAgICBSZXRhaW5QdHI8V0tFZGl0b3JVbmRvVGFyZ2V0T2Jq Qz4gbV91bmRvVGFyZ2V0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nv Y29hL1dlYlZpZXdJbXBsLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0NvY29hL1dlYlZp ZXdJbXBsLm1tCmluZGV4IDc3ZTA1OWM3MDcxMjlmODQ3MzViMTczMDY2MTJkNWE3MGIwNmZlOWUu LjVkZDUwOWQ5MzkxZTU2YTQwZWJjM2RkOGVhNDdmMTkyYjVjMDQ0OTEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db2NvYS9XZWJWaWV3SW1wbC5tbQorKysgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQ29jb2EvV2ViVmlld0ltcGwubW0KQEAgLTc1MCw3ICs3NTAsMTAg QEAgdm9pZCBXZWJWaWV3SW1wbDo6dXBkYXRlV2luZG93QW5kVmlld0ZyYW1lcygpCiAKIHZvaWQg V2ViVmlld0ltcGw6OnNldEZpeGVkTGF5b3V0U2l6ZShDR1NpemUgZml4ZWRMYXlvdXRTaXplKQog ewotICAgIG1fcGFnZS0+c2V0Rml4ZWRMYXlvdXRTaXplKFdlYkNvcmU6OmV4cGFuZGVkSW50U2l6 ZShXZWJDb3JlOjpGbG9hdFNpemUoZml4ZWRMYXlvdXRTaXplKSkpOworICAgIG1fbGFzdFJlcXVl c3RlZEZpeGVkTGF5b3V0U2l6ZSA9IGZpeGVkTGF5b3V0U2l6ZTsKKworICAgIGlmIChzdXBwb3J0 c0FyYml0cmFyeUxheW91dE1vZGVzKCkpCisgICAgICAgIG1fcGFnZS0+c2V0Rml4ZWRMYXlvdXRT aXplKFdlYkNvcmU6OmV4cGFuZGVkSW50U2l6ZShXZWJDb3JlOjpGbG9hdFNpemUoZml4ZWRMYXlv dXRTaXplKSkpOwogfQogCiBDR1NpemUgV2ViVmlld0ltcGw6OmZpeGVkTGF5b3V0U2l6ZSgpIGNv bnN0CkBAIC0xMDAxLDE2ICsxMDA0LDIwIEBAIHZvaWQgV2ViVmlld0ltcGw6OnVwZGF0ZVN1cHBv cnRzQXJiaXRyYXJ5TGF5b3V0TW9kZXMoKQogICAgIGlmICghc3VwcG9ydHNBcmJpdHJhcnlMYXlv dXRNb2RlcygpKSB7CiAgICAgICAgIFdLTGF5b3V0TW9kZSBvbGRSZXF1ZXN0ZWRMYXlvdXRNb2Rl ID0gbV9sYXN0UmVxdWVzdGVkTGF5b3V0TW9kZTsKICAgICAgICAgQ0dGbG9hdCBvbGRSZXF1ZXN0 ZWRWaWV3U2NhbGUgPSBtX2xhc3RSZXF1ZXN0ZWRWaWV3U2NhbGU7CisgICAgICAgIENHU2l6ZSBv bGRSZXF1ZXN0ZWRGaXhlZExheW91dFNpemUgPSBtX2xhc3RSZXF1ZXN0ZWRGaXhlZExheW91dFNp emU7CiAgICAgICAgIHNldFZpZXdTY2FsZSgxKTsKICAgICAgICAgc2V0TGF5b3V0TW9kZShrV0tM YXlvdXRNb2RlVmlld1NpemUpOworICAgICAgICBzZXRGaXhlZExheW91dFNpemUoQ0dTaXplWmVy byk7CiAKICAgICAgICAgLy8gVGhlICdsYXN0IHJlcXVlc3RlZCcgcGFyYW1ldGVycyB3aWxsIGhh dmUgYmVlbiBvdmVyd3JpdHRlbiBieSBzZXR0aW5nIHRoZW0gYWJvdmUsIGJ1dCB3ZSBkb24ndAog ICAgICAgICAvLyB3YW50IHRoaXMgdG8gY291bnQgYXMgYSByZXF1ZXN0IChvbmx5IGNoYW5nZXMg ZnJvbSB0aGUgY2xpZW50IGNvdW50KSwgc28gcmVzZXQgdGhlbS4KICAgICAgICAgbV9sYXN0UmVx dWVzdGVkTGF5b3V0TW9kZSA9IG9sZFJlcXVlc3RlZExheW91dE1vZGU7CiAgICAgICAgIG1fbGFz dFJlcXVlc3RlZFZpZXdTY2FsZSA9IG9sZFJlcXVlc3RlZFZpZXdTY2FsZTsKKyAgICAgICAgbV9s YXN0UmVxdWVzdGVkRml4ZWRMYXlvdXRTaXplID0gb2xkUmVxdWVzdGVkRml4ZWRMYXlvdXRTaXpl OwogICAgIH0gZWxzZSBpZiAobV9sYXN0UmVxdWVzdGVkTGF5b3V0TW9kZSAhPSBbbV9sYXlvdXRT dHJhdGVneSBsYXlvdXRNb2RlXSkgewogICAgICAgICBzZXRWaWV3U2NhbGUobV9sYXN0UmVxdWVz dGVkVmlld1NjYWxlKTsKICAgICAgICAgc2V0TGF5b3V0TW9kZShtX2xhc3RSZXF1ZXN0ZWRMYXlv dXRNb2RlKTsKKyAgICAgICAgc2V0Rml4ZWRMYXlvdXRTaXplKG1fbGFzdFJlcXVlc3RlZEZpeGVk TGF5b3V0U2l6ZSk7CiAgICAgfQogfQogCg==