159710 2016-07-13 03:53:35 -0700 Test WTF.StringViewIterators is crashing since r203119 2016-07-13 23:18:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=159609 P2 Normal --- 1 cgarcia webkit-unassigned darin lforschler mmaxfield oldest_to_newest 1210396 0 cgarcia 2016-07-13 03:53:35 -0700 I think there are two problems in the test case added in r203119. First is that it's testing StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a const reference to the string view member of the deleted CodePoints object. 1210397 1 283508 cgarcia 2016-07-13 03:55:05 -0700 Created attachment 283508 Patch 1210580 2 mmaxfield 2016-07-13 12:16:59 -0700 Wow... whoops. Thanks so much for fixing this. 1210884 3 cgarcia 2016-07-13 23:18:31 -0700 Committed r203214: <http://trac.webkit.org/changeset/203214> 283508 2016-07-13 03:55:05 -0700 2016-07-13 09:06:03 -0700 Patch wtf-string-view-test.diff text/plain 1597 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjMzY3 YTE2Li41NmE4MmE5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTYtMDctMTMgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFRlc3QgV1RGLlN0cmluZ1ZpZXdJdGVy YXRvcnMgaXMgY3Jhc2hpbmcgc2luY2UgcjIwMzExOQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NzEwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIHR3byBwcm9ibGVtcyBpbiB0aGUgdGVz dCBjYXNlIGFkZGVkIGluIHIyMDMxMTkuIEZpcnN0IGlzIHRoYXQgaXQncyB0ZXN0aW5nCisgICAg ICAgIFN0cmluZ1ZpZXc6OkNvZGVVbml0czo6SXRlcmF0b3IgaW5zdGVhZCBvZiBTdHJpbmdWaWV3 OjpDb2RlUG9pbnRzOjpJdGVyYXRvciwgYW5kIHNlY29uZCBpcyB0aGF0CisgICAgICAgIFN0cmlu Z1ZpZXc6OmNvZGVQb2ludHMoKSByZXR1cm5zIGEgdGVtcG9yYXJ5LCBzbyB0aGUgaXRlcmF0b3Ig Y3JlYXRlZCBmcm9tIHRoZSB0ZW1wb3JhcnkgZW5kcyB1cCBwb2ludGluZyB0byBhCisgICAgICAg IGNvbnN0IHJlZmVyZW5jZSB0byB0aGUgc3RyaW5nIHZpZXcgbWVtYmVyIG9mIHRoZSBkZWxldGVk IENvZGVQb2ludHMgb2JqZWN0LgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYv U3RyaW5nVmlldy5jcHA6CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAxNi0w Ny0xMiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgV2Ugc2hvdWxk IHVzZSBkaWZmZXJlbnQgc3RhY2sgbGltaXRzIGZvciBzdGFjayBjaGVja3MgZnJvbSBKUyBhbmQg aG9zdCBjb2RlLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvU3Ry aW5nVmlldy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9TdHJpbmdWaWV3LmNw cAppbmRleCBlMjhjMjRhLi5jNTM5ZGRjIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJ L1Rlc3RzL1dURi9TdHJpbmdWaWV3LmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9TdHJpbmdWaWV3LmNwcApAQCAtMTIyLDcgKzEyMiw4IEBAIFRFU1QoV1RGLCBTdHJpbmdW aWV3SXRlcmF0b3JzKQogICAgIFN0cmluZyBoZWxvKCJoZWxvIik7CiAgICAgU3RyaW5nVmlldyBo ZWxvVmlldyhoZWxvKTsKIAotICAgIGF1dG8gY29kZVBvaW50c0l0ZXJhdG9yID0gaGVsb1ZpZXcu Y29kZVVuaXRzKCkuYmVnaW4oKTsKKyAgICBhdXRvIGNvZGVQb2ludHMgPSBoZWxvVmlldy5jb2Rl UG9pbnRzKCk7CisgICAgYXV0byBjb2RlUG9pbnRzSXRlcmF0b3IgPSBjb2RlUG9pbnRzLmJlZ2lu KCk7CiAgICAgRVhQRUNUX0VRKCpjb2RlUG9pbnRzSXRlcmF0b3IsICdoJyk7CiAgICAgRVhQRUNU X0VRKCpjb2RlUG9pbnRzSXRlcmF0b3IsICdoJyk7CiAgICAgKytjb2RlUG9pbnRzSXRlcmF0b3I7 Cg==