159706 2016-07-13 03:01:41 -0700 CLoop buildfix after r203142 2016-07-13 03:23:23 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P1 Blocker --- 159442 1 ossy ossy commit-queue ggaren keith_miller mark.lam msaboff ossy saam oldest_to_newest 1210378 0 ossy 2016-07-13 03:01:41 -0700 http://trac.webkit.org/r203142 broke the CLoop buildfix and http://trac.webkit.org/r203144 didn't fix it. C loop is still broken: Source/JavaScriptCore/CMakeFiles/LLIntOffsetsExtractor.dir/llint/LLIntOffsetsExtractor.cpp.o:LLIntOffsetsExtractor.cpp:function JSC::CLoopStack::isSafeToRecurse() const: error: undefined reference to 'JSC::ExecState::topOfFrameInternal()' collect2: error: ld returned 1 exit status JSC::CLoopStack::isSafeToRecurse() can't be inlined because of this build failure,let's move it to CLoopStack.cpp instead of CLoopStackInlines.h. (Feel free to fix it yourself, if you know a better fix for it.) 1210379 1 283500 ossy 2016-07-13 03:03:01 -0700 Created attachment 283500 Patch for landing 1210383 2 283500 commit-queue 2016-07-13 03:23:19 -0700 Comment on attachment 283500 Patch for landing Clearing flags on attachment: 283500 Committed r203156: <http://trac.webkit.org/changeset/203156> 1210384 3 commit-queue 2016-07-13 03:23:23 -0700 All reviewed patches have been landed. Closing bug. 283500 2016-07-13 03:03:01 -0700 2016-07-13 03:23:19 -0700 Patch for landing bug-159706-20160713120216.patch text/plain 2878 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 OWRkOWI5ZTZmZjdjOGVjOTNiZDEzMGI2ZTEzYWFkNjU4OWRkZDI1Li42NDljOGVmNmUxOTZkNTVi OTgxZmExMjNmYWQ3ODYzMTllZjUxZjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNy0xMyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIENMb29wIGJ1aWxkZml4IGFmdGVyIHIyMDMxNDIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTcwNgorCisgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGRmaXguCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9DTG9vcFN0YWNrLmNw cDoKKyAgICAgICAgKEpTQzo6Q0xvb3BTdGFjazo6aXNTYWZlVG9SZWN1cnNlKToKKyAgICAgICAg KiBpbnRlcnByZXRlci9DTG9vcFN0YWNrLmg6CisgICAgICAgICogaW50ZXJwcmV0ZXIvQ0xvb3BT dGFja0lubGluZXMuaDoKKyAgICAgICAgKEpTQzo6Q0xvb3BTdGFjazo6aXNTYWZlVG9SZWN1cnNl KTogRGVsZXRlZC4KKwogMjAxNi0wNy0xMiAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFw cGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBBcnJheS5wcm90b3R5cGUuam9pbigpIGZhaWxzIHNv bWUgY29uZm9ybWFuY2UgdGVzdHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9p bnRlcnByZXRlci9DTG9vcFN0YWNrLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9DTG9vcFN0YWNrLmNwcAppbmRleCA5YzgwNzIyMjA0YWM0NzFlYmU0NjNkMmQ3ZWExZGVh ZjdlNjllNjE5Li5mNjg4ZTg4YjM0NzkxMzM4MjVjMzg1MmNhMmNjZDZjZjU3YzI5NzY4IDEwMDY0 NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0ZXIvQ0xvb3BTdGFjay5jcHAK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NMb29wU3RhY2suY3BwCkBA IC0xNDcsNiArMTQ3LDEyIEBAIHZvaWQgQ0xvb3BTdGFjazo6c2V0U29mdFJlc2VydmVkWm9uZVNp emUoc2l6ZV90IHJlc2VydmVkWm9uZVNpemUpCiAgICAgICAgIGdyb3cobV9lbmQgKyAxKTsKIH0K IAorYm9vbCBDTG9vcFN0YWNrOjppc1NhZmVUb1JlY3Vyc2UoKSBjb25zdAoreworICAgIHZvaWQq IHJlc2VydmF0aW9uTGltaXQgPSByZWludGVycHJldF9jYXN0PGludDhfdCo+KHJlc2VydmF0aW9u VG9wKCkgKyBtX3NvZnRSZXNlcnZlZFpvbmVTaXplSW5SZWdpc3RlcnMpOworICAgIHJldHVybiAh bV90b3BDYWxsRnJhbWUgfHwgKG1fdG9wQ2FsbEZyYW1lLT50b3BPZkZyYW1lKCkgPiByZXNlcnZh dGlvbkxpbWl0KTsKK30KKwogc2l6ZV90IENMb29wU3RhY2s6OmNvbW1pdHRlZEJ5dGVDb3VudCgp CiB7CiAgICAgTG9ja0hvbGRlciBsb2NrZXIoc3RhY2tTdGF0aXN0aWNzTXV0ZXgpOwpkaWZmIC0t Z2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0NMb29wU3RhY2suaCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9DTG9vcFN0YWNrLmgKaW5kZXggMjBmZGJi MTM3MjMwYTdhNTMwYzFkNmY2YzQ2OWE3OWE2MWU3ZjVkZC4uZGU3YmJhNmY1NWI3YTI0Yjk4YTgw NDNiY2QwM2Y1ZjFjMWY5NDExYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0NMb29wU3RhY2suaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW50ZXJw cmV0ZXIvQ0xvb3BTdGFjay5oCkBAIC02OSw3ICs2OSw2IEBAIG5hbWVzcGFjZSBKU0MgewogCiAg ICAgICAgIHZvaWQgc2V0U29mdFJlc2VydmVkWm9uZVNpemUoc2l6ZV90KTsKICAgICAgICAgYm9v bCBpc1NhZmVUb1JlY3Vyc2UoKSBjb25zdDsKLQogICAgICAgICBpbmxpbmUgUmVnaXN0ZXIqIHRv cE9mU3RhY2soKTsKIAogICAgIHByaXZhdGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvaW50ZXJwcmV0ZXIvQ0xvb3BTdGFja0lubGluZXMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnRlcnByZXRlci9DTG9vcFN0YWNrSW5saW5lcy5oCmluZGV4IDZlOGRlYzc3NmU0MTQ4 YmFkNjUyZTViMTRiM2RiYzZhNjEwOWNkZGQuLjQ0ZTM4NWJkYzA2YjMyNGE4M2VlOTY1ZTNhYjdi NGI3MzJlM2MyNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRl ci9DTG9vcFN0YWNrSW5saW5lcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnBy ZXRlci9DTG9vcFN0YWNrSW5saW5lcy5oCkBAIC00MiwxMiArNDIsNiBAQCBpbmxpbmUgYm9vbCBD TG9vcFN0YWNrOjplbnN1cmVDYXBhY2l0eUZvcihSZWdpc3RlciogbmV3VG9wT2ZTdGFjaykKICAg ICByZXR1cm4gZ3JvdyhuZXdUb3BPZlN0YWNrKTsKIH0KIAotYm9vbCBDTG9vcFN0YWNrOjppc1Nh ZmVUb1JlY3Vyc2UoKSBjb25zdAotewotICAgIHZvaWQqIHJlc2VydmF0aW9uTGltaXQgPSByZWlu dGVycHJldF9jYXN0PGludDhfdCo+KHJlc2VydmF0aW9uVG9wKCkgKyBtX3NvZnRSZXNlcnZlZFpv bmVTaXplSW5SZWdpc3RlcnMpOwotICAgIHJldHVybiAhbV90b3BDYWxsRnJhbWUgfHwgKG1fdG9w Q2FsbEZyYW1lLT50b3BPZkZyYW1lKCkgPiByZXNlcnZhdGlvbkxpbWl0KTsKLX0KLQogaW5saW5l IFJlZ2lzdGVyKiBDTG9vcFN0YWNrOjp0b3BPZkZyYW1lRm9yKENhbGxGcmFtZSogZnJhbWUpCiB7 CiAgICAgaWYgKFVOTElLRUxZKCFmcmFtZSkpCg==