159696 2016-07-12 16:34:45 -0700 Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.showsFilterBar') 2016-07-13 16:34:31 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED http://daringfireball.net/ InRadar P2 Normal --- 1 joepeck mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1210233 0 joepeck 2016-07-12 16:34:45 -0700 Summary: Uncaught exception closing Timeline Tab while viewing Script & Events Timeline. Steps to Reproduce: 1. Inspect this page 2. Show timeline tab 3. Enable Scripts + Events timeline 4. Reload => populate timeline data 5. Select Script + Events timeline 6. Close Timeline Tab => Uncaught exception Uncaught Exceptions: - TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.showsFilterBar') (at ScriptClusterTimelineView.js:65:80) showsFilterBar @ ScriptClusterTimelineView.js:65:80 _updateFilterBar @ TimelineRecordingContentView.js:800:102 _contentViewSelectionPathComponentDidChange @ TimelineRecordingContentView.js:325:30 dispatch @ Object.js:162:30 dispatchEventToListeners @ Object.js:177:21 _currentContentViewDidChange @ ClusterContentView.js:225:38 dispatch @ Object.js:162:30 dispatchEventToListeners @ Object.js:169:17 closeAllContentViews @ ContentViewContainer.js:345:38 closed @ ClusterContentView.js:75:56 _disassociateFromContentView @ ContentViewContainer.js:476:27 closeAllContentViews @ ContentViewContainer.js:339:46 closed @ TimelineRecordingContentView.js:198:79 _disassociateFromContentView @ ContentViewContainer.js:476:27 closeAllContentViews @ ContentViewContainer.js:339:46 closed @ ContentBrowserTabContentView.js:121:71 closed @ TimelineTabContentView.js:298:21 _disassociateFromContentView @ ContentViewContainer.js:476:27 closeContentView @ ContentViewContainer.js:309:46 _tabBarItemRemoved @ TabBrowser.js:238:52 dispatch @ Object.js:162:30 dispatchEventToListeners @ Object.js:169:17 removeTabBarItem @ TabBar.js:298:38 _handleClick @ TabBar.js:607:34 _handleClick @ [native code] 1210235 1 webkit-bug-importer 2016-07-12 16:35:06 -0700 <rdar://problem/27312356> 1210643 2 mattbaker 2016-07-13 13:41:41 -0700 By the time ScriptClusterTimelineView showFilterBar is called, currentContentView has been destroyed. Simply adding a null check fixes this, but just kicks the can down the road: [Error] Assertion Failed: Record selected in hidden overview graph – null selectRecord (TimelineOverview.js:399) _contentViewSelectionPathComponentDidChange (TimelineRecordingContentView.js:338) dispatch (Object.js:162) dispatchEventToListeners (Object.js:177) _currentContentViewDidChange (ClusterContentView.js:225) dispatch (Object.js:162) dispatchEventToListeners (Object.js:169) closeAllContentViews (ContentViewContainer.js:345) closed (ClusterContentView.js:75) _disassociateFromContentView (ContentViewContainer.js:476) closeAllContentViews (ContentViewContainer.js:339) closed (TimelineRecordingContentView.js:198) _disassociateFromContentView (ContentViewContainer.js:476) closeAllContentViews (ContentViewContainer.js:339) closed (ContentBrowserTabContentView.js:121) closed (TimelineTabContentView.js:298) _disassociateFromContentView (ContentViewContainer.js:476) closeContentView (ContentViewContainer.js:309) _tabBarItemRemoved (TabBrowser.js:238) dispatch (Object.js:162) dispatchEventToListeners (Object.js:169) removeTabBarItem (TabBar.js:234) _handleClick (TabBar.js:607) _handleClick Working on a solution which addresses both. 1210644 3 joepeck 2016-07-13 13:42:42 -0700 Well, probably _all_ of these forwarding messages should be resilient. 1210747 4 mattbaker 2016-07-13 15:17:40 -0700 (In reply to comment #3) > Well, probably _all_ of these forwarding messages should be resilient. This is a separate but related issue. Both problems stem from TimelineRecordingContentView handling SelectedPathComponentsDidChange, which is emitted by ContentViewContainer.closeAllContentViews(). If ContentView had a "closed" property we could early return from the SelectedPathComponentsDidChange handle. Luckily we can use the "visible" property in the same way. Skipping these updates when the tab is hidden should be safe, since TimelineRecordingContentView.shown() triggers a CurrentContentViewDidChange -> SelectedPathComponentsDidChange. 1210751 5 283579 mattbaker 2016-07-13 15:29:49 -0700 Created attachment 283579 [Patch] Proposed Fix 1210753 6 283579 joepeck 2016-07-13 15:33:22 -0700 Comment on attachment 283579 [Patch] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=283579&action=review r=me > Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js:322 > - if (event.target !== this._timelineContentBrowser.currentContentView) > + if (!this.visible || event.target !== this._timelineContentBrowser.currentContentView) Style: This would read better as a separate if + bail. These are two very different conditions. 1210756 7 283581 mattbaker 2016-07-13 15:37:38 -0700 Created attachment 283581 [Patch] For Landing 1210773 8 283581 commit-queue 2016-07-13 16:34:27 -0700 Comment on attachment 283581 [Patch] For Landing Clearing flags on attachment: 283581 Committed r203198: <http://trac.webkit.org/changeset/203198> 1210774 9 commit-queue 2016-07-13 16:34:31 -0700 All reviewed patches have been landed. Closing bug. 283579 2016-07-13 15:29:49 -0700 2016-07-13 15:37:35 -0700 [Patch] Proposed Fix bug-159696-20160713152904.patch text/plain 1890 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 NjkxMjdmODc3MGQzYWE2MzM2OTFiMjdlNjhhM2U1ZDY2NjdkNjg3Li45YmE3NGVjYzc5M2EwNmE3 ZTcwNjNjYmU2YzEzNjM4MzMyZGUxODEzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNy0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IG51bGwgaXMgbm90IGFu IG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5fY29udGVudFZpZXdDb250YWluZXIuY3VycmVudENv bnRlbnRWaWV3LnNob3dzRmlsdGVyQmFyJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1OTY5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjczMTIz NTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUu X2NvbnRlbnRWaWV3U2VsZWN0aW9uUGF0aENvbXBvbmVudERpZENoYW5nZSk6CisgICAgICAgIEVh cmx5IHJldHVybiBpZiBjb250ZW50IHZpZXcgbm90IHZpc2libGUsIHNpbmNlIHRoZSBldmVudCBp cyBzZW50IGR1cmluZworICAgICAgICB0YWIgdGVhcmRvd24gYW5kIHRoZSBjdXJyZW50IFRpbWVs aW5lVmlldyBtYXkgYmUgaW52YWxpZC4KKwogMjAxNi0wNy0xMiAgSm9zZXBoIFBlY29yYXJvICA8 cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjE5Mjc4OSk6IFdlYiBJ bnNwZWN0b3I6IExvZyBWYWx1ZSBjb250ZXh0IG1lbnUgYXBwZWFycyB0d2ljZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNv cmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggYzM3YjljMWU1YjEz ZjI3NThkYzI3ZTE1ZGNlMDg3M2VkMWM1ZmFjNS4uNGEzMzg3ZmRmNDYwM2E0OWE3M2RlY2Y3OTdj NzliYzk2ZGFjMTE5ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3LmpzCkBAIC0zMTksNyArMzE5LDcgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3Jk aW5nQ29udGVudFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGUKIAog ICAgIF9jb250ZW50Vmlld1NlbGVjdGlvblBhdGhDb21wb25lbnREaWRDaGFuZ2UoZXZlbnQpCiAg ICAgewotICAgICAgICBpZiAoZXZlbnQudGFyZ2V0ICE9PSB0aGlzLl90aW1lbGluZUNvbnRlbnRC cm93c2VyLmN1cnJlbnRDb250ZW50VmlldykKKyAgICAgICAgaWYgKCF0aGlzLnZpc2libGUgfHwg ZXZlbnQudGFyZ2V0ICE9PSB0aGlzLl90aW1lbGluZUNvbnRlbnRCcm93c2VyLmN1cnJlbnRDb250 ZW50VmlldykKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB0aGlzLl91cGRhdGVGaWx0 ZXJCYXIoKTsK 283581 2016-07-13 15:37:38 -0700 2016-07-13 16:34:27 -0700 [Patch] For Landing bug-159696-20160713153653.patch text/plain 1812 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 NjkxMjdmODc3MGQzYWE2MzM2OTFiMjdlNjhhM2U1ZDY2NjdkNjg3Li44NDZlZmI0NmE4NmFhMDI2 YjU5ZTExNWZlYzljOTlhOTU2ODBkM2JiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNi0wNy0xMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgVW5jYXVnaHQgRXhjZXB0aW9uOiBUeXBlRXJyb3I6IG51bGwgaXMgbm90IGFu IG9iamVjdCAoZXZhbHVhdGluZyAndGhpcy5fY29udGVudFZpZXdDb250YWluZXIuY3VycmVudENv bnRlbnRWaWV3LnNob3dzRmlsdGVyQmFyJykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE1OTY5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjczMTIz NTY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBlY29yYXJvLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcucHJvdG90eXBl Ll9jb250ZW50Vmlld1NlbGVjdGlvblBhdGhDb21wb25lbnREaWRDaGFuZ2UpOgorICAgICAgICBF YXJseSByZXR1cm4gaWYgY29udGVudCB2aWV3IG5vdCB2aXNpYmxlLCBzaW5jZSB0aGUgZXZlbnQg aXMgc2VudCBkdXJpbmcKKyAgICAgICAgdGFiIHRlYXJkb3duIGFuZCB0aGUgY3VycmVudCBUaW1l bGluZVZpZXcgbWF5IGJlIGludmFsaWQuCisKIDIwMTYtMDctMTIgIEpvc2VwaCBQZWNvcmFybyAg PHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIxOTI3ODkpOiBXZWIg SW5zcGVjdG9yOiBMb2cgVmFsdWUgY29udGV4dCBtZW51IGFwcGVhcnMgdHdpY2UKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVj b3JkaW5nQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzCmluZGV4IGMzN2I5YzFlNWIx M2YyNzU4ZGMyN2UxNWRjZTA4NzNlZDFjNWZhYzUuLmZkNWM0YjI4NzQyMTc3ZjAyNjg3MDA3YzNk ZjJmZTIzMmVjZWU2MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250 ZW50Vmlldy5qcwpAQCAtMzE5LDYgKzMxOSw5IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29y ZGluZ0NvbnRlbnRWaWV3ID0gY2xhc3MgVGltZWxpbmVSZWNvcmRpbmdDb250ZW50VmlldyBlCiAK ICAgICBfY29udGVudFZpZXdTZWxlY3Rpb25QYXRoQ29tcG9uZW50RGlkQ2hhbmdlKGV2ZW50KQog ICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLnZpc2libGUpCisgICAgICAgICAgICByZXR1cm47CisK ICAgICAgICAgaWYgKGV2ZW50LnRhcmdldCAhPT0gdGhpcy5fdGltZWxpbmVDb250ZW50QnJvd3Nl ci5jdXJyZW50Q29udGVudFZpZXcpCiAgICAgICAgICAgICByZXR1cm47CiAK