159669 2016-07-12 00:23:48 -0700 JSCOnly bulidfix after r203078 2016-07-12 04:30:07 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159598 1 ossy ossy andersca cgarcia commit-queue gyuyoung.kim mmaxfield ossy ysuzuki oldest_to_newest 1209968 0 ossy 2016-07-12 00:23:48 -0700 https://trac.webkit.org/changeset/203078 broke the build on JSCOnly port: lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::wordBreakIterator(WTF::StringView)': TextBreakIterator.cpp:(.text+0x238): undefined reference to `WTF::currentTextBreakLocaleID()' lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::sentenceBreakIterator(WTF::StringView)': TextBreakIterator.cpp:(.text+0x3a0): undefined reference to `WTF::currentTextBreakLocaleID()' lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::openLineBreakIterator(WTF::AtomicString const&, WTF::LineBreakIteratorMode, bool)': TextBreakIterator.cpp:(.text+0x790): undefined reference to `WTF::currentTextBreakLocaleID()' TextBreakIterator.cpp:(.text+0x7bc): undefined reference to `WTF::currentTextBreakLocaleID()' lib/../Source/WTF/wtf/CMakeFiles/WTF.dir/text/TextBreakIterator.cpp.o: In function `WTF::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView)': TextBreakIterator.cpp:(.text+0xc58): undefined reference to `WTF::currentTextBreakLocaleID()' collect2: error: ld returned 1 exit status It seems JSCOnly port should have currentTextBreakLocaleID() since this patch, fix is coming. 1209970 1 283395 ossy 2016-07-12 00:28:46 -0700 Created attachment 283395 Patch 1209971 2 283395 ossy 2016-07-12 00:30:25 -0700 Comment on attachment 283395 Patch Speculative fix, simply duplicate the GTK's dummy implementation. I'll be able to test it in ~3 hours. 1209988 3 283395 ossy 2016-07-12 03:47:56 -0700 Comment on attachment 283395 Patch build tested, it works 1209991 4 283395 ysuzuki 2016-07-12 04:08:41 -0700 Comment on attachment 283395 Patch r=me, it is the same to GTK, and EFL. 1209993 5 283395 commit-queue 2016-07-12 04:30:01 -0700 Comment on attachment 283395 Patch Clearing flags on attachment: 283395 Committed r203112: <http://trac.webkit.org/changeset/203112> 1209994 6 commit-queue 2016-07-12 04:30:07 -0700 All reviewed patches have been landed. Closing bug. 283395 2016-07-12 00:28:46 -0700 2016-07-12 04:30:01 -0700 Patch bug-159669-20160712002803.patch text/plain 2740 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDhmOGQ3MTI5NWNmZTMwYmVkZWYyNTE4 NzIxOWU1NWY5ZTJkM2M2OGEuLjkxYjMzNDFiYTlhNDkzZDAwYWQyMTNmOGUwODAyZWZmNjlhYTEw YjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTYtMDctMTIgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBKU0NPbmx5IGJ1bGlkZml4IGFmdGVyIHIyMDMw NzgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTY2 OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3Rm L1BsYXRmb3JtSlNDT25seS5jbWFrZToKKyAgICAgICAgKiB3dGYvdGV4dC9qc2Nvbmx5L1RleHRC cmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1VKU0NPbmx5LmNwcDogQWRkZWQuCisgICAgICAgIChXVEY6 OmN1cnJlbnRTZWFyY2hMb2NhbGVJRCk6CisgICAgICAgIChXVEY6OmN1cnJlbnRUZXh0QnJlYWtM b2NhbGVJRCk6CisKIDIwMTYtMDctMTEgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFw cGxlLmNvbT4KIAogICAgICAgICBJbXBsZW1lbnQgZ3JhcGhlbWUgY2x1c3RlciBpdGVyYXRvciBv biBTdHJpbmdWaWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUpTQ09ubHku Y21ha2UgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUpTQ09ubHkuY21ha2UKaW5kZXggZWNkNmE0 ZjhkMTllNGU4NjZlYzllNTI5MzZjOGY0NDgzNzJkMWQ5ZC4uNjc5ZmIyYjdhN2Q2NzNjZjAxZTk1 ZTk1NjY5YjEzM2ZmNDQ2NzAxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvUGxhdGZvcm1K U0NPbmx5LmNtYWtlCisrKyBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSlNDT25seS5jbWFrZQpA QCAtMSw1ICsxLDcgQEAKIGxpc3QoQVBQRU5EIFdURl9TT1VSQ0VTCiAgICAgUGxhdGZvcm1Vc2Vy UHJlZmVycmVkTGFuZ3VhZ2VzVW5peC5jcHAKKworICAgIHRleHQvanNjb25seS9UZXh0QnJlYWtJ dGVyYXRvckludGVybmFsSUNVSlNDT25seS5jcHAKICkKIAogaWYgKExPV0VSQ0FTRV9FVkVOVF9M T09QX1RZUEUgU1RSRVFVQUwgImdsaWIiKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4 dC9qc2Nvbmx5L1RleHRCcmVha0l0ZXJhdG9ySW50ZXJuYWxJQ1VKU0NPbmx5LmNwcCBiL1NvdXJj ZS9XVEYvd3RmL3RleHQvanNjb25seS9UZXh0QnJlYWtJdGVyYXRvckludGVybmFsSUNVSlNDT25s eS5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uMjNhZGEzMDg2NjMwZTk4MGQ0M2E1ZTViYjJmYTIyMDYxZGIwNDlm OAotLS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XVEYvd3RmL3RleHQvanNjb25seS9UZXh0QnJl YWtJdGVyYXRvckludGVybmFsSUNVSlNDT25seS5jcHAKQEAgLTAsMCArMSwzNyBAQAorLyoKKyAq IENvcHlyaWdodCAoQykgMjAwNyBBbHAgVG9rZXIgPGFscEBhdG9rZXIuY29tPgorICoKKyAqIFRo aXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQv b3IKKyAqIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVy YWwgUHVibGljCisgKiBMaWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBG b3VuZGF0aW9uOyBlaXRoZXIKKyAqIHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlv dXIgb3B0aW9uKSBhbnkgbGF0ZXIgdmVyc2lvbi4KKyAqCisgKiBUaGlzIGxpYnJhcnkgaXMgZGlz dHJpYnV0ZWQgaW4gdGhlIGhvcGUgdGhhdCBpdCB3aWxsIGJlIHVzZWZ1bCwKKyAqIGJ1dCBXSVRI T1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisg KiBNRVJDSEFOVEFCSUxJVFkgb3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBT ZWUgdGhlIEdOVQorICogTGlicmFyeSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRl dGFpbHMuCisgKgorICogWW91IHNob3VsZCBoYXZlIHJlY2VpdmVkIGEgY29weSBvZiB0aGUgR05V IExpYnJhcnkgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorICogYWxvbmcgd2l0aCB0aGlzIGxpYnJh cnk7IHNlZSB0aGUgZmlsZSBDT1BZSU5HLkxJQi4gIElmIG5vdCwgd3JpdGUgdG8KKyAqIHRoZSBG cmVlIFNvZnR3YXJlIEZvdW5kYXRpb24sIEluYy4sIDUxIEZyYW5rbGluIFN0cmVldCwgRmlmdGgg Rmxvb3IsCisgKiBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KKyAqLworCisjaW5jbHVkZSAi Y29uZmlnLmgiCisjaW5jbHVkZSAiVGV4dEJyZWFrSXRlcmF0b3JJbnRlcm5hbElDVS5oIgorCitu YW1lc3BhY2UgV1RGIHsKKworY29uc3QgY2hhciogY3VycmVudFNlYXJjaExvY2FsZUlEKCkKK3sK KyAgICAvLyBGSVhNRTogU2hvdWxkIHVzZSBzeXN0ZW0gbG9jYWxlLgorICAgIHJldHVybiAiIjsK K30KKworY29uc3QgY2hhciogY3VycmVudFRleHRCcmVha0xvY2FsZUlEKCkKK3sKKyAgICAvLyBG SVhNRTogU2hvdWxkIHVzZSBzeXN0ZW0gbG9jYWxlLgorICAgIHJldHVybiAiZW5fdXMiOworfQor Cit9Cg==