159661 2016-07-11 20:21:53 -0700 REGRESSION (202694): Audio and Video playback controls: Cannot find a position slider to adjust playback position using VO. 2016-07-12 16:40:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino ryanhaddad oldest_to_newest 1209921 0 dino 2016-07-11 20:21:53 -0700 The change in r202694 broke the visibility of the scrubber in MediaDocuments. 1209922 1 dino 2016-07-11 20:22:50 -0700 <rdar://problem/27285135> 1209923 2 283384 dino 2016-07-11 20:27:51 -0700 Created attachment 283384 Patch 1210023 3 283384 eric.carlson 2016-07-12 07:53:44 -0700 Comment on attachment 283384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283384&action=review > LayoutTests/media/controls/default-size-should-show-scrubber.html:11 > +let tester = new ControlsTest() Nit: this can be a const > LayoutTests/media/controls/default-size-should-show-scrubber.html:37 > + let elementState = tester.stateForControlsElement(name); Ditto. 1210099 4 283384 eric.carlson 2016-07-12 11:07:26 -0700 Comment on attachment 283384 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283384&action=review > LayoutTests/media/controls/default-size-should-show-scrubber.html:6 > + if (state === null || typeof state.className !== "string") > + return false; Don't you want to return true here? > LayoutTests/media/controls/default-size-should-show-scrubber.html:7 > + let classes = state.className.split(); Nit: this can be a const. 1210120 5 dino 2016-07-12 11:53:11 -0700 Committed r203120: <http://trac.webkit.org/changeset/203120> 1210232 6 ryanhaddad 2016-07-12 16:31:16 -0700 The test added with this change is frequently failing on El Capitan Debug WK2 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols%2Fdefault-size-should-show-scrubber.html 1210240 7 ryanhaddad 2016-07-12 16:40:24 -0700 (In reply to comment #6) > The test added with this change is frequently failing on El Capitan Debug WK2 > > https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard. > html#showAllRuns=true&tests=media%2Fcontrols%2Fdefault-size-should-show- > scrubber.html Direct link to a failure: https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/6506 283384 2016-07-11 20:27:51 -0700 2016-07-12 07:53:44 -0700 Patch bug-159661-20160712132707.patch text/plain 5176 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMDg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODBjYjdkZmM2N2VkMTk4 NzllZmRjZDBmYzRmYzNiZGZmYWFhNWRmZS4uNzkwNWUyMmU3MGQwMGUyYzk3NjRlNjlmMDY1OTEx ZGM3NjYxZGEwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE2LTA3LTExICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OICgyMDI2OTQp OiBBdWRpbyBhbmQgVmlkZW8gcGxheWJhY2sgY29udHJvbHM6IENhbm5vdCBmaW5kIGEgcG9zaXRp b24gc2xpZGVyIHRvIGFkanVzdCBwbGF5YmFjayBwb3NpdGlvbiB1c2luZyBWTy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTY2MQorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vMjcyODUxMzU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5nZSBpbiByMjAyNjk0IGNhdXNlZCBNZWRpYURvY3Vt ZW50cyB0byBub3QgYWx3YXlzCisgICAgICAgIHNob3cgdGhlaXIgc2NydWJiZXIuIFRoZSBmaXgg aXMgdG8gcmVkdWNlIHRoZSBtaW5pbXVtIGFtb3VudAorICAgICAgICBvZiBzaXplIG5lZWRlZCB0 byBzaG93IHRoZSBzY3J1YmJlci4KKworICAgICAgICBUZXN0OiBtZWRpYS9jb250cm9scy9kZWZh dWx0LXNpemUtc2hvdWxkLXNob3ctc2NydWJiZXIuaHRtbAorCisgICAgICAgICogTW9kdWxlcy9t ZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBsZS5qczogODAgcGl4ZWxzIGlzIGVub3VnaAor ICAgICAgICB0byBzaG93IHRoZSBzY3J1YmJlci4KKwogMjAxNi0wNy0xMSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFBvdGVudGlhbCBudWxsIGRlcmVmZXJlbmNl IHVuZGVyIERvY3VtZW50TG9hZGVyOjptYWluUmVjZWl2ZWRFcnJvcigpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpz IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYWNvbnRyb2xzL21lZGlhQ29udHJvbHNBcHBs ZS5qcwppbmRleCBmNTkwNzNmMmJiNzNmNjM4MDc1ZGQ2MGU5ODJhY2ExYWY0MmU2NDc1Li41OTkx NDc1NzNhNDZjMGJkZGFjNWQyZDYwNWU3ZmZiMWE4OWNiMjA2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21lZGlhY29udHJvbHMvbWVkaWFDb250cm9sc0FwcGxlLmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFjb250cm9scy9tZWRpYUNvbnRyb2xzQXBwbGUu anMKQEAgLTEzMyw3ICsxMzMsNyBAQCBDb250cm9sbGVyLnByb3RvdHlwZSA9IHsKICAgICAgICAg cmlnaHQ6IDM5LAogICAgICAgICBkb3duOiA0MAogICAgIH0sCi0gICAgTWluaW11bVRpbWVsaW5l V2lkdGg6IDEwMCwKKyAgICBNaW5pbXVtVGltZWxpbmVXaWR0aDogODAsCiAgICAgQnV0dG9uV2lk dGg6IDMyLAogCiAgICAgZXh0ZW5kOiBmdW5jdGlvbihjaGlsZCkKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NDZiYmYxMzU1 ZDNhOTA4MDQyMmFmNjk0YTYzMzZkMDE5NDI0M2JiLi43ZmNlY2RmZjk1MWZlMDY2YTk0NWJmNDg5 ZDM2ODRhYmI5NzMzMzk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTYtMDctMTEgIERlYW4g SmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKDIwMjY5NCk6 IEF1ZGlvIGFuZCBWaWRlbyBwbGF5YmFjayBjb250cm9sczogQ2Fubm90IGZpbmQgYSBwb3NpdGlv biBzbGlkZXIgdG8gYWRqdXN0IHBsYXliYWNrIHBvc2l0aW9uIHVzaW5nIFZPLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NjYxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yNzI4NTEzNT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IHRoYXQgY2hlY2tzIHRoZSBzY3J1YmJlciBpcyB2 aXNpYmxlIG9uIGEgZGVmYXVsdCBtZWRpYSBlbGVtZW50LgorICAgICAgICBVbmZvcnR1bmF0ZWx5 IHRoaXMgaXNuJ3QgcXVpdGUgYW4gYWNjdXJhdGUgdGVzdCwgc2luY2Ugd2UgcmVhbGx5IHdhbnQg dG8KKyAgICAgICAgZXhhbWluZSBhIE1lZGlhIERvY3VtZW50LCBidXQgaXQncyBjbG9zZSBlbm91 Z2guCisKKyAgICAgICAgKiBtZWRpYS9jb250cm9scy9kZWZhdWx0LXNpemUtc2hvdWxkLXNob3ct c2NydWJiZXItZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBtZWRpYS9jb250cm9scy9k ZWZhdWx0LXNpemUtc2hvdWxkLXNob3ctc2NydWJiZXIuaHRtbDogQWRkZWQuCisKIDIwMTYtMDct MTEgIE5hbiBXYW5nICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQ3Jhc2ggd2hl biBiYWNrc3BhY2luZyBpbiBudW1iZXIgZmllbGQgd2l0aCBzcGluIGJ1dHRvbgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvbWVkaWEvY29udHJvbHMvZGVmYXVsdC1zaXplLXNob3VsZC1zaG93LXNj cnViYmVyLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL2NvbnRyb2xzL2RlZmF1bHQt c2l6ZS1zaG91bGQtc2hvdy1zY3J1YmJlci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTIwNmQz OTM2YWJmMDQxOTI4MjJmNGU1ZDE1NDk3MDA5NGExMDY3ZAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL21lZGlhL2NvbnRyb2xzL2RlZmF1bHQtc2l6ZS1zaG91bGQtc2hvdy1zY3J1YmJl ci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxNiBAQAorVGhpcyB0ZXN0cyB0aGF0IHRoZSBzY3J1 YmJlciBzaG93cyBvbiBhIGRlZmF1bHQgbWVkaWEgZWxlbWVudC4KKworVGhpcyB0ZXN0IG9ubHkg cnVucyBpbiBEUlQhCisKKworRVZFTlQ6IGNhbnBsYXl0aHJvdWdoCitQQVNTOiBXZSBhcmUgdXNp bmcgdGhlIGFwcGxlIGlkaW9tCitTY3J1YiB0byB0aGUgZW5kIG9mIHRoZSBtZWRpYQorRVZFTlQ6 IGVuZGVkCitQQVNTOiBWaWRlbyBpcyBwYXVzZWQKK1BBU1M6IFRpbWVsaW5lIGlzIHZpc2libGUK K1BBU1M6IFRpbWUgUmVtYWluaW5nIGlzIHZpc2libGUKK1BBU1M6IEN1cnJlbnQgVGltZSBpcyB2 aXNpYmxlCisKK1Rlc3RpbmcgZmluaXNoZWQuCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21l ZGlhL2NvbnRyb2xzL2RlZmF1bHQtc2l6ZS1zaG91bGQtc2hvdy1zY3J1YmJlci5odG1sIGIvTGF5 b3V0VGVzdHMvbWVkaWEvY29udHJvbHMvZGVmYXVsdC1zaXplLXNob3VsZC1zaG93LXNjcnViYmVy Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNDIzZDA5ZGZiNGMwNTVjMmU2ZTA5MTQzYzE0YmM1MGJhOGVhODU5 OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL2NvbnRyb2xzL2RlZmF1bHQt c2l6ZS1zaG91bGQtc2hvdy1zY3J1YmJlci5odG1sCkBAIC0wLDAgKzEsNDcgQEAKKzxzY3JpcHQg c3JjPSIuLi9tZWRpYS1maWxlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJjb250cm9scy10 ZXN0LWhlbHBlcnMuanMiPjwvc2NyaXB0PgorPHNjcmlwdD4KK2NvbnN0IGlzVmlzaWJsZSA9IChz dGF0ZSkgPT4geworICAgIGlmIChzdGF0ZSA9PT0gbnVsbCB8fCB0eXBlb2Ygc3RhdGUuY2xhc3NO YW1lICE9PSAic3RyaW5nIikKKyAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIGxldCBjbGFzc2Vz ID0gc3RhdGUuY2xhc3NOYW1lLnNwbGl0KCk7CisgICAgcmV0dXJuICFjbGFzc2VzLmluY2x1ZGVz KCJkcm9wcGVkIikgJiYgIWNsYXNzZXMuaW5jbHVkZXMoImhpZGRlbiIpOworfQorCitsZXQgdGVz dGVyID0gbmV3IENvbnRyb2xzVGVzdCgpCisgICAgLndoZW5SZWFkeShzY3J1YkFuZFdhaXQpCisg ICAgLnN0YXJ0KCk7CisKK2Z1bmN0aW9uIHNjcnViQW5kV2FpdCgpCit7CisgICAgY3VycmVudFN0 YXRlID0gdGVzdGVyLmN1cnJlbnRTdGF0ZTsKKyAgICB0ZXN0ZXIudGVzdCgiV2UgYXJlIHVzaW5n IHRoZSBhcHBsZSBpZGlvbSIpCisgICAgICAgIC52YWx1ZShjdXJyZW50U3RhdGUuaWRpb20pCisg ICAgICAgIC5pc0VxdWFsVG8oImFwcGxlIik7CisKKyAgICB0ZXN0ZXIubG9nTWVzc2FnZSgiU2Ny dWIgdG8gdGhlIGVuZCBvZiB0aGUgbWVkaWEiKTsKKworICAgIHRlc3Rlci5yZXNldEV2ZW50VHJp Z2dlcigiZW5kZWQiKQorICAgICAgICAud2hlblJlYWR5KHJ1blRlc3RzKTsKKyAgICB0ZXN0ZXIu bWVkaWEuY3VycmVudFRpbWUgPSB0ZXN0ZXIubWVkaWEuZHVyYXRpb24gLSAwLjA1OworICAgIHRl c3Rlci5tZWRpYS5wbGF5KCk7Cit9CisKK2Z1bmN0aW9uIHJ1blRlc3RzKCkKK3sKKyAgICB0ZXN0 ZXIudGVzdCgiVmlkZW8gaXMgcGF1c2VkIikKKyAgICAgICAgLnZhbHVlKHRlc3Rlci5tZWRpYS5w YXVzZWQpCisgICAgICAgIC5pc1RydWUoKTsKKworICAgIFsiVGltZWxpbmUiLCAiVGltZSBSZW1h aW5pbmciLCAiQ3VycmVudCBUaW1lIl0uZm9yRWFjaChuYW1lID0+IHsKKyAgICAgICAgbGV0IGVs ZW1lbnRTdGF0ZSA9IHRlc3Rlci5zdGF0ZUZvckNvbnRyb2xzRWxlbWVudChuYW1lKTsKKyAgICAg ICAgdGVzdGVyLnRlc3QoYCR7bmFtZX0gaXMgdmlzaWJsZWApCisgICAgICAgICAgLnZhbHVlKGlz VmlzaWJsZShlbGVtZW50U3RhdGUpKQorICAgICAgICAgIC5pc1RydWUoKTsKKyAgICB9KTsKKyAg ICB0ZXN0ZXIuZW5kKCk7Cit9Cis8L3NjcmlwdD4KKzxwPlRoaXMgdGVzdHMgdGhhdCB0aGUgc2Ny dWJiZXIgc2hvd3Mgb24gYSBkZWZhdWx0IG1lZGlhIGVsZW1lbnQuPC9wPgorPHA+VGhpcyB0ZXN0 IG9ubHkgcnVucyBpbiBEUlQhPC9wPgorPHZpZGVvIG5hbWU9Im1lZGlhIiBjb250cm9scyBhdXRv cGxheSBzdHlsZT0id2lkdGg6MzAwcHggIWltcG9ydGFudDsiPjwvdmlkZW8+Cg==