159660 2016-07-11 18:37:43 -0700 Web Inspector: ProfileView sometimes shows Top Functions data despite Top Functions being disabled 2016-07-11 20:30:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1209910 0 joepeck 2016-07-11 18:37:43 -0700 Summary: ProfileView sometimes shows Top Functions data despite Top Functions being disabled Steps to Reproduce: 1. Record a profile 2. Toggle Top Functions on and off 3. Toggle Inverted on and off => Suddenly displayed like Top Functions is on 1209911 1 webkit-bug-importer 2016-07-11 18:38:18 -0700 <rdar://problem/27291647> 1209912 2 283378 joepeck 2016-07-11 18:38:59 -0700 Created attachment 283378 [PATCH] Proposed Fix 1209913 3 283379 joepeck 2016-07-11 18:40:03 -0700 Created attachment 283379 [PATCH] Proposed Fix Better ChangeLog. 1209925 4 283379 commit-queue 2016-07-11 20:30:49 -0700 Comment on attachment 283379 [PATCH] Proposed Fix Clearing flags on attachment: 283379 Committed r203102: <http://trac.webkit.org/changeset/203102> 1209926 5 commit-queue 2016-07-11 20:30:53 -0700 All reviewed patches have been landed. Closing bug. 283378 2016-07-11 18:38:59 -0700 2016-07-11 18:40:03 -0700 [PATCH] Proposed Fix setting-1.patch text/plain 1962 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM2ZWY0M2YuLjI1ODdkYzUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTA3LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJvZmls ZVZpZXcgc29tZXRpbWVzIHNob3dzIFRvcCBGdW5jdGlvbnMgZGF0YSBkZXNwaXRlIFRvcCBGdW5j dGlvbnMgYmVpbmcgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTY2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjcyOTE2NDc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1NjcmlwdFByb2ZpbGVUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU2NyaXB0UHJvZmlsZVRpbWVsaW5lVmlldy5wcm90b3R5cGUuX3Byb2ZpbGVPcmll bnRhdGlvbkJ1dHRvbkNsaWNrZWQpOgorICAgICAgICBQYXNzIHRoZSB2YWx1ZSBvZiB0aGUgc2V0 dGluZywgbm90IHRoZSBzZXR0aW5nIGl0c2VsZiAod2hpY2ggd291bGQgYWx3YXlzIGJlIHRyZWF0 ZWQgYXMgdHJ1dGh5KS4KKworMjAxNi0wNy0xMSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVzZSBzZXBhcmF0ZSBmaWxlcyBm b3IgVHJlZU91dGxpbmUvVHJlZUVsZW1lbnQgYW5kIERhdGFHcmlkL0RhdGFHcmlkTm9kZQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NjU5CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Njcmlw dFByb2ZpbGVUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9TY3JpcHRQcm9maWxlVGltZWxpbmVWaWV3LmpzCmluZGV4IDJmODZjYWMuLmU3 MmQwY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NjcmlwdFByb2ZpbGVUaW1lbGluZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0UHJvZmlsZVRpbWVsaW5lVmlldy5qcwpAQCAt MTQyLDcgKzE0Miw3IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRQcm9maWxlVGltZWxpbmVWaWV3ID0g Y2xhc3MgU2NyaXB0UHJvZmlsZVRpbWVsaW5lVmlldyBleHRlbmRzCiAgICAgICAgICAgICBuZXdP cmllbnRhdGlvbiA9IFdlYkluc3BlY3Rvci5TY3JpcHRQcm9maWxlVGltZWxpbmVWaWV3LlByb2Zp bGVPcmllbnRhdGlvbi5Ub3BEb3duOwogCiAgICAgICAgIFdlYkluc3BlY3Rvci5TY3JpcHRQcm9m aWxlVGltZWxpbmVWaWV3LnByb2ZpbGVPcmllbnRhdGlvblNldHRpbmcudmFsdWUgPSBuZXdPcmll bnRhdGlvbjsKLSAgICAgICAgdGhpcy5fc2hvd1Byb2ZpbGVWaWV3Rm9yT3JpZW50YXRpb24obmV3 T3JpZW50YXRpb24sIFdlYkluc3BlY3Rvci5TY3JpcHRQcm9maWxlVGltZWxpbmVWaWV3LnByb2Zp bGVUeXBlU2V0dGluZyk7CisgICAgICAgIHRoaXMuX3Nob3dQcm9maWxlVmlld0Zvck9yaWVudGF0 aW9uKG5ld09yaWVudGF0aW9uLCBXZWJJbnNwZWN0b3IuU2NyaXB0UHJvZmlsZVRpbWVsaW5lVmll dy5wcm9maWxlVHlwZVNldHRpbmcudmFsdWUpOwogCiAgICAgICAgIHRoaXMuZGlzcGF0Y2hFdmVu dFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5Db250ZW50Vmlldy5FdmVudC5TZWxlY3Rpb25QYXRo Q29tcG9uZW50c0RpZENoYW5nZSk7CiAK 283379 2016-07-11 18:40:03 -0700 2016-07-11 20:30:49 -0700 [PATCH] Proposed Fix settings-2.patch text/plain 1920 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDM2ZWY0M2YuLjQ1MWZjN2QgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE2LTA3LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJvZmls ZVZpZXcgc29tZXRpbWVzIHNob3dzIFRvcCBGdW5jdGlvbnMgZGF0YSBkZXNwaXRlIFRvcCBGdW5j dGlvbnMgYmVpbmcgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTY2MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjcyOTE2NDc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL1NjcmlwdFByb2ZpbGVUaW1lbGluZVZpZXcuanM6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuU2NyaXB0UHJvZmlsZVRpbWVsaW5lVmlldy5wcm90b3R5cGUuX3Byb2ZpbGVPcmll bnRhdGlvbkJ1dHRvbkNsaWNrZWQpOgorICAgICAgICBQYXNzIHRoZSB2YWx1ZSBvZiB0aGUgc2V0 dGluZywgbm90IHRoZSBzZXR0aW5nIGl0c2VsZi4KKworMjAxNi0wNy0xMSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFVzZSBz ZXBhcmF0ZSBmaWxlcyBmb3IgVHJlZU91dGxpbmUvVHJlZUVsZW1lbnQgYW5kIERhdGFHcmlkL0Rh dGFHcmlkTm9kZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTU5NjU5CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1NjcmlwdFByb2ZpbGVUaW1lbGluZVZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TY3JpcHRQcm9maWxlVGltZWxpbmVWaWV3LmpzCmlu ZGV4IDJmODZjYWMuLmU3MmQwY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NjcmlwdFByb2ZpbGVUaW1lbGluZVZpZXcuanMKKysrIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2NyaXB0UHJvZmlsZVRpbWVs aW5lVmlldy5qcwpAQCAtMTQyLDcgKzE0Miw3IEBAIFdlYkluc3BlY3Rvci5TY3JpcHRQcm9maWxl VGltZWxpbmVWaWV3ID0gY2xhc3MgU2NyaXB0UHJvZmlsZVRpbWVsaW5lVmlldyBleHRlbmRzCiAg ICAgICAgICAgICBuZXdPcmllbnRhdGlvbiA9IFdlYkluc3BlY3Rvci5TY3JpcHRQcm9maWxlVGlt ZWxpbmVWaWV3LlByb2ZpbGVPcmllbnRhdGlvbi5Ub3BEb3duOwogCiAgICAgICAgIFdlYkluc3Bl Y3Rvci5TY3JpcHRQcm9maWxlVGltZWxpbmVWaWV3LnByb2ZpbGVPcmllbnRhdGlvblNldHRpbmcu dmFsdWUgPSBuZXdPcmllbnRhdGlvbjsKLSAgICAgICAgdGhpcy5fc2hvd1Byb2ZpbGVWaWV3Rm9y T3JpZW50YXRpb24obmV3T3JpZW50YXRpb24sIFdlYkluc3BlY3Rvci5TY3JpcHRQcm9maWxlVGlt ZWxpbmVWaWV3LnByb2ZpbGVUeXBlU2V0dGluZyk7CisgICAgICAgIHRoaXMuX3Nob3dQcm9maWxl Vmlld0Zvck9yaWVudGF0aW9uKG5ld09yaWVudGF0aW9uLCBXZWJJbnNwZWN0b3IuU2NyaXB0UHJv ZmlsZVRpbWVsaW5lVmlldy5wcm9maWxlVHlwZVNldHRpbmcudmFsdWUpOwogCiAgICAgICAgIHRo aXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5Db250ZW50Vmlldy5FdmVu dC5TZWxlY3Rpb25QYXRoQ29tcG9uZW50c0RpZENoYW5nZSk7CiAK