159652 2016-07-11 16:08:21 -0700 SVN.create_patch should find svn-create-patch relative to the WebKit root. 2016-07-11 17:25:54 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jmarcell webkit-unassigned adele ap commit-queue dbates ddkilzer ggaren glenn jmarcell lforschler mcatanzaro youennf oldest_to_newest 1209852 0 jmarcell 2016-07-11 16:08:21 -0700 SVN.create_patch should find svn-create-patch relative to the WebKit root. 1209853 1 283360 jmarcell 2016-07-11 16:10:10 -0700 Created attachment 283360 Patch 1209857 2 283360 dbates 2016-07-11 16:19:44 -0700 Comment on attachment 283360 Patch r=me 1209858 3 283360 dbates 2016-07-11 16:20:35 -0700 Comment on attachment 283360 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283360&action=review > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:42 > +from webkitpy.common.webkit_finder import WebKitFinder > from webkitpy.common.memoized import memoized > from webkitpy.common.system.executive import Executive, ScriptError > from webkitpy.common.config.urls import svn_server_host, svn_server_realm Please sort these imports with respect to the UNIX sort command. 1209892 4 jmarcell 2016-07-11 17:25:54 -0700 Landed: https://trac.webkit.org/changeset/203095 283360 2016-07-11 16:10:10 -0700 2016-07-11 16:19:44 -0700 Patch bug-159652-20160711160929.patch text/plain 1959 jmarcell U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMDY3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWZmNTVlMjdlMDA1ZDYwYmY5NzY1MGM5MDRmYzY0OTgz YzQ5NTNmMy4uMWQyNjU1MzFkNWNiODM2YTY0OWJjZWU3Y2ZlNTY4ZjUxZjBlZWFiNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTA3LTExICBKYXNvbiBNYXJjZWxsICA8am1hcmNlbGxAYXBwbGUuY29tPgorCisg ICAgICAgIFNWTi5jcmVhdGVfcGF0Y2ggc2hvdWxkIGZpbmQgc3ZuLWNyZWF0ZS1wYXRjaCByZWxh dGl2ZSB0byB0aGUgV2ViS2l0IHJvb3QuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNTk2NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9z dm4ucHk6CisgICAgICAgIChTVk4uY3JlYXRlX3BhdGNoKTogVXNlIFdlYktpdEZpbmRlciB0byBm aW5kIHRoZSBXZWJLaXQgY2hlY2tvdXQgc28gdGhhdCB3ZSBjYW4gZmluZCBzdm4tY3JlYXRlLXBh dGNoIHJlbGF0aXZlIHRvIGl0LgorCiAyMDE2LTA3LTExICBNYXJrIExhbSAgPG1hcmsubGFtQGFw cGxlLmNvbT4KIAogICAgICAgICBDaGFuZ2UgcnVuLXdlYmtpdC10ZXN0cy5weSBhbmQgcnVuLWpz Yy1zdHJlc3MtdGVzdHMgdG8gdXNlIGEgc21hbGxlciBKUyBzdGFjayBzaXplIGZvciB0ZXN0aW5n LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2Nt L3N2bi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS9zdm4u cHkKaW5kZXggOGIyMWE3NDk3OWMzOWQ2YzFlMmYxNzg0ZTJjNDc2NGFkZDQ1NTgzYy4uMjM1NmYw YjBjYWE4ODNmNmQ1NjI4YjhmOGIxM2Q3NzkzNGRiZDA4YyAxMDA2NDQKLS0tIGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtL3N2bi5weQorKysgYi9Ub29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20vc3ZuLnB5CkBAIC0zNiw2ICszNiw3IEBA IGltcG9ydCBzdHJpbmcKIGltcG9ydCBzeXMKIGltcG9ydCB0ZW1wZmlsZQogCitmcm9tIHdlYmtp dHB5LmNvbW1vbi53ZWJraXRfZmluZGVyIGltcG9ydCBXZWJLaXRGaW5kZXIKIGZyb20gd2Via2l0 cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXplZAogZnJvbSB3ZWJraXRweS5jb21tb24u c3lzdGVtLmV4ZWN1dGl2ZSBpbXBvcnQgRXhlY3V0aXZlLCBTY3JpcHRFcnJvcgogZnJvbSB3ZWJr aXRweS5jb21tb24uY29uZmlnLnVybHMgaW1wb3J0IHN2bl9zZXJ2ZXJfaG9zdCwgc3ZuX3NlcnZl cl9yZWFsbQpAQCAtMjc5LDcgKzI4MCw3IEBAIGNsYXNzIFNWTihTQ00sIFNWTlJlcG9zaXRvcnkp OgogICAgICAgICAgICAgcmV0dXJuICIiCiAgICAgICAgIGVsaWYgY2hhbmdlZF9maWxlcyA9PSBO b25lOgogICAgICAgICAgICAgY2hhbmdlZF9maWxlcyA9IFtdCi0gICAgICAgIHNjcmlwdF9wYXRo ID0gc2VsZi5fZmlsZXN5c3RlbS5qb2luKHNlbGYuY2hlY2tvdXRfcm9vdCwgIlRvb2xzIiwgIlNj cmlwdHMiLCAic3ZuLWNyZWF0ZS1wYXRjaCIpCisgICAgICAgIHNjcmlwdF9wYXRoID0gV2ViS2l0 RmluZGVyKHNlbGYuX2ZpbGVzeXN0ZW0pLnBhdGhfZnJvbV93ZWJraXRfYmFzZSgiVG9vbHMiLCAi U2NyaXB0cyIsICJzdm4tY3JlYXRlLXBhdGNoIikKICAgICAgICAgcmV0dXJuIHNlbGYucnVuKFtz Y3JpcHRfcGF0aCwgIi0tbm8tc3R5bGUiXSArIGNoYW5nZWRfZmlsZXMsCiAgICAgICAgICAgICBj d2Q9c2VsZi5jaGVja291dF9yb290LCByZXR1cm5fc3RkZXJyPUZhbHNlLAogICAgICAgICAgICAg ZGVjb2RlX291dHB1dD1GYWxzZSkK