<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>159645</bug_id>
          
          <creation_ts>2016-07-11 14:44:06 -0700</creation_ts>
          <short_desc>Array.prototype.splice is wrong w.r.t ES6 spec</short_desc>
          <delta_ts>2017-05-03 16:27:12 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>171591</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Saam Barati">saam</reporter>
          <assigned_to name="Saam Barati">saam</assigned_to>
          <cc>benjamin</cc>
    
    <cc>fpizlo</cc>
    
    <cc>ggaren</cc>
    
    <cc>gskachkov</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>oliver</cc>
    
    <cc>sukolsak</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1209814</commentid>
    <comment_count>0</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2016-07-11 14:44:06 -0700</bug_when>
    <thetext>Specifically, this code is wrong:
```
            for (unsigned k = 0; k &lt; deleteCount; ++k) {
                JSValue v = getProperty(exec, thisObj, k + begin);
                if (UNLIKELY(vm.exception()))
                    return JSValue::encode(jsUndefined());
                if (!v)
                    continue;
                result-&gt;putByIndexInline(exec, k, v, true);
                if (UNLIKELY(vm.exception()))
                    return JSValue::encode(jsUndefined());
            }
```
We should be calling defineOwnProperty.
See spec:
https://tc39.github.io/ecma262/#sec-array.prototype.splice
and
https://tc39.github.io/ecma262/#sec-createdatapropertyorthrow</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1304361</commentid>
    <comment_count>1</comment_count>
    <who name="Saam Barati">saam</who>
    <bug_when>2017-05-03 16:27:12 -0700</bug_when>
    <thetext>

*** This bug has been marked as a duplicate of bug 171591 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>