159641 2016-07-11 12:59:00 -0700 some paths in Array.prototype.splice don't account for the array not having certain indexed properties 2016-07-11 15:09:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov keith_miller mark.lam msaboff oliver sukolsak webkit-bug-importer ysuzuki oldest_to_newest 1209760 0 saam 2016-07-11 12:59:00 -0700 ... 1209761 1 saam 2016-07-11 12:59:33 -0700 <rdar://problem/27171999> 1209817 2 283348 saam 2016-07-11 14:47:37 -0700 Created attachment 283348 patch 1209823 3 saam 2016-07-11 15:09:47 -0700 landed in: https://trac.webkit.org/changeset/203087 283348 2016-07-11 14:47:37 -0700 2016-07-11 14:49:37 -0700 patch a-backup.diff text/plain 4483 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzMDg0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBA CisyMDE2LTA3LTExICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IHNvbWUgcGF0aHMgaW4gQXJyYXkucHJvdG90eXBlLnNwbGljZSBkb24ndCBhY2NvdW50IGZvciB0 aGUgYXJyYXkgbm90IGhhdmluZyBjZXJ0YWluIGluZGV4ZWQgcHJvcGVydGllcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NjQxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8yNzE3MTk5OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBcnJheS5wcm90b3R5cGUuc3BsaWNlIHdhcyBpbmNvcnJlY3RseSBw dXR0aW5nIHByb3BlcnRpZXMgb24KKyAgICAgICAgdGhlIHJlc3VsdCBhcnJheSBldmVuIGlmIHRo ZSB8dGhpc3wgYXJyYXkgZGlkbid0IGhhdmUgdGhvc2UKKyAgICAgICAgcHJvcGVydGllcy4gVGhp cyBpcyBub3QgdGhlIGJlaGF2aW9yIG9mIHRoZSBzcGVjLiBIb3dldmVyLCB0aGlzCisgICAgICAg IGNvdWxkIGFsc28gY2F1c2UgYSBjcmFzaCBiZWNhdXNlIHdlIGNhbiBjb25zdHJ1Y3QgYSBwcm9n cmFtIHdoZXJlCisgICAgICAgIHdlIHdvdWxkIHB1dEJ5SW5kZXggb24gYSB0eXBlZCBhcnJheSB3 aGVyZSB0aGUgdmFsdWUgd2UgYXJlCisgICAgICAgIHB1dHRpbmcgaXMgSlNWYWx1ZSgpLiBUaGlz IGlzIGJhZCBiZWNhdXNlIHRoZSB0eXBlZCBhcnJheSB3aWxsCisgICAgICAgIHRyeSB0byBjb252 ZXJ0IEpTVmFsdWUoKSBpbnRvIGFuIGludGVnZXIuCisKKyAgICAgICAgKiBydW50aW1lL0FycmF5 UHJvdG90eXBlLmNwcDoKKyAgICAgICAgKEpTQzo6YXJyYXlQcm90b0Z1bmNTcGxpY2UpOgorICAg ICAgICAqIHRlc3RzL3N0cmVzcy9hcnJheS1wcm90b3R5cGUtc3BsaWNlLW1ha2luZy10eXBlZC1h cnJheS5qczogQWRkZWQuCisgICAgICAgIChhc3NlcnQpOgorICAgICAgICAodGVzdCk6CisKIDIw MTYtMDctMTEgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZmFj dG9yIEpTU3RhY2sgdG8gb25seSBiZSB0aGUgc3RhY2sgZGF0YSBzdHJ1Y3R1cmUgZm9yIHRoZSBD IExvb3AuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlw ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvQXJyYXlQ cm90b3R5cGUuY3BwCShyZXZpc2lvbiAyMDMwNzQpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg4NSw2ICs4ODUs OCBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIGFycmF5UHJvdG9GCiAgICAgICAgICAg ICAgICAgSlNWYWx1ZSB2ID0gZ2V0UHJvcGVydHkoZXhlYywgdGhpc09iaiwgayArIGJlZ2luKTsK ICAgICAgICAgICAgICAgICBpZiAoVU5MSUtFTFkodm0uZXhjZXB0aW9uKCkpKQogICAgICAgICAg ICAgICAgICAgICByZXR1cm4gSlNWYWx1ZTo6ZW5jb2RlKGpzVW5kZWZpbmVkKCkpOworICAgICAg ICAgICAgICAgIGlmICghdikKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CiAgICAgICAg ICAgICAgICAgcmVzdWx0LT5wdXRCeUluZGV4SW5saW5lKGV4ZWMsIGssIHYsIHRydWUpOwogICAg ICAgICAgICAgICAgIGlmIChVTkxJS0VMWSh2bS5leGNlcHRpb24oKSkpCiAgICAgICAgICAgICAg ICAgICAgIHJldHVybiBKU1ZhbHVlOjplbmNvZGUoanNVbmRlZmluZWQoKSk7CkBAIC04OTgsNiAr OTAwLDggQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvRgogICAgICAg ICAgICAgICAgIEpTVmFsdWUgdiA9IGdldFByb3BlcnR5KGV4ZWMsIHRoaXNPYmosIGsgKyBiZWdp bik7CiAgICAgICAgICAgICAgICAgaWYgKFVOTElLRUxZKHZtLmV4Y2VwdGlvbigpKSkKICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1VuZGVmaW5lZCgpKTsKKyAg ICAgICAgICAgICAgICBpZiAoIXYpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAg ICAgICAgICAgICAgIHJlc3VsdC0+aW5pdGlhbGl6ZUluZGV4KHZtLCBrLCB2KTsKICAgICAgICAg ICAgIH0KICAgICAgICAgfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVz cy9hcnJheS1wcm90b3R5cGUtc3BsaWNlLW1ha2luZy10eXBlZC1hcnJheS5qcwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2FycmF5LXByb3RvdHlwZS1z cGxpY2UtbWFraW5nLXR5cGVkLWFycmF5LmpzCShub25leGlzdGVudCkKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS90ZXN0cy9zdHJlc3MvYXJyYXktcHJvdG90eXBlLXNwbGljZS1tYWtpbmctdHlw ZWQtYXJyYXkuanMJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw2MCBAQAorZnVuY3Rpb24gYXNz ZXJ0KGIpIHsKKyAgICBpZiAoIWIpCisgICAgICAgIHRocm93IG5ldyBFcnJvcigiQmFkIGFzc2Vy dGlvbiEiKQorfQorCitmdW5jdGlvbiB0ZXN0KGYsIG4gPSA0KSB7CisgICAgZm9yIChsZXQgaSA9 IDA7IGkgPCBuOyBpKyspCisgICAgICAgIGYoKTsKK30KKwordGVzdChmdW5jdGlvbigpIHsKKyAg ICAvLyBUaGlzIHNob3VsZCBub3QgY3Jhc2guCisKKyAgICAvLyBGSVhNRTogdGhpcyBtaWdodCBu ZWVkIHRvIGJlIHVwZGF0ZWQgYXMgd2UgbWFrZSBvdXIgc3BsaWNlIGltcGxlbWVudGF0aW9uCisg ICAgLy8gbW9yZSBFUzYgY29tcGxpYW50OiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTU5NjQ1CisgICAgbGV0IHggPSBbMSwyLDMsNCw1XTsKKyAgICB4LmNvbnN0cnVj dG9yID0gVWludDhBcnJheTsKKyAgICBkZWxldGUgeFsyXTsKKyAgICBhc3NlcnQoISgyIGluIHgp KTsKKyAgICBsZXQgcmVtb3ZlZCA9IHguc3BsaWNlKDEsMyk7CisgICAgYXNzZXJ0KHJlbW92ZWQg aW5zdGFuY2VvZiBVaW50OEFycmF5KTsKKyAgICBhc3NlcnQocmVtb3ZlZC5sZW5ndGggPT09IDMp OworICAgIGFzc2VydChyZW1vdmVkWzBdID09PSAyKTsKKyAgICBhc3NlcnQocmVtb3ZlZFsxXSA9 PT0gMCk7CisgICAgYXNzZXJ0KHJlbW92ZWRbMl0gPT09IDQpOworCisgICAgYXNzZXJ0KHggaW5z dGFuY2VvZiBBcnJheSk7CisgICAgYXNzZXJ0KHgubGVuZ3RoID09PSAyKTsKKyAgICBhc3NlcnQo eFswXSA9PT0gMSk7CisgICAgYXNzZXJ0KHhbMV0gPT09IDUpOworfSk7CisKK3Rlc3QoZnVuY3Rp b24oKSB7CisgICAgbGV0IHggPSBbMSwyLDMsNCw1XTsKKyAgICB4LmNvbnN0cnVjdG9yID0gVWlu dDhBcnJheTsKKyAgICBkZWxldGUgeFsyXTsKKyAgICBhc3NlcnQoISgyIGluIHgpKTsKKyAgICBP YmplY3QuZGVmaW5lUHJvcGVydHkoVWludDhBcnJheSwgU3ltYm9sLnNwZWNpZXMsIHt2YWx1ZTog bnVsbH0pOworICAgIGFzc2VydChVaW50OEFycmF5W1N5bWJvbC5zcGVjaWVzXSA9PT0gbnVsbCk7 CisgICAgeCA9IG5ldyBQcm94eSh4LCB7CisgICAgICAgIGdldCh0YXJnZXQsIHByb3BlcnR5LCBy ZWNlaXZlcikgeworICAgICAgICAgICAgaWYgKHBhcnNlSW50KHByb3BlcnR5LCAxMCkpCisgICAg ICAgICAgICAgICAgYXNzZXJ0KHByb3BlcnR5ICE9PSAiMiIpOworICAgICAgICAgICAgcmV0dXJu IFJlZmxlY3QuZ2V0KHRhcmdldCwgcHJvcGVydHksIHJlY2VpdmVyKTsKKyAgICAgICAgfQorICAg IH0pOworCisgICAgbGV0IHJlbW92ZWQgPSB4LnNwbGljZSgxLDMpOworICAgIGFzc2VydChyZW1v dmVkIGluc3RhbmNlb2YgQXJyYXkpOyAvLyBXZSBzaG91bGRuJ3QgbWFrZSBhIFR5cGVkQXJyYXkg aGVyZSBiZWNhdXNlIFN5bWJvbC5zcGVjaWVzIGlzIG51bGwuCisgICAgYXNzZXJ0KHJlbW92ZWQu bGVuZ3RoID09PSAzKTsKKyAgICBhc3NlcnQocmVtb3ZlZFswXSA9PT0gMik7CisgICAgYXNzZXJ0 KHJlbW92ZWRbMV0gPT09IHVuZGVmaW5lZCk7CisgICAgYXNzZXJ0KCEoMSBpbiByZW1vdmVkKSk7 CisgICAgYXNzZXJ0KHJlbW92ZWRbMl0gPT09IDQpOworCisgICAgYXNzZXJ0KHggaW5zdGFuY2Vv ZiBBcnJheSk7CisgICAgYXNzZXJ0KHgubGVuZ3RoID09PSAyKTsKKyAgICBhc3NlcnQoeFswXSA9 PT0gMSk7CisgICAgYXNzZXJ0KHhbMV0gPT09IDUpOworfSk7Cg==