159621 2016-07-11 07:04:49 -0700 Red and blue colors are swapped in video rendered through WebGL when GSTREAMER_GL is enabled 2016-09-22 05:57:50 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 159673 1 olivier.blin webkit-unassigned bugs-noreply commit-queue mcatanzaro pnormand yoon zan oldest_to_newest 1209632 0 olivier.blin 2016-07-11 07:04:49 -0700 When a video is rendered through WebGL, and GSTREAMER_GL is enabled, red and blue colors are swapped. This occurs for example with the following videos: http://www.scirra.com/labs/bugs/webglvideo/ http://www.dailymotion.com/embed/video/x4jiicp?autoplay=1 This seems to be because ImageGStreamerCairo expects video frames in either BGRA or ARGB, while when GSTREAMER_GL is enabled, createVideoSinkGL() forces a RGBA format. Without GSTREAMER_GL, the rendering is fine since VideoSinkGStreamer uses either BGRA or ARGB. 1209634 1 283315 olivier.blin 2016-07-11 07:09:14 -0700 Created attachment 283315 Patch 1209636 2 olivier.blin 2016-07-11 07:10:02 -0700 This patch fixes the issue for me, but I am not sure if this can cause performance regression. 1209653 3 283315 commit-queue 2016-07-11 07:45:18 -0700 Comment on attachment 283315 Patch Clearing flags on attachment: 283315 Committed r203059: <http://trac.webkit.org/changeset/203059> 1209654 4 commit-queue 2016-07-11 07:45:22 -0700 All reviewed patches have been landed. Closing bug. 1209665 5 olivier.blin 2016-07-11 08:56:05 -0700 Reopening to attach new patch. 1209666 6 283318 olivier.blin 2016-07-11 08:56:09 -0700 Created attachment 283318 Patch 1209670 7 pnormand 2016-07-11 09:04:54 -0700 What does this patch have to do with this bug? :) 1209671 8 283318 olivier.blin 2016-07-11 09:05:02 -0700 Comment on attachment 283318 Patch Wrong bug, sorry 1210001 9 commit-queue 2016-07-12 06:02:12 -0700 Re-opened since this is blocked by bug 159673 1232412 10 olivier.blin 2016-09-22 05:57:50 -0700 Fixed now that GPU-GPU WebGL video integration has landed, see bug 159928 283315 2016-07-11 07:09:14 -0700 2016-07-11 08:55:56 -0700 Patch bug-159621-20160711160832.patch text/plain 2799 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDc1ODFhNzc4MzdmNzI3 YjA4NDQzMGEwOWI1OGY3ZGIxNjAxZjM5Yy4uN2Q1MDg0MmEzZmZjNTBmNzJlZjU5NjM5NWRhNTM0 YWM4ZDA3NGNkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE2LTA3LTExICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgUmVkIGFu ZCBibHVlIGNvbG9ycyBhcmUgc3dhcHBlZCBpbiB2aWRlbyByZW5kZXJlZCB0aHJvdWdoIFdlYkdM IHdoZW4gR1NUUkVBTUVSX0dMIGlzIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTYyMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYSB2aWRlbyBpcyByZW5kZXJlZCB0aHJvdWdoIFdl YkdMLCBhbmQgR1NUUkVBTUVSX0dMIGlzIGVuYWJsZWQsIHJlZCBhbmQgYmx1ZSBjb2xvcnMgYXJl IHN3YXBwZWQuCisgICAgICAgIFRoaXMgb2NjdXJzIGZvciBleGFtcGxlIHdpdGggdGhlIGZvbGxv d2luZyB2aWRlb3M6CisgICAgICAgIGh0dHA6Ly93d3cuc2NpcnJhLmNvbS9sYWJzL2J1Z3Mvd2Vi Z2x2aWRlby8KKyAgICAgICAgaHR0cDovL3d3dy5kYWlseW1vdGlvbi5jb20vZW1iZWQvdmlkZW8v eDRqaWljcD9hdXRvcGxheT0xCisKKyAgICAgICAgVGhpcyBpcyBiZWNhdXNlIEltYWdlR1N0cmVh bWVyQ2Fpcm8gZXhwZWN0cyB2aWRlbyBmcmFtZXMgaW4gZWl0aGVyCisgICAgICAgIEJHUkEgb3Ig QVJHQiwgd2hpbGUgd2hlbiBHU1RSRUFNRVJfR0wgaXMgZW5hYmxlZCwKKyAgICAgICAgY3JlYXRl VmlkZW9TaW5rR0woKSBmb3JjZXMgYSBSR0JBIGZvcm1hdC4KKworICAgICAgICBXaXRob3V0IEdT VFJFQU1FUl9HTCwgdGhlIHJlbmRlcmluZyBpcyBmaW5lIHNpbmNlCisgICAgICAgIFZpZGVvU2lu a0dTdHJlYW1lciB1c2VzIGVpdGhlciBCR1JBIG9yIEFSR0IuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlOjpjcmVh dGVWaWRlb1NpbmtHTCk6CisKIDIwMTYtMDctMDggIE5hZWwgT3VlZHJhb2dvICA8bmFlbC5vdWVk cmFvZ29AY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIEV4ZWNTdGF0ZSBzaG91bGQgYmUgcGFzc2Vk IGJ5IHJlZmVyZW5jZSBpbiBKUyBiaW5kaW5ncyBnZW5lcmF0b3IgZm9yIGN1c3RvbSBjb25zdHJ1 Y3RvcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJC YXNlLmNwcAppbmRleCBlZDU2OGFjNzAwYTFjZmFhODEyZWU3Y2U4ZTg3ZGU3MmEyZWZiZmM2Li4z NWU4Nzg0M2FhZTAyMGQ2ZjAzMmFiYzE4ZTRiYjY4YTgyNGYyYzY4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyQmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCkBAIC04NSw2ICs4 NSwxMiBAQAogI2luY2x1ZGUgPGNhaXJvLWdsLmg+CiAjZW5kaWYKIAorI2lmIEdfQllURV9PUkRF UiA9PSBHX0xJVFRMRV9FTkRJQU4KKyNkZWZpbmUgR1NUX0dMX0NBUFNfRk9STUFUICJCR1JBIgor I2Vsc2UKKyNkZWZpbmUgR1NUX0dMX0NBUFNfRk9STUFUICJBUkdCIgorI2VuZGlmCisKIEdTVF9E RUJVR19DQVRFR09SWSh3ZWJraXRfbWVkaWFfcGxheWVyX2RlYnVnKTsKICNkZWZpbmUgR1NUX0NB VF9ERUZBVUxUIHdlYmtpdF9tZWRpYV9wbGF5ZXJfZGVidWcKIApAQCAtODI3LDcgKzgzMyw3IEBA IEdzdEVsZW1lbnQqIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OmNyZWF0ZVZpZGVv U2lua0dMKCkKIAogICAgIGdzdF9iaW5fYWRkX21hbnkoR1NUX0JJTih2aWRlb1NpbmspLCB1cGxv YWQsIGNvbG9yY29udmVydCwgYXBwc2luaywgbnVsbHB0cik7CiAKLSAgICBHUmVmUHRyPEdzdENh cHM+IGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2NhcHNfZnJvbV9zdHJpbmcoInZpZGVvL3gtcmF3KCIg R1NUX0NBUFNfRkVBVFVSRV9NRU1PUllfR0xfTUVNT1JZICIpLCBmb3JtYXQgPSAoc3RyaW5nKSB7 IFJHQkEgfSIpKTsKKyAgICBHUmVmUHRyPEdzdENhcHM+IGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2Nh cHNfZnJvbV9zdHJpbmcoInZpZGVvL3gtcmF3KCIgR1NUX0NBUFNfRkVBVFVSRV9NRU1PUllfR0xf TUVNT1JZICIpLCBmb3JtYXQgPSAoc3RyaW5nKSB7ICIgR1NUX0dMX0NBUFNfRk9STUFUICIgfSIp KTsKIAogICAgIHJlc3VsdCAmPSBnc3RfZWxlbWVudF9saW5rX3BhZHModXBsb2FkLCAic3JjIiwg Y29sb3Jjb252ZXJ0LCAic2luayIpOwogICAgIHJlc3VsdCAmPSBnc3RfZWxlbWVudF9saW5rX3Bh ZHNfZmlsdGVyZWQoY29sb3Jjb252ZXJ0LCAic3JjIiwgYXBwc2luaywgInNpbmsiLCBjYXBzLmdl dCgpKTsK 283318 2016-07-11 08:56:09 -0700 2016-07-11 09:05:02 -0700 Patch bug-159621-20160711175528.patch text/plain 3220 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWMzMzA2MWYyY2RhMGYzZTM0NjUyMGU5YTAzZDZiNDZl Mzg2OWVkNy4uMTdhOWE2MGQ1OTc3M2JkZWFjYjE2YjAzMWQyOTVlNjg5NTVlYjE2MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDE2LTA3LTExICBPbGl2aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5j b20+CisKKyAgICAgICAgU3lzdGVtIHByb3h5IHNldHRpbmdzIG5vdCB1c2VkIHdoZW4gYnVpbGRp bmcgZGVwcyB3aXRoIGpoYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTU2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgYWRkcyB0aGUgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXZl bCBidWlsZCBkZXAgdG8gZW5hYmxlCisgICAgICAgIHRoZSBsaWJnaW9nbm9tZXByb3h5LnNvIGdp byBtb2R1bGUgaW4gZ2xpYi1uZXR3b3JraW5nLCB3aGljaCB1c2VzCisgICAgICAgIEdTZXR0aW5n cyBvbiBvcmcuZ25vbWUuc3lzdGVtLnByb3h5LgorICAgICAgICBUaGlzIGlzIG5lZWRlZCB0byBx dWVyeSBzeXN0ZW0gcHJveHkgc2V0dGluZ3MgZm9yIEdub21lIGRlc2t0b3BzLgorCisgICAgICAg IGRjb25mIGNhbiBiZSBtYW51YWxseSBhZGRlZCB0byBqaGJ1aWxkIHRvIGJ1aWxkIHRoZQorICAg ICAgICBsaWJkY29uZnNldHRpbmdzLnNvIGdpbyBtb2R1bGUgZm9yIEdTZXR0aW5ncywgc28gdGhh dAorICAgICAgICBsaWJnaW9nbm9tZXByb3h5LnNvIGNhbiBhY2Nlc3Mgc3lzdGVtIHNldHRpbmdz LgorICAgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvV2ViS2l0R1RLL1N0YXJ0 SGFja2luZyNXb3JraW5nYmVoaW5kYXByb3h5CisKKyAgICAgICAgQXMgYW4gYWx0ZXJuYXRpdmUg dG8gZGNvbmYgc2V0dGluZ3MsIHRoaXMgY29tbWl0IGFsc28gYWRkcyB0aGUKKyAgICAgICAgbGli cHJveHktZGV2ZWwgYnVpbGQgZGVwIHRvIGVuYWJsZSB0aGUgbGliZ2lvbGlicHJveHkuc28gbW9k dWxlIGluCisgICAgICAgIGdsaWItbmV0d29ya2luZyAoc3VnZ2VzdGVkIGJ5IEZ1amlpIEhpcm9u b3JpKS4KKworICAgICAgICBJdCBpcyB1c2VmdWwgdG8gcmVhZCBwcm94eSBzZXR0aW5ncyBmcm9t IGVudmlyb25tZW50IHZhcmlhYmxlcy4KKyAgICAgICAgRnJvbSBhIEdub21lIGRlc2t0b3AsIG9u ZSBtYXkgdW5zZXQgdGhlIEdOT01FX0RFU0tUT1BfU0VTU0lPTl9JRAorICAgICAgICBlbnZpcm9u bWVudCB2YXJpYWJsZSB0byBmb3JjZSB1c2luZyB0aGUgZW52dmFyIG1vZHVsZSBpbiBsaWJwcm94 eS4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKwogMjAxNi0wNy0wOCAg S29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAgICAgICAgUmVtb3Zl ZCBRdCBsZWZ0b3ZlcnMgZnJvbSBUb29scy4KZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9pbnN0YWxs LWRlcGVuZGVuY2llcyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCAwZjU5 ODUwOWJkOWYyMTcyM2I1MzZiZTE4OWE1YjQ3YzQxN2FmMGQ3Li4zMjdiYTcwZDZjODNhMDViOTFj NDZkYjBjYjdhNDAyMzc0MTdiZWRlIDEwMDc1NQotLS0gYS9Ub29scy9ndGsvaW5zdGFsbC1kZXBl bmRlbmNpZXMKKysrIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCkBAIC0xNTAsNiAr MTUwLDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAgIHBhY2th Z2VzPSIkcGFja2FnZXMgXAogICAgICAgICBnaXQgXAogICAgICAgICBnb2JqZWN0LWludHJvc3Bl Y3Rpb24gXAorICAgICAgICBnc2V0dGluZ3MtZGVza3RvcC1zY2hlbWFzLWRldiBcCiAgICAgICAg IGljb24tbmFtaW5nLXV0aWxzIFwKICAgICAgICAgbGliY3JvY28zLWRldiBcCiAgICAgICAgIGxp YmRybS1kZXYgXApAQCAtMTY3LDYgKzE2OCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNp ZXNXaXRoQXB0IHsKICAgICAgICAgbGlib3JjLTAuNC1kZXYgXAogICAgICAgICBsaWJwMTEta2l0 LWRldiBcCiAgICAgICAgIGxpYnBjaWFjY2Vzcy1kZXYgXAorICAgICAgICBsaWJwcm94eS1kZXYg XAogICAgICAgICBsaWJzc2wtZGV2IFwKICAgICAgICAgbGlidGlmZjUtZGV2IFwKICAgICAgICAg bGlidjRsLWRldiBcCkBAIC0zMDIsNiArMzA0LDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVu Y2llc1dpdGhQYWNtYW4gewogICAgICAgICBleHBhdCBcCiAgICAgICAgIGdpdCBcCiAgICAgICAg IGdvYmplY3QtaW50cm9zcGVjdGlvbiBcCisgICAgICAgIGdzZXR0aW5ncy1kZXNrdG9wLXNjaGVt YXMgXAogICAgICAgICBpY29uLW5hbWluZy11dGlscyBcCiAgICAgICAgIGxpYmNyb2NvIFwKICAg ICAgICAgbGliZHJtIFwKQEAgLTMxMiw2ICszMTUsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5k ZW5jaWVzV2l0aFBhY21hbiB7CiAgICAgICAgIGxpYmlucHV0IFwKICAgICAgICAgcDExLWtpdCBc CiAgICAgICAgIGxpYnBjaWFjY2VzcyBcCisgICAgICAgIGxpYnByb3h5IFwKICAgICAgICAgbGli dGlmZiBcCiAgICAgICAgIGxpYnhmaXhlcyBcCiAgICAgICAgIGxpYnhmb250IFwKQEAgLTQyOCw2 ICs0MzIsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aERuZiB7CiAgICAgICAg IGRvY2Jvb2stdXRpbHMtcGRmIFwKICAgICAgICAgZ2l0IFwKICAgICAgICAgZ29iamVjdC1pbnRy b3NwZWN0aW9uIFwKKyAgICAgICAgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXZlbCBcCiAg ICAgICAgIGljb24tbmFtaW5nLXV0aWxzIFwKICAgICAgICAgaXRzdG9vbCBcCiAgICAgICAgIGxp Ylhmb250LWRldmVsIFwKQEAgLTQ0MCw2ICs0NDUsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5k ZW5jaWVzV2l0aERuZiB7CiAgICAgICAgIGxpYmlucHV0LWRldmVsIFwKICAgICAgICAgbGlicDEx LWRldmVsIFwKICAgICAgICAgbGlicGNpYWNjZXNzLWRldmVsIFwKKyAgICAgICAgbGlicHJveHkt ZGV2ZWwgXAogICAgICAgICBsaWJ0aWZmLWRldmVsIFwKICAgICAgICAgbGlieGNiLWRldmVsIFwK ICAgICAgICAgbGlieGtiZmlsZS1kZXZlbCBcCg==