159615 2016-07-10 22:43:32 -0700 [ES6] Promise.{all,race} no longer use @@species 2016-07-11 00:27:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki benjamin fpizlo ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1209592 0 ysuzuki 2016-07-10 22:43:32 -0700 [ES6] Promise.{all,race} no longer use @@species 1209593 1 283300 ysuzuki 2016-07-10 22:51:37 -0700 Created attachment 283300 Patch 1209594 2 283300 keith_miller 2016-07-10 23:02:52 -0700 Comment on attachment 283300 Patch r=me. I'm curious what the reasoning behind dropping @@species support was. 1209598 3 ysuzuki 2016-07-11 00:09:57 -0700 (In reply to comment #2) > Comment on attachment 283300 [details] > Patch > > r=me. I'm curious what the reasoning behind dropping @@species support was. https://github.com/tc39/ecma262/issues/151 https://esdiscuss.org/topic/resolve-reject-on-promise-subclasses-and-species#content-1 https://esdiscuss.org/topic/subclassing-es6-objects-with-es5-syntax#content-50 > Overall consistency in the language. Except for the two offending Promise static methods, all uses of @@species in the ES2015 spec (15 uses) are for the following pattern: Starting from one instance, one constructs a derived object for that instance. (The effective lookup of the @@species property is factored in the SpiecesConstructor and ArraySpeciesCreate abstract operations.) > > Also, in static methods like Promise.all and Promise.race, a constructor is explicitly provided by the user: simply use it. Compare with what is done for arrays: Seems that Promise.{resolve,reject,all,race} static functions are a factory function while Array#map etc. is an instance method. 1209599 4 ysuzuki 2016-07-11 00:10:40 -0700 (In reply to comment #3) In the above comment, this is the quoted part from the es-discuss :) > > Overall consistency in the language. Except for the two offending Promise static methods, all uses of @@species in the ES2015 spec (15 uses) are for the following pattern: Starting from one instance, one constructs a derived object for that instance. (The effective lookup of the @@species property is factored in the SpiecesConstructor and ArraySpeciesCreate abstract operations.) > > > > Also, in static methods like Promise.all and Promise.race, a constructor is explicitly provided by the user: simply use it. Compare with what is done for arrays: 1209602 5 ysuzuki 2016-07-11 00:27:21 -0700 Committed r203052: <http://trac.webkit.org/changeset/203052> 283300 2016-07-10 22:51:37 -0700 2016-07-10 23:02:52 -0700 Patch bug-159615-20160711145056.patch text/plain 3616 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjAzMDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi MjhkMTlmYzY1YTc1ZjdlZTY0ZTQ1OTA4MmE5OTIwNzkyZDY5MzUyLi4xMzJmM2Q3ZjM0YTZkOWRm ZjFhMDA0NjhjMmQ2OTIyMTIyYjMwMjlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wNy0xMCAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbRVM2XSBQcm9taXNlLnthbGwscmFjZX0gbm8gbG9uZ2VyIHVzZSBA QHNwZWNpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1OTYxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFzIHBlciB0aGUgbGF0ZXN0IEVTIGRyYWZ0LCBQcm9taXNlLnthbGwscmFjZX0gbm8gbG9uZ2Vy IHVzZSBAQHNwZWNpZXMuCisgICAgICAgIFNvLCB0aGlzIHBhdGNoIGRyb3BzIEZJWE1Fcy4KKwor ICAgICAgICAqIGJ1aWx0aW5zL1Byb21pc2VDb25zdHJ1Y3Rvci5qczoKKyAgICAgICAgKGFsbCk6 CisgICAgICAgIChyYWNlKToKKyAgICAgICAgKiB0ZXN0cy9zdHJlc3MvaWdub3JlLXByb21pc2Ut c3BlY2llcy5qczogQWRkZWQuCisgICAgICAgIChzaG91bGRCZSk6CisgICAgICAgIChEZXJpdmVk UHJvbWlzZS5wcm90b3R5cGUuZ2V0IFN5bWJvbCk6CisgICAgICAgIChEZXJpdmVkUHJvbWlzZSk6 CisKIDIwMTYtMDctMTAgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMDMwMzcuCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnVpbHRpbnMvUHJvbWlzZUNvbnN0cnVjdG9yLmpzIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL2J1aWx0aW5zL1Byb21pc2VDb25zdHJ1Y3Rvci5qcwppbmRleCA3 N2NlNTdjODMyMDI2YTMxYmZjZGQ0Yjg3MmM0YzhjNzQ1YjU0MzdjLi44Y2YxOTk5ZWNmZjI4MzE3 M2NkNzQyZThkYmM1NjRjZDgxMDZmOTdhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvYnVpbHRpbnMvUHJvbWlzZUNvbnN0cnVjdG9yLmpzCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9idWlsdGlucy9Qcm9taXNlQ29uc3RydWN0b3IuanMKQEAgLTMwLDExICszMCw3IEBAIGZ1 bmN0aW9uIGFsbChpdGVyYWJsZSkKICAgICBpZiAoIUBpc09iamVjdCh0aGlzKSkKICAgICAgICAg dGhyb3cgbmV3IEBUeXBlRXJyb3IoInx0aGlzfCBpcyBub3QgYSBvYmplY3QiKTsKIAotICAgIC8v IEZJWE1FOiBGaXggdGhpcyBjb2RlIHdoZW4gQEBzcGVjaWVzIHdlbGwta25vd24gc3ltYm9sIGlz IGxhbmRlZC4KLSAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTQ2NjI0Ci0gICAgdmFyIGNvbnN0cnVjdG9yID0gdGhpczsKLQotICAgIHZhciBwcm9taXNlQ2Fw YWJpbGl0eSA9IEBuZXdQcm9taXNlQ2FwYWJpbGl0eShjb25zdHJ1Y3Rvcik7CisgICAgdmFyIHBy b21pc2VDYXBhYmlsaXR5ID0gQG5ld1Byb21pc2VDYXBhYmlsaXR5KHRoaXMpOwogCiAgICAgdmFy IHZhbHVlcyA9IFtdOwogICAgIHZhciBpbmRleCA9IDA7CkBAIC02Miw3ICs1OCw3IEBAIGZ1bmN0 aW9uIG5ld1Jlc29sdmVFbGVtZW50KGluZGV4KQogICAgIHRyeSB7CiAgICAgICAgIGZvciAodmFy IHZhbHVlIG9mIGl0ZXJhYmxlKSB7CiAgICAgICAgICAgICBAcHV0QnlWYWxEaXJlY3QodmFsdWVz LCBpbmRleCwgQHVuZGVmaW5lZCk7Ci0gICAgICAgICAgICB2YXIgbmV4dFByb21pc2UgPSBjb25z dHJ1Y3Rvci5yZXNvbHZlKHZhbHVlKTsKKyAgICAgICAgICAgIHZhciBuZXh0UHJvbWlzZSA9IHRo aXMucmVzb2x2ZSh2YWx1ZSk7CiAgICAgICAgICAgICB2YXIgcmVzb2x2ZUVsZW1lbnQgPSBuZXdS ZXNvbHZlRWxlbWVudChpbmRleCk7CiAgICAgICAgICAgICArK3JlbWFpbmluZ0VsZW1lbnRzQ291 bnQ7CiAgICAgICAgICAgICBuZXh0UHJvbWlzZS50aGVuKHJlc29sdmVFbGVtZW50LCBwcm9taXNl Q2FwYWJpbGl0eS5AcmVqZWN0KTsKQEAgLTg2LDE1ICs4MiwxMSBAQCBmdW5jdGlvbiByYWNlKGl0 ZXJhYmxlKQogICAgIGlmICghQGlzT2JqZWN0KHRoaXMpKQogICAgICAgICB0aHJvdyBuZXcgQFR5 cGVFcnJvcigifHRoaXN8IGlzIG5vdCBhIG9iamVjdCIpOwogCi0gICAgLy8gRklYTUU6IEZpeCB0 aGlzIGNvZGUgd2hlbiBAQHNwZWNpZXMgd2VsbC1rbm93biBzeW1ib2wgaXMgbGFuZGVkLgotICAg IC8vIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNDY2MjQKLSAgICB2 YXIgY29uc3RydWN0b3IgPSB0aGlzOwotCi0gICAgdmFyIHByb21pc2VDYXBhYmlsaXR5ID0gQG5l d1Byb21pc2VDYXBhYmlsaXR5KGNvbnN0cnVjdG9yKTsKKyAgICB2YXIgcHJvbWlzZUNhcGFiaWxp dHkgPSBAbmV3UHJvbWlzZUNhcGFiaWxpdHkodGhpcyk7CiAKICAgICB0cnkgewogICAgICAgICBm b3IgKHZhciB2YWx1ZSBvZiBpdGVyYWJsZSkgewotICAgICAgICAgICAgdmFyIG5leHRQcm9taXNl ID0gY29uc3RydWN0b3IucmVzb2x2ZSh2YWx1ZSk7CisgICAgICAgICAgICB2YXIgbmV4dFByb21p c2UgPSB0aGlzLnJlc29sdmUodmFsdWUpOwogICAgICAgICAgICAgbmV4dFByb21pc2UudGhlbihw cm9taXNlQ2FwYWJpbGl0eS5AcmVzb2x2ZSwgcHJvbWlzZUNhcGFiaWxpdHkuQHJlamVjdCk7CiAg ICAgICAgIH0KICAgICB9IGNhdGNoIChlcnJvcikgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pZ25vcmUtcHJvbWlzZS1zcGVjaWVzLmpzIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL3N0cmVzcy9pZ25vcmUtcHJvbWlzZS1zcGVjaWVzLmpzCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmI1YjI1Y2YxYTU4Y2EzZjQxM2UzYmUzZWM4YmYxNTJlN2U0NjI3MmIKLS0tIC9k ZXYvbnVsbAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvdGVzdHMvc3RyZXNzL2lnbm9yZS1w cm9taXNlLXNwZWNpZXMuanMKQEAgLTAsMCArMSwxMyBAQAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0 dWFsLCBleHBlY3RlZCkgeworICAgIGlmIChhY3R1YWwgIT09IGV4cGVjdGVkKQorICAgICAgICB0 aHJvdyBuZXcgRXJyb3IoJ2JhZCB2YWx1ZTogJyArIGFjdHVhbCk7Cit9CisKK2NsYXNzIERlcml2 ZWRQcm9taXNlIGV4dGVuZHMgUHJvbWlzZSB7CisgICAgc3RhdGljIGdldCBbU3ltYm9sLnNwZWNp ZXNdKCkgeworICAgICAgICByZXR1cm4gUHJvbWlzZTsKKyAgICB9Cit9CisKK3Nob3VsZEJlKERl cml2ZWRQcm9taXNlLmFsbChbIDEsIDIsIDNdKSBpbnN0YW5jZW9mIERlcml2ZWRQcm9taXNlLCB0 cnVlKTsKK3Nob3VsZEJlKERlcml2ZWRQcm9taXNlLnJhY2UoWyAxLCAyLCAzXSkgaW5zdGFuY2Vv ZiBEZXJpdmVkUHJvbWlzZSwgdHJ1ZSk7Cg==