15961 2007-11-12 16:11:01 -0800 View source mode is missing the processing instruction line. 2013-01-02 12:49:54 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED HasReduction, InRadar P2 Normal --- 1 anyang.ren esprehn ap esprehn hyatt webkit.review.bot oldest_to_newest 61032 0 anyang.ren 2007-11-12 16:11:01 -0800 In the view source mode, the processing instruction line is missing in the output. For example, the first line of the HTML page at http://alioth.debian.org/ is a processing instruction: <?xml version="1.0" encoding="UTF-8"?> This line is missing in the view source mode output. I tracked it down to the HTMLTokenizer class, specifically the HTMLTokenizer::write and HTMLTokenizer::parseProcessingInstruction methods. 61035 1 17217 anyang.ren 2007-11-12 16:31:39 -0800 Created attachment 17217 Preliminary patch for discussion This patch is intended to show where the problem is, even though it is in the form of a fix. I hope that the WebKit team can come up with a better fix. In HTMLTokenizer::write, after the call to parseProcessingInstruction returns, we continue the while loop. So we skip the processToken call at the end of the switch statement, and the line is not added to the HTMLViewSourceDocument by the addViewSourceToken call in HTMLTokenizer::processToken. I first tried removing the "continue" statement so that we fall through to the processToken call after the switch statement. But the parseTag call after the processToken call caused an empty "<>" tag to be added after the processing instruction line. So I'm now calling processToken before the continue statement. The other changes in this patch add the characters of the processing instruction line to 'buffer' (via the 'dest' pointer) so that they show up in the output. It is also necessary to remove the state.setDiscardLF(true) statement so that we don't lose the LF after the processing instruction line in the output. Note that I mark the processing instruction line as a textAtom simply because it is easier to work with HTMLTokenizer::processToken and HTMLViewSourceDocument::addViewSourceToken to output a textAtom. I believe the processing instruction line should be handled as a tag. 61113 2 anyang.ren 2007-11-13 13:28:47 -0800 David, I'd appreciate your comments on this view source mode bug and the right way to fix it. Thanks. 61155 3 ddkilzer 2007-11-13 20:32:23 -0800 Viewing the source of http://alioth.debian.org/ from Safari 3 Public Beta with a local debug build of WebKit r27716 on Tiger shows the <?xml...> tag for me. Which Safari/WebKit are you seeing this on? Please set the "review?" flag if you want the patch reviewed for comments. 61223 4 17217 anyang.ren 2007-11-14 11:42:09 -0800 Comment on attachment 17217 Preliminary patch for discussion I'm using WebKit/WebCore/html/HTMLTokenizer.cpp, r25754. I'm not using Safari. Safari's "View Source" command doesn't seem to be implemented using the "view source mode" of the HTMLTokenizer class. 61244 5 anyang.ren 2007-11-14 14:40:51 -0800 (In reply to comment #3) > Viewing the source of http://alioth.debian.org/ from Safari 3 Public Beta with > a local debug build of WebKit r27716 on Tiger shows the <?xml...> tag for me. You can confirm this bug using the Source view in the Web Inspector. 62051 6 17217 mjs 2007-11-22 23:00:45 -0800 Comment on attachment 17217 Preliminary patch for discussion I'm not 100% sure if this change is right, it seems generally ok. However, it needs a ChangeLog and a layout test. You can force view source mode by putting the relevant contents into an <iframe> element with the viewsource attribute set. r- for lack of test case and ChangeLog. 67258 7 18449 eric 2008-01-14 15:38:28 -0800 Created attachment 18449 test case Here is a test case which I believe demonstrates the bug. 68636 8 aroben 2008-01-29 11:04:07 -0800 <rdar://problem/5712854> 695806 9 esprehn 2012-08-15 00:38:53 -0700 This is actually fixed, probably by the HTML5 parser rewrite. We should just add a layout test and close this bug. (Note the patch here is impossible to apply as well since HTMLTokenizer has been entirely rewritten.) 798800 10 181046 esprehn 2013-01-02 12:27:03 -0800 Created attachment 181046 Patch 798819 11 181046 webkit.review.bot 2013-01-02 12:49:50 -0800 Comment on attachment 181046 Patch Clearing flags on attachment: 181046 Committed r138637: <http://trac.webkit.org/changeset/138637> 798821 12 webkit.review.bot 2013-01-02 12:49:54 -0800 All reviewed patches have been landed. Closing bug. 17217 2007-11-12 16:31:39 -0800 2013-01-02 12:27:02 -0800 Preliminary patch for discussion HTMLTokenizer.txt text/plain 2085 anyang.ren LS0tIEhUTUxUb2tlbml6ZXIuY3BwLm9yaWcJMjAwNy0xMS0xMiAxNjowMTo0Mi41MzA5OTM4MDAg LTA4MDAKKysrIEhUTUxUb2tlbml6ZXIuY3BwCTIwMDctMTEtMDkgMTc6NTU6MjYuNzg2Mzg0MTAw IC0wODAwCkBAIC02MTksMjggKzYxOSwzMSBAQAogICAgIHJldHVybiBzdGF0ZTsKIH0KIAogSFRN TFRva2VuaXplcjo6U3RhdGUgSFRNTFRva2VuaXplcjo6cGFyc2VQcm9jZXNzaW5nSW5zdHJ1Y3Rp b24oU2VnbWVudGVkU3RyaW5nICZzcmMsIFN0YXRlIHN0YXRlKQogewogICAgIFVDaGFyIG9sZGNo YXIgPSAwOwogICAgIHdoaWxlICghc3JjLmlzRW1wdHkoKSkgewogICAgICAgICBVQ2hhciBjaGJl Z2luID0gKnNyYzsKKyAgICAgICAgY2hlY2tCdWZmZXIoKTsKKyAgICAgICAgKmRlc3QrKyA9IGNo YmVnaW47CiAgICAgICAgIGlmIChjaGJlZ2luID09ICdcJycpCiAgICAgICAgICAgICB0cXVvdGUg PSB0cXVvdGUgPT0gU2luZ2xlUXVvdGUgPyBOb1F1b3RlIDogU2luZ2xlUXVvdGU7CiAgICAgICAg IGVsc2UgaWYgKGNoYmVnaW4gPT0gJ1wiJykKICAgICAgICAgICAgIHRxdW90ZSA9IHRxdW90ZSA9 PSBEb3VibGVRdW90ZSA/IE5vUXVvdGUgOiBEb3VibGVRdW90ZTsKICAgICAgICAgLy8gTG9vayBm b3IgJz8+JwogICAgICAgICAvLyBTb21lIGNyYXBweSBzaXRlcyBvbWl0IHRoZSAiPyIgYmVmb3Jl IGl0LCBzbwogICAgICAgICAvLyB3ZSBsb29rIGZvciBhbiB1bnF1b3RlZCAnPicgaW5zdGVhZC4g KElFIGNvbXBhdGlibGUpCiAgICAgICAgIGVsc2UgaWYgKGNoYmVnaW4gPT0gJz4nICYmICghdHF1 b3RlIHx8IG9sZGNoYXIgPT0gJz8nKSkgewogICAgICAgICAgICAgLy8gV2UgZ290IGEgJz8+JyBz ZXF1ZW5jZQogICAgICAgICAgICAgc3RhdGUuc2V0SW5Qcm9jZXNzaW5nSW5zdHJ1Y3Rpb24oZmFs c2UpOwogICAgICAgICAgICAgc3JjLmFkdmFuY2UobGluZU51bWJlclB0cigpKTsKLSAgICAgICAg ICAgIHN0YXRlLnNldERpc2NhcmRMRih0cnVlKTsKKyAgICAgICAgICAgIC8vc3RhdGUuc2V0RGlz Y2FyZExGKHRydWUpOworICAgICAgICAgICAgY3VyclRva2VuLnRhZ05hbWUgPSB0ZXh0QXRvbTsK ICAgICAgICAgICAgIHJldHVybiBzdGF0ZTsgLy8gRmluaXNoZWQgcGFyc2luZyBjb21tZW50IQog ICAgICAgICB9CiAgICAgICAgIHNyYy5hZHZhbmNlKGxpbmVOdW1iZXJQdHIoKSk7CiAgICAgICAg IG9sZGNoYXIgPSBjaGJlZ2luOwogICAgIH0KICAgICAKICAgICByZXR1cm4gc3RhdGU7CiB9CkBA IC0xNDA4LDE5ICsxNDExLDIxIEBACiAgICAgICAgICAgICAgICAgY2FzZSAnISc6IHsKICAgICAg ICAgICAgICAgICAgICAgLy8gPCEtLSBjb21tZW50IC0tPgogICAgICAgICAgICAgICAgICAgICBz ZWFyY2hDb3VudCA9IDE7IC8vIExvb2sgZm9yICc8IS0tJyBzZXF1ZW5jZSB0byBzdGFydCBjb21t ZW50CiAgICAgICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAg ICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgY2FzZSAnPyc6IHsKICAgICAgICAgICAg ICAgICAgICAgLy8geG1sIHByb2Nlc3NpbmcgaW5zdHJ1Y3Rpb24KKyAgICAgICAgICAgICAgICAg ICAgKmRlc3QrKyA9ICc8JzsKICAgICAgICAgICAgICAgICAgICAgc3RhdGUuc2V0SW5Qcm9jZXNz aW5nSW5zdHJ1Y3Rpb24odHJ1ZSk7CiAgICAgICAgICAgICAgICAgICAgIHRxdW90ZSA9IE5vUXVv dGU7CiAgICAgICAgICAgICAgICAgICAgIHN0YXRlID0gcGFyc2VQcm9jZXNzaW5nSW5zdHJ1Y3Rp b24oc3JjLCBzdGF0ZSk7CisgICAgICAgICAgICAgICAgICAgIHByb2Nlc3NUb2tlbigpOwogICAg ICAgICAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICAgICAgY2FzZSAnJSc6CiAgICAgICAgICAg ICAgICAgICAgIGlmICghYnJva2VuU2VydmVyKSB7CiAgICAgICAgICAgICAgICAgICAgICAgICAv LyA8JSBzZXJ2ZXIgc3R1ZmYsIGhhbmRsZSBhcyBjb21tZW50ICU+CiAgICAgICAgICAgICAgICAg ICAgICAgICBzdGF0ZS5zZXRJblNlcnZlcih0cnVlKTsK 18449 2008-01-14 15:38:28 -0800 2008-01-14 15:38:28 -0800 test case viewsource.html text/html 185 eric PGlmcmFtZSB2aWV3c291cmNlIHNyYz0iZGF0YTp0ZXh0L2h0bWw7YmFzZTY0LFBEOTRiV3dnZG1W eWMybHZiajFjWEZ3aU1TNHdYRnhjSWlCbGJtTnZaR2x1WnoxY1hGd2lWVlJHTFRoY1hGd2lQejRO Q2p4b2RHMXNQZzBLUEdKdlpIaytEUW84Y0Q1R1QwODhMM0ErRFFvOEwySnZaSGsrRFFvOGFIUnRi RDQ9Ij48L2lmcmFtZT4= 181046 2013-01-02 12:27:03 -0800 2013-01-02 12:49:50 -0800 Patch bug-15961-20130102122411.patch text/plain 1882 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM4NjI2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTNlZDg3MzI5ZDk0ODZhZmQ4OGI1 NjU1YmNiM2FiYjBiMWQxYTY1Ni4uODMxYTNhN2JlNjRkNDI0ODE4ODNmZmI3ZDAxMzIwZmExMDcw N2NlNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEzLTAxLTAyICBFbGxpb3R0IFNwcmVobiAg PGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFZpZXcgc291cmNlIG1vZGUgaXMgbWlz c2luZyB0aGUgcHJvY2Vzc2luZyBpbnN0cnVjdGlvbiBsaW5lLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NjEKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSB0ZXN0IGZvciBYTUwgZG9jdW1lbnRz IHNob3duIGluIHZpZXdzb3VyY2UgbW9kZS4gVGhlIGJ1ZworICAgICAgICB3aXRoIHRoZSBtaXNz aW5nIHByb2Nlc3NpbmcgaW5zdHJ1Y3Rpb24gbGluZSB3YXMgZml4ZWQgbG9uZworICAgICAgICBh Z28gd2l0aCB0aGUgSFRNTDUgcGFyc2VyIHJld3JpdGUgc28gdGhpcyBqdXN0IGFkZHMgYSB0ZXN0 LgorCisgICAgICAgICogZmFzdC9mcmFtZXMvdmlld3NvdXJjZS14bWwtZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L2ZyYW1lcy92aWV3c291cmNlLXhtbC5odG1sOiBBZGRlZC4K KwogMjAxMy0wMS0wMiAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IHNhbmRib3hlZCBpZnJhbWUgYXR0cmlidXRlIHBhcnNpbmcgbGF5b3V0IHRlc3RzIGFyZSBmbGFr eQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvdmlld3NvdXJjZS14bWwtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMvdmlld3NvdXJjZS14bWwtZXhwZWN0 ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAuLjA4NGI3MGZlNjJhYjE1M2EyY2M1MmM3ZTdmM2NjZmQ5YjczZmE0 YzMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2ZyYW1lcy92aWV3c291cmNl LXhtbC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw2IEBACisKKworLS0tLS0tLS0KK0ZyYW1lOiAn PCEtLWZyYW1lUGF0aCAvLzwhLS1mcmFtZTAtLT4tLT4nCistLS0tLS0tLQorPD94bWwgdmVyc2lv bj0iMS4wIj8+PGRpdj48c2VjdGlvbi8+PC9kaXY+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2ZyYW1lcy92aWV3c291cmNlLXhtbC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFtZXMv dmlld3NvdXJjZS14bWwuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZmE2OWNlMTljYzBhOGQzMmNmODYxY2Zj MTkwNGM2MzNmZDU4N2FhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mcmFt ZXMvdmlld3NvdXJjZS14bWwuaHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgaHRtbD4N CisNCis8c2NyaXB0Pg0KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgew0KKyAgICB0ZXN0UnVubmVy LmR1bXBBc1RleHQoKTsNCisgICAgdGVzdFJ1bm5lci5kdW1wQ2hpbGRGcmFtZXNBc1RleHQoKTsN Cit9DQorPC9zY3JpcHQ+DQorDQorPGlmcmFtZSB2aWV3c291cmNlIHNyYz0nZGF0YTp0ZXh0L2h0 bWwsPD94bWwgdmVyc2lvbj0iMS4wIj8+PGRpdj48c2VjdGlvbi8+PC9kaXY+Jz48L2lmcmFtZT4N Cg==