159596 2016-07-08 20:13:54 -0700 REGRESSION: manifest.json generation takes multiple seconds on perf dashboard 2016-07-09 08:40:20 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez commit-queue dewei_zhu kling koivisto rniwa slewis oldest_to_newest 1209403 0 rniwa 2016-07-08 20:13:54 -0700 Manifest generation has gotten slower over time (5.3s in production server). Reduce the runtime since we need to do this on every test submission, this could impact each tester's cycle time. 1209407 1 283243 rniwa 2016-07-08 20:41:56 -0700 Created attachment 283243 Reduces runtime by 10x 1209443 2 283243 cdumez 2016-07-09 08:18:30 -0700 Comment on attachment 283243 Reduces runtime by 10x rs=me 1209446 3 283243 commit-queue 2016-07-09 08:40:15 -0700 Comment on attachment 283243 Reduces runtime by 10x Clearing flags on attachment: 283243 Committed r203030: <http://trac.webkit.org/changeset/203030> 1209447 4 commit-queue 2016-07-09 08:40:20 -0700 All reviewed patches have been landed. Closing bug. 283243 2016-07-08 20:41:56 -0700 2016-07-09 08:40:15 -0700 Reduces runtime by 10x bug-159596-20160708204120.patch text/plain 6459 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzMDE5KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIzIEBACisyMDE2LTA3LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIFJFR1JFU1NJT046IG1hbmlmZXN0Lmpzb24gZ2VuZXJhdGlvbiB0YWtlcyBtdWx0 aXBsZSBzZWNvbmRzIG9uIHBlcmYgZGFzaGJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgbW9zdCBvZiBDUFUgdGltZSB3YXMgc3BlbnQgbG9v a2luZyBmb3IgYSBkdXBsaWNhdGUgZW50cnkgaW4gYW4gYXJyYXkgb2YgbWV0cmljcyBieSBhcnJh eV9zZWFyY2guCisgICAgICAgIFRoaXMgcGF0Y2ggbW92ZXMgdG8gcG9zdGdyZXMgYnkgdXNpbmcg YWdncmVnYXRlIGZ1bmN0aW9ucyBpbiB0aGUgcXVlcnkuIEFsc28gbW92ZWQgdGhlIGNvZGUgdG8g Y29udmVydAorICAgICAgICBkYXRldGltZSB0byBVTklYIGVwb2NoIHRpbWVzdGFtcCBmcm9tIFBI UCB0byB3aXRoaW4gcG9zdGdyZXMgcXVlcnkuCisKKyAgICAgICAgVGhlc2UgaW1wcm92ZW1lbnRz IHJlZHVjZSB0b3RhbCBydW50aW1lIG9mIE1hbmlmZXN0OjpnZW5lcmF0ZSBmcm9tIH40cyB0byB+ MzUwbXMgb24gbXkgbWFjaGluZS4KKworICAgICAgICAqIHB1YmxpYy9pbmNsdWRlL21hbmlmZXN0 LnBocDoKKyAgICAgICAgKE1hbmlmZXN0OjpnZW5lcmF0ZSk6IE5vIGxvbmdlciBmZXRjaGVzIHRl c3RfY29uZmlndXJhdGlvbnMgdGFibGUgYXMgdGhpcyBpcyBkb25lIGluIE1hbmlmZXN0OjpwbGF0 Zm9ybXMgbm93LgorICAgICAgICBBbHNvIG1vdmVkIGNhbGxzIHRvIGVhY2ggbWV0aG9kIGluIHRo ZSBjbGFzcyB0byBzZXBhcmF0ZSBsaW5lcyBmb3IgZWFzaWVyIGluc3RydW1lbnRhdGlvbi4KKyAg ICAgICAgKE1hbmlmZXN0OjpwbGF0Zm9ybXMpOiBHcm91cCB0ZXN0IGNvbmZpZ3VyYXRpb25zIChj dXJyZW50LCBiYXNlbGluZSwgdGFyZ2V0KSBieSBwbGF0Zm9ybSBhbmQgbWV0cmljLgorICAgICAg ICBVc2UgdGhlIG1heCBvZiB0aGUgbGFzdCBtb2RpZmllZCBkYXRlcyBpbiBVTklYIGVwb2NoIHRp bWVzdGFtcHMgKG1zIHRvIGJlIGNvbXBhdGlibGUgd2l0aCBKUydzIHJlcHJlc2VudGF0aW9uKS4K KyAgICAgICAgQSBnaXZlbiBwbGF0Zm9ybSwgbWV0cmljIHBhaXIgaXMgY29uc2lkZXJlZCB0byBi ZSBpbiB0aGUgdjEgZGFzaGJvYXJkIGlmIGFueSB0ZXN0IGNvbmZpZ3VyYXRpb24gaXMgaW4uCisK IDIwMTYtMDctMDggIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAg YnVuZGxlLXYzLXNjcmlwdHMucHkgc2hvdWxkIGNvbXByZXNzIEhUTUwvQ1NTIHRlbXBsYXRlcwpJ bmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1YmxpYy9pbmNsdWRlL21hbmlmZXN0LnBo cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL2luY2x1ZGUv bWFuaWZlc3QucGhwCShyZXZpc2lvbiAyMDMwMDYpCisrKyBXZWJzaXRlcy9wZXJmLndlYmtpdC5v cmcvcHVibGljL2luY2x1ZGUvbWFuaWZlc3QucGhwCSh3b3JraW5nIGNvcHkpCkBAIC0xNCw3ICsx NCw2IEBAIGNsYXNzIE1hbmlmZXN0R2VuZXJhdG9yIHsKICAgICBmdW5jdGlvbiBnZW5lcmF0ZSgp IHsKICAgICAgICAgJHN0YXJ0X3RpbWUgPSBtaWNyb3RpbWUodHJ1ZSk7CiAKLSAgICAgICAgJGNv bmZpZ190YWJsZSA9ICR0aGlzLT5kYi0+ZmV0Y2hfdGFibGUoJ3Rlc3RfY29uZmlndXJhdGlvbnMn KTsKICAgICAgICAgJHBsYXRmb3JtX3RhYmxlID0gJHRoaXMtPmRiLT5mZXRjaF90YWJsZSgncGxh dGZvcm1zJyk7CiAgICAgICAgICRyZXBvc2l0b3JpZXNfdGFibGUgPSAkdGhpcy0+ZGItPmZldGNo X3RhYmxlKCdyZXBvc2l0b3JpZXMnKTsKIApAQCAtMjYsMTMgKzI1LDE5IEBAIGNsYXNzIE1hbmlm ZXN0R2VuZXJhdG9yIHsKICAgICAgICAgZm9yZWFjaCAoJHJlcG9zaXRvcmllc193aXRoX2NvbW1p dCBhcyAmJHJvdykKICAgICAgICAgICAgICRyb3cgPSAkcm93Wydjb21taXRfcmVwb3NpdG9yeSdd OwogCisgICAgICAgICR0ZXN0cyA9IChvYmplY3QpJHRoaXMtPnRlc3RzKCk7CisgICAgICAgICRt ZXRyaWNzID0gKG9iamVjdCkkdGhpcy0+bWV0cmljcygpOworICAgICAgICAkcGxhdGZvcm1zID0g KG9iamVjdCkkdGhpcy0+cGxhdGZvcm1zKCRwbGF0Zm9ybV90YWJsZSwgZmFsc2UpOworICAgICAg ICAkZGFzaGJvYXJkID0gKG9iamVjdCkkdGhpcy0+cGxhdGZvcm1zKCRwbGF0Zm9ybV90YWJsZSwg dHJ1ZSk7CisgICAgICAgICRyZXBvc2l0b3JpZXMgPSAob2JqZWN0KSR0aGlzLT5yZXBvc2l0b3Jp ZXMoJHJlcG9zaXRvcmllc190YWJsZSwgJHJlcG9zaXRvcmllc193aXRoX2NvbW1pdCk7CisKICAg ICAgICAgJHRoaXMtPm1hbmlmZXN0ID0gYXJyYXkoCiAgICAgICAgICAgICAnc2l0ZVRpdGxlJyA9 PiBjb25maWcoJ3NpdGVUaXRsZScsICdQZXJmb3JtYW5jZSBEYXNoYm9hcmQnKSwKLSAgICAgICAg ICAgICd0ZXN0cycgPT4gKG9iamVjdCkkdGhpcy0+dGVzdHMoKSwKLSAgICAgICAgICAgICdtZXRy aWNzJyA9PiAob2JqZWN0KSR0aGlzLT5tZXRyaWNzKCksCi0gICAgICAgICAgICAnYWxsJyA9PiAo b2JqZWN0KSR0aGlzLT5wbGF0Zm9ybXMoJGNvbmZpZ190YWJsZSwgJHBsYXRmb3JtX3RhYmxlLCBm YWxzZSksCi0gICAgICAgICAgICAnZGFzaGJvYXJkJyA9PiAob2JqZWN0KSR0aGlzLT5wbGF0Zm9y bXMoJGNvbmZpZ190YWJsZSwgJHBsYXRmb3JtX3RhYmxlLCB0cnVlKSwKLSAgICAgICAgICAgICdy ZXBvc2l0b3JpZXMnID0+IChvYmplY3QpJHRoaXMtPnJlcG9zaXRvcmllcygkcmVwb3NpdG9yaWVz X3RhYmxlLCAkcmVwb3NpdG9yaWVzX3dpdGhfY29tbWl0KSwKKyAgICAgICAgICAgICd0ZXN0cycg PT4gJiR0ZXN0cywKKyAgICAgICAgICAgICdtZXRyaWNzJyA9PiAmJG1ldHJpY3MsCisgICAgICAg ICAgICAnYWxsJyA9PiAmJHBsYXRmb3JtcywKKyAgICAgICAgICAgICdkYXNoYm9hcmQnID0+ICYk ZGFzaGJvYXJkLAorICAgICAgICAgICAgJ3JlcG9zaXRvcmllcycgPT4gJiRyZXBvc2l0b3JpZXMs CiAgICAgICAgICAgICAnYnVpbGRlcnMnID0+IChvYmplY3QpJHRoaXMtPmJ1aWxkZXJzKCksCiAg ICAgICAgICAgICAnYnVnVHJhY2tlcnMnID0+IChvYmplY3QpJHRoaXMtPmJ1Z190cmFja2Vycygk cmVwb3NpdG9yaWVzX3RhYmxlKSwKICAgICAgICAgICAgICdkYXNoYm9hcmRzJyA9PiAob2JqZWN0 KWNvbmZpZygnZGFzaGJvYXJkcycpLApAQCAtNzksMzIgKzg0LDMzIEBAIGNsYXNzIE1hbmlmZXN0 R2VuZXJhdG9yIHsKICAgICAgICAgcmV0dXJuICRtZXRyaWNzOwogICAgIH0KIAotICAgIHByaXZh dGUgZnVuY3Rpb24gcGxhdGZvcm1zKCRjb25maWdfdGFibGUsICRwbGF0Zm9ybV90YWJsZSwgJGlz X2Rhc2hib2FyZCkgeworICAgIHByaXZhdGUgZnVuY3Rpb24gcGxhdGZvcm1zKCRwbGF0Zm9ybV90 YWJsZSwgJGlzX2Rhc2hib2FyZCkgeworICAgICAgICAkbWV0cmljcyA9ICR0aGlzLT5kYi0+cXVl cnlfYW5kX2ZldGNoX2FsbCgnU0VMRUNUIGNvbmZpZ19tZXRyaWMgQVMgbWV0cmljX2lkLCBjb25m aWdfcGxhdGZvcm0gQVMgcGxhdGZvcm1faWQsCisgICAgICAgICAgICBleHRyYWN0KGVwb2NoIGZy b20gbWF4KGNvbmZpZ19ydW5zX2xhc3RfbW9kaWZpZWQpKSAqIDEwMDAgQVMgbGFzdF9tb2RpZmll ZCwgYm9vbF9vcihjb25maWdfaXNfaW5fZGFzaGJvYXJkKSBBUyBpbl9kYXNoYm9hcmQKKyAgICAg ICAgICAgIEZST00gdGVzdF9jb25maWd1cmF0aW9ucyBHUk9VUCBCWSBjb25maWdfbWV0cmljLCBj b25maWdfcGxhdGZvcm0gT1JERVIgQlkgY29uZmlnX3BsYXRmb3JtJyk7CisKICAgICAgICAgJHBs YXRmb3JtX21ldHJpY3MgPSBhcnJheSgpOwotICAgICAgICBpZiAoJGNvbmZpZ190YWJsZSkgewot ICAgICAgICAgICAgZm9yZWFjaCAoJGNvbmZpZ190YWJsZSBhcyAkY29uZmlnX3JvdykgewotICAg ICAgICAgICAgICAgIGlmICgkaXNfZGFzaGJvYXJkICYmICFEYXRhYmFzZTo6aXNfdHJ1ZSgkY29u ZmlnX3Jvd1snY29uZmlnX2lzX2luX2Rhc2hib2FyZCddKSkKKworICAgICAgICBpZiAoJG1ldHJp Y3MpIHsKKyAgICAgICAgICAgICRjdXJyZW50X3BsYXRmb3JtX2VudHJ5ID0gbnVsbDsKKyAgICAg ICAgICAgIGZvcmVhY2ggKCRtZXRyaWNzIGFzICRtZXRyaWNfcm93KSB7CisgICAgICAgICAgICAg ICAgaWYgKCRpc19kYXNoYm9hcmQgJiYgIURhdGFiYXNlOjppc190cnVlKCRtZXRyaWNfcm93Wydp bl9kYXNoYm9hcmQnXSkpCiAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCi0gICAgICAg ICAgICAgICAgJG5ld19sYXN0X21vZGlmaWVkID0gYXJyYXlfZ2V0KCRjb25maWdfcm93LCAnY29u ZmlnX3J1bnNfbGFzdF9tb2RpZmllZCcsIDApOwotICAgICAgICAgICAgICAgIGlmICgkbmV3X2xh c3RfbW9kaWZpZWQpCi0gICAgICAgICAgICAgICAgICAgICRuZXdfbGFzdF9tb2RpZmllZCA9IHN0 cnRvdGltZSgkY29uZmlnX3Jvd1snY29uZmlnX3J1bnNfbGFzdF9tb2RpZmllZCddKSAqIDEwMDA7 Ci0KLSAgICAgICAgICAgICAgICAkcGxhdGZvcm0gPSAmYXJyYXlfZW5zdXJlX2l0ZW1faGFzX2Fy cmF5KCRwbGF0Zm9ybV9tZXRyaWNzLCAkY29uZmlnX3Jvd1snY29uZmlnX3BsYXRmb3JtJ10pOwot ICAgICAgICAgICAgICAgICRtZXRyaWNzID0gJmFycmF5X2Vuc3VyZV9pdGVtX2hhc19hcnJheSgk cGxhdGZvcm0sICdtZXRyaWNzJyk7Ci0gICAgICAgICAgICAgICAgJGxhc3RfbW9kaWZpZWQgPSAm YXJyYXlfZW5zdXJlX2l0ZW1faGFzX2FycmF5KCRwbGF0Zm9ybSwgJ2xhc3RfbW9kaWZpZWQnKTsK LQotICAgICAgICAgICAgICAgICRtZXRyaWNfaWQgPSAkY29uZmlnX3Jvd1snY29uZmlnX21ldHJp YyddOwotICAgICAgICAgICAgICAgICRpbmRleCA9IGFycmF5X3NlYXJjaCgkbWV0cmljX2lkLCAk bWV0cmljcyk7Ci0gICAgICAgICAgICAgICAgaWYgKCRpbmRleCA9PT0gRkFMU0UpIHsKLSAgICAg ICAgICAgICAgICAgICAgYXJyYXlfcHVzaCgkbWV0cmljcywgJG1ldHJpY19pZCk7Ci0gICAgICAg ICAgICAgICAgICAgIGFycmF5X3B1c2goJGxhc3RfbW9kaWZpZWQsICRuZXdfbGFzdF9tb2RpZmll ZCk7Ci0gICAgICAgICAgICAgICAgfSBlbHNlCi0gICAgICAgICAgICAgICAgICAgICRsYXN0X21v ZGlmaWVkWyRpbmRleF0gPSBtYXgoJGxhc3RfbW9kaWZpZWRbJGluZGV4XSwgJG5ld19sYXN0X21v ZGlmaWVkKTsKKyAgICAgICAgICAgICAgICAkcGxhdGZvcm1faWQgPSAkbWV0cmljX3Jvd1sncGxh dGZvcm1faWQnXTsKKyAgICAgICAgICAgICAgICBpZiAoISRjdXJyZW50X3BsYXRmb3JtX2VudHJ5 IHx8ICRjdXJyZW50X3BsYXRmb3JtX2VudHJ5WydpZCddICE9ICRwbGF0Zm9ybV9pZCkgeworICAg ICAgICAgICAgICAgICAgICAkY3VycmVudF9wbGF0Zm9ybV9lbnRyeSA9ICZhcnJheV9lbnN1cmVf aXRlbV9oYXNfYXJyYXkoJHBsYXRmb3JtX21ldHJpY3MsICRwbGF0Zm9ybV9pZCk7CisgICAgICAg ICAgICAgICAgICAgICRjdXJyZW50X3BsYXRmb3JtX2VudHJ5WydpZCddID0gJHBsYXRmb3JtX2lk OworICAgICAgICAgICAgICAgICAgICBhcnJheV9lbnN1cmVfaXRlbV9oYXNfYXJyYXkoJGN1cnJl bnRfcGxhdGZvcm1fZW50cnksICdtZXRyaWNzJyk7CisgICAgICAgICAgICAgICAgICAgIGFycmF5 X2Vuc3VyZV9pdGVtX2hhc19hcnJheSgkY3VycmVudF9wbGF0Zm9ybV9lbnRyeSwgJ2xhc3RfbW9k aWZpZWQnKTsKKyAgICAgICAgICAgICAgICB9CisKKyAgICAgICAgICAgICAgICBhcnJheV9wdXNo KCRjdXJyZW50X3BsYXRmb3JtX2VudHJ5WydtZXRyaWNzJ10sICRtZXRyaWNfcm93WydtZXRyaWNf aWQnXSk7CisgICAgICAgICAgICAgICAgYXJyYXlfcHVzaCgkY3VycmVudF9wbGF0Zm9ybV9lbnRy eVsnbGFzdF9tb2RpZmllZCddLCAkbWV0cmljX3Jvd1snbGFzdF9tb2RpZmllZCddKTsKICAgICAg ICAgICAgIH0KICAgICAgICAgfQogICAgICAgICAkY29uZmlndXJhdGlvbnMgPSBhcnJheSgpOwot ICAgICAgICAKKwogICAgICAgICAkcGxhdGZvcm1zID0gYXJyYXkoKTsKICAgICAgICAgaWYgKCRw bGF0Zm9ybV90YWJsZSkgewogICAgICAgICAgICAgZm9yZWFjaCAoJHBsYXRmb3JtX3RhYmxlIGFz ICRwbGF0Zm9ybV9yb3cpIHsK