159582 2016-07-08 14:40:03 -0700 bundle-v3-scripts.py should compress HTML/CSS templates 2016-07-08 20:32:39 -0700 1 1 1 Unclassified WebKit Perf Dashboard WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez joepeck rniwa oldest_to_newest 1209271 0 rniwa 2016-07-08 14:40:03 -0700 Since v3 UI embeds HTML and CSS inside the scripts, we should be stripping whitespace in bundle-v3-scripts.py from those. 1209335 1 283225 rniwa 2016-07-08 16:59:06 -0700 Created attachment 283225 Patch 1209405 2 283225 joepeck 2016-07-08 20:26:35 -0700 Comment on attachment 283225 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283225&action=review r=me! > Websites/perf.webkit.org/tools/bundle-v3-scripts.py:51 > + content = re.sub(r'\s+([{};:])', r'\1', content) This could have a bug with ":" for the new things like "foo :matches(...)" would suddenly change. You could copy the cssminify function that the inspector uses and use it here: (1 of these) Source/JavaScriptCore/Scripts/cssmin.py Source/WebInspectorUI/Scripts/cssmin.py 1209406 3 rniwa 2016-07-08 20:32:39 -0700 Committed r203019: <http://trac.webkit.org/changeset/203019> 283225 2016-07-08 16:59:06 -0700 2016-07-08 20:26:35 -0700 Patch bug-159582-20160708165830.patch text/plain 3410 rniwa SW5kZXg6IFdlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzMDA2KQorKysg V2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE2LTA3LTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgor CisgICAgICAgIGJ1bmRsZS12My1zY3JpcHRzLnB5IHNob3VsZCBjb21wcmVzcyBIVE1ML0NTUyB0 ZW1wbGF0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE1OTU4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFN0cmlwIGxlYWRpbmcgYW5kIHRyYWlsaW5nIHdoaXRlc3BhY2VzIGZyb20gSFRNTCBhbmQgQ1NT IHRlbXBsYXRlcy4gVGhpcyBpcyBhIDglIHByb2dyZXNzaW9uIG9uIHRoZSBmaWxlIHNpemUuCisK KyAgICAgICAgKiBJbnN0YWxsLm1kOiBVcGRhdGVkIHRoZSBsaXN0IG9mIE1JTUUgdHlwZXMgdG8g YXBwbHkgZGVmbGF0ZSBmb3IgbmV3ZXIgdmVyc2lvbnMgb2YgQXBhY2hlLgorICAgICAgICAqIHRv b2xzL2J1bmRsZS12My1zY3JpcHRzLnB5OgorICAgICAgICAobWFpbik6CisgICAgICAgIChjb21w cmVzc190ZW1wbGF0ZSk6IEFkZGVkLgorCiAyMDE2LTA2LTEzICBSeW9zdWtlIE5pd2EgIDxybml3 YUB3ZWJraXQub3JnPgogCiAgICAgICAgIEJ1aWxkIGZpeC4gU3RyaXAgb3V0ICJ1c2Ugc3RyaWN0 IiBldmVyeXdoZXJlIHNvIHRoYXQgdGhlIHBlcmYgZGFzaGJvYXJkIHdvcmtzIG9uIHRoZSBzaGlw cGluZyBTYWZhcmkuCkluZGV4OiBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvSW5zdGFsbC5tZAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvSW5zdGFsbC5tZAkocmV2aXNp b24gMjAzMDA2KQorKysgV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0luc3RhbGwubWQJKHdvcmtp bmcgY29weSkKQEAgLTczLDcgKzczLDcgQEAgVGhlIGFwYWNoZSBsb2dzIGFyZSBsb2NhdGVkIGF0 IGAvcHJpdmF0ZQogIDIuIEFkZCB0aGUgZm9sbG93aW5nIGRpcmVjdGl2ZXMgdG8gZW5hYmxlIGd6 aXA6CiAKICAgICAgICAgPElmTW9kdWxlIG1vZF9kZWZsYXRlLmM+Ci0gICAgICAgICAgICBBZGRP dXRwdXRGaWx0ZXJCeVR5cGUgREVGTEFURSB0ZXh0L2h0bWwgdGV4dC94bWwgdGV4dC9wbGFpbiBh cHBsaWNhdGlvbi9qc29uIGFwcGxpY2F0aW9uL3htbCBhcHBsaWNhdGlvbi94aHRtbCt4bWwKKyAg ICAgICAgICAgIEFkZE91dHB1dEZpbHRlckJ5VHlwZSBERUZMQVRFIHRleHQvaHRtbCB0ZXh0L3ht bCB0ZXh0L2phdmFzY3JpcHQgYXBwbGljYXRpb24vamF2YXNjcmlwdCB0ZXh0L3BsYWluIGFwcGxp Y2F0aW9uL2pzb24gYXBwbGljYXRpb24veG1sIGFwcGxpY2F0aW9uL3hodG1sK3htbAogICAgICAg ICA8L0lmTW9kdWxlPgogCiAgMy4gQWRkIHRoZSBmb2xsb3dpbmcgZGlyZWN0aXZlcyB0byBlbmFi bGUgemxpYiBjb21wcmVzc2lvbiBhbmQgTXVsdGlWaWV3cyBvbiBEb2N1bWVudFJvb3QgKHBlcmYu d2Via2l0Lm9yZy9wdWJsaWMpOgpJbmRleDogV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xz L2J1bmRsZS12My1zY3JpcHRzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNpdGVzL3BlcmYud2Via2l0 Lm9yZy90b29scy9idW5kbGUtdjMtc2NyaXB0cy5weQkocmV2aXNpb24gMjAzMDA2KQorKysgV2Vi c2l0ZXMvcGVyZi53ZWJraXQub3JnL3Rvb2xzL2J1bmRsZS12My1zY3JpcHRzLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0yMCw5ICsyMCwxMyBAQCBkZWYgbWFpbihhcmd2KToKICAgICAgICAgdW5idW5k bGVkX3NjcmlwdHMgPSB0ZW1wbGF0ZS5nZXRFbGVtZW50c0J5VGFnTmFtZSgnc2NyaXB0JykKICAg ICAgICAgZm9yIHNjcmlwdCBpbiB1bmJ1bmRsZWRfc2NyaXB0czoKICAgICAgICAgICAgIHNyYyA9 IHNjcmlwdC5nZXRBdHRyaWJ1dGUoJ3NyYycpCisKICAgICAgICAgICAgIHdpdGggb3Blbihvcy5w YXRoLmpvaW4ocHVibGljX3YzX2Rpciwgc3JjKSkgYXMgc2NyaXB0X2ZpbGU6CiAgICAgICAgICAg ICAgICAgc2NyaXB0X2NvbnRlbnQgPSBzY3JpcHRfZmlsZS5yZWFkKCkKICAgICAgICAgICAgICAg ICBzY3JpcHRfY29udGVudCA9IHJlLnN1YihyJyhbXCJcJ10pdXNlIHN0cmljdFwxOycsICcnLCBz Y3JpcHRfY29udGVudCkKKyAgICAgICAgICAgICAgICBzY3JpcHRfY29udGVudCA9IHJlLnN1Yihy Jyg/UDxwcmVmaXg+XG5ccypzdGF0aWNccysoP1A8dHlwZT5cdyspVGVtcGxhdGVcKFwpXHMqe1te YF0qYCkoP1A8Y29udGVudD5bXmBdKikoP1A8c3VmZml4PmA7P1xzKn0pJywKKyAgICAgICAgICAg ICAgICAgICAgY29tcHJlc3NfdGVtcGxhdGUsIHNjcmlwdF9jb250ZW50LCByZS5NVUxUSUxJTkUp CisKICAgICAgICAgICAgICAgICBidW5kbGVkX3NjcmlwdCArPSBzY3JpcHRfY29udGVudAogCiAg ICAganNtaW4gPSBzdWJwcm9jZXNzLlBvcGVuKFsncHl0aG9uJywgb3MucGF0aC5qb2luKHRvb2xz X2RpciwgJ2pzbWluLnB5JyldLCBzdGRpbj1zdWJwcm9jZXNzLlBJUEUsIHN0ZG91dD1zdWJwcm9j ZXNzLlBJUEUpCkBAIC0zNSw1ICszOSwyMCBAQCBkZWYgbWFpbihhcmd2KToKICAgICB3aXRoIG9w ZW4ob3MucGF0aC5qb2luKHB1YmxpY192M19kaXIsICdidW5kbGVkLXNjcmlwdHMuanMnKSwgJ3cn KSBhcyBidW5kbGVkX2ZpbGU6CiAgICAgICAgIGJ1bmRsZWRfZmlsZS53cml0ZShtaW5pZmllZF9z Y3JpcHQpCiAKKworZGVmIGNvbXByZXNzX3RlbXBsYXRlKG1hdGNoKToKKyAgICBwcmVmaXggPSBt YXRjaC5ncm91cCgncHJlZml4JykKKyAgICBjb250ZW50ID0gbWF0Y2guZ3JvdXAoJ2NvbnRlbnQn KQorICAgIHN1ZmZpeCA9IG1hdGNoLmdyb3VwKCdzdWZmaXgnKQorCisgICAgY29udGVudCA9IHJl LnN1YihyJ1xzKycsICcgJywgY29udGVudCkKKworICAgIGlmIG1hdGNoLmdyb3VwKCd0eXBlJykg PT0gJ2Nzcyc6CisgICAgICAgIGNvbnRlbnQgPSByZS5zdWIocidccysoW3t9OzpdKScsIHInXDEn LCBjb250ZW50KQorICAgICAgICBjb250ZW50ID0gcmUuc3ViKHInKFt7fTs6XSlccysnLCByJ1wx JywgY29udGVudCkKKworICAgIHJldHVybiBwcmVmaXggKyBjb250ZW50ICsgc3VmZml4CisKKwog aWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKICAgICBtYWluKHN5cy5hcmd2KQo=