15958 2007-11-12 12:53:03 -0800 base64 spends 1.1% of total time checking for special Infinity case 2007-11-13 00:05:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric ggaren darin ggaren oldest_to_newest 61010 0 eric 2007-11-12 12:53:03 -0800 base64 spends 1.1% of total time working around toDouble/kjs_dota logic mismatch Well, here's another softball: at least 1.4% of *total time* in base64 is spent on this line in UString::toDouble: if (strncmp(c, "Infinity", 8) == 0) { We already have our own custom dota (aka kjs_dota) we just need a way to call into that logic where it doesn't ever return "Infinity" and instead does what UString::toDouble wants it to. 61048 1 ggaren 2007-11-12 22:25:04 -0800 I'll take this. 61055 2 17221 ggaren 2007-11-12 23:14:42 -0800 Created attachment 17221 Patch 61058 3 17221 sam 2007-11-12 23:48:12 -0800 Comment on attachment 17221 Patch Looking reasonable. r=me. 61059 4 17221 eric 2007-11-12 23:48:50 -0800 Comment on attachment 17221 Patch Oh. I figured we'd had up kjs_dota, but this looks great too. :) 61061 5 ggaren 2007-11-13 00:05:19 -0800 Committed revision 27748. 17221 2007-11-12 23:14:42 -0800 2007-11-12 23:48:12 -0800 Patch patch-inf.txt text/plain 1427 ggaren SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI3NzQ1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMDctMTEt MTIgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeGVkIGh0dHA6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTU4CisgICAgICAgIGJhc2U2NCBzcGVuZHMg MS4xJSBvZiB0b3RhbCB0aW1lIGNoZWNraW5nIGZvciBzcGVjaWFsIEluZmluaXR5IGNhc2UKKyAg ICAgICAgCisgICAgICAgIFVzZSBhIGZhc3QgY2hhcmFjdGVyIHRlc3QgaW5zdGVhZCBvZiBjYWxs aW5nIHN0cm5jbXAuCisgICAgICAgIAorICAgICAgICAxLjElIHNwZWVkdXAgb24gc3RyaW5nLWJh c2U2NC4gU3VuU3BpZGVyIHJlcG9ydHMgYSAuNCUgc3BlZWR1cCBvdmVyYWxsOworICAgICAgICBT aGFya3MgcmVwb3J0cyBvbmx5IC4xJS4gV2hvIGFyZSB5b3UgZ29pbmcgdG8gYmVsaWV2ZT8gSHVo PworCisgICAgICAgICoga2pzL3VzdHJpbmcuY3BwOgorICAgICAgICAoS0pTOjpVU3RyaW5nOjp0 b0RvdWJsZSk6CisKIDIwMDctMTEtMTIgIEpvc2ggQWFzICA8am9zaG1vekBnbWFpbC5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBranMvdXN0cmluZy5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0ga2pzL3VzdHJpbmcuY3BwCShyZXZpc2lvbiAyNzcyMSkKKysrIGtqcy91c3RyaW5n LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAwMSw3ICsxMDAxLDcgQEAgZG91YmxlIFVTdHJpbmc6 OnRvRG91YmxlKGJvb2wgdG9sZXJhdGVUcgogICAgICAgLy8gY29udmVydHMgdGhlIHN0cmluZyAi aW5mIiB3aXRoIGFueSBjYXBpdGFsaXphdGlvbiB0byBpbmZpbml0eSwKICAgICAgIC8vIHdoZXJl YXMgdGhlIEVDTUEgc3BlYyByZXF1aXJlcyB0aGF0IGl0IGJlIGNvbnZlcnRlZCB0byBOYU4uCiAK LSAgICAgIGlmIChzdHJuY21wKGMsICJJbmZpbml0eSIsIDgpID09IDApIHsKKyAgICAgIGlmIChj WzBdID09ICdJJyAmJiBjWzFdID09ICduJyAmJiBjWzJdID09ICdmJyAmJiBjWzNdID09ICdpJyAm JiBjWzRdID09ICduJyAmJiBjWzVdID09ICdpJyAmJiBjWzZdID09ICd0JyAmJiBjWzddID09ICd5 JykgewogICAgICAgICBkID0gc2lnbiAqIEluZjsKICAgICAgICAgYyArPSA4OwogICAgICAgfSBl bHNlIGlmICgoZCA9PSBJbmYgfHwgZCA9PSAtSW5mKSAmJiAqYyAhPSAnSScgJiYgKmMgIT0gJ2kn KQo=