159574 2016-07-08 12:18:43 -0700 Fix client certificate authentication after r200463 2016-07-10 11:49:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=157220 P2 Normal --- 1 achristensen achristensen commit-queue sam oldest_to_newest 1209232 0 achristensen 2016-07-08 12:18:43 -0700 Fix client certificate authentication after r200463 1209233 1 283188 achristensen 2016-07-08 12:20:39 -0700 Created attachment 283188 Patch 1209269 2 283198 achristensen 2016-07-08 14:19:49 -0700 Created attachment 283198 Patch 1209270 3 commit-queue 2016-07-08 14:21:32 -0700 Attachment 283198 did not pass style-queue: ERROR: Source/WebKit2/Shared/Authentication/mac/AuthenticationManager.mac.mm:59: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1209544 4 283198 commit-queue 2016-07-10 11:49:33 -0700 Comment on attachment 283198 Patch Clearing flags on attachment: 283198 Committed r203040: <http://trac.webkit.org/changeset/203040> 1209545 5 commit-queue 2016-07-10 11:49:36 -0700 All reviewed patches have been landed. Closing bug. 283188 2016-07-08 12:20:39 -0700 2016-07-08 14:19:46 -0700 Patch bug-159574-20160708122002.patch text/plain 1654 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzAwMSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA3LTA4ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNsaWVu dCBjZXJ0aWZpY2F0ZSBhdXRoZW50aWNhdGlvbiBhZnRlciByMjAwNDYzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1NzQKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI2OTMxMDA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2hhcmVkL0F1dGhlbnRpY2F0aW9uL21hYy9BdXRoZW50aWNhdGlvbk1h bmFnZXIubWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpsZWFmQ2VydGlmaWNhdGUpOgorICAgICAg ICBDbGllbnQgY2VydGlmaWNhdGUgYXV0aGVudGljYXRpb24gc3RpbGwgdXNlcyBjZXJ0aWZpY2F0 ZSBjaGFpbnMgaW5zdGVhZCBvZiBTZWNUcnVzdFJlZnMuCisKIDIwMTYtMDctMDggIEFuZGVycyBD YXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggMzItYml0IGJ1aWxk LgpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0F1dGhlbnRpY2F0aW9uL21hYy9BdXRoZW50 aWNhdGlvbk1hbmFnZXIubWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJl ZC9BdXRoZW50aWNhdGlvbi9tYWMvQXV0aGVudGljYXRpb25NYW5hZ2VyLm1hYy5tbQkocmV2aXNp b24gMjAyOTk0KQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0F1dGhlbnRpY2F0aW9uL21hYy9B dXRoZW50aWNhdGlvbk1hbmFnZXIubWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOSwxMSArMzks MTEgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBzdGF0aWMgU2VjQ2VydGlmaWNhdGVSZWYgbGVhZkNl cnRpZmljYXRlKGNvbnN0IENlcnRpZmljYXRlSW5mbyYgY2VydGlmaWNhdGVJbmZvKQogewogI2lm IEhBVkUoU0VDX1RSVVNUX1NFUklBTElaQVRJT04pCi0gICAgcmV0dXJuIFNlY1RydXN0R2V0Q2Vy dGlmaWNhdGVBdEluZGV4KGNlcnRpZmljYXRlSW5mby50cnVzdCgpLCAwKTsKLSNlbHNlCisgICAg aWYgKGF1dG8gdHJ1c3QgPSBjZXJ0aWZpY2F0ZUluZm8udHJ1c3QoKSkKKyAgICAgICAgcmV0dXJu IFNlY1RydXN0R2V0Q2VydGlmaWNhdGVBdEluZGV4KHRydXN0LCAwKTsKKyNlbmRpZgogICAgIEFT U0VSVChDRkFycmF5R2V0Q291bnQoY2VydGlmaWNhdGVJbmZvLmNlcnRpZmljYXRlQ2hhaW4oKSkp OwogICAgIHJldHVybiAoU2VjQ2VydGlmaWNhdGVSZWYpQ0ZBcnJheUdldFZhbHVlQXRJbmRleChj ZXJ0aWZpY2F0ZUluZm8uY2VydGlmaWNhdGVDaGFpbigpLCAwKTsKLSNlbmRpZgogfQogCiBzdGF0 aWMgTlNBcnJheSAqY2hhaW4oY29uc3QgQ2VydGlmaWNhdGVJbmZvJiBjZXJ0aWZpY2F0ZUluZm8p Cg== 283198 2016-07-08 14:19:49 -0700 2016-07-10 11:49:33 -0700 Patch bug-159574-20160708141912.patch text/plain 4734 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwMzAwNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA3LTA4ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGNsaWVu dCBjZXJ0aWZpY2F0ZSBhdXRoZW50aWNhdGlvbiBhZnRlciByMjAwNDYzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTk1NzQKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzI2OTMxMDA2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gIFdlIHJlYWxseSBuZWVkIGEgdGVzdCBmb3IgdGhp cworCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jZi9DZXJ0aWZpY2F0ZUluZm8uaDoKKyAg ICAgICAgKFdlYkNvcmU6OkNlcnRpZmljYXRlSW5mbzo6Q2VydGlmaWNhdGVJbmZvKToKKyAgICAg ICAgKFdlYkNvcmU6OkNlcnRpZmljYXRlSW5mbzo6dHJ1c3QpOgorICAgICAgICBNYWtlIHN1cmUg d2Ugb25seSBnZXQgdGhlIHRydXN0IGZvciBUcnVzdCB0eXBlIENlcnRpZmljYXRlSW5mb3MuICAK KyAgICAgICAgSWYgd2UgbWl4IHVwIG91ciB0eXBlcywgd2UgZ2V0IHVuZXhwZWN0ZWQgbnVsbHB0 cnMsIHdoaWNoIHdpbGwgY2F1c2UgYXV0aGVudGljYXRpb24gdG8gZmFpbC4KKwogMjAxNi0wNy0w OCAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgUHJldmVudCBm dWxsc2NyZWVuIHZpZGVvIGRpbWVuc2lvbiBzdGF0ZSBmcm9tIGJlaW5nIHJlc2V0IGFmdGVyIGNv bmZpZ3VyaW5nLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9DZXJ0 aWZpY2F0ZUluZm8uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2NmL0NlcnRpZmljYXRlSW5mby5oCShyZXZpc2lvbiAyMDI5OTQpCisrKyBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL0NlcnRpZmljYXRlSW5mby5oCSh3b3JraW5nIGNvcHkp CkBAIC01Myw3ICs1Myw3IEBAIHB1YmxpYzoKICAgICB7CiAgICAgfQogIAotICAgIFNlY1RydXN0 UmVmIHRydXN0KCkgY29uc3QgeyByZXR1cm4gbV90cnVzdC5nZXQoKTsgfQorICAgIFNlY1RydXN0 UmVmIHRydXN0KCkgY29uc3QgeyBBU1NFUlQobV90cnVzdCk7IHJldHVybiBtX3RydXN0LmdldCgp OyB9CiAjZW5kaWYKIAogICAgIENlcnRpZmljYXRlSW5mbyhSZXRhaW5QdHI8Q0ZBcnJheVJlZj4m JiBjZXJ0aWZpY2F0ZUNoYWluKQpJbmRleDogU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwkocmV2aXNpb24gMjAzMDAxKQorKysg U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTYtMDctMDggIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4K KworICAgICAgICBGaXggY2xpZW50IGNlcnRpZmljYXRlIGF1dGhlbnRpY2F0aW9uIGFmdGVyIHIy MDA0NjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1 OTU3NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjY5MzEwMDY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTaGFyZWQvQXV0aGVudGljYXRpb24v bWFjL0F1dGhlbnRpY2F0aW9uTWFuYWdlci5tYWMubW06CisgICAgICAgIChXZWJLaXQ6OmxlYWZD ZXJ0aWZpY2F0ZSk6CisgICAgICAgIChXZWJLaXQ6OmNoYWluKToKKyAgICAgICAgSGFuZGxlIHRo ZSBkaWZmZXJlbnQgdHlwZXMgb2YgQ2VydGlmaWNhdGVJbmZvcy4KKwogMjAxNi0wNy0wOCAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCAzMi1iaXQg YnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXV0aGVudGljYXRpb24vbWFjL0F1 dGhlbnRpY2F0aW9uTWFuYWdlci5tYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIv U2hhcmVkL0F1dGhlbnRpY2F0aW9uL21hYy9BdXRoZW50aWNhdGlvbk1hbmFnZXIubWFjLm1tCShy ZXZpc2lvbiAyMDI5OTQpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQXV0aGVudGljYXRpb24v bWFjL0F1dGhlbnRpY2F0aW9uTWFuYWdlci5tYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTM5LDMy ICszOSwzNCBAQCBuYW1lc3BhY2UgV2ViS2l0IHsKIHN0YXRpYyBTZWNDZXJ0aWZpY2F0ZVJlZiBs ZWFmQ2VydGlmaWNhdGUoY29uc3QgQ2VydGlmaWNhdGVJbmZvJiBjZXJ0aWZpY2F0ZUluZm8pCiB7 CiAjaWYgSEFWRShTRUNfVFJVU1RfU0VSSUFMSVpBVElPTikKLSAgICByZXR1cm4gU2VjVHJ1c3RH ZXRDZXJ0aWZpY2F0ZUF0SW5kZXgoY2VydGlmaWNhdGVJbmZvLnRydXN0KCksIDApOwotI2Vsc2UK KyAgICBpZiAoY2VydGlmaWNhdGVJbmZvLnR5cGUoKSA9PSBDZXJ0aWZpY2F0ZUluZm86OlR5cGU6 OlRydXN0KQorICAgICAgICByZXR1cm4gU2VjVHJ1c3RHZXRDZXJ0aWZpY2F0ZUF0SW5kZXgoY2Vy dGlmaWNhdGVJbmZvLnRydXN0KCksIDApOworI2VuZGlmCisgICAgQVNTRVJUKGNlcnRpZmljYXRl SW5mby50eXBlKCkgPT0gQ2VydGlmaWNhdGVJbmZvOjpUeXBlOjpDZXJ0aWZpY2F0ZUNoYWluKTsK ICAgICBBU1NFUlQoQ0ZBcnJheUdldENvdW50KGNlcnRpZmljYXRlSW5mby5jZXJ0aWZpY2F0ZUNo YWluKCkpKTsKICAgICByZXR1cm4gKFNlY0NlcnRpZmljYXRlUmVmKUNGQXJyYXlHZXRWYWx1ZUF0 SW5kZXgoY2VydGlmaWNhdGVJbmZvLmNlcnRpZmljYXRlQ2hhaW4oKSwgMCk7Ci0jZW5kaWYKIH0K IAogc3RhdGljIE5TQXJyYXkgKmNoYWluKGNvbnN0IENlcnRpZmljYXRlSW5mbyYgY2VydGlmaWNh dGVJbmZvKQogewogI2lmIEhBVkUoU0VDX1RSVVNUX1NFUklBTElaQVRJT04pCi0gICAgQ0ZJbmRl eCBjb3VudCA9IFNlY1RydXN0R2V0Q2VydGlmaWNhdGVDb3VudChjZXJ0aWZpY2F0ZUluZm8udHJ1 c3QoKSk7Ci0gICAgaWYgKGNvdW50IDwgMikKLSAgICAgICAgcmV0dXJuIG5pbDsKLQotICAgIE5T TXV0YWJsZUFycmF5ICphcnJheSA9IFtOU011dGFibGVBcnJheSBhcnJheV07Ci0gICAgZm9yIChD RkluZGV4IGkgPSAxOyBpIDwgY291bnQ7ICsraSkKLSAgICAgICAgW2FycmF5IGFkZE9iamVjdDoo aWQpU2VjVHJ1c3RHZXRDZXJ0aWZpY2F0ZUF0SW5kZXgoY2VydGlmaWNhdGVJbmZvLnRydXN0KCks IGkpXTsKLSAgICAgICAgCi0gICAgcmV0dXJuIGFycmF5OwotI2Vsc2UKKyAgICBpZiAoY2VydGlm aWNhdGVJbmZvLnR5cGUoKSA9PSBDZXJ0aWZpY2F0ZUluZm86OlR5cGU6OlRydXN0KSB7CisgICAg ICAgIENGSW5kZXggY291bnQgPSBTZWNUcnVzdEdldENlcnRpZmljYXRlQ291bnQoY2VydGlmaWNh dGVJbmZvLnRydXN0KCkpOworICAgICAgICBpZiAoY291bnQgPCAyKQorICAgICAgICAgICAgcmV0 dXJuIG5pbDsKKworICAgICAgICBOU011dGFibGVBcnJheSAqYXJyYXkgPSBbTlNNdXRhYmxlQXJy YXkgYXJyYXldOworICAgICAgICBmb3IgKENGSW5kZXggaSA9IDE7IGkgPCBjb3VudDsgKytpKQor ICAgICAgICAgICAgW2FycmF5IGFkZE9iamVjdDooaWQpU2VjVHJ1c3RHZXRDZXJ0aWZpY2F0ZUF0 SW5kZXgoY2VydGlmaWNhdGVJbmZvLnRydXN0KCksIGkpXTsKKyAgICAgICAgICAgIAorICAgICAg ICByZXR1cm4gYXJyYXk7CisgICAgfQorI2VuZGlmCisgICAgQVNTRVJUKGNlcnRpZmljYXRlSW5m by50eXBlKCkgPT0gQ2VydGlmaWNhdGVJbmZvOjpUeXBlOjpDZXJ0aWZpY2F0ZUNoYWluKTsKICAg ICBDRkluZGV4IGNoYWluQ291bnQgPSBDRkFycmF5R2V0Q291bnQoY2VydGlmaWNhdGVJbmZvLmNl cnRpZmljYXRlQ2hhaW4oKSk7CiAgICAgcmV0dXJuIGNoYWluQ291bnQgPiAxID8gWyhOU0FycmF5 ICopY2VydGlmaWNhdGVJbmZvLmNlcnRpZmljYXRlQ2hhaW4oKSBzdWJhcnJheVdpdGhSYW5nZTpO U01ha2VSYW5nZSgxLCBjaGFpbkNvdW50IC0gMSldIDogbmlsOwotI2VuZGlmCiB9CiAKLQogLy8g RklYTUU6IFRoaXMgZnVuY3Rpb24gY3JlYXRlcyBhbiBpZGVudGl0eSBmcm9tIGEgY2VydGlmaWNh dGUsIHdoaWNoIHNob3VsZCBub3QgYmUgbmVlZGVkLiBXZSBzaG91bGQgcGFzcyBhbiBpZGVudGl0 eSBvdmVyIElQQyAoYXMgd2UgZG8gb24gaU9TKS4KIGJvb2wgQXV0aGVudGljYXRpb25NYW5hZ2Vy Ojp0cnlVc2VDZXJ0aWZpY2F0ZUluZm9Gb3JDaGFsbGVuZ2UoY29uc3QgQXV0aGVudGljYXRpb25D aGFsbGVuZ2UmIGNoYWxsZW5nZSwgY29uc3QgQ2VydGlmaWNhdGVJbmZvJiBjZXJ0aWZpY2F0ZUlu Zm8sIGNvbnN0IENoYWxsZW5nZUNvbXBsZXRpb25IYW5kbGVyJiBjb21wbGV0aW9uSGFuZGxlcikK IHsK