159571 2016-07-08 11:41:33 -0700 speculateTypedArrayIsNotNeutered has an inverted speculation 2016-07-08 11:51:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue mark.lam msaboff saam oldest_to_newest 1209213 0 keith_miller 2016-07-08 11:41:33 -0700 speculateTypedArrayIsNotNeutered has an inverted speculation 1209214 1 283185 keith_miller 2016-07-08 11:44:33 -0700 Created attachment 283185 Patch 1209215 2 283185 mark.lam 2016-07-08 11:45:51 -0700 Comment on attachment 283185 Patch r=me Got tests? 1209216 3 keith_miller 2016-07-08 11:46:44 -0700 (In reply to comment #2) > Comment on attachment 283185 [details] > Patch > > r=me > > Got tests? It's already breaking tests on ToT but only if we eagerly FTL. 1209217 4 mark.lam 2016-07-08 11:47:45 -0700 (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 283185 [details] > > Patch > > > > r=me > > > > Got tests? > > It's already breaking tests on ToT but only if we eagerly FTL. Can you add a comment in the ChangeLog about which tests will break? Why is it not breaking on the test bots? Do we need to change a config on that test? 1209219 5 keith_miller 2016-07-08 11:49:06 -0700 Committed r202997: <http://trac.webkit.org/changeset/202997> 1209221 6 keith_miller 2016-07-08 11:51:22 -0700 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Comment on attachment 283185 [details] > > > Patch > > > > > > r=me > > > > > > Got tests? > > > > It's already breaking tests on ToT but only if we eagerly FTL. > > Can you add a comment in the ChangeLog about which tests will break? Why is > it not breaking on the test bots? Do we need to change a config on that > test? I'll make it clearer in the Changelog that there is already a test failing on the bots. 283185 2016-07-08 11:44:33 -0700 2016-07-08 11:45:51 -0700 Patch bug-159571-20160708114357.patch text/plain 1743 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 NTRjODE4M2MxOTZlOTM5ZTI4ODcwZTI2MjYxMjA5MjM4MmVkODk1Li45MGUyYzMzOWJkMGM1OWQ2 NzgxN2NmM2I4OGYzMzRmMGY1MjBhZDQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOSBAQAogMjAxNi0wNy0wOCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBzcGVjdWxhdGVUeXBlZEFycmF5SXNOb3ROZXV0ZXJlZCBoYXMgYW4g aW52ZXJ0ZWQgc3BlY3VsYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTU3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZvciBzb21lIGNvbmZ1c2luZyByZWFzb24gRlRMTG93ZXJERkdUb0IzIHRh a2VzIHRoZSBjb25kaXRpb24gdGhlCisgICAgICAgIHNwZWN1bGF0aW9uIHdhbnRzIHRvIGJlIGZh bHNlLiBUaGlzIGlzc3VlIGNhdXNlZAorICAgICAgICB0eXBlZGFycmF5LWFjY2Vzcy1tb25vbW9y cGhpYy1uZXV0ZXJlZC5qcyB0byBmYWlsLgorCisgICAgICAgICogZnRsL0ZUTExvd2VyREZHVG9C My5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpMb3dlckRGR1RvQjM6OnNwZWN1bGF0ZVR5 cGVkQXJyYXlJc05vdE5ldXRlcmVkKToKKworMjAxNi0wNy0wOCAgS2VpdGggTWlsbGVyICA8a2Vp dGhfbWlsbGVyQGFwcGxlLmNvbT4KKwogICAgICAgICBUeXBlZEFycmF5cyBuZWVkIG1vcmUgaXNO ZXV0ZXJlZCBjaGVja3MuCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNTkyMzEKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9G VExMb3dlckRGR1RvQjMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Z0bC9GVExMb3dlckRG R1RvQjMuY3BwCmluZGV4IDNmYjc4NzM4OTRkNDQ3NGY4Y2JiMTE1YzJkZDVjYTg5OTE2NGI5YmYu LmQ1MjNlODAzY2IzZjQwZDgxMjM5YzBjNTAyOGY2ZDMwODViNGY0NzUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5jcHAKQEAgLTEwNjA0LDcgKzEwNjA0 LDcgQEAgcHJpdmF0ZToKIAogICAgICAgICBMQmFzaWNCbG9jayBsYXN0TmV4dCA9IG1fb3V0LmFw cGVuZFRvKGlzV2FzdGVmdWwsIGNvbnRpbnVhdGlvbik7CiAgICAgICAgIExWYWx1ZSB2ZWN0b3Ig PSBtX291dC5sb2FkUHRyKGJhc2UsIG1faGVhcHMuSlNBcnJheUJ1ZmZlclZpZXdfdmVjdG9yKTsK LSAgICAgICAgc3BlY3VsYXRlKFVuY291bnRhYmxlLCBqc1ZhbHVlVmFsdWUodmVjdG9yKSwgbV9u b2RlLCBtX291dC5ub3RaZXJvNjQodmVjdG9yKSk7CisgICAgICAgIHNwZWN1bGF0ZShVbmNvdW50 YWJsZSwganNWYWx1ZVZhbHVlKHZlY3RvciksIG1fbm9kZSwgbV9vdXQuaXNaZXJvNjQodmVjdG9y KSk7CiAgICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0aW9uKTsKIAogICAgICAgICBtX291dC5h cHBlbmRUbyhjb250aW51YXRpb24sIGxhc3ROZXh0KTsK