159567 2016-07-08 09:48:38 -0700 System proxy settings not used when building deps with jhbuild 2016-07-11 11:05:54 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned annulen bugs-noreply cgarcia commit-queue fujii loic.yhuel mcatanzaro pnormand zan oldest_to_newest 1209160 0 olivier.blin 2016-07-08 09:48:38 -0700 The system proxy settings (dconf org.gnome.system.proxy) are not used by WebKitGTK when deps have been built through jhbuild. 1209168 1 283179 olivier.blin 2016-07-08 09:58:22 -0700 Created attachment 283179 Patch 1209169 2 olivier.blin 2016-07-08 10:02:55 -0700 This is my first attempt, mostly for reference. It enables dconf and gnome proxy modules in gio, in the jhbuild root. The disadvantage is that it pulls dconf in the jhbuild modules for everyone, as pointed by Konstantin. Fujii suggested instead to use the libproxy support in glib-networking. I'll post a second patch to do that. 1209182 3 annulen 2016-07-08 10:19:05 -0700 I think there is no need to build libproxy with jhbuild, just add appropriate packages to Tools/gtk/install-dependencies (and also for EFL if you like). glib-networking activates proxy support automatically when building if libproxy headers are available. 1209183 4 olivier.blin 2016-07-08 10:20:21 -0700 (In reply to comment #3) > I think there is no need to build libproxy with jhbuild, just add > appropriate packages to Tools/gtk/install-dependencies (and also for EFL if > you like). glib-networking activates proxy support automatically when > building if libproxy headers are available. Yes, that's what I plan to propose as a patch, once I get this working. 1209601 5 pnormand 2016-07-11 00:13:22 -0700 Not sure you saw this Wiki page? https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy I don't think we need a patch for this. 1209622 6 olivier.blin 2016-07-11 06:00:11 -0700 (In reply to comment #5) > Not sure you saw this Wiki page? > > https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy > > I don't think we need a patch for this. I was not aware of this wiki page, building dconf this way is a good solution. Though, on my system, this didn't work by default, since libgiognomeproxy.so was not built in glib-networking, because gsettings.m4 was not installed on my system. What do you think of just adding the following in Tools/gtk/install-dependencies? - gsettings-desktop-schemas-dev: for gsettings.m4, to enable libgiognomeproxy.so in libnetworking - libproxy-dev: to enable libgiolibproxy.so in glib-networking for generic proxy support, including through environment variables libproxy support in glib-networking works for me without dconf, provided I unset GNOME_DESKTOP_SESSION_ID, in which case it uses the usual proxy environment variables (envvar libproxy module). Otherwise, it uses the gnome3 libproxy module, which will use system proxy settings only if the libdconfsettings.so gio module is available in the jhbuild root. 1209629 7 mcatanzaro 2016-07-11 06:46:28 -0700 Good investigation. I've never understood why we have so many different proxy modules. (In reply to comment #6) > What do you think of just adding the following in > Tools/gtk/install-dependencies? > - gsettings-desktop-schemas-dev: for gsettings.m4, to enable > libgiognomeproxy.so in libnetworking > - libproxy-dev: to enable libgiolibproxy.so in glib-networking for generic > proxy support, including through environment variables Sounds good to me. Please look up the Arch dependencies too; you can use the package search on https://www.archlinux.org/ 1209675 8 283319 olivier.blin 2016-07-11 09:20:11 -0700 Created attachment 283319 Patch 1209705 9 283319 commit-queue 2016-07-11 11:05:48 -0700 Comment on attachment 283319 Patch Clearing flags on attachment: 283319 Committed r203069: <http://trac.webkit.org/changeset/203069> 1209706 10 commit-queue 2016-07-11 11:05:54 -0700 All reviewed patches have been landed. Closing bug. 283179 2016-07-08 09:58:22 -0700 2016-07-11 09:20:02 -0700 Patch bug-159567-20160708185746.patch text/plain 3119 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWMzMzA2MWYyY2RhMGYzZTM0NjUyMGU5YTAzZDZiNDZl Mzg2OWVkNy4uOTIyOGQ0MWEwZTQyMjlmYTJiM2EyZGY5NTFhMDlmNDhkYzlhMzRkNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDE2LTA3LTA4ICBPbGl2aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5j b20+CisKKyAgICAgICAgU3lzdGVtIHByb3h5IHNldHRpbmdzIG5vdCB1c2VkIHdoZW4gYnVpbGRp bmcgZGVwcyB3aXRoIGpoYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTU2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcHVsbHMgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXZlbCBi dWlsZCBkZXAgdG8gZW5hYmxlIHRoZQorICAgICAgICBsaWJnaW9nbm9tZXByb3h5LnNvIGdpbyBt b2R1bGUgaW4gZ2xpYi1uZXR3b3JraW5nLCB3aGljaCB1c2VzCisgICAgICAgIEdTZXR0aW5ncyBv biBvcmcuZ25vbWUuc3lzdGVtLnByb3h5LgorCisgICAgICAgIEl0IGFsc28gYWRkcyBhIGRjb25m IGpoYnVpbGQgbW9kdWxlIHRvIGJ1aWxkIHRoZQorICAgICAgICBsaWJkY29uZnNldHRpbmdzLnNv IGdpbyBtb2R1bGUgZm9yIEdTZXR0aW5ncy4KKyAgICAgICAgZGNvbmYgbmVlZHMgdmFsYSBhcyBh IGJ1aWxkIGRlcC4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKyAgICAg ICAgKiBndGsvamhidWlsZC5tb2R1bGVzOgorCiAyMDE2LTA3LTA4ICBLb25zdGFudGluIFRva2Fy ZXYgIDxhbm51bGVuQHlhbmRleC5ydT4KIAogICAgICAgICBSZW1vdmVkIFF0IGxlZnRvdmVycyBm cm9tIFRvb2xzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzIGIv VG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCmluZGV4IDBmNTk4NTA5YmQ5ZjIxNzIzYjUz NmJlMTg5YTViNDdjNDE3YWYwZDcuLjFiMDhmNjQxM2FjZDFjNmNjNWFhNjE2MDRlNjY5MWYyNGVh NTcwN2IgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcworKysgYi9U b29scy9ndGsvaW5zdGFsbC1kZXBlbmRlbmNpZXMKQEAgLTE1MCw2ICsxNTAsNyBAQCBmdW5jdGlv biBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aEFwdCB7CiAgICAgcGFja2FnZXM9IiRwYWNrYWdlcyBc CiAgICAgICAgIGdpdCBcCiAgICAgICAgIGdvYmplY3QtaW50cm9zcGVjdGlvbiBcCisgICAgICAg IGdzZXR0aW5ncy1kZXNrdG9wLXNjaGVtYXMtZGV2IFwKICAgICAgICAgaWNvbi1uYW1pbmctdXRp bHMgXAogICAgICAgICBsaWJjcm9jbzMtZGV2IFwKICAgICAgICAgbGliZHJtLWRldiBcCkBAIC0x ODAsNiArMTgxLDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAg ICAgICBsbHZtLWRldiBcCiAgICAgICAgIHB5dGhvbi1kZXYgXAogICAgICAgICByYWdlbCBcCisg ICAgICAgIHZhbGFjIFwKICAgICAgICAgeDExcHJvdG8tYmlncmVxcy1kZXYgXAogICAgICAgICB4 MTFwcm90by1jb21wb3NpdGUtZGV2IFwKICAgICAgICAgeDExcHJvdG8tZ2wtZGV2IFwKQEAgLTQy OCw2ICs0MzAsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aERuZiB7CiAgICAg ICAgIGRvY2Jvb2stdXRpbHMtcGRmIFwKICAgICAgICAgZ2l0IFwKICAgICAgICAgZ29iamVjdC1p bnRyb3NwZWN0aW9uIFwKKyAgICAgICAgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXZlbCBc CiAgICAgICAgIGljb24tbmFtaW5nLXV0aWxzIFwKICAgICAgICAgaXRzdG9vbCBcCiAgICAgICAg IGxpYlhmb250LWRldmVsIFwKQEAgLTQ0Nyw2ICs0NTAsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVw ZW5kZW5jaWVzV2l0aERuZiB7CiAgICAgICAgIG10ZGV2LWRldmVsIFwKICAgICAgICAgcmFnZWwg XAogICAgICAgICBzeXN0ZW1kLWRldmVsIFwKKyAgICAgICAgdmFsYSBcCiAgICAgICAgIHhvcmct eDExLWZvbnQtdXRpbHMgXAogICAgICAgICB4b3JnLXgxMS1wcm90by1kZXZlbCBcCiAgICAgICAg IHhvcmcteDExLXV0aWwtbWFjcm9zIFwKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1v ZHVsZXMgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVzCmluZGV4IDAyZDQyYWI1MGJmOTE3NjA3 ODAwN2NmMDI3YWY5OTBkMWVhZjEwOTMuLjZjODE3YjU1OTNmY2NkMzgyNTViNTM1OTM1MDc1NzBl YTIxYTIyZTAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMKKysrIGIvVG9v bHMvZ3RrL2poYnVpbGQubW9kdWxlcwpAQCAtMTcsNiArMTcsNyBAQAogICAgICAgPGRlcCBwYWNr YWdlPSJndGsrIi8+CiAgICAgICA8ZGVwIHBhY2thZ2U9ImdsaWIiLz4KICAgICAgIDxkZXAgcGFj a2FnZT0iZ2xpYi1uZXR3b3JraW5nIi8+CisgICAgICA8ZGVwIHBhY2thZ2U9ImRjb25mIi8+CiAg ICAgICA8ZGVwIHBhY2thZ2U9Imdub21lLWljb24tdGhlbWUiLz4KICAgICAgIDxkZXAgcGFja2Fn ZT0iZ25vbWUtaWNvbi10aGVtZS1zeW1ib2xpYyIvPgogICAgICAgPGRlcCBwYWNrYWdlPSJnbm9t ZS10aGVtZXMtc3RhbmRhcmQiLz4KQEAgLTIyNCw2ICsyMjUsMTQgQEAKICAgICAgICAgICAgIG1k NXN1bT0iZjg4ZTE2MzMyMmMwODM0Zjk3ODFkNjIyNDc3MWFiMmUiLz4KICAgPC9hdXRvdG9vbHM+ CiAKKyAgPGF1dG90b29scyBpZD0iZGNvbmYiPgorICAgIDxkZXBlbmRlbmNpZXM+CisgICAgICA8 ZGVwIHBhY2thZ2U9ImdsaWIiLz4KKyAgICA8L2RlcGVuZGVuY2llcz4KKyAgICA8YnJhbmNoIG1v ZHVsZT0iZGNvbmYiIHZlcnNpb249IjAuMjYuMCIKKyAgICAgICAgICAgIHJlcG89ImdpdC5nbm9t ZS5vcmciLz4KKyAgPC9hdXRvdG9vbHM+CisKICAgPGF1dG90b29scyBpZD0ibGlic291cCIKICAg ICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS13aXRob3V0LWdub21lIC0tZGlzYWJsZS1pbnRyb3Nw ZWN0aW9uIj4KICAgICA8aWYgY29uZGl0aW9uLXNldD0ibWFjb3MiPgo= 283319 2016-07-11 09:20:11 -0700 2016-07-11 11:05:48 -0700 Patch bug-159567-20160711181929.patch text/plain 3220 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWMzMzA2MWYyY2RhMGYzZTM0NjUyMGU5YTAzZDZiNDZl Mzg2OWVkNy4uMTdhOWE2MGQ1OTc3M2JkZWFjYjE2YjAzMWQyOTVlNjg5NTVlYjE2MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMw IEBACisyMDE2LTA3LTExICBPbGl2aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5j b20+CisKKyAgICAgICAgU3lzdGVtIHByb3h5IHNldHRpbmdzIG5vdCB1c2VkIHdoZW4gYnVpbGRp bmcgZGVwcyB3aXRoIGpoYnVpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE1OTU2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgYWRkcyB0aGUgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXZl bCBidWlsZCBkZXAgdG8gZW5hYmxlCisgICAgICAgIHRoZSBsaWJnaW9nbm9tZXByb3h5LnNvIGdp byBtb2R1bGUgaW4gZ2xpYi1uZXR3b3JraW5nLCB3aGljaCB1c2VzCisgICAgICAgIEdTZXR0aW5n cyBvbiBvcmcuZ25vbWUuc3lzdGVtLnByb3h5LgorICAgICAgICBUaGlzIGlzIG5lZWRlZCB0byBx dWVyeSBzeXN0ZW0gcHJveHkgc2V0dGluZ3MgZm9yIEdub21lIGRlc2t0b3BzLgorCisgICAgICAg IGRjb25mIGNhbiBiZSBtYW51YWxseSBhZGRlZCB0byBqaGJ1aWxkIHRvIGJ1aWxkIHRoZQorICAg ICAgICBsaWJkY29uZnNldHRpbmdzLnNvIGdpbyBtb2R1bGUgZm9yIEdTZXR0aW5ncywgc28gdGhh dAorICAgICAgICBsaWJnaW9nbm9tZXByb3h5LnNvIGNhbiBhY2Nlc3Mgc3lzdGVtIHNldHRpbmdz LgorICAgICAgICAgIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvV2ViS2l0R1RLL1N0YXJ0 SGFja2luZyNXb3JraW5nYmVoaW5kYXByb3h5CisKKyAgICAgICAgQXMgYW4gYWx0ZXJuYXRpdmUg dG8gZGNvbmYgc2V0dGluZ3MsIHRoaXMgY29tbWl0IGFsc28gYWRkcyB0aGUKKyAgICAgICAgbGli cHJveHktZGV2ZWwgYnVpbGQgZGVwIHRvIGVuYWJsZSB0aGUgbGliZ2lvbGlicHJveHkuc28gbW9k dWxlIGluCisgICAgICAgIGdsaWItbmV0d29ya2luZyAoc3VnZ2VzdGVkIGJ5IEZ1amlpIEhpcm9u b3JpKS4KKworICAgICAgICBJdCBpcyB1c2VmdWwgdG8gcmVhZCBwcm94eSBzZXR0aW5ncyBmcm9t IGVudmlyb25tZW50IHZhcmlhYmxlcy4KKyAgICAgICAgRnJvbSBhIEdub21lIGRlc2t0b3AsIG9u ZSBtYXkgdW5zZXQgdGhlIEdOT01FX0RFU0tUT1BfU0VTU0lPTl9JRAorICAgICAgICBlbnZpcm9u bWVudCB2YXJpYWJsZSB0byBmb3JjZSB1c2luZyB0aGUgZW52dmFyIG1vZHVsZSBpbiBsaWJwcm94 eS4KKworICAgICAgICAqIGd0ay9pbnN0YWxsLWRlcGVuZGVuY2llczoKKwogMjAxNi0wNy0wOCAg S29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAKICAgICAgICAgUmVtb3Zl ZCBRdCBsZWZ0b3ZlcnMgZnJvbSBUb29scy4KZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9pbnN0YWxs LWRlcGVuZGVuY2llcyBiL1Rvb2xzL2d0ay9pbnN0YWxsLWRlcGVuZGVuY2llcwppbmRleCAwZjU5 ODUwOWJkOWYyMTcyM2I1MzZiZTE4OWE1YjQ3YzQxN2FmMGQ3Li4zMjdiYTcwZDZjODNhMDViOTFj NDZkYjBjYjdhNDAyMzc0MTdiZWRlIDEwMDc1NQotLS0gYS9Ub29scy9ndGsvaW5zdGFsbC1kZXBl bmRlbmNpZXMKKysrIGIvVG9vbHMvZ3RrL2luc3RhbGwtZGVwZW5kZW5jaWVzCkBAIC0xNTAsNiAr MTUwLDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVuY2llc1dpdGhBcHQgewogICAgIHBhY2th Z2VzPSIkcGFja2FnZXMgXAogICAgICAgICBnaXQgXAogICAgICAgICBnb2JqZWN0LWludHJvc3Bl Y3Rpb24gXAorICAgICAgICBnc2V0dGluZ3MtZGVza3RvcC1zY2hlbWFzLWRldiBcCiAgICAgICAg IGljb24tbmFtaW5nLXV0aWxzIFwKICAgICAgICAgbGliY3JvY28zLWRldiBcCiAgICAgICAgIGxp YmRybS1kZXYgXApAQCAtMTY3LDYgKzE2OCw3IEBAIGZ1bmN0aW9uIGluc3RhbGxEZXBlbmRlbmNp ZXNXaXRoQXB0IHsKICAgICAgICAgbGlib3JjLTAuNC1kZXYgXAogICAgICAgICBsaWJwMTEta2l0 LWRldiBcCiAgICAgICAgIGxpYnBjaWFjY2Vzcy1kZXYgXAorICAgICAgICBsaWJwcm94eS1kZXYg XAogICAgICAgICBsaWJzc2wtZGV2IFwKICAgICAgICAgbGlidGlmZjUtZGV2IFwKICAgICAgICAg bGlidjRsLWRldiBcCkBAIC0zMDIsNiArMzA0LDcgQEAgZnVuY3Rpb24gaW5zdGFsbERlcGVuZGVu Y2llc1dpdGhQYWNtYW4gewogICAgICAgICBleHBhdCBcCiAgICAgICAgIGdpdCBcCiAgICAgICAg IGdvYmplY3QtaW50cm9zcGVjdGlvbiBcCisgICAgICAgIGdzZXR0aW5ncy1kZXNrdG9wLXNjaGVt YXMgXAogICAgICAgICBpY29uLW5hbWluZy11dGlscyBcCiAgICAgICAgIGxpYmNyb2NvIFwKICAg ICAgICAgbGliZHJtIFwKQEAgLTMxMiw2ICszMTUsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5k ZW5jaWVzV2l0aFBhY21hbiB7CiAgICAgICAgIGxpYmlucHV0IFwKICAgICAgICAgcDExLWtpdCBc CiAgICAgICAgIGxpYnBjaWFjY2VzcyBcCisgICAgICAgIGxpYnByb3h5IFwKICAgICAgICAgbGli dGlmZiBcCiAgICAgICAgIGxpYnhmaXhlcyBcCiAgICAgICAgIGxpYnhmb250IFwKQEAgLTQyOCw2 ICs0MzIsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5kZW5jaWVzV2l0aERuZiB7CiAgICAgICAg IGRvY2Jvb2stdXRpbHMtcGRmIFwKICAgICAgICAgZ2l0IFwKICAgICAgICAgZ29iamVjdC1pbnRy b3NwZWN0aW9uIFwKKyAgICAgICAgZ3NldHRpbmdzLWRlc2t0b3Atc2NoZW1hcy1kZXZlbCBcCiAg ICAgICAgIGljb24tbmFtaW5nLXV0aWxzIFwKICAgICAgICAgaXRzdG9vbCBcCiAgICAgICAgIGxp Ylhmb250LWRldmVsIFwKQEAgLTQ0MCw2ICs0NDUsNyBAQCBmdW5jdGlvbiBpbnN0YWxsRGVwZW5k ZW5jaWVzV2l0aERuZiB7CiAgICAgICAgIGxpYmlucHV0LWRldmVsIFwKICAgICAgICAgbGlicDEx LWRldmVsIFwKICAgICAgICAgbGlicGNpYWNjZXNzLWRldmVsIFwKKyAgICAgICAgbGlicHJveHkt ZGV2ZWwgXAogICAgICAgICBsaWJ0aWZmLWRldmVsIFwKICAgICAgICAgbGlieGNiLWRldmVsIFwK ICAgICAgICAgbGlieGtiZmlsZS1kZXZlbCBcCg==