159564 2016-07-08 09:35:24 -0700 Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975 2016-07-12 10:44:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen bburg commit-queue glenn lforschler oldest_to_newest 1209144 0 youennf 2016-07-08 09:35:24 -0700 The option --with-wrapper-files should be changed to --wrappers 1209148 1 283173 youennf 2016-07-08 09:37:06 -0700 Created attachment 283173 Patch 1209164 2 youennf 2016-07-08 09:56:03 -0700 I was thinking that bots were running builtin generation tests. But it seems this is not the case, or not with the run-builtins-generator-tests at least. It might be good to add such tests I guess. 1210078 3 283173 bburg 2016-07-12 10:21:43 -0700 Comment on attachment 283173 Patch r=me 1210079 4 bburg 2016-07-12 10:22:27 -0700 (In reply to comment #2) > I was thinking that bots were running builtin generation tests. > But it seems this is not the case, or not with the > run-builtins-generator-tests at least. > It might be good to add such tests I guess. They don't. I've asked many times for other random test suites to run with EWS and bots. 1210081 5 youennf 2016-07-12 10:25:03 -0700 (In reply to comment #4) > (In reply to comment #2) > > I was thinking that bots were running builtin generation tests. > > But it seems this is not the case, or not with the > > run-builtins-generator-tests at least. > > It might be good to add such tests I guess. > > They don't. I've asked many times for other random test suites to run with > EWS and bots. I'll prepare a patch for ESW. As of bots, I also requested that, maybe it is just a matter of preparing a patch as well. 1210082 6 youennf 2016-07-12 10:25:09 -0700 (In reply to comment #4) > (In reply to comment #2) > > I was thinking that bots were running builtin generation tests. > > But it seems this is not the case, or not with the > > run-builtins-generator-tests at least. > > It might be good to add such tests I guess. > > They don't. I've asked many times for other random test suites to run with > EWS and bots. I'll prepare a patch for ESW. As of bots, I also requested that, maybe it is just a matter of preparing a patch as well. 1210089 7 283173 commit-queue 2016-07-12 10:44:14 -0700 Comment on attachment 283173 Patch Clearing flags on attachment: 283173 Committed r203118: <http://trac.webkit.org/changeset/203118> 1210090 8 commit-queue 2016-07-12 10:44:18 -0700 All reviewed patches have been landed. Closing bug. 283173 2016-07-08 09:37:06 -0700 2016-07-12 10:44:14 -0700 Patch bug-159564-20160708183630.patch text/plain 1263 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWMzMzA2MWYyY2RhMGYzZTM0NjUyMGU5YTAzZDZiNDZl Mzg2OWVkNy4uNGQzZDUxOGFiNDFhOThkZTUzNjBjM2I0ZTdlMGFlOWViOTRlMzFhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE2LTA3LTA4ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBGaXhpbmcgVG9vbHMvU2NyaXB0cy9ydW4tYnVpbHRpbnMtZ2VuZXJhdG9yLXRlc3RzIGFm dGVyIGh0dHBzOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC8yMDI5NzUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1OTU2NAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9j b2RlZ2VuL21haW4ucHk6CisgICAgICAgIChCdWlsdGluc0dlbmVyYXRvclRlc3RzLmdlbmVyYXRl X2Zyb21fanNfYnVpbHRpbnMpOiBDaGFuZ2luZyAtLXdpdGgtd3JhcHBlci1maWxlcyBvcHRpb24g dG8gLS13cmFwcGVycy4KKwogMjAxNi0wNy0wOCAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxl bkB5YW5kZXgucnU+CiAKICAgICAgICAgUmVtb3ZlZCBRdCBsZWZ0b3ZlcnMgZnJvbSBUb29scy4K ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29kZWdlbi9tYWluLnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb2RlZ2VuL21haW4ucHkKaW5kZXggMTQzYmYxNmViZjU1Yjlm ZDExYjYzMjU5OGEyODMyZTgyZDIwY2ZmMi4uY2I4ODRkMWE1Y2JhZTIyNzgyY2M0MDA4Nzc4ODVm M2FlYTdjMjM2NiAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb2RlZ2VuL21h aW4ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb2RlZ2VuL21haW4ucHkKQEAgLTQ5 LDcgKzQ5LDcgQEAgY2xhc3MgQnVpbHRpbnNHZW5lcmF0b3JUZXN0czoKICAgICAgICAgICAgIGNt ZC5hcHBlbmQoJy0tY29tYmluZWQnKQogCiAgICAgICAgIGlmIGdlbmVyYXRlX3dyYXBwZXI6Ci0g ICAgICAgICAgICBjbWQuYXBwZW5kKCctLXdpdGgtd3JhcHBlci1maWxlcycpCisgICAgICAgICAg ICBjbWQuYXBwZW5kKCctLXdyYXBwZXJzJykKIAogICAgICAgICBjbWQuYXBwZW5kKGJ1aWx0aW5z X2ZpbGUpCiAK