159563 2016-07-08 09:31:17 -0700 AX: Eliminate test noise from roles-computedRoleString.html 2016-07-08 11:02:39 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Trivial --- 1 jdiggs jdiggs aboxhall apinheiro cfleizach commit-queue dmazzoni jcraig mario samuel_white webkit-bug-importer oldest_to_newest 1209140 0 jdiggs 2016-07-08 09:31:17 -0700 The expectations for roles-computedRoleString.html include a " X" at the top. This " X" is noise, and unintentional noise at that. (We try to hide all the content; we're just missing some.) And its presence can trigger false positives such as what is seen in bug 139403. At some point we can consider always hiding the content (when it is unrelated to what is being tested) for all of our tests. In the meantime, I see no good reason why the "fix" for the issue in bug 139403 should be to update the noise. 1209141 1 webkit-bug-importer 2016-07-08 09:31:47 -0700 <rdar://problem/27247069> 1209143 2 283171 jdiggs 2016-07-08 09:34:16 -0700 Created attachment 283171 Patch 1209198 3 283171 commit-queue 2016-07-08 11:02:34 -0700 Comment on attachment 283171 Patch Clearing flags on attachment: 283171 Committed r202994: <http://trac.webkit.org/changeset/202994> 1209199 4 commit-queue 2016-07-08 11:02:39 -0700 All reviewed patches have been landed. Closing bug. 283171 2016-07-08 09:34:16 -0700 2016-07-08 11:02:34 -0700 Patch bug-159563-20160708123340.patch text/plain 3987 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjAyOTc4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2MzZWM0YzM3MzUzYzdjYzE2NDYy OTVkMDQyYmFmNjIwY2JmYTQ0NC4uNDU3MTU5ZmUxYTk0YjdhNDU0YTE5MDRlYTNjYjc2ZGE1NzU2 NjJkMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA3LTA4ICBKb2FubWFyaWUgRGlnZ3Mg IDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogRWxpbWluYXRlIHRlc3Qgbm9pc2Ug ZnJvbSByb2xlcy1jb21wdXRlZFJvbGVTdHJpbmcuaHRtbAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTU5NTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIHdlIGhpZGUgYWxsIHRoZSBjb250ZW50 LCBhcyB0aGUgdGVzdCBpbnRlbmRzIHRvIGRvLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9y b2xlcy1jb21wdXRlZFJvbGVTdHJpbmctZXhwZWN0ZWQudHh0OiBVcGRhdGVkLgorICAgICAgICAq IGFjY2Vzc2liaWxpdHkvcm9sZXMtY29tcHV0ZWRSb2xlU3RyaW5nLmh0bWw6IFVwZGF0ZWQuCisg ICAgICAgICogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtY29tcHV0ZWRSb2xlU3Ry aW5nLWV4cGVjdGVkLnR4dDogVXBkYXRlZC4KKwogMjAxNi0wNy0wOCAgRnJlZGVyaWMgV2FuZyAg PGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgVXNlIFJhZGljYWwqIGNvbnN0YW50cyBmcm9t IHRoZSBPcGVuVHlwZSBNQVRIIHRhYmxlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS9yb2xlcy1jb21wdXRlZFJvbGVTdHJpbmctZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvYWNjZXNzaWJpbGl0eS9yb2xlcy1jb21wdXRlZFJvbGVTdHJpbmctZXhwZWN0ZWQudHh0Cmlu ZGV4IDU1YTg4YzdiODE2YzZkY2Y5ZDkwYmRmNmE0N2EwMjA2MWZjN2FmNTYuLmQ4YjY2Y2M5OWUx YjI5MDdhMGY0MTg3N2ZjNmRmNDFmZjg4Njk3NDUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Fj Y2Vzc2liaWxpdHkvcm9sZXMtY29tcHV0ZWRSb2xlU3RyaW5nLWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3JvbGVzLWNvbXB1dGVkUm9sZVN0cmluZy1leHBlY3Rl ZC50eHQKQEAgLTEsNCArMSwzIEBACi0gWAogVGhpcyB0ZXN0cyB0aGF0IG5hdGl2ZSBlbGVtZW50 cyBhbmQgQVJJQSBvdmVycmlkZXMgcmVzdWx0IGluIHRoZSBzYW1lIEFSSUEgY29tcHV0ZWQgcm9s ZSwgcmVnYXJkbGVzcyBvZiBwbGF0Zm9ybS4KIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEg c2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9yb2xlcy1jb21wdXRlZFJvbGVT dHJpbmcuaHRtbCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvcm9sZXMtY29tcHV0ZWRSb2xl U3RyaW5nLmh0bWwKaW5kZXggMDM0ZWRkM2ExMTBjZTU3NWE4N2MxZDVkNmYyNjAxZGZjNzQ2ZWZk OS4uODU2ZDU2YmRkZjYxMzY2MDRmNDRjYmM4YTk3Y2IzZjkyNGEyYjRkNyAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9yb2xlcy1jb21wdXRlZFJvbGVTdHJpbmcuaHRtbAor KysgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3JvbGVzLWNvbXB1dGVkUm9sZVN0cmluZy5o dG1sCkBAIC03LDYgKzcsNyBAQAogPCEtLSBIVE1MIGVsZW1lbnRzIGluIGFscGhhYmV0aWNhbCBv cmRlciwgZXhjZXB0aW5nIHRoZSBuZWVkIGZvciBuZXN0aW5nIChlLmcuIDxsaT4gaXMgd2l0aCBp dHMgPG9sPiBhbmQgPHVsPiBwYXJlbnRzKSAtLT4KIDwhLS0gVGhpcyBvbmx5IHRlc3RzIGVsZW1l bnRzIHRoYXQgaGF2ZSBhbiBleGFjdCAxOjEgQVJJQSByb2xlIG1hcHBpbmcsIGFuZCBjb21wdXRl ZCByb2xlIG92ZXJyaWRlcy4gLS0+CiA8IS0tID09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0gLS0+Cis8ZGl2IGlkPSJjb250ZW50Ij4KIDxhIGRhdGEtcm9sZT0ibGlu ayIgaHJlZj0iIyIgZGF0YS1ub3RlPSJbaHJlZl0iIGNsYXNzPSJleCI+WDwvYT4KIDxhcnRpY2xl IGRhdGEtcm9sZT0iYXJ0aWNsZSIgY2xhc3M9ImV4Ij5YPC9hcnRpY2xlPgogPGFzaWRlIGRhdGEt cm9sZT0iY29tcGxlbWVudGFyeSIgY2xhc3M9ImV4Ij5YPC9hc2lkZT4KQEAgLTI4Miw2ICsyODMs NyBAQCBiYXIiIHNyYz0iZm9vLnBuZyIgICAgICAgICAgICAgICAgICAgZGF0YS1yb2xlPSJpbWci IGFsdD0iWCIgY2xhc3M9ImV4Ij48IS0tIFtzaQogPGltZyByb2xlPSJpbWcgdGV4dCIgc3JjPSJm b28ucG5nIiAgIGRhdGEtcm9sZT0iaW1nIiBhbHQ9IlgiIGNsYXNzPSJleCI+CiA8aW1nIHJvbGU9 InByZXNlbnRhdGlvbiIgICAgICAgICAgICAgZGF0YS1yb2xlPSJpbWciIGRhdGEtbm90ZT0iW2Fy aWEtbGFiZWxdIiBhbHQ9IlgiIHNyYz0iZm9vLnBuZyIgYXJpYS1sYWJlbD0iWCIgY2xhc3M9ImV4 Ij48IS0tIHByZXNlbnRhdGlvbiB3aXRoIGdsb2JhbCBhdHRyIHNob3VsZCBmYWxsYmFjayB0byBp bXBsaWNpdCByb2xlIC0tPgogPGEgaHJlZj0iIyIgcm9sZT0iZm9vIGJhciIgICAgICAgICAgIGRh dGEtcm9sZT0ibGluayIgY2xhc3M9ImV4Ij5YPC9hPgorPC9kaXY+CiAKIDxkaXYgaWQ9ImNvbnNv bGUiPjwvZGl2PgogPHNjcmlwdD4KQEAgLTMyMywxMSArMzI1LDcgQEAgaWYgKHdpbmRvdy50ZXN0 UnVubmVyICYmIHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgewogICAgIH0KIAogICAg IC8vIE9uY2UgdGVzdHMgYXJlIGNvbXBsZXRlLCBoaWRlIGFsbCB0aGUgZXhhbXBsZSBtYXJrdXAu Ci0gICAgZXhhbXBsZXMgPSBkb2N1bWVudC5xdWVyeVNlbGVjdG9yQWxsKCIuZXgiKTsKLSAgICBm b3IgKHZhciBpID0gMCwgYyA9IGV4YW1wbGVzLmxlbmd0aDsgaSA8IGM7IGkrKykgewotICAgICAg ICBlbCA9IGV4YW1wbGVzW2ldOwotICAgICAgICBlbC5zdHlsZS5kaXNwbGF5ID0gIm5vbmUiOwot ICAgIH0KKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29udGVudCIpLnN0eWxlLnZpc2li aWxpdHkgPSAiaGlkZGVuIjsKIH0KIDwvc2NyaXB0PgogPHNjcmlwdCBzcmM9Ii4uL3Jlc291cmNl cy9qcy10ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtY29tcHV0ZWRSb2xlU3RyaW5nLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JvbGVzLWNvbXB1 dGVkUm9sZVN0cmluZy1leHBlY3RlZC50eHQKaW5kZXggMjg1MDI2OGE2ZjlmMjg0ZDQwNGNjY2My Y2MwNWUxNWFjYWFhZTZkOS4uZTJmNTY0NWU4MTE1YjdmYTZkYTMxNTkxZWE4OWFiY2RiYWZjMTlk ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9s ZXMtY29tcHV0ZWRSb2xlU3RyaW5nLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9yb2xlcy1jb21wdXRlZFJvbGVTdHJpbmctZXhwZWN0ZWQu dHh0CkBAIC0xLDQgKzEsMyBAQAotIFgKIFRoaXMgdGVzdHMgdGhhdCBuYXRpdmUgZWxlbWVudHMg YW5kIEFSSUEgb3ZlcnJpZGVzIHJlc3VsdCBpbiB0aGUgc2FtZSBBUklBIGNvbXB1dGVkIHJvbGUs IHJlZ2FyZGxlc3Mgb2YgcGxhdGZvcm0uCiAKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNl cmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4K